D13106: Add RTL support to some QtQuick ported KCMs

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  I'm starting to think you're right about putting it at a higher level.
  
  I'm not sure how viable it is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13106

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13745: Implement support for virtual desktops on Wayland

[Eike Hein]

hein updated this revision to Diff 36903.
hein added a comment.


  Adjust to new semantics for IsOnAllDesktops.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13745?vs=36857=36903

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13745

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/abstracttasksproxymodeliface.cpp
  libtaskmanager/abstracttasksproxymodeliface.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/windowtasksmodel.cpp
  libtaskmanager/windowtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13717: Implement Seek() and Seeked()

[Adam Mokhtari]

mokhtari marked 3 inline comments as done.
mokhtari added inline comments.

INLINE COMMENTS

> broulik wrote in content-script.js:177
> Please avoid negating a longer statement, this makes the code hard to 
> understand at a glance:
> 
>   if (activePlayer.seekable.length === 0)

Good point. Fixed.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, 
Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, 
jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, 
jensreuterberg, ach, abetts, sebas, apol, mart

D13717: Implement Seek() and Seeked()

[Adam Mokhtari]

mokhtari updated this revision to Diff 36902.
mokhtari added a comment.


  Clean things up a bit:
  
  - use signal auto-relaying to clean up mprisplugin logic
  - use more readable test in content-script.js

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13717?vs=36854=36902

REVISION DETAIL
  https://phabricator.kde.org/D13717

AFFECTED FILES
  extension/content-script.js
  extension/extension.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, 
Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, 
jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, 
jensreuterberg, ach, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi added a comment.


  In D10297#272726 , @rkflx wrote:
  
  > Awesome, I did not expect that the fix for the shortcuts would be so 
simple. Thanks for your patience, we are nearly there…

INLINE COMMENTS

> rkflx wrote in ksysguardprocesslist.cpp:421-427
> Left-over debug code?

It was supposed to serve as reminder of how the parameters for the 
globalShortcut method were determined. To help debugging later. Should it be 
removed?

> rkflx wrote in ksysguardprocesslist.cpp:429
> Do you think it is really necessary to display `not set`? For me, an empty 
> string would also work just fine, now that you are using `\t` instead of 
> `(…)`.
> 
> Also I found a way to omit the string and `\t` entirely and let Qt do all the 
> work:
> 
>   auto runCommandAction = new QAction(i18nc("@action:inmenu", "Run Command"), 
> this);
>   const auto runCommandShortcutList = 
> KGlobalAccel::self()->globalShortcut(QStringLiteral("krunner"), 
> QStringLiteral("run command"));
>   if (runCommandShortcutList.size() > 0) {
>   runCommandAction->setShortcut(runCommandShortcutList[0]);
>   }

Yes, is this much better.

Might there be a chance of a some kind of keyboard shortcut conflict because we 
now set it also locally?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, broulik, mart, hein, rkflx
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi updated this revision to Diff 36895.
gregormi marked an inline comment as done.
gregormi edited the summary of this revision.
gregormi added a comment.


  - info comment
  - Remove the now useless "not set" string
  - Set shortcut text with Qt methods and omit the translation context string 
and \t

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10297?vs=35172=36895

BRANCH
  arcpatch-D10297_2

REVISION DETAIL
  https://phabricator.kde.org/D10297

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/ProcessWidgetUI.ui
  processui/ksysguardprocesslist.cpp

To: gregormi, #plasma, colomar, broulik, mart, hein, rkflx
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi marked 6 inline comments as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:260
> Maybe you could avoid this special case if you added a hidden label in 
> `loadSoftware`?
> 
> Also, "label in … the button" sounds a bit odd. Perhaps "label" would be 
> enough, or use `@title:row`? (See 
> https://api.kde.org/frameworks/ki18n/html/prg_guide.html)

Good idea. DONE.

> rkflx wrote in Module.ui:349-351
> Works perfectly fine for me. I think there might be something off with your 
> local shortcuts setup.

Ok. Then I leave it like that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 36893.
gregormi added a comment.


  - Rework the Module.ui layout to fix the spacing
  - Add dummy label to remove special case for "Distro"
  - Use C++11 for loop and add qAsConst
  - Make RTL aware by not removing the colon
  - Improve translation context message

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=35167=36893

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi added a comment.


  I added some qDebug code in Module::copyToClipboard() and noticed that the 
method is always called twice when the Copy to clipboard button is clicked.
  
  When I remove the line 125 in Module.cpp: connect(ui->pushButtonCopyInfo, 
::clicked, this, ::copyToClipboard);
  then the nothing happens when the button is clicked.
  
  With a web search I only found this 
https://stackoverflow.com/questions/34416103/function-connected-to-the-button-is-called-twice-after-one-click
 which is not the case here. Any idea why the slot method is called twice?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi added a comment.


  Thanks Henrik for the review. I fixed the layout and it looks now like this 
in Qt Designer:
  
  F5972316: grafik.png 
  
  The blue arrow shows a difference to your proposal. Do you think the grid 
layout there is ok? I push an update when I have the other things ready.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D13745: Implement support for virtual desktops on Wayland

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:458
> +return (window->plasmaVirtualDesktops().isEmpty()
> +|| d->virtualDesktopInfo->numberOfDesktops() == 
> window->plasmaVirtualDesktops().count());
>  } else if (role == Geometry) {

note that the protocol ensures the list of desktops is empty when is on all 
virtual desktops, even when every desktop has been added by hand

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13745

To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

PSA: Phabricator staging repositories

[Bhushan Shah]

Hello developers,

So in last few days I and Ben has been working on setting up the staging
repositories for phabricator. More information on this feature is
documented as part of Harbormaster documentation [1] change handoff
section.

To explain further, this will allow the people to push commits for
review to a dedicated staging area, which opens up the new possibilities
like,

- Landing the changes directly from Web UI
- Handing over the changes to CI systems like build.kde.org or
  build.neon.kde.org or binary-factory.kde.org which in turn can run the
  build against proposed changes and send status back to review saying
  "Hey! That review doesn't build" or "All Green!"

Currently required changes for those two usecases is not implemented
yet. But, enabling staging repository is the first step in that
direction. Currently we have all pieces to enable the staging area in
the repositories ready, but it is not enabled. As we think we should
notify community about upcoming changes. We will be enabling this feature
in upcoming week.

# So how does staging repository works?

When you create a diff using arcanist, what it does is, push the commit
for which changes were created to tag like phabricator/diff/12345, where
12345 represents the diff ID to different git mirror of mainline git
repositories on git.kde.org.

The URL where this tags will be pushed is,

"stag...@git.kde.org:reponame.git"

One imporant thing to note is, stag...@git.kde.org won't accept the
normal pushes, and for most of the developers this URL is implementation
detail. You should not push direct changes to this repositories.

Also, to allow non-developers to push to the staging area, we have
enabled the option to upload ssh keys for the normal users. The keys
added there will be synced to stag...@git.kde.org automatically allowing
the non-developers to push to staging area.

So in general here is what you should do,

# For users who want to submit the changes to phabricator

Please make sure you have your keys uploaded to identity.kde.org, you
can do it by clicking on "Manage SSH Keys" option in right sidebar
after logging in.

# For both users and developers

Make sure your ~/.ssh/config have entry for stag...@git.kde.org.

Below is example from my ssh config.

Host git.kde.org
HostName git.kde.org
User staging
IdentityFile ~/.ssh/id_rsa_kde

# For maintainers of projects

For some reason you don't want your project to use the staging
repositories on phabricator, or have any questions, please get in touch
with us.

PS: We are interested in getting some beta testing for this feature
before we enable this changes to all repositories, if you maintain a
project and if you are interested in testing this out, please mention
us.

PPS: I have just sent this e-mail to few lists I am subscribed to
(kde-devel, kde-core-devel, kde-frameworks-devel, plasma-devel and
sysadmin list) but if you think I have missed sending this to some list,
feel free to forward it and please make sure to include sysad...@kde.org
or me in reply.

Thanks

[1] https://secure.phabricator.com/book/phabricator/article/harbormaster/

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D13772: Add AppStream metadata

[Nathaniel Graham]

ngraham added a comment.


  Are folks satisfied with this now?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D13772

To: ngraham, #plasma, apol, mak, pino
Cc: pino, mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.cpp:484
>  {
> +const QString cacheKey = themeName + QLatin1Char('@') + 
> QString::number(size) + QLatin1Char('@') + QString::number(dpr,'f',1) + 
> QLatin1Char('@') + QString::number(limit);
> +

so if you request previewIcons with a limit of 6 then request again with a 
limit of 12 you're duplicating the first 6 in another cache.

If you're going to have this limit, would having a cache per icon then building 
the list on every invocation would be cleander?

(would also allow use of QPixmapCache which has a nice auto-expunge)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

To: broulik, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[Kai Uwe Broulik]

broulik updated this revision to Diff 36882.
broulik added a comment.


  - Explain why QVariantList

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13793?vs=36881=36882

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[Kai Uwe Broulik]

broulik updated this revision to Diff 36881.
broulik added a comment.


  - Add comment explaining the number 6

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13793?vs=36878=36881

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> main.h:110
> +// ListView deletes and recreates delegates as you scroll, so once we 
> generated previews, cache them
> +QHash*/> m_previewCache;
> +

leftovers?

> main.qml:156
>  Qt.callLater(function() {
> -previews = kcm.previewIcons(model.themeName, 
> Math.min(thumbFlow.iconWidth, thumbFlow.iconHeight), Screen.devicePixelRatio)
> +thumbFlow.loadPreviews(6 /*limit*/);
>  });

reason for 6?
should be at least documented

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

To: broulik, #plasma
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13793: [Icons KCM] Load preview pixmaps for animation on-demand and cache them

[Kai Uwe Broulik]

broulik updated this revision to Diff 36878.
broulik retitled this revision from "[Icons KCM] Cache preview pixmaps" to 
"[Icons KCM] Load preview pixmaps for animation on-demand and cache them".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13793?vs=36876=36878

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13793: [Icons KCM] Cache preview pixmaps

[Kai Uwe Broulik]

broulik updated this revision to Diff 36876.
broulik added a comment.


  - Evict cache when installing new theme

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13793?vs=36875=36876

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13793: [Icons KCM] Cache preview pixmaps

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  TODO evict cache when reloading model (installing new theme)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13793: [Icons KCM] Cache preview pixmaps

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  ListView deletes and recreates delegates as you scroll, leading to us 
recreating the icon pixmaps as you scroll up and down with many themes installed

TEST PLAN
  Verified that every icon theme is loaded only once
  Scrolling down initially is still a bit sluggish depending on themes (I 
should also delay loading the animated preview pixmaps..) but once it's loaded 
it's fast

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13793

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/icons/main.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Jan Grulich]

jgrulich added a comment.


  One more possible thing to improve, I don't know if there is interest in 
supporting Gnome, but Gnome creates streams in BGRx format, which means it 
wouldn't mach your stream, if you want to support it you need to change it to 
something like :
  ":",  pwType->format_video.format, "Ieu", pwType->video_format.RGBx, 
SPA_POD_PROP_ENUM(2, pwType_->video_format.RGBx,  pwType_->video_format.BGRx)

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications
Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, 
mart, hein

D13694: Fix wrong availability of profiles and ports.

[David Rosca]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ba737f478208: Fix wrong availability of profiles and 
ports. (authored by akrutzler, committed by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13694?vs=36728=36868

REVISION DETAIL
  https://phabricator.kde.org/D13694

AFFECTED FILES
  src/port.h
  src/profile.h

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13717: Implement Seek() and Seeked()

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> content-script.js:177
> +if (activePlayer) {
> +if (!(activePlayer.seekable.length > 0)) {
> +console.warn("Got seek command, but player is not seekable");

Please avoid negating a longer statement, this makes the code hard to 
understand at a glance:

  if (activePlayer.seekable.length === 0)

> mokhtari wrote in mprisplugin.cpp:205
> MPrisPlugin doesn't define Seeked, so no. But it's fine with me if you think 
> adding it to the parent and using the signal auto-relaying would be better.
> 
> Regarding macros vs. keywords, I just figured macros would be more 
> compatible, but it could be switched to using emit as well.

Doesn't it work if you define the signal in `mprisplugin.h` and emit there? The 
generated DBus code from the XML should auto-relay them. Agreed, it's somewhat 
magic.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, 
Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, 
jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, 
jensreuterberg, ach, abetts, sebas, apol, mart

D13788: Use Pin/Unpin also for window tasks when there's only one activity

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ContextMenu.qml:486
>  
> -checkable: true
> -
> -text: i18nc("Toggle action for showing a launcher button while the 
> application is not running", "")
> +text: (isPinned ? i18nc("Action for removing the launcher button 
> shown while the application is not running", "Unpin")
> +: i18nc("Action for showing a launcher button while the 
> application is not running", ""))

Un?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13788

To: hein, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart