gregormi marked 6 inline comments as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:260
> Maybe you could avoid this special case if you added a hidden label in 
> `loadSoftware`?
> 
> Also, "label in … the button" sounds a bit odd. Perhaps "label" would be 
> enough, or use `@title:row`? (See 
> https://api.kde.org/frameworks/ki18n/html/prg_guide.html)

Good idea. DONE.

> rkflx wrote in Module.ui:349-351
> Works perfectly fine for me. I think there might be something off with your 
> local shortcuts setup.

Ok. Then I leave it like that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

Reply via email to