Re: [Qemu-devel] [PATCH 1/2] raw: add license header
Christoph Hellwig h...@lst.de writes: On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. The coded was intended to be GPLv2. Can you send a patch to add your copyright to this file? I added the BSD license that most folks Signed-off-by but you should add your GPLv2 copyright (making the file effectively GPLv2). Regards, Anthony Liguori
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On 31.07.2013 10:01, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com In general, I very much prefer to protect my work with a strong copyleft license like the GPLv2+. However, my contributions to raw.c are trivial, so I choose to go with the flow in this case. Signed-off-by: Markus Armbruster arm...@redhat.com same applies for me. Signed-off-by: Peter Lieven p...@kamp.de
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. The coded was intended to be GPLv2.
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. The coded was intended to be GPLv2. I guess some day we'll rewrite it, perhaps when libqblock is closer to being merged. Paolo
[Qemu-devel] [PATCH 1/2] raw: add license header
Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/raw.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/block/raw.c b/block/raw.c index f1682d4..4751825 100644 --- a/block/raw.c +++ b/block/raw.c @@ -1,3 +1,26 @@ +/* + * Block driver for RAW format + * + * Copyright (c) 2006 Fabrice Bellard + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the Software), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ #include qemu-common.h #include block/block_int.h -- 1.8.1.4
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
Am 31.07.2013 um 08:19 hat Paolo Bonzini geschrieben: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com Thanks, Paolo, for taking the effort to clarify the license. Signed-off-by: Kevin Wolf kw...@redhat.com block/raw.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/block/raw.c b/block/raw.c index f1682d4..4751825 100644 --- a/block/raw.c +++ b/block/raw.c @@ -1,3 +1,26 @@ +/* + * Block driver for RAW format + * + * Copyright (c) 2006 Fabrice Bellard This part of the code is actually something that Fabrice never touched (and consequently you didn't CC him either). This should probably refer to Christoph instead or include all of the people who contributed to the file. Kevin
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
Paolo Bonzini pbonz...@redhat.com writes: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com In general, I very much prefer to protect my work with a strong copyleft license like the GPLv2+. However, my contributions to raw.c are trivial, so I choose to go with the flow in this case. Signed-off-by: Markus Armbruster arm...@redhat.com
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com I switched employers since my block/raw.c contributions, but FWIW: Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Signed-off-by: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/raw.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/block/raw.c b/block/raw.c index f1682d4..4751825 100644 --- a/block/raw.c +++ b/block/raw.c @@ -1,3 +1,26 @@ +/* + * Block driver for RAW format + * + * Copyright (c) 2006 Fabrice Bellard + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the Software), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ #include qemu-common.h #include block/block_int.h -- 1.8.1.4
Re: [Qemu-devel] [PATCH 1/2] raw: add license header
On Wed, 31 Jul 2013 08:19:51 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus Armbruster arm...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Cc: Jeff Cody jc...@redhat.com Cc: Peter Lieven p...@kamp.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/raw.c | 23 +++ 1 file changed, 23 insertions(+) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com diff --git a/block/raw.c b/block/raw.c index f1682d4..4751825 100644 --- a/block/raw.c +++ b/block/raw.c @@ -1,3 +1,26 @@ +/* + * Block driver for RAW format + * + * Copyright (c) 2006 Fabrice Bellard + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the Software), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ #include qemu-common.h #include block/block_int.h
