Issue 2006 in reviewboard: Signature for my reviews and of my review requests is incorrect
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2006 by lousyb...@gmail.com: Signature for my reviews and of my review requests is incorrect http://code.google.com/p/reviewboard/issues/detail?id=2006 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? Reviewboard 1.5.3 What's the URL of the page containing the problem? A/A Any reviewboard where I have issued comments, generated reviews, it is an account preferences issue. Account is under Stephen Goddard as my login is sgoddard, however, have changed it (correct now for email) via Active Directory to be Steve Goddard What steps will reproduce the problem? 1.Reply to any review 2.Create any review request 3.Add comments to a review What is the expected output? What do you see instead? My email account is under Steve Goddard NOT Stephen Goddard (Done a few days back) Therefore, my signature and ID for comments needs to use Steve Goddard and not Stephen Goddard and the signature should be - Steve NOT - Stephen What operating system are you using? What browser? All browsers, not a browser issue but an account preferences issue. Please provide any additional information below. When can these type of preferences for an account be configurable in the accounts page? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2007 in reviewboard: error uploading diff with post-review 0.3.2 (path resolution fail)
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2007 by latch...@gmail.com: error uploading diff with post-review
0.3.2 (path resolution fail)
http://code.google.com/p/reviewboard/issues/detail?id=2007
I create a diff with the following command so that I can see the changes in
our sql scripts between iterations:
svn diff http://svn/marin/branches/iteration-0009/mscm/sql/changes
http://svn/marin/branches/iteration-0010/mscm/sql/changes sql.diff
I then post-review that diff:
post-review -d --diff-filename=sql.diff
RBTools 0.3.2
Home = /Users/jon
svn info
diff --version
repository info: Path: http://svn/marin, Base path:
/branches/iteration-0009, Supports changesets: False
svn propget reviewboard:url /Users/jon/checkout/branches/iteration-0009
HTTP GETting api/
HTTP GETting http://rb/api/info/
Using the new web API
HTTP GETting http://rb/api/repositories/
HTTP GETting http://rb/api/repositories/1/
HTTP GETting http://rb/api/repositories/1/info/
repository info: Path: http://svn/marin, Base path:
/branches/iteration-0009, Supports changesets: False
Attempting to create review request on http://svn/marin for None
HTTP POSTing to http://rb/api/review-requests/: {'repository':
u'http://svn/marin'}
Review request created
Uploading diff, size: 14301
HTTP POSTing to http://rb/api/review-requests/11742/diffs/:
{'basedir': '/branches/iteration-0009'}
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'/branches/iteration-0009/iteration-0009/mscm/sql/changes/MARIN_COMMON/6595',
u'err': {u'msg': u'The file was not found in the repository', u'code':
207}, u'revision': u'40575'}
As you can see, iteration-0009 gets included twice in the path for some
reason.
Not sure how to work around this one. Ideas?
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2007 in reviewboard: error uploading diff with post-review 0.3.2 (path resolution fail)
Updates: Labels: -Type-Defect Type-Support Comment #1 on issue 2007 by chip...@gmail.com: error uploading diff with post-review 0.3.2 (path resolution fail) http://code.google.com/p/reviewboard/issues/detail?id=2007 post-review finds the directory within the SVN server that represents the current directory it's being run from. In this case, that's /branches/iteration-0009. The diffs are including the iteration-0009 part as well. So you need to either have the diffs not contain that, or you need to run this from /branches. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2007 in reviewboard: error uploading diff with post-review 0.3.2 (path resolution fail)
Comment #2 on issue 2007 by latch...@gmail.com: error uploading diff with post-review 0.3.2 (path resolution fail) http://code.google.com/p/reviewboard/issues/detail?id=2007 This used to work with post-review 0.2 and older versions of rb. The header for the diff of a file looks like this: Index: MARIN/201102281519-create-last-forecast-settings === --- MARIN/201102281519-create-last-forecast-settings (.../iteration-0009/mscm/sql/changes) (revision 0) +++ MARIN/201102281519-create-last-forecast-settings (.../iteration-0010/mscm/sql/changes) (revision 40584) When I run svn diff and post-review, I do it from within the iteration-XXX directory since that is all I have checked out of svn and where the reviewboard:url property is set. It wouldn't make sense for me to checkout ALL of /branches from svn since I don't need all of our branches... Ideally, post-review would look at the diff and use the current working directory + path/to/file/in/diff (MARIN/201102281519-create-last-forecast-settings ) to create the svn path. I was able to upload the diff using the webui by just setting the path to /branches, but it seems like there should be a way to do this from the CLI too without having to checkout all of /branches to upload the diff. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
