[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has abandoned this change. ( 
http://gerrit.cloudera.org:8080/8458 )

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..


Abandoned

https://gerrit.cloudera.org/#/c/8460/ supersedes
--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 2
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8458 )

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG@18
PS2, Line 18:   at least "1.7" (found 
/opt/toolchain/sun-jdk-64bit-1.6.0.31/bin/java)
hrm, haven't we required java7 for quite a long time now?


http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG@22
PS2, Line 22:   Unknown CMake command "add_jar".
Does the build in question define -DNO_TESTS? It seems like it's a bug that the 
include(UseJava) is wrapped in a 'if(NOT NO_TESTS)' but the add_jar in  
kudu/hms/CMakeLists.txt is not wrapped in it. i.e I'm not sure this is a cmake 
version issue



--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 2
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 03 Nov 2017 18:00:52 +
Gerrit-HasComments: Yes

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8458 )

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8458/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8458/1//COMMIT_MSG@11
PS1, Line 11: This is currently causing build failures in some environments 
(unfortunately none visible upstream). Given this might require more code 
changes, let's temporarily revert.
> can you share what the build failure is? I'm OK revertinng patches based on
Done.



--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 1
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 03 Nov 2017 17:52:27 +
Gerrit-HasComments: Yes

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review) 
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd 
Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8458

to look at the new patch set (#2).

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..

Revert "KUDU-2191 (2/n): Hive Metastore client"

This reverts commit 31d16f7493544c850e019f1d2fdc7eef6e2c2258.

This is currently causing build failures in some environments (unfortunately 
none visible upstream).
Given this might require more code changes, let's temporarily revert.

For example, we now require JDK 7 for tests that don't require Java (like 
running
benchmarks):
CMake Error at 
thirdparty/installed/common/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:137
 (message):
  Could NOT find Java: Found unsuitable version "1.6.0.31", but required is
  at least "1.7" (found /opt/toolchain/sun-jdk-64bit-1.6.0.31/bin/java)

We also used to be able to build with older versions of cmake but now:
CMake Error at src/kudu/hms/CMakeLists.txt:54 (add_jar):
  Unknown CMake command "add_jar".

Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
---
M CMakeLists.txt
M build-support/dist_test.py
M build-support/iwyu/iwyu-filter.awk
M build-support/run_dist_test.py
D cmake_modules/FindJavaHome.cmake
D cmake_modules/FindThrift.cmake
D src/kudu/hms/CMakeLists.txt
D src/kudu/hms/hive_metastore.thrift
D src/kudu/hms/hms_client-test.cc
D src/kudu/hms/hms_client.cc
D src/kudu/hms/hms_client.h
D src/kudu/hms/mini_hms.cc
D src/kudu/hms/mini_hms.h
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
18 files changed, 9 insertions(+), 2,930 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8458/2
--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 2
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8458 )

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8458/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8458/1//COMMIT_MSG@11
PS1, Line 11: This is currently causing build failures in some environments 
(unfortunately none visible upstream). Given this might require more code 
changes, let's temporarily revert.
can you share what the build failure is? I'm OK revertinng patches based on 
some private test environment, but it's not very friendly to just revert 
without at least explaning the issue or pasting a log, etc.



--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 1
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 03 Nov 2017 17:47:20 +
Gerrit-HasComments: Yes

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review) 
Jean-Daniel Cryans has reverted this change. ( 
http://gerrit.cloudera.org:8080/8458 )

Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..


Uploaded patch set 1.
--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: revert
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 1
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Revert "KUDU-2191 (2/n): Hive Metastore client"

2017-11-03 Thread Jean-Daniel Cryans (Code Review) 
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd 
Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8458

to review the following change.


Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client"
..

Revert "KUDU-2191 (2/n): Hive Metastore client"

This reverts commit 31d16f7493544c850e019f1d2fdc7eef6e2c2258.

This is currently causing build failures in some environments (unfortunately 
none visible upstream). Given this might require more code changes, let's 
temporarily revert.

Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
---
M CMakeLists.txt
M build-support/dist_test.py
M build-support/iwyu/iwyu-filter.awk
M build-support/run_dist_test.py
D cmake_modules/FindJavaHome.cmake
D cmake_modules/FindThrift.cmake
D src/kudu/hms/CMakeLists.txt
D src/kudu/hms/hive_metastore.thrift
D src/kudu/hms/hms_client-test.cc
D src/kudu/hms/hms_client.cc
D src/kudu/hms/hms_client.h
D src/kudu/hms/mini_hms.cc
D src/kudu/hms/mini_hms.h
M thirdparty/LICENSE.txt
M thirdparty/build-definitions.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
18 files changed, 9 insertions(+), 2,930 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8458/1
--
To view, visit http://gerrit.cloudera.org:8080/8458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11
Gerrit-Change-Number: 8458
Gerrit-PatchSet: 1
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon