[kudu-CR] Implement SchemaRelationProvider
Andy Grove has uploaded a new change for review. http://gerrit.cloudera.org:8080/3529 Change subject: Implement SchemaRelationProvider .. Implement SchemaRelationProvider Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56 --- M java/kudu-spark/src/main/scala/org/kududb/spark/kudu/DefaultSource.scala M java/kudu-spark/src/test/scala/org/kududb/spark/kudu/DefaultSourceTest.scala 2 files changed, 75 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3529/1 -- To view, visit http://gerrit.cloudera.org:8080/3529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4194d7ec139f0f9e3c1d508e8aca860484839d56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andy Grove
[kudu-CR] thirdparty: add boost and switch to header-only build
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: add boost and switch to header-only build .. thirdparty: add boost and switch to header-only build The addition of boost to thirdparty is bound to make some squeamish, so here's my rationale: 1. My original goal was to enable the TSAN build on Ubuntu 16.04, a distro that has switched to the new gcc5 ABI. This renders the system boost installation unusable as it can't link against our TSAN-instrumented libstdc++. To be fair, switching to a header-only build has eliminated this problem. 2. Boost is effectively the last remaining dependency that isn't explicitly managed as a thirdparty dependency. The only exceptions are glibc, libstdc++, and libsasl, all of which should not be managed due to their interactions with other ABIs. In my opinion, Kudu should manage as many dependencies as possible in this way. 3. Doing this means Kudu developers will no longer need to install boost system packages to build Kudu. 4. Historically, Kudu has permitted the use of any boost version even though some versions needed patches to build with a new compiler. IIRC, https://svn.boost.org/trac/boost/ticket/6165 was one such instance. 5. For the boost logic that Kudu does use, we'll know exactly which features exist and which do not. There'll be no more version-based ambiguity. 6. Doing this means we can drop the odd boost_uuid appendage. 7. This patch by no means implies that boost is to stay in Kudu forever. We're already at the point where we can get by with boost headers alone. Once we replace the remaining bits (i.e. optional and intrusive lists come to mind), we can jettison it altogether. With that out of the way, here are the details: - Inclusion of boost as a thirdparty dependency. I spent some time fighting with the boost build to get it to copy the headers without building anything; eventually I gave up and used rsync instead. - Removal of boost components from Kudu's cmake logic. This netted a nice cleanup of cmake code. - Removal of boost handling from documentation and other random places. - Removal of boost_uuid. Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371 Reviewed-on: http://gerrit.cloudera.org:8080/3500 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert--- M CMakeLists.txt M LICENSE.txt M build-support/dist_test.py M build-support/release/rat_exclude_files.txt M docs/contributing.adoc M docs/installation.adoc M src/kudu/util/CMakeLists.txt M thirdparty/.gitignore M thirdparty/LICENSE.txt D thirdparty/boost_uuid/LICENSE.txt D thirdparty/boost_uuid/boost/uuid/name_generator.hpp D thirdparty/boost_uuid/boost/uuid/nil_generator.hpp D thirdparty/boost_uuid/boost/uuid/random_generator.hpp D thirdparty/boost_uuid/boost/uuid/seed_rng.hpp D thirdparty/boost_uuid/boost/uuid/sha1.hpp D thirdparty/boost_uuid/boost/uuid/string_generator.hpp D thirdparty/boost_uuid/boost/uuid/uuid.hpp D thirdparty/boost_uuid/boost/uuid/uuid_generators.hpp D thirdparty/boost_uuid/boost/uuid/uuid_io.hpp D thirdparty/boost_uuid/boost/uuid/uuid_serialize.hpp M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/boost-issue-12179-fix-compilation-errors.patch M thirdparty/preflight.py M thirdparty/vars.sh 26 files changed, 98 insertions(+), 1,558 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] locks: add new read-write mutex
Adar Dembo has submitted this change and it was merged. Change subject: locks: add new read-write mutex .. locks: add new read-write mutex The new mutex is a thin wrapper around pthread read/write locks. It has no features of which to speak: no debugging hooks, no optimizations, nothing. Take these rwlock-perf results with a grain of salt; they only test read/read contention, not read/write or write/write contention. The values are millions of cycles. num_threads laptop_old laptop_new ve0518_old ve0518_new --- 1 26183 18982 2 1604 644914730 3 1504 9172204 1567 4 2398 1792 3185 2162 5 3210 2179 3943 2308 6 4070 2696 4135 2515 7 4741 3253 4557 2732 8 5457 3853 5114 3145 Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Reviewed-on: http://gerrit.cloudera.org:8080/3496 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon--- M src/kudu/experiments/rwlock-perf.cc M src/kudu/util/CMakeLists.txt M src/kudu/util/mutex.cc A src/kudu/util/rw_mutex.cc A src/kudu/util/rw_mutex.h 5 files changed, 122 insertions(+), 5 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
Adar Dembo has posted comments on this change. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3528/1/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: Line 555: // TODO: Re-elect TS-1 What does this mean in the context of this patch? -- To view, visit http://gerrit.cloudera.org:8080/3528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2091/ -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan BurkertGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
Kudu Jenkins has posted comments on this change. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2090/ -- To view, visit http://gerrit.cloudera.org:8080/3528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3528 to review the following change. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails I looped this test 500x on ASAN and 500x on TSAN and saw no failures. Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de --- M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/external_mini_cluster.cc 2 files changed, 38 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3528/1 -- To view, visit http://gerrit.cloudera.org:8080/3528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a1e585bdc2c8c968850e2c6b7c28f572ddbe5de Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike PercyGerrit-Reviewer: Todd Lipcon
[kudu-CR] Persistent cache support for NVM
Kudu Jenkins has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2088/ -- To view, visit http://gerrit.cloudera.org:8080/2593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sarah JelinekGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sarah Jelinek Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Mike Percy has submitted this change and it was merged. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange This test was supposed to wait until the master had committed a given operation, but in fact was only waiting until all of the servers had _replicated_ the operation. In TSAN builds where things ran slower, this caused it to be about 7% flaky. The fix is to simply wait for the op to be committed, not just replicated. With the fix, I looped it 100 times and it passed. Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24 Reviewed-on: http://gerrit.cloudera.org:8080/3511 Tested-by: Todd LipconReviewed-by: Mike Percy --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/3511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Mike Percy has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] locks: change kudu::shared lock constructor to pass by ref
Todd Lipcon has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] locks: add new read-write mutex
Todd Lipcon has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp
Adar Dembo has posted comments on this change. Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60db2acf7642aa6eb2c850032a7dc9639b6ae40e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](gh-pages) Update links to kudu.apache.org
Todd Lipcon has posted comments on this change. Change subject: Update links to kudu.apache.org .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd LipconGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Update version numbers on releases page to say incubating
Todd Lipcon has posted comments on this change. Change subject: Update version numbers on releases page to say incubating .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id62cc81f5045d73df6164fae950efd64fa4b5758 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd LipconGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Update links to kudu.apache.org
Todd Lipcon has submitted this change and it was merged. Change subject: Update links to kudu.apache.org .. Update links to kudu.apache.org Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Reviewed-on: http://gerrit.cloudera.org:8080/3522 Reviewed-by: Jean-Daniel CryansTested-by: Todd Lipcon --- M README.adoc M _posts/2016-02-26-apache-kudu-0-7-0-released.md M _posts/2016-03-10-apache-kudu-0-7-1-released.md M _posts/2016-04-11-apache-kudu-0-8-0-released.md M _posts/2016-04-11-weekly-update.md M _posts/2016-04-18-weekly-update.md M _posts/2016-04-19-kudu-0-8-0-predicate-improvements.md M _posts/2016-04-25-weekly-update.md M _posts/2016-05-03-weekly-update.md M _posts/2016-06-01-weekly-update.md M _posts/2016-06-02-no-default-partitioning.md M _posts/2016-06-10-apache-kudu-0-9-0-released.md M _posts/2016-06-13-weekly-update.md M _posts/2016-06-21-weekly-update.md M docs/release_notes.html M faq.md M releases/0.5.0/docs/release_notes.html M releases/0.6.0/docs/release_notes.html M releases/0.7.0/docs/release_notes.html M releases/0.7.1/docs/release_notes.html M releases/0.8.0/docs/release_notes.html M releases/0.9.0/docs/release_notes.html 22 files changed, 34 insertions(+), 34 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/3522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Update links to kudu.apache.org
Jean-Daniel Cryans has posted comments on this change. Change subject: Update links to kudu.apache.org .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd LipconGerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR] tablet: change default bloom filter FP rate to 0.01%
Todd Lipcon has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3517/2//COMMIT_MSG Commit Message: PS2, Line 25: https://gist.github.com/toddlipcon/1ab9b36b7fbae10b635d3a905e1fe55a > interesting how the changed graph seems to have a second life towards the e yea, guess I should have mentioned that -- that was me hacking out block cache memory tracking (KUDU-1502) -- To view, visit http://gerrit.cloudera.org:8080/3517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99bdd6298349a5be5f1fc3a666fe04305699e293 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd LipconGerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update version numbers on releases page to say incubating
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3523 to review the following change. Change subject: Update version numbers on releases page to say incubating .. Update version numbers on releases page to say incubating Change-Id: Id62cc81f5045d73df6164fae950efd64fa4b5758 --- M releases/index.md 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/3523/1 -- To view, visit http://gerrit.cloudera.org:8080/3523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id62cc81f5045d73df6164fae950efd64fa4b5758 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd LipconGerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR](gh-pages) Update links to kudu.apache.org
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3522 to review the following change. Change subject: Update links to kudu.apache.org .. Update links to kudu.apache.org Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 --- M README.adoc M _posts/2016-02-26-apache-kudu-0-7-0-released.md M _posts/2016-03-10-apache-kudu-0-7-1-released.md M _posts/2016-04-11-apache-kudu-0-8-0-released.md M _posts/2016-04-11-weekly-update.md M _posts/2016-04-18-weekly-update.md M _posts/2016-04-19-kudu-0-8-0-predicate-improvements.md M _posts/2016-04-25-weekly-update.md M _posts/2016-05-03-weekly-update.md M _posts/2016-06-01-weekly-update.md M _posts/2016-06-02-no-default-partitioning.md M _posts/2016-06-10-apache-kudu-0-9-0-released.md M _posts/2016-06-13-weekly-update.md M _posts/2016-06-21-weekly-update.md M docs/release_notes.html M faq.md M releases/0.5.0/docs/release_notes.html M releases/0.6.0/docs/release_notes.html M releases/0.7.0/docs/release_notes.html M releases/0.7.1/docs/release_notes.html M releases/0.8.0/docs/release_notes.html M releases/0.9.0/docs/release_notes.html 22 files changed, 34 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/3522/1 -- To view, visit http://gerrit.cloudera.org:8080/3522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0523a4840196c92c739aeae5c0de6d52cb1a72a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd LipconGerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] thirdparty: add boost and switch to header-only build
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b73a8e2a86099429b6032023a01a0da7b02371 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] locks: add new read-write mutex
Dan Burkert has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/5/src/kudu/util/mutex.cc File src/kudu/util/mutex.cc: Line 87: MicrosecondsInt64 end_time = GetMonoTimeMicros(); I still don't really get what this is about. Is the point just to avoid an unused variable warning on 'rv'? If so, why not just NOLINT that directly instead of jumping through these hoops. -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex
Dan Burkert has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] locks: change kudu::shared lock constructor to pass by ref
Dan Burkert has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] refactor AsyncKuduSession
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3477/3/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java: Line 409: DeferredbatchResponses = new Deferred<>(); > Nit: not really a fan of sometimes using Deferred.fromResult() and other ti Here is not a case with a result though, it's just creating a Deferred. -- To view, visit http://gerrit.cloudera.org:8080/3477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee6d029b1a56e254bfb9a870917883abeadb6b8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] master failover-itest: eliminate some flakiness
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3521 to review the following change. Change subject: master_failover-itest: eliminate some flakiness .. master_failover-itest: eliminate some flakiness Due to the inherent asynchronicity of SIGSTOP and the lack of "exactly once" semantics [1], it's possible for any DDL operation issued by these tests to return a result suggesting it had already been performed prior to being issued. See TestCreateTableSync for a detailed example. I've never run into this myself, but it has occurred at least once [2] in the wild. 1. Beyond basic EO semantics, RPC results would need to be persisted and replicated, neither of which are in scope for David's current project. 2. http://dist-test.cloudera.org:8080/diagnose?key=d73c47c0-3c15-11e6-8c40-0242ac110001 Change-Id: Ieba6da4d2a4333760022c68783c32dc2689a8a26 --- M src/kudu/integration-tests/master_failover-itest.cc 1 file changed, 45 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/3521/1 -- To view, visit http://gerrit.cloudera.org:8080/3521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieba6da4d2a4333760022c68783c32dc2689a8a26 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Todd Lipcon
[kudu-CR] master failover-itest: eliminate some flakiness
Kudu Jenkins has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2085/ -- To view, visit http://gerrit.cloudera.org:8080/3521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba6da4d2a4333760022c68783c32dc2689a8a26 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar DemboGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3142 to look at the new patch set (#4). Change subject: KUDU-1386 NaN float and double values are not handled correctly .. KUDU-1386 NaN float and double values are not handled correctly Previously, TypeInfo::Compare always returned 0 for comparisons with NaN. This meant that an equality predicate on a floating point column would always return all NaN values for the column. This patch changes Compare so that NaN compares > all non-NaN floating point values, and == to itself (contrary to IEEE754 standard), based on the suggestion from Todd Lipcon that we follow Postgres's example. Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae --- M src/kudu/client/predicate-test.cc M src/kudu/common/key_util.cc M src/kudu/common/types-test.cc M src/kudu/common/types.h 4 files changed, 101 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/3142/4 -- To view, visit http://gerrit.cloudera.org:8080/3142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Peter Ebert Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2084/ -- To view, visit http://gerrit.cloudera.org:8080/3142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Peter Ebert Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up
Kudu Jenkins has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2083/ -- To view, visit http://gerrit.cloudera.org:8080/3501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fb0d45f85786b9e2631b5dc0bf044a9d3192a39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will BerkeleyGerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 8: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2081/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: Integration test for replay cache
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2082/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3506 to look at the new patch set (#5). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Disable exactly once semantics by default and add a flag to enable it for tests Since exactly once semantics is still missing some pieces, like garbage collection this disables it by default on the client, but adds a flag to allow enabling it and enables it in all tests, by default. This allows to start adding exactly once semantics to some RPCs and run tests without enabling it globally. Note that the flag was added to env.cc as it had to be added somwhere that would be close to a top level dependency (for instance, adding it to the rpc system wouldn't allow to enable it in KuduTest). Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 --- M src/kudu/rpc/retriable_rpc.h M src/kudu/util/env.cc M src/kudu/util/test_util.cc 3 files changed, 20 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/3506/5 -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 5: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2080/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro AlvesGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: Integration test for replay cache
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3519 Change subject: WIP: Integration test for replay cache .. WIP: Integration test for replay cache This adds a new integration test for replay cache that writes to all replicas of a tablet at the same time. This uses the fact that all replicas must eventually agree, and once the result is stored in replay cache, followers can also reply to rpc's, to store all the responses obtained from all the replicas, for the same rpcs. This then proceeds to make sure the responses are the same. WIP because it needs cleanup and pulling of some suff to other patches. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/consensus/consensus_peers.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/service_if.cc M src/kudu/tablet/transactions/transaction_driver.cc 6 files changed, 212 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/1 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves