[GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20199 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20199#discussion_r160879315 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -842,6 +842,7 @@ class VersionsSuite extends SparkFunSuite with Logging { } test(s"$version: SPARK-17920: Insert into/overwrite avro table") { + assume(!(Utils.isWindows && version == "0.12")) --- End diff -- Nice. Yea, let's merge this one after adding a comment saying it's skipped because it's failed in the condition on Windows. Then, see if we can fix the root cause, and then re-enable this test in the PR if everything goes well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20199#discussion_r160709123 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -842,6 +842,7 @@ class VersionsSuite extends SparkFunSuite with Logging { } test(s"$version: SPARK-17920: Insert into/overwrite avro table") { + assume(!(Utils.isWindows && version == "0.12")) --- End diff -- @HyukjinKwon Ok, will comment. And I have find serval issues which exactly describe the same problem: - https://issues.apache.org/jira/browse/SPARK-12216 - https://issues.apache.org/jira/browse/SPARK-8333 - https://issues.apache.org/jira/browse/SPARK-18979 It seems this is a common issue exists on Windows and haven't been resolved yet. And I didn't find a accurate cause for the error from those issues. And now, I doubt this problem maybe related to URLClassLoader. And, I have reproduce the same issue after I did a experiment with URLClassLoader. Though, I'm not sure this is the real cause, yet. Working on this. We can merge this pr to master after I add comment. And open a new pr of that issue(if fixed) or communicate under one of those issues. WDYT? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20199#discussion_r160681813 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -842,6 +842,7 @@ class VersionsSuite extends SparkFunSuite with Logging { } test(s"$version: SPARK-17920: Insert into/overwrite avro table") { + assume(!(Utils.isWindows && version == "0.12")) --- End diff -- @Ngone51 Have you had a chance to check out the issue? If you can't find, let's leave a comment here saying like ... it's intendedly skipped because it fails on Windows. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20199: [Spark-22967][TESTS]Fix VersionSuite's unit tests...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20199#discussion_r160408416 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala --- @@ -58,7 +58,7 @@ class VersionsSuite extends SparkFunSuite with Logging { */ protected def withTempDir(f: File => Unit): Unit = { val dir = Utils.createTempDir().getCanonicalFile -try f(dir) finally Utils.deleteRecursively(dir) +f(dir) --- End diff -- Yea, sounds good. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org