[webkit-changes] [295754] trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp

2022-06-22 Thread timothy_horton 
Title: [295754] trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp








Revision 295754
Author timothy_hor...@apple.com
Date 2022-06-22 16:01:03 -0700 (Wed, 22 Jun 2022)


Log Message
Build is broken: bitwise operation between different enumeration types in ShareableBitmapCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=241876

Unreviewed build fix.

* Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:
(WebKit::bitmapInfo):
Add some casts.

Canonical link: https://commits.webkit.org/251759@main

Modified Paths

trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp




Diff

Modified: trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp (295753 => 295754)

--- trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp	2022-06-22 22:48:04 UTC (rev 295753)
+++ trunk/Source/WebKit/Shared/cg/ShareableBitmapCG.cpp	2022-06-22 23:01:03 UTC (rev 295754)
@@ -69,7 +69,7 @@
 {
 CGBitmapInfo info = 0;
 if (wantsExtendedRange(configuration)) {
-info |= kCGBitmapFloatComponents | kCGBitmapByteOrder16Host;
+info |= kCGBitmapFloatComponents | static_cast(kCGBitmapByteOrder16Host);
 
 if (configuration.isOpaque)
 info |= kCGImageAlphaNoneSkipLast;
@@ -76,7 +76,7 @@
 else
 info |= kCGImageAlphaPremultipliedLast;
 } else {
-info |= kCGBitmapByteOrder32Host;
+info |= static_cast(kCGBitmapByteOrder32Host);
 
 if (configuration.isOpaque)
 info |= kCGImageAlphaNoneSkipFirst;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295630] trunk

2022-06-17 Thread timothy_horton 
Title: [295630] trunk








Revision 295630
Author timothy_hor...@apple.com
Date 2022-06-16 23:58:01 -0700 (Thu, 16 Jun 2022)


Log Message
Record InteractionRegions per RenderLayer, instead of all on the root
https://bugs.webkit.org/show_bug.cgi?id=241503


Reviewed by Simon Fraser.

* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::pathsForRegion):
(WebCore::InteractionRegionOverlay::activeLayer const):
(WebCore::InteractionRegionOverlay::activeRegion const):
(WebCore::InteractionRegionOverlay::drawRect):
Hit test to the correct layer and retrieve regions from that layer for the debug overlay.
Also, fix some coordinate conversion now that we actually see non-root layers.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::cursorTypeForElement):
(WebCore::interactionRegionForRenderedRegion):
(WebCore::absoluteBoundingRectForRange): Deleted.
(WebCore::regionForElement): Deleted.
(WebCore::interactionRegions): Deleted.
* Source/WebCore/page/InteractionRegion.h:
Refactor InteractionRegion to take the same arguments as EventRegion::unite(),
so we can call it from there. Use the painting-originated rects in the Region,
instead of computing them ourselves.

* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegionContext::unite):
(WebCore::EventRegionContext::uniteInteractionRegions):
(WebCore::EventRegionContext::copyInteractionRegionsToEventRegion):
(WebCore::EventRegion::computeInteractionRegions): Deleted.
* Source/WebCore/rendering/EventRegion.h:
Collect InteractionRegions in a HashMap by element identifier, in order to
unite the rects for a given element -- but not *across* elements, like other EventRegions.
We need to keep them separate so that we can add an indicator for the united region.
Also, unusually, we maintain this map on the EventRegionContext as we paint, and copy them
to the serialized type at the end, to avoid having two different members on
EventRegion that are only valid on opposite sides of the process boundary.

* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
Stop computing interaction regions for the root layer.

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollLayerClipping):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paint):
Plumb the renderer through to EventRegionContext so that we can use it in
InteractionRegion::interactionRegionForRenderedRegion.

* LayoutTests/interaction-region/click-handler-in-shadowed-layer-expected.txt: Added.
* LayoutTests/interaction-region/click-handler-in-shadowed-layer.html: Added.
* LayoutTests/interaction-region/inline-link-in-layer-expected.txt: Added.
* LayoutTests/interaction-region/inline-link-in-layer.html: Added.
* LayoutTests/interaction-region/inline-link-in-composited-iframe-expected.txt: Added.
* LayoutTests/interaction-region/inline-link-in-composited-iframe.html: Added.
* LayoutTests/interaction-region/inline-link-in-non-composited-iframe-expected.txt: Added.
* LayoutTests/interaction-region/inline-link-in-non-composited-iframe.html: Added.
Add some tests.

Canonical link: https://commits.webkit.org/251635@main

Modified Paths

trunk/Source/WebCore/page/DebugPageOverlays.cpp
trunk/Source/WebCore/page/InteractionRegion.cpp
trunk/Source/WebCore/page/InteractionRegion.h
trunk/Source/WebCore/rendering/EventRegion.cpp
trunk/Source/WebCore/rendering/EventRegion.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderReplaced.cpp
trunk/Source/WebCore/rendering/TextBoxPainter.cpp


Added Paths

trunk/LayoutTests/interaction-region/click-handler-in-shadowed-layer-expected.txt
trunk/LayoutTests/interaction-region/click-handler-in-shadowed-layer.html
trunk/LayoutTests/interaction-region/inline-link-in-composited-iframe-expected.txt
trunk/LayoutTests/interaction-region/inline-link-in-composited-iframe.html
trunk/LayoutTests/interaction-region/inline-link-in-layer-expected.txt
trunk/LayoutTests/interaction-region/inline-link-in-layer.html
trunk/LayoutTests/interaction-region/inline-link-in-non-composited-iframe-expected.txt
trunk/LayoutTests/interaction-region/inline-link-in-non-composited-iframe.html




Diff

Added: trunk/LayoutTests/interaction-region/click-handler-in-shadowed-layer-expected.txt (0 => 295630)

--- trunk/LayoutTests/interaction-region/click-handler-in-shadowed-layer-expected.txt	(rev 0)
+++ trunk/LayoutTests/interaction-region/click-handler-in-shadowed-layer-expected.txt	2022-06-17 06:58:01 UTC (rev 295630)
@@ -0,0 +1,34 @@
+ (GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+

[webkit-changes] [295432] trunk/Source

2022-06-09 Thread timothy_horton 
Title: [295432] trunk/Source








Revision 295432
Author timothy_hor...@apple.com
Date 2022-06-09 13:30:57 -0700 (Thu, 09 Jun 2022)


Log Message
Upstream linkage of ApplePushService
https://bugs.webkit.org/show_bug.cgi?id=241473

Reviewed by Wenson Hsieh.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/251438@main

Modified Paths

trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WTF/wtf/PlatformHave.h (295431 => 295432)

--- trunk/Source/WTF/wtf/PlatformHave.h	2022-06-09 20:13:45 UTC (rev 295431)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2022-06-09 20:30:57 UTC (rev 295432)
@@ -1234,3 +1234,8 @@
 #if PLATFORM(MAC)
 #define HAVE_ADDITIONAL_APPLE_CAMERA_SERVICE 1
 #endif
+
+#if ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13) \
+|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16))
+#define HAVE_APPLE_PUSH_SERVICE_URL_TOKEN_SUPPORT 1
+#endif


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (295431 => 295432)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-06-09 20:13:45 UTC (rev 295431)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2022-06-09 20:30:57 UTC (rev 295432)
@@ -60,6 +60,13 @@
 WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
 WK_APPKIT_LDFLAGS_maccatalyst = -framework AppKit;
 
+WK_APPLE_PUSH_SERVICE_LDFLAGS = $(WK_APPLE_PUSH_SERVICE_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_APPLE_PUSH_SERVICE_LDFLAGS_iphoneos = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_IOS_16));
+WK_APPLE_PUSH_SERVICE_LDFLAGS_iphonesimulator = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_IOS_16));
+WK_APPLE_PUSH_SERVICE_LDFLAGS_IOS_SINCE_16 = -framework ApplePushService;
+WK_APPLE_PUSH_SERVICE_LDFLAGS_macosx = $(WK_APPLE_PUSH_SERVICE_LDFLAGS$(WK_MACOS_1300));
+WK_APPLE_PUSH_SERVICE_LDFLAGS_MACOS_SINCE_1300 = -framework ApplePushService;
+
 WK_BACKBOARD_SERVICES_LDFLAGS = $(WK_BACKBOARD_SERVICES_LDFLAGS_$(WK_PLATFORM_NAME));
 WK_BACKBOARD_SERVICES_LDFLAGS_iphoneos = -framework BackBoardServices;
 WK_BACKBOARD_SERVICES_LDFLAGS_iphonesimulator = -framework BackBoardServices;
@@ -166,7 +173,7 @@
 WK_INSTALL_COORDINATION_LDFLAGS_iphoneos = -framework InstallCoordination;
 WK_INSTALL_COORDINATION_LDFLAGS_iphonesimulator = $(WK_INSTALL_COORDINATION_LDFLAGS_iphoneos)
 
-FRAMEWORK_AND_LIBRARY_LDFLAGS = -lobjc -framework CFNetwork -framework CoreAudio -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework IOKit -framework IOSurface -framework WebKitLegacy -lnetwork -framework Metal $(WK_ACCESSIBILITY_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_BACKBOARD_SERVICES_LDFLAGS) $(WK_RUNNINGBOARD_SERVICES_LDFLAGS) $(WK_AUTHKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_CONTACTS_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) $(WK_CORE_SERVICES_LDFLAGS) $(WK_GRAPHICS_SERVICES_LDFLAGS) $(WK_LIBNETWORKEXTENSION_LDFLAGS) $(WK_LIBSANDBOX_LDFLAGS) $(WK_LIBWEBRTC_LDFLAGS) $(WK_MOBILE_CORE_SERVICES_LDFLAGS) $(WK_MOBILE_GESTALT_LDFLAGS) $(WK_PDFKIT_LDFLAGS) $(WK_PROTOTYPE_TOOLS_LDFLAGS) $(WK_SAFE_BROWSING_LDFLAGS) $(WK_SECURITY_INTERFACE_LDFLAGS) $(WK_UIKIT_LDFLAGS) $(WK_UNIFORM_TYPE_IDENTIFIERS_LDFLAGS) $(WK_URL_FORMATTING_LDFLAGS) $(WK_WEBINSPECTORUI_LDFLAGS) $(WK_COORDINATOR_LDFLAGS) $(WK_INSTALL_COORDINATION_LD
 FLAGS) $(WK_APP_STORE_DAEMON_LDFLAGS);
+FRAMEWORK_AND_LIBRARY_LDFLAGS = -lobjc -framework CFNetwork -framework CoreAudio -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework IOKit -framework IOSurface -framework WebKitLegacy -lnetwork -framework Metal $(WK_ACCESSIBILITY_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_APPLE_PUSH_SERVICE_LDFLAGS) $(WK_BACKBOARD_SERVICES_LDFLAGS) $(WK_RUNNINGBOARD_SERVICES_LDFLAGS) $(WK_AUTHKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_CONTACTS_LDFLAGS) $(WK_CORE_PREDICTION_LDFLAGS) $(WK_CORE_SERVICES_LDFLAGS) $(WK_GRAPHICS_SERVICES_LDFLAGS) $(WK_LIBNETWORKEXTENSION_LDFLAGS) $(WK_LIBSANDBOX_LDFLAGS) $(WK_LIBWEBRTC_LDFLAGS) $(WK_MOBILE_CORE_SERVICES_LDFLAGS) $(WK_MOBILE_GESTALT_LDFLAGS) $(WK_PDFKIT_LDFLAGS) $(WK_PROTOTYPE_TOOLS_LDFLAGS) $(WK_SAFE_BROWSING_LDFLAGS) $(WK_SECURITY_INTERFACE_LDFLAGS) $(WK_UIKIT_LDFLAGS) $(WK_UNIFORM_TYPE_IDENTIFIERS_LDFLAGS) $(WK_URL_FORMATTING_LDFLAGS) $(WK_WEBINSPECTORUI_LDFLAGS) $(WK_COORDINATOR_LDFLA
 GS) $(WK_INSTALL_COORDINATION_LDFLAGS) $(WK_APP_STORE_DAEMON_LDFLAGS);
 
 // Prevent C++ standard library basic_stringstream, operator new, delete and their related exception types from being exported as weak symbols.
 UNEXPORTED_SYMBOL_LDFLAGS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-unexported_symbol -Wl,__Znwm -Wl,-unexported_symbol -Wl,__ZTVNSt3__117bad_function_callE -Wl,-unexported_symbol

[webkit-changes] [295411] trunk/Source

2022-06-08 Thread timothy_horton 
Title: [295411] trunk/Source








Revision 295411
Author timothy_hor...@apple.com
Date 2022-06-08 22:15:13 -0700 (Wed, 08 Jun 2022)


Log Message
Upstream some camera-related sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=241446

Reviewed by Wenson Hsieh.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/251417@main

Modified Paths

trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WTF/wtf/PlatformHave.h (295410 => 295411)

--- trunk/Source/WTF/wtf/PlatformHave.h	2022-06-09 05:12:01 UTC (rev 295410)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2022-06-09 05:15:13 UTC (rev 295411)
@@ -1230,3 +1230,7 @@
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13)
 #define HAVE_SHARING_SERVICE_PICKER_POPOVER_SPI 1
 #endif
+
+#if PLATFORM(MAC)
+#define HAVE_ADDITIONAL_APPLE_CAMERA_SERVICE 1
+#endif


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (295410 => 295411)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2022-06-09 05:12:01 UTC (rev 295410)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2022-06-09 05:15:13 UTC (rev 295411)
@@ -2053,8 +2053,14 @@
 (with-filter (uid 0)
 (allow syscall-unix (syscall-number SYS_gettid))) ;; Needed for base system, see 
 
-#if USE(APPLE_INTERNAL_SDK)
-#include 
+#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE)
+(if (equal? (param "CPU") "arm64")
+(with-filter (extension "com.apple.webkit.camera")
+(allow mach-lookup
+(require-all
+(extension "com.apple.webkit.extension.mach")
+(global-name "com.apple.appleh13camerad")
+
 #endif
 
 #if HAVE(SANDBOX_MESSAGE_FILTERING)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295396] trunk

2022-06-08 Thread timothy_horton 
Title: [295396] trunk








Revision 295396
Author timothy_hor...@apple.com
Date 2022-06-08 15:32:16 -0700 (Wed, 08 Jun 2022)


Log Message
App-overridden WKScrollView deceleration is reset every time WebKit commits the layer tree
https://bugs.webkit.org/show_bug.cgi?id=241436


Reviewed by Simon Fraser.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView scrollViewWillBeginDragging:]):
* Source/WebKit/UIProcess/ios/WKScrollView.h:
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView setDecelerationRate:]):
(-[WKScrollView _setDecelerationRateInternal:]):
Like we do for many other properties, if the client sets the deceleration rate
on WKScrollView, stop overriding it internally.

* Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(TEST):
Add an API test.

Canonical link: https://commits.webkit.org/251402@main

Modified Paths

trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
trunk/Source/WebKit/UIProcess/ios/WKScrollView.h
trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm
trunk/Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm




Diff

Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (295395 => 295396)

--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2022-06-08 22:10:21 UTC (rev 295395)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm	2022-06-08 22:32:16 UTC (rev 295396)
@@ -1686,9 +1686,7 @@
 // FIXME: We will want to detect whether snapping will occur before beginning to drag. See WebPageProxy::didCommitLayerTree.
 WebKit::RemoteScrollingCoordinatorProxy* coordinator = _page->scrollingCoordinatorProxy();
 ASSERT(scrollView == _scrollView.get());
-CGFloat scrollDecelerationFactor = (coordinator && coordinator->shouldSetScrollViewDecelerationRateFast()) ? UIScrollViewDecelerationRateFast : UIScrollViewDecelerationRateNormal;
-scrollView.horizontalScrollDecelerationFactor = scrollDecelerationFactor;
-scrollView.verticalScrollDecelerationFactor = scrollDecelerationFactor;
+[_scrollView _setDecelerationRateInternal:(coordinator && coordinator->shouldSetScrollViewDecelerationRateFast()) ? UIScrollViewDecelerationRateFast : UIScrollViewDecelerationRateNormal];
 
 coordinator->setRootNodeIsInUserScroll(true);
 #endif


Modified: trunk/Source/WebKit/UIProcess/ios/WKScrollView.h (295395 => 295396)

--- trunk/Source/WebKit/UIProcess/ios/WKScrollView.h	2022-06-08 22:10:21 UTC (rev 295395)
+++ trunk/Source/WebKit/UIProcess/ios/WKScrollView.h	2022-06-08 22:32:16 UTC (rev 295396)
@@ -39,6 +39,7 @@
 - (void)_setScrollEnabledInternal:(BOOL)enabled;
 - (void)_setZoomEnabledInternal:(BOOL)enabled;
 - (BOOL)_setContentScrollInsetInternal:(UIEdgeInsets)insets;
+- (void)_setDecelerationRateInternal:(UIScrollViewDecelerationRate)rate;
 
 // FIXME: Likely we can remove this special case for watchOS and tvOS.
 #if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)


Modified: trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm (295395 => 295396)

--- trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm	2022-06-08 22:10:21 UTC (rev 295395)
+++ trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm	2022-06-08 22:32:16 UTC (rev 295396)
@@ -129,6 +129,7 @@
 
 BOOL _backgroundColorSetByClient;
 BOOL _indicatorStyleSetByClient;
+BOOL _decelerationRateSetByClient;
 // FIXME: Likely we can remove this special case for watchOS and tvOS.
 #if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
 BOOL _contentInsetAdjustmentBehaviorWasExternallyOverridden;
@@ -260,6 +261,20 @@
 super.indicatorStyle = indicatorStyle;
 }
 
+- (void)setDecelerationRate:(UIScrollViewDecelerationRate)rate
+{
+_decelerationRateSetByClient = YES;
+super.decelerationRate = rate;
+}
+
+- (void)_setDecelerationRateInternal:(UIScrollViewDecelerationRate)rate
+{
+if (_decelerationRateSetByClient)
+return;
+
+super.decelerationRate = rate;
+}
+
 static inline bool valuesAreWithinOnePixel(CGFloat a, CGFloat b)
 {
 return CGFAbs(a - b) < 1;


Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm (295395 => 295396)

--- trunk/Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm	2022-06-08 22:10:21 UTC (rev 295395)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm	2022-06-08 22:32:16 UTC (rev 295396)
@@ -282,4 +282,18 @@
 EXPECT_TRUE(CGColorEqualToColor([webView scrollView].backgroundColor.CGColor, whiteColor.get()));
 }
 
+TEST(WKScrollViewTests, DecelerationSetByClient)
+{
+auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 320, 500)]);
+
+[webView synchronouslyLoadHTMLStringAndWaitUntilAllImmediateChildFramesPaint:@"first"];
+EXPECT_FLOAT_EQ([webView scrollView].decelerationRate, UIScrollViewDecelerationRateNormal);
+
+[webView scrollView].decelerationRate = UIScrollViewDecelerationRateFast;
+EXPECT_FLOAT_EQ([webView scrollView].decelerationRate, UIScrollViewDecelerationRateFast);
+
+[webView synchronouslyLoadHTMLStringAndWaitUntilAllImmediateChildFramesPaint:@"second"];
+

[webkit-changes] [295378] trunk/Source/WebCore/platform/graphics/cocoa/ GraphicsContextCocoa.mm

2022-06-08 Thread timothy_horton 
Title: [295378] trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm








Revision 295378
Author timothy_hor...@apple.com
Date 2022-06-08 00:53:21 -0700 (Wed, 08 Jun 2022)


Log Message
Unreviewed build fix after r295376
https://bugs.webkit.org/show_bug.cgi?id=241406

* Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:

Canonical link: https://commits.webkit.org/251386@main

Modified Paths

trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm




Diff

Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm (295377 => 295378)

--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm	2022-06-08 07:26:02 UTC (rev 295377)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm	2022-06-08 07:53:21 UTC (rev 295378)
@@ -31,6 +31,7 @@
 #import "GraphicsContextPlatformPrivateCG.h"
 #import "IntRect.h"
 #import 
+#import 
 #import 
 #import 
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [295297] trunk/LayoutTests/compositing

2022-06-06 Thread timothy_horton 
Title: [295297] trunk/LayoutTests/compositing








Revision 295297
Author timothy_hor...@apple.com
Date 2022-06-06 14:46:41 -0700 (Mon, 06 Jun 2022)


Log Message
REGRESSION (r295269): compositing/hidpi-compositing-layer-with-zero-sized-container.html times out
https://bugs.webkit.org/show_bug.cgi?id=241346

Reviewed by Alan Bujtas.

* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html:
* LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html:
This test was slow before, but r295269 made it even slower due to WKTR's force repaint
now causing the compositing layers to repaint as well (a progression).

Reduce the number of layers per test from 1600 to 400, and split the test
in half; one test for offsets below 1, one for offsets between 1 and 2;
Alan says that rounding behavior is different between these two cases.

Canonical link: https://commits.webkit.org/251342@main

Modified Paths

trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html
trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html


Added Paths

trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html
trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html




Diff

Modified: trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html (295296 => 295297)

--- trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html	2022-06-06 21:35:24 UTC (rev 295296)
+++ trunk/LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html	2022-06-06 21:46:41 UTC (rev 295297)
@@ -20,9 +20,9 @@
 
   var container = document.getElementById("container");
   containerAdjustment = 0;
-  for (i = 0; i < 40; ++i) {
+  for (i = 0; i < 20; ++i) {
 var childAdjustment = 0;
-for (j = 0; j < 40; ++j) {
+for (j = 0; j < 20; ++j) {
   var c = document.createElement("div");
   c.className = "container";
   c.style.top = (6 * i + j * containerAdjustment) + "px";