[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 etonkovid...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #9 from James Forrester --- (In reply to etonkovidova from comment #8) > test2 has the same validation that is in betalabs: > > - cannot add Talk: as a template - 'Add template' is disabled > - cannot add a template or a category with |(a pipe), < and > chars > - if 'Page settings' redirection has aforementioned symbols - > MediaWiki:Badtitletext is displayed. Does it need some improvement? That sounds like it covers all our needs. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 etonkovid...@wikimedia.org changed: What|Removed |Added CC||etonkovid...@wikimedia.org --- Comment #8 from etonkovid...@wikimedia.org --- test2 has the same validation that is in betalabs: - cannot add Talk: as a template - 'Add template' is disabled - cannot add a template or a category with |(a pipe), < and > chars - if 'Page settings' redirection has aforementioned symbols - MediaWiki:Badtitletext is displayed. Does it need some improvement? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 James Forrester changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Target Milestone|VE-deploy-nextup|VE-deploy-2014-11-05 ||(1.25wmf7) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #7 from Gerrit Notification Bot --- Change 169623 merged by jenkins-bot: Introducing isValid() in MWTitileInputWidget https://gerrit.wikimedia.org/r/169623 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 Gerrit Notification Bot changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #6 from Gerrit Notification Bot --- Change 169623 had a related patch set uploaded by SuchetaG: Introducing isValid() in MWTitileInputWidget https://gerrit.wikimedia.org/r/169623 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 Roan Kattouw changed: What|Removed |Added Assignee|kren...@wikimedia.org |sucheta.ghos...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 Roan Kattouw changed: What|Removed |Added Blocks||72468 --- Comment #5 from Roan Kattouw --- This is scarily close to what I filed bug 72468 about. While filing it I was thinking that an isValid() implementation should also be provided. I'll add that to that bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #4 from Alex Monk --- (In reply to James Forrester from comment #3) > (In reply to Alex Monk from comment #1) > > Currently the redirect section of the page settings dialog and the template > > placeholder page use MWTitleInputWidget. > > > > The template placeholder page can be fixed with a simple change from value > > === '' to !mw.Title.newFromText( value ) in > > MWTemplatePlaceholderPage#onTemplateInputChange. It will no longer allow you > > to add a template with an invalid name. No need for isValid here. > > What happens when you use a parser function or a magic word? I imagine it would break. So let's not do that. > > As for the redirect settings, that seems more difficult. I don't think we > > should just silently ignore the value if it was set to an invalid title... > > And I don't think we should disable the apply button either. > > We show "invalid title" for link searches; presumably that's evaluated > server-side? That is shown when the page does not seem to exist (based on the search results) and we get a false-y value from mw.Title.newFromText on the given title. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2014-10-16|VE-deploy-nextup -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2014-10-09|VE-deploy-2014-10-16 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #3 from James Forrester --- (In reply to Alex Monk from comment #1) > Currently the redirect section of the page settings dialog and the template > placeholder page use MWTitleInputWidget. > > The template placeholder page can be fixed with a simple change from value > === '' to !mw.Title.newFromText( value ) in > MWTemplatePlaceholderPage#onTemplateInputChange. It will no longer allow you > to add a template with an invalid name. No need for isValid here. What happens when you use a parser function or a magic word? > As for the redirect settings, that seems more difficult. I don't think we > should just silently ignore the value if it was set to an invalid title... > And I don't think we should disable the apply button either. We show "invalid title" for link searches; presumably that's evaluated server-side? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #2 from Alex Monk --- Bump. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 James Forrester changed: What|Removed |Added Target Milestone|VE-deploy-2014-10-02|VE-deploy-2014-10-09 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 James Forrester changed: What|Removed |Added Priority|Unprioritized |High Target Milestone|VE-deploy-2014-09-25|VE-deploy-2014-10-02 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 --- Comment #1 from Alex Monk --- Currently the redirect section of the page settings dialog and the template placeholder page use MWTitleInputWidget. The template placeholder page can be fixed with a simple change from value === '' to !mw.Title.newFromText( value ) in MWTemplatePlaceholderPage#onTemplateInputChange. It will no longer allow you to add a template with an invalid name. No need for isValid here. As for the redirect settings, that seems more difficult. I don't think we should just silently ignore the value if it was set to an invalid title... And I don't think we should disable the apply button either. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71249] VisualEditor: TitleInputWidget should validate inputs
https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 Roan Kattouw changed: What|Removed |Added CC||roan.katt...@gmail.com Assignee|jforrester+veteambztickets@ |kren...@wikimedia.org |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
