On Sat, 13 May 2023 16:42:33 GMT, Marius Hanl wrote:
>> Carl Döbbelin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added isEmbedded
>
> modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/HostUtils.java
> line 60:
>
>> 58:
On Thu, 11 May 2023 17:59:48 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 14:57:31 GMT, Carl Döbbelin wrote:
> I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader`
> class, as the PlatformUtils are not Exported to the corresponding module.
I wonder if this was done on purpose.
-
PR Comment: https://git.openjdk.org
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Found an occurrences:
* `com.sun.javafx.application.LauncherImpl` line 386.
* `com.sun.media.jfxmediaimpl.HostU
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote:
> Focused only on raw type problems, and removing casts that were no longer
> needed because of the changes.
I started reviewing but there are too many files, which makes the GitHub
interface unresponsive. Can you break it into 4 PRs of ~5
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote:
> Adding TextFlow.underlineShape() to add support for a spellchecker-like
> decoration, using
>
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>
>
> which mirrors an existing method in Text with exactly the same signature.
I'm not f
On Tue, 9 May 2023 18:26:02 GMT, Andy Goryachev wrote:
>> Don't think we have an enum (maybe we should), but `PlatformUtil` already
>> takes care of identifying the OS, also using
>> `System.getProperty("os.name")`. You can use `PlatformUtil.isMac()`. If we
>> make an enum, that's where is sho
On Tue, 9 May 2023 17:54:35 GMT, Andy Goryachev wrote:
>> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>>
>> Only Windows and macOS parts were affected, tests work good on both
>> platforms.
>>
>> I looked through the code and didn't find any other cases of
>> `R
f code.
> And this would also be useful for developers as this abstract superclass
> deals already with e.g. all the *children* property stuff for you when
> extending such superclass.
>
> -- Marius
>
> *Gesendet:* Montag, 08. Mai 2023 um 23:18 Uhr
> *Von:* "Nir Lisker&qu
d-off-by: Nir Soffer
---
subprojects/libvhost-user/libvhost-user.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 8fb61e2df2..5f26d2d378 100644
--- a/sub
present though.
I think that some prototyping is required first.
- Nir
[1] https://bugs.openjdk.org/browse/JDK-8091607
[2] https://bugs.openjdk.org/browse/JDK-8226456
On Mon, May 8, 2023 at 10:03 PM Carl Carlec wrote:
> Hello JavaFX community,
> I've created a draft PR for an enh
On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Wed, 3 May 2023 20:55:42 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
>> 741:
>>
>>> 739: *
>>> 740: * @param hgap the width of the horizontal gaps between columns
>>> 741: * @param vgap the height of the vertical gaps
On Wed, 3 May 2023 21:03:57 GMT, Andy Goryachev wrote:
>> I will change them in my next commit. Completely forgot about them. :)
>
> I thought it's only in jdk, not jfx. @kevinrushforth could you confirm that?
We use the script every release.
-
PR Review Comment: https://git.openj
On Wed, 3 May 2023 20:23:19 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
>> 737:
>>
>>> 735: }
>>> 736:
>>> 737: /**
>>
>> we probably need to update the year `2011, 2023,` in the header
>
> also in the test.
There is a sc
On Wed, 3 May 2023 20:13:42 GMT, Marius Hanl wrote:
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, th
On Sat, 18 Feb 2023 17:59:12 GMT, Nir Lisker wrote:
> Most of the changes revolve around unifying the sorting methods for a
> collection with `Comparable` elements with sorting methods that take an
> external `Comparator` by passing `Comparator.naturalOrder()` from the former
> t
If I knew what the fix was I would have. Right now I'm not sure anymore
what the correct behavior should be even.
On Mon, May 1, 2023 at 10:44 PM Andy Goryachev
wrote:
> Nir, would you like to submit a pull request?
>
>
>
> Thank you
>
> -andy
>
>
>
>
rging the stage horizontally while AS_NEEDED is
selected does not reallocate the space (you need to toggle the policies).
I'm guessing there's a missing call to layoutChildren during this resizing.
Does anyone have any input here?
Thanks,
Nir
[1] https://bugs.openjdk.org/browse/JDK-8199934
On Fri, 28 Apr 2023 12:46:38 GMT, Kevin Rushforth wrote:
>> The formatter is set to 120 characters in a line, I think it's fine to leave
>> as is.
>
> If you were already modifying this, then sure. I don't think Ambarish's point
> was about the line being too long. In this case, the rewrapping
On Fri, 28 Apr 2023 06:30:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Added missing space
>> - Merge branch 'ma
ome warnings
> suppressions.
>
> Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is
> unrelated to this test.
Nir Lisker has updated the pull request incrementally with two additional
commits since the last revision:
- Addressed review comments for S
> Adds the javadoc commands to generate the NEW page and to be able to select
> versions in the DEPRECATED page.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Auto-detect latest version
-
Changes:
- all:
On Fri, 21 Apr 2023 13:30:38 GMT, Nir Lisker wrote:
> 3. Each major release, a new version string will need to be added.
This can be solved by reading the major version directly from the properties
file, but it would require to script the generation of the string that includes
the versi
Vote: YES
On Wed, Apr 26, 2023 at 8:33 PM Philip Race wrote:
> Vote: yes
>
> -phil.
>
>
ome warnings
> suppressions.
>
> Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is
> unrelated to this test.
Nir Lisker has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- Adde
'copy', 'fill', 'reverse', 'rotate' etc.
These all state that one change notification is fired on the supplied
ObservableList, but just calls its 'setAll', so there is no actual
guarantee that only one event will be fired.
Did ObservableList mean to specify that bulk operations are reported as one
change?
- Nir
On Fri, 21 Apr 2023 22:14:58 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/SequencedMap.java line 152:
>>
>>> 150: var it = entrySet().iterator();
>>> 151: return it.hasNext() ? Map.Entry.copyOf(it.next()) : null;
>>> 152: }
>>
>> Would is be better to fi
On Fri, 21 Apr 2023 13:18:31 GMT, Nir Lisker wrote:
> Adds the javadoc commands to generate the NEW page and to be able to select
> versions in the DEPRECATED page.
Notes to reviewers:
1. The `-since` option does not play well with the javafx one: if documentation
was added on a `p
Adds the javadoc commands to generate the NEW page and to be able to select
versions in the DEPRECATED page.
-
Commit messages:
- Added 'since' releases for the New and Deprecated pages
Changes: https://git.openjdk.org/jfx/pull/1109/files
Webrev: https://webrevs.openjdk.org/?repo=
example, it can be enabled via a command line option, then it would
> be easy to add that conditional on checking that the current boot JDK is
> new enough. Maybe you can file an RFE.
>
> -- Kevin
>
>
> On 4/20/2023 7:27 AM, Nir Lisker wrote:
>
> Any info on this?
>
&g
Any info on this?
On Tue, Apr 11, 2023 at 4:43 AM Nir Lisker wrote:
> Hi,
>
> I noticed that the JDK's javadoc contains a 'NEW' section [1], but
> JavaFX's docs don't have it. Do we need to update the javadoc tool?
>
> [1] https://docs.oracle.c
On Thu, 20 Apr 2023 04:19:55 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with four additional
> commits since the last revision:
>
> - Add missing @throws and @since tags.
> - Convert code samples to snip
On Wed, 19 Apr 2023 18:22:28 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/SequencedMap.java line 110:
>>
>>> 108: * {@code Entry} thus obtained will update a mapping in the underlying
>>> map, or whether
>>> 109: * it will throw an exception, or whether changes to the und
On Wed, 19 Apr 2023 14:41:59 GMT, Nir Lisker wrote:
>> Stuart Marks has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove unnecessary 'final' from a couple places.
>> - Clarify ordering
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Remove unnecessary 'final' from a couple places.
> - Clarify orderin
On Tue, 18 Apr 2023 20:12:01 GMT, Andy Goryachev wrote:
> Monkey Tester - a JavaFX application designed to support ad-hoc testing of
> JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> , and adds methods that can provide `Subscription`s in
>> `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one addition
On Mon, 17 Apr 2023 11:25:53 GMT, John Hendrikx wrote:
>> Description copied from issue:
>>
>> There are up to two additional invalidations performed that really should be
>> avoided, causing downstream fluent bindings to be recomputed with the same
>> values. This is very confusing as these
When building from git we need autoconf, automake and libtool.
Signed-off-by: Nir Soffer
---
Changes sinve v1:
- Remove `,` between package namses (Laszlo)
README.md | 7 +++
1 file changed, 7 insertions(+)
diff --git a/README.md b/README.md
index c7166613..7eed0e31 100644
--- a
On Mon, Apr 17, 2023 at 7:38 PM Laszlo Ersek wrote:
>
> On 4/17/23 18:36, Nir Soffer wrote:
> > When building from git we need autoconf, automake and libtool.
> >
> > Signed-off-by: Nir Soffer
> > ---
> > README.md | 7 +++
> > 1 file changed, 7 in
When building from git we need autoconf, automake and libtool.
Signed-off-by: Nir Soffer
---
README.md | 7 +++
1 file changed, 7 insertions(+)
diff --git a/README.md b/README.md
index c7166613..42a187c0 100644
--- a/README.md
+++ b/README.md
@@ -32,10 +32,17 @@ ## License
very liberal
On Mon, 17 Apr 2023 07:23:40 GMT, John Hendrikx wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit sin
On Mon, 17 Apr 2023 07:23:40 GMT, John Hendrikx wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit sin
On Fri, 14 Apr 2023 09:47:45 GMT, John Hendrikx wrote:
>> These changes use base classes for custom properties where possible for the
>> `ExpressionHelper` logic instead of duplicating these each time.
>
> John Hendrikx has refreshed the contents of this pull request, and previous
> commits hav
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
On Sat, 15 Apr 2023 01:36:48 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java
>> line 44:
>>
>>> 42: * an observable form.
>>> 43: */
>>> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase {
>>
>> Maybe
On Mon, 17 Apr 2023 04:51:03 GMT, Michael Strauß wrote:
> I don't know what "visual events" are, maybe input events?
I thought something like that too, including scroll and touch events. Maybe
@kevinrushforth knows.
> Anyway, the added value of this entire javadoc seems to be rather low, I'm
On Sat, 15 Apr 2023 18:01:28 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
On Tue, 11 Apr 2023 07:57:56 GMT, John Hendrikx wrote:
>> Fixes three issues in ExpressionHelper:
>>
>> - Current Value was not retained when changing from SingleChange to Generic,
>> this can lead to missed changes
>> - Current Value was not retained when changing from Generic to SingleChange,
Hi,
I noticed that the JDK's javadoc contains a 'NEW' section [1], but
JavaFX's docs don't have it. Do we need to update the javadoc tool?
[1] https://docs.oracle.com/en/java/javase/19/docs/api/new-list.html
- Nir
On Mon, 10 Apr 2023 00:14:31 GMT, John Hendrikx wrote:
> Well, I am just following the specification here, but JavaFX itself isn't...
>
> We may need to make a decision here. JavaFX is not consistent itself where it
> applies `equals` and where it uses reference equality:
Alright, so this is f
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Sun, 9 Apr 2023 21:27:36 GMT, John Hendrikx wrote:
>> Description copied from issue:
>>
>> There are up to two additional invalidations performed that really should be
>> avoided, causing downstream fluent bindings to be recomputed with the same
>> values. This is very confusing as these s
On Sun, 9 Apr 2023 09:04:15 GMT, John Hendrikx wrote:
> > Also, I really wish we could make `add/removeListener` throw on `null` :)
>
> You mean immediately? Because the `null` check is done by `ExpressionHelper`
> already. What I wish for is that `removeListener` would throw when removing
> n
On Fri, 7 Apr 2023 06:36:50 GMT, John Hendrikx wrote:
>> Description copied from issue:
>>
>> There are up to two additional invalidations performed that really should be
>> avoided, causing downstream fluent bindings to be recomputed with the same
>> values. This is very confusing as these s
On Fri, 7 Apr 2023 06:36:50 GMT, John Hendrikx wrote:
>> Description copied from issue:
>>
>> There are up to two additional invalidations performed that really should be
>> avoided, causing downstream fluent bindings to be recomputed with the same
>> values. This is very confusing as these s
On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx wrote:
> Fixes three issues in ExpressionHelper:
>
> - Current Value was not retained when changing from SingleChange to Generic,
> this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange,
> t
On Sun, 2 Apr 2023 23:50:15 GMT, Michael Strauß wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
On Sat, 1 Apr 2023 18:14:11 GMT, Michael Strauß wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
On Wed, 22 Mar 2023 14:10:20 GMT, Kevin Rushforth wrote:
> @nlisker do you also want to review this?
Yes, but it will take me a bit of time to get to it.
-
PR Comment: https://git.openjdk.org/jfx/pull/1023#issuecomment-1479756994
On Thu, 16 Mar 2023 17:14:28 GMT, Kevin Rushforth wrote:
>> Release notes for JavaFX 20, including one important change to note (the
>> requirement of JDK 17 as the minimum needed to run JavaFX 20) and the list
>> of enhancements and bugs fixed in this release.
>>
>> Note: This PR is targeted
erpret-trailers --in-place --trailer "$sob" "$1"
You can also use a pre-commit hook but the commit-msg hook is more
convenient.
And in github you can add the DCO application to the project:
https://github.com/apps/dco
Once installed it will check that all commits are signed off, and
provide helpful error
messages to contributors.
Nir
erpret-trailers --in-place --trailer "$sob" "$1"
You can also use a pre-commit hook but the commit-msg hook is more
convenient.
And in github you can add the DCO application to the project:
https://github.com/apps/dco
Once installed it will check that all commits are signed off, and
provide helpful error
messages to contributors.
Nir
erpret-trailers --in-place --trailer "$sob" "$1"
You can also use a pre-commit hook but the commit-msg hook is more
convenient.
And in github you can add the DCO application to the project:
https://github.com/apps/dco
Once installed it will check that all commits are signed off
t of view of the client. Maybe make this more clear?
> Makes no difference to implementations (other than older code
> still using 'handle' may be slightly harder to tie back to the spec).
To avoid confusion with older code that carefully used "handle" to match
the spec, maybe add a note that "cookie" was named "handle" before?
Nir
t of view of the client. Maybe make this more clear?
> Makes no difference to implementations (other than older code
> still using 'handle' may be slightly harder to tie back to the spec).
To avoid confusion with older code that carefully used "handle" to m
On Thu, Mar 2, 2023 at 10:46 AM Richard W.M. Jones wrote:
>
> On Mon, Feb 27, 2023 at 07:09:33PM +0200, Nir Soffer wrote:
> > On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones
> > wrote:
> > > I think it would be more useful if (or in addition) it could compute
>
s use that for probing against other hash(block[m]) values, and
> maybe determine repeating patterns in the plaintext. I'm not a
> cryptographer so I can't exactly show what security property is broken
> by separating the IV from block[n].
>
> > (This is what blkhash solves, but unfortunately the out
On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones wrote:
>
> On Mon, Feb 27, 2023 at 04:24:33PM +0200, Nir Soffer wrote:
> > On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones
> > wrote:
> > >
> > >
> > > https://github.com/kubevirt/containerized-
d to package it for Fedora/CentOS Stream.
I also work on "qemu-img checksum", getting more reviews on this can help:
Lastest version:
https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00971.html
Last reveiw are here:
https://lists.nongnu.org/archive/html/qemu-block/2022-12/
M
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
This pull request has now been integrated.
Changeset: 7bf2372b
Author: Nir Lisker
URL:
https://git.openjdk.org/jfx/commit/7bf2372baf8ea719b8b611cd1476596d8c141c50
Stats:
ld *not* be increased. I
> distinctly remember that, because it surprised me -- I actually recalled
> an *even earlier* experience reading the documentation, which had again
> stated that "O" would increase the reference count.
Maybe here:
https://docs.python.org/2/c-api/arg.html#building-values
Looks like another incompatibility between python 2 and 3.
Nir
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
On Wed, 15 Feb 2023 09:46:22 GMT, John Hendrikx wrote:
>> This contains the following:
>> - Nested changes or invalidations using ExpressionHelper are delayed until
>> the current emission completes
>> - This fixes odd change events being produced (with incorrect oldValue)
>> - Also fixes a
On Wed, 15 Feb 2023 09:46:22 GMT, John Hendrikx wrote:
>> This contains the following:
>> - Nested changes or invalidations using ExpressionHelper are delayed until
>> the current emission completes
>> - This fixes odd change events being produced (with incorrect oldValue)
>> - Also fixes a
On Sat, 18 Feb 2023 19:29:05 GMT, John Hendrikx wrote:
> Confusing me again here :-) Did you mean to say "breadth-first" where you
> said "depth-first" ?
>
> Breadth first is for sure a lot easier, as the old values are much easier to
> get correct for it.
>
> I've given depth first some more
On Tue, 14 Feb 2023 23:27:07 GMT, John Hendrikx wrote:
> I couldn't quite see which you prefer here; you said "This one makes sense"
> but not quite sure which version it refers to (I suppose the depth first
> version?)
I should have said "this one makes sense **too**". The point was that whil
Most of the changes revolve around unifying the sorting methods for a
collection with `Comparable` elements with sorting methods that take an
external `Comparator` by passing `Comparator.naturalOrder()` from the former to
the latter. This eliminates method duplication and some warnings suppressi
Vote: Yes
On Fri, Feb 17, 2023, 04:54 Philip Race wrote:
> Vote: yes
>
> -phil
>
>
On Sun, 5 Feb 2023 20:11:35 GMT, John Hendrikx wrote:
> I don't think we should care about depth-first, breadth-first. The only thing
> that I think is important here is that the contract of ChangeListener is
> respected. I think that that contract should be:
...
I'll be more concrete. Here is
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
On Sun, 1 Jan 2023 15:25:01 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 1640:
>>
>>> 1638: @Override
>>> 1639: public Iterator iterator() {
>>> 1640: return new Iterator<>() {
>>
>> Here the empty `Set
On Wed, 8 Feb 2023 15:05:46 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request with a new
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote:
>
> On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users
> wrote:
> >
> > Hi All,
> >
> > We backup our VM's with a custom script based on the
> > https://github.com/oVirt/python-ovirt-engine-sdk4
On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote:
>
> On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users
> wrote:
> The easiest way would be to enable debug logs - it will be even slower,
> but we will see these logs showing all extents:
Using the --debug option
Run ba
o there will be 4 threads on the server size serving the data.
Please share debug log of a slow backup, and info about the backup image storage
for example, is this local file system or NFS?
Nir
___
Users mailing list -- users@ovirt.org
To unsubscri
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1025/files
- new: ht
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
-
Changes:
- all: ht
On Tue, 7 Feb 2023 19:52:14 GMT, Kevin Rushforth wrote:
>> A specialized layout... +1
>
> +1 from me as well.
Suggestion:
* A specialized layout for rich text.
-
PR: https://git.openjdk.org/jfx/pull/1025
On Tue, 7 Feb 2023 13:05:21 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>
On Tue, 7 Feb 2023 12:25:14 GMT, John Hendrikx wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>
On Tue, 7 Feb 2023 12:17:43 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with three additional
commits since the last revision:
- Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
Co-authored-by: John Hendrikx
- Upd
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update
modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java
Co-authored-by: John Hendr
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
Integrating can wait until a bit before the release to allow for more mistakes
to be included.
-
PR: https://git.openjdk.org/jfx/pull/1025
Fixes and cleanup in the areas in the linked issue.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1025/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1025&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8293587
Stats: 50 lines in 6 fi
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request incrementa
401 - 500 of 7236 matches
Mail list logo
