On Wed, 9 Mar 2022 07:04:56 GMT, David Holmes wrote:
> I have reservations about contorting things this way just to get
> "deterministic output".
>
> The VM needs to fully initialize and then become quiescent before the dump
> occurs, and as I say below if you don't start other threads then
On Wed, 9 Mar 2022 06:49:02 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/prims/jvm.cpp line 2873:
>
>> 2871: // execute in parallel, symbols and classes
On Wed, 9 Mar 2022 05:10:44 GMT, Ioi Lam wrote:
>> This patch makes the result of "java -Xshare:dump" deterministic:
>> - Disabled new Java threads from launching. This is harmless. See comments
>> in jvm.cpp
>> - Fixed a problem in hashtable ordering in heapShared.cpp
>> - BasicHashtableEntry
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a gap on 64-bit platforms that may contain random
On Tue, 8 Mar 2022 14:02:35 GMT, Magnus Ihse Bursie wrote:
>> I'm of the opinion that options which cannot have empty values, and will
>> fall back to default ones if no explicit one is provided, would generate an
>> error if --without-* is passed, while others that _can_ have empty values
>>
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what module represents the caller with no stack frame is
On Tue, 8 Mar 2022 19:11:02 GMT, Ioi Lam wrote:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
> - BasicHashtableEntry has a
This patch makes the result of "java -Xshare:dump" deterministic:
- Disabled new Java threads from launching. This is harmless. See comments in
jvm.cpp
- Fixed a problem in hashtable ordering in heapShared.cpp
- BasicHashtableEntry has a gap on 64-bit platforms that may contain random
bits.
On Thu, 3 Mar 2022 16:55:46 GMT, Tim Prinzing wrote:
>> The caller class returned by Reflection::getCallerClass was used to gain
>> access to it's module in most cases and class loader in one case. I added a
>> method to translate the caller class to caller module so that the decision
>> of
On Mon, 7 Mar 2022 22:47:13 GMT, Magnus Ihse Bursie wrote:
> The BSD version of the date command that ships with macOS cannot handle all
> ISO 8601 formats. More specifically, it cannot handle trailing milliseconds.
>
> This fix will allow it to be more tolerant.
This pull request has now
On Tue, 8 Mar 2022 02:48:45 GMT, Julian Waters wrote:
>> ... and this goes for all the changes in the PR.
>
> I'm of the opinion that options which cannot have empty values, and will fall
> back to default ones if no explicit one is provided, would generate an error
> if --without-* is passed,
On Mon, 7 Mar 2022 23:32:33 GMT, Magnus Ihse Bursie wrote:
> For reproducability, we should set the source date on jib profiles from the
> buildId.
This pull request has now been integrated.
Changeset: c6d743fb
Author:Magnus Ihse Bursie
URL:
On Mon, 7 Mar 2022 23:32:33 GMT, Magnus Ihse Bursie wrote:
> For reproducability, we should set the source date on jib profiles from the
> buildId.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7735
On Tue, 8 Mar 2022 04:15:51 GMT, David Holmes wrote:
> Passing --without-x makes no sense at all IMHO.
Even so, I'd argue that it should be handled properly and show what really went
wrong, rather than throwing, for instance, "no is not a valid version string"
(In the case of
15 matches
Mail list logo
