On Tue, 8 Mar 2022 04:15:51 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Passing --without-x makes no sense at all IMHO. Even so, I'd argue that it should be handled properly and show what really went wrong, rather than throwing, for instance, "no is not a valid version string" (In the case of --without-version-string). Besides, to an outside observer some of the configure options that cannot have --without-* set would still seem to make sense when glanced over, it may not be immediately obvious that said option cannot have no value. Even without the errors though, many of the configure options also don't check if --without-* is passed, which would result in the silent build error of setting said option to a literal "no", that would appear to have worked correctly regardless (All the --with-vender-* options are examples of this) > If you pass "" as the value then you get what you deserve if the build fails. I've been wondering if I should fold that into the "yes" check for several of them, since many interpret --with-*= as "use the default value" ------------- PR: https://git.openjdk.java.net/jdk/pull/7713
