[PATCH] testsuite: fix last "which" change

2014-01-19 Thread Michael Tokarev
urrent value of PATH where our busybox binary resides. Signed-off-by: Michael Tokarev --- testsuite/which/which-uses-default-path |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/which/which-uses-default-path b/testsuite/which/which-uses-default-path index 349583d..

1.22: zcat does not decompress data anymore [bisected]

2014-01-28 Thread Michael Tokarev
Since this commit: commit 41655438c6b61d05ddf3619f31abc1fa3583e2be Author: Denys Vlasenko Date: Thu Feb 28 18:37:04 2013 +0100 zcat: fix "zcat FILE" trying to do detection twice busybox's zcat does not decompress files without .gz extension anymore: $ gzip < README > x $ ./busybox zcat

Re: 1.22: zcat does not decompress data anymore [bisected]

2014-01-28 Thread Michael Tokarev
28.01.2014 12:48, Michael Tokarev пишет: > Since this commit: > > commit 41655438c6b61d05ddf3619f31abc1fa3583e2be > Author: Denys Vlasenko > Date: Thu Feb 28 18:37:04 2013 +0100 > > zcat: fix "zcat FILE" trying to do detection twice > > busybox

[PATCH trivial] do not fail build if SIGPWR is not defined

2014-01-29 Thread Michael Tokarev
Apparently, some *BSD variants (and maybe some other OSes) does not define SIGPWR signal. So since commit 760fc6debcba8c, busybox fails to build on such platforms. Fix this. Signed-off-By: Michael Tokarev diff --git a/init/init.c b/init/init.c index d29328c..992a21e 100644 --- a/init/init.c

Re: [PATCH trivial] do not fail build if SIGPWR is not defined

2014-01-29 Thread Michael Tokarev
29.01.2014 12:51, Harald Becker пишет: > Hi Michael ! > >> Apparently, some *BSD variants (and maybe some other OSes) does >> not define SIGPWR signal. So since commit 760fc6debcba8c, >> busybox fails to build on such platforms. Fix this. > >> +#ifdef SIGPWR >> + (1 << SIGP

Re: mdev and post 3.6 kernels

2014-02-09 Thread Michael Tokarev
09.02.2014 05:28, Michael J. Hammel wrote: > I've been using 3.2.27 from the RPi repos with mdev and usbfs. This > worked fine to load drivers for wifi and webcams. I'm trying to move to > RPi's "3.10.y" branch. I've found that usbfs is deprecated and now I'm > not sure how to find the usb devic

[PATCH] iproute: support onelink route option and print route flags

2014-07-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- networking/libiproute/iproute.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/networking/libiproute/iproute.c b/networking/libiproute/iproute.c index ec4d8ba..273f6fe 100644 --- a/networking/libiproute/iproute.c +++ b

[PATCH] iproute: support onelink route option and print route flags

2014-07-27 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- networking/libiproute/iproute.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/networking/libiproute/iproute.c b/networking/libiproute/iproute.c index ec4d8ba..273f6fe 100644 --- a/networking/libiproute/iproute.c +++ b

Fwd: [PATCH] iproute: support onelink route option and print route flags

2014-07-27 Thread Michael Tokarev
0/2.5/0.85, \ dsn=2.0.0, status=sent (250 2.0.0 Ok: queued as 669BE8C12E) (The timestamp is in UTC). Resending again now using my regular MUA, just in case, and adding a Cc to postmaster@... Thanks, /mjt --- Begin Message --- Signed-off-by: Michael Tokarev --- networking/libiproute/ipro

Re: Fwd: [PATCH] iproute: support onelink route option and print route flags

2014-07-27 Thread Michael Tokarev
28.07.2014 10:23, Michael Tokarev wrote: > Hello. I submitted the attached patch to the list 2 times, but > it never made into the list for some reason. Last time was > today, here's a line from my maillog: > > Jul 28 06:05:45 isrv postfix/smtp[24869]: 4586B45736: >

Re: Fwd: [PATCH] iproute: support onelink route option and print route flags

2014-07-28 Thread Michael Tokarev
28.07.2014 10:46, Baruch Siach wrote: [] > I received your original post today. It's also on the gmane.org archive at > http://article.gmane.org/gmane.linux.busybox/39641. Oh. I think I know what's going on. The mailing list does not send email to the author if he's already listed in a Cc list.

Re: Fwd: [PATCH] iproute: support onelink route option and print route flags

2014-11-10 Thread Michael Tokarev
A friendly ping, https://www.mail-archive.com/busybox@busybox.net/msg19972.html . It's been several months already, apparently forgotten. Thanks, /mjt ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

[PATCH] ip addr: support change and replace commands

2015-05-20 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- networking/ip.c | 2 +- networking/libiproute/ipaddress.c | 20 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/networking/ip.c b/networking/ip.c index 98fe621..d35345c 100644 --- a/networking/ip.c +++ b

Re: [PATCH] ip addr: support change and replace commands

2015-06-23 Thread Michael Tokarev
Ping? 20.05.2015 16:27, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > networking/ip.c | 2 +- > networking/libiproute/ipaddress.c | 20 > 2 files changed, 13 insertions(+), 9 deletions(-) > > diff --git a/network

Re: [PATCH] ip addr: support change and replace commands

2015-06-23 Thread Michael Tokarev
23.06.2015 18:44, Bernhard Reutner-Fischer wrote: > On June 23, 2015 3:27:54 PM GMT+02:00, Michael Tokarev > wrote: >> Ping? >> >> 20.05.2015 16:27, Michael Tokarev wrote: >>> Signed-off-by: Michael Tokarev >>> --- >>> networking/ip.c

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2015-06-28 Thread Michael Tokarev
[Rehashing a thread from 3 years ago] 28.01.2013 11:48, Denys Vlasenko wrote: > On Monday 28 January 2013 00:17, Abdoulaye Walsimou GAYE wrote: > diff --git a/archival/libarchive/Kbuild.src > b/archival/libarchive/Kbuild.src > index 58457fc..87e1ab9 100644 > --- a/archival/libarc

Re: [PATCH] tar: Fix build error when CONFIG_UNCOMPRESS is not selected

2015-07-01 Thread Michael Tokarev
un 28, 2015 at 9:44 AM, Michael Tokarev wrote: >> [Rehashing a thread from 3 years ago] >> >> 28.01.2013 11:48, Denys Vlasenko wrote: >>> On Monday 28 January 2013 00:17, Abdoulaye Walsimou GAYE wrote: >> >>>>>>> diff --git a/archival/libarchiv

Re: [PATCH] su: support numeric UIDs with a -n flag

2022-05-10 Thread Michael Tokarev
10.05.2022 16:30, Ben Fuller wrote: Signed-off-by: Ben Fuller --- Hi, I want to be able to use UIDs rather than usernames in order to handle cases where some POSIX tools truncate usernames at 8 characters. This patch adds a `-n` flag to su, which causes it to interpret the given USER as a numer

Re: [PATCH] su: support numeric UIDs with a -n flag

2022-05-10 Thread Michael Tokarev
10.05.2022 16:53, Michael Tokarev wrote: .. Do you really want su there? Maybe setpriv will better suit your needs? Grrr, and setpriv in busybox does not support user/group settings at all... ;) Why I asked: it is uncommon for su to accept numeric UIDs, - be it busybox or anything else. Also

[PATCH] use libresolv on non-linux too

2022-11-04 Thread Michael Tokarev
nslookup uses symbols from libresolv, no matter it is on linux or not. This also eliminates hackish way to detect linux. --- Makefile.flags | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile.flags b/Makefile.flags index 84cb00a75..be0a3c4bb 100644 --- a/Makefile.flags +++ b/Makefile.fla

[PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2022-11-04 Thread Michael Tokarev
ny pressure on the main development, - the only thing needed is to keep the existing "depends on PLATFORM_LINUX" lines. Signed-off-by: Michael Tokarev --- Config.in | 4 Makefile| 9 - configs/TEST_nommu_defconfig| 1 + conf

[PATCH] Fix non-Linux builds

2022-11-04 Thread Michael Tokarev
From: Samuel Thibault Some features are Linux-only. Also, libresolv is used on all GNU platforms, notably GNU/Hurd and GNU/kfreeBSD. --- coreutils/dd.c | 20 ++-- networking/traceroute.c | 2 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/coreutils/

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2022-11-04 Thread Michael Tokarev
NUX should have been made a non-user-selectable symbol whith automatic value depending on the actual platform in question. This is an attempt to do just that. Thanks, /mjt 04.11.2022 19:49, Michael Tokarev wrote: This effectively reverts the following two commits: commit e3b1a1fd28558f7

Re: [PATCH] Fix non-Linux builds

2022-11-04 Thread Michael Tokarev
04.11.2022 19:49, Michael Tokarev wrote: From: Samuel Thibault Some features are Linux-only. And this is what's left from the patch by Samuel sent in October - only the actual source changes. Maybe some bits could be done in a more compact way, with less ifdeffery.

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2022-11-06 Thread Michael Tokarev
07.11.2022 08:25, Kang-Che Sung wrote: On Sat, Nov 5, 2022 at 12:55 AM Michael Tokarev wrote: diff --git a/Makefile b/Makefile +.platform.in: + $(Q)printf '#ifndef __linux__\nplatform_is_not_linux\n#endif' \ + | $(CPP) - | grep -s platform_is_not_linux \ +

Re: [PATCH] build system: fix linking on Red Hat systems

2022-12-31 Thread Michael Tokarev
31.12.2022 11:48, Ron Yorston wrote: Commit 77216c368 (Fix non-Linux builds) made linking with libresolv conditional on the output of 'gcc -dumpmachine' containing 'gnu'. This broke builds on Red Hat systems (Fedora, RHEL) and derivatives (CentOS, Rocky). Such systems report a machine type of t

Re: [PATCH] build system: fix linking on Red Hat systems

2022-12-31 Thread Michael Tokarev
31.12.2022 14:23, David Laight wrote: [] You don't need to check whether libresolv is needed just whether it exists. We only need to worry about all this only if nslookup applet is in use (this is already the case in the Makefile), - this is what I mean, if we don't have nslookup we don't have

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2023-01-21 Thread Michael Tokarev
A friendly ping? This patch still applies and works okay with current 1.36 version. Thanks, /mjt 04.11.2022 19:49, Michael Tokarev wrote: This effectively reverts the following two commits: commit e3b1a1fd28558f7a1b3c0ec33313bedb675be8a1 Author: Denys Vlasenko Date: Sat Feb 26

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2023-01-21 Thread Michael Tokarev
21.01.2023 19:49, Clément Péron пишет: Hi Michael, On Sat, 21 Jan 2023 at 16:38, Michael Tokarev wrote: A friendly ping? This patch still applies and works okay with current 1.36 version. diff --git a/miscutils/lsscsi.c b/miscutils/lsscsi.c index 8f7eda761..a9d8c3772 100644 --- a

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2023-04-01 Thread Michael Tokarev
Friendly ping #2. Is something like this not welcomed at all, or is okay generally but done in a wrong way, or maybe something else entirely? The change is relatively large and the code is bit-rotting slowly.. Thanks, /mjt 04.11.2022 19:49, Michael Tokarev wrote: This effectively reverts

Re: [PATCH v2] seedrng: fix getrandom() detection for non-glibc libc

2023-04-26 Thread Michael Tokarev
26.04.2023 15:09, Raphaël Mélotte пишет: glibc <= 2.24 does not provide getrandom(). A check for it has been added in 200a9669fbf6f06894e42439fc11a1a6073a and fixed in cb57abb46f06f4ede8d9ccbdaac67377fdf416cf. However, building with a libc other than glibc can lead to the same problem as not

[PATCH] syslogd: fork after init on a regular system, not before

2023-06-08 Thread Michael Tokarev
system, keep current code. Signed-off-by: Michael Tokarev --- This is a generic problem with many busybox daemons, I think its root is within the no-MMU system support (where we can't fork). I think this should be solved in a more generic way too, but this is just an example of how this c

Re: [PATCH] syslogd: fork after init on a regular system, not before

2023-06-14 Thread Michael Tokarev
13.06.2023 17:30, Denys Vlasenko wrote: I think we can delay daemonizing in both cases. Please try current git. Yes, your version is better, it is definitely cleaner, especially after the preparational patch. But does it work for non-MMU case? Or will it just open /dev/log twice and everythin

Re: [PATCH] syslogd: fork after init on a regular system, not before

2023-06-14 Thread Michael Tokarev
14.06.2023 23:30, Michael Tokarev пишет: 13.06.2023 17:30, Denys Vlasenko wrote: I think we can delay daemonizing in both cases. Please try current git. Yes, your version is better, it is definitely cleaner, especially after the preparational patch. But does it work for non-MMU case? Or

Re: [PATCH] syslogd: fork after init on a regular system, not before

2023-06-14 Thread Michael Tokarev
14.06.2023 23:52, Michael Tokarev wrote: Actually it doesn't work on regular system too, the fd#0 is redirected from /dev/null somewhere down the line and enters a tight loop Attached is the fix. Not touching daemonize_or_reexec(). Signed-off-by: Michael Tokarev --- busybox.orig/sys

Re: [PATCH] syslogd: fork after init on a regular system, not before

2023-06-18 Thread Michael Tokarev
14.06.2023 23:58, Michael Tokarev wrote: 14.06.2023 23:52, Michael Tokarev wrote: Actually it doesn't work on regular system too, the fd#0 is redirected from /dev/null somewhere down the line and enters a tight loop Attached is the fix. Not touching daemonize_or_reexec(). Signed-o

Re: [PATCH] udhcpd: Per-client boot_file

2023-06-24 Thread Michael Tokarev
25.06.2023 02:23, Adam Goldman wrote: This patch adds the ability to specify a different boot_file for each client. This is useful if clients have different CPU architectures or if some clients are legacy BIOS and some are EFI. It adds a config file option of the form "for xx:xx:xx:xx:xx:xx boot

Re: syslogd problem

2023-09-20 Thread Michael Tokarev
20.09.2023 18:16, Jeff Pohlmeyer wrote: It seems that local logging with syslogd is no longer working for me. I think commit 02378ce20c6d2df062357b6d60fc440609d203be (syslogd: decrease stack usage, ~50 bytes) has broken something. It's been broken for quite some time http://lists.busybox.net/

Re: [PATCH] syslogd: fork after init on a regular system, not before

2023-10-05 Thread Michael Tokarev
03.10.2023 20:16, Denys Vlasenko: Pushed to git, thank you. Thank you for that. There's one more issue in there with remote logging, see this message for the patch: http://lists.busybox.net/pipermail/busybox/2023-September/090499.html /mjt On Sun, Jun 18, 2023 at 9:24 AM Michael To

Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets

2023-10-07 Thread Michael Tokarev
Another ping 1.5 hours later? Thanks, /mjt ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: syslogd problem

2023-11-13 Thread Michael Tokarev
21.09.2023 15:10, Jeff Pohlmeyer : On Wed, Sep 20, 2023 at 11:54 AM Michael Tokarev wrote: It's been broken for quite some time Thanks, I didn't know about that one. These are actually two different problems, your "read() not blocking" fix, and my "OPT_locallo

Spelling: recevied, delimeter

2023-11-13 Thread Michael Tokarev
--- a/coreutils/cut.c +++ b/coreutils/cut.c @@ -33,8 +33,8 @@ //usage: "\n -b LIST Output only bytes from LIST" //usage: "\n -c LIST Output only characters from LIST" //usage: "\n -d SEP Field delimiter for input (default -f TAB, -F run of whitespace)" -//usage:

Re: [PATCH v1] seedrng.c: fix clock_gettime support for older kernels and glibc combinations

2024-01-20 Thread Michael Tokarev
19.01.2024 16:30, Thomas Devoogdt : CLOCK_BOOTTIME has been added in Linux >= 2.6.39, so fallback to CLOCK_MONOTONIC on older kernels. Also, ensure proper compilation with older glibc versions. Why do you care about such old kernels? To me, it would be better to clean up such old fallbacks, re

Re: networking: compilation error on ubuntu 24

2024-07-14 Thread Michael Tokarev
13.07.2024 17:50, Denys Vlasenko wrote: Your headers are not new enough for tc applet. Disable CONFIG_TC, or install newer headers. It isn't "new enough", it is "too new". This part has been removed from 6.9 kernel. FWIW. Thanks, /mjt ___ busybox m

interesting segfault when running awk as pid==1

2012-07-05 Thread Michael Tokarev
Hello. I've an "interesting" case here, when busybox (in debian) segfaults when run in initramfs as pid == 1, when invoking awk applet (PREFER_APPLETS is set to yes). I can't trigger it with pid != 1, and since pid=1 is special in linux, I can't really debug it too. To complicate things further,

Re: interesting segfault when running awk as pid==1

2012-07-05 Thread Michael Tokarev
On 06.07.2012 04:10, ra...@gmx.de wrote: > Hi Michael ! > >> I've an "interesting" case here, when busybox (in debian) >> segfaults when run in initramfs as pid == 1, when invoking >> awk applet (PREFER_APPLETS is set to yes). I can't trigger >> it with pid != 1, and since pid=1 is special in lin

Re: interesting segfault when running awk as pid==1

2012-07-06 Thread Michael Tokarev
On 06.07.2012 15:03, Laurent Bercot wrote: >> As I stated in my initial email, when running awk from a subshell >> it works. I know PID=1 is special, and for one, it can't be straced >> or debugged. > > Actually, on some Linux versions (I'm not certain which ones though, > but it should work on

Re: interesting segfault when running awk as pid==1

2012-07-07 Thread Michael Tokarev
On 07.07.2012 23:33, Denys Vlasenko wrote: [] >>> The debian-specific patch in question is this (one-liner): >>> >>> shell/ash.c: >>> - { VSTRFIXED|VTEXTFIXED , bb_PATH_root_path, changepath }, >>> + { VSTRFIXED|VTEXTFIXED|VEXPORT, bb_PATH_root_path, changepath }, >>> >>> so it me

Re: [PATCH] include/libbb.h: declare messages with ALIGN1

2012-07-16 Thread Michael Tokarev
On 16.07.2012 12:56, Aurelien Jarno wrote: > Some messages strings are defined with ALIGN1 in libbb/messages.c > to make sure strings are not aligned and thus to save some bytes. The > corresponding declaration in include/libbb.h should also use ALIGN1, > otherwise the compiler may assume they are

udhcpd: write leases on exit?

2012-07-18 Thread Michael Tokarev
Why udhcpd does not write leases file upon receipt of termination signal? Here's the code in question (networking/udhcp/udhcpd.c): switch (udhcp_sp_read(&rfds)) { case SIGUSR1: bb_info_msg("Received SIGUSR1"); write_l

declare more strings with ALIGN1

2012-07-19 Thread Michael Tokarev
As with messages in libbb/messages.c and their declarations in include/libbb.h, there are a few other places where ALIGN1 (force no alignment) is used in definition but not in declaration, which leads to miscompiles. Fix these too. --- a/include/busybox.h +++ b/include/busybox.h @@ -13,10 +13,10

Re: declare more strings with ALIGN1

2012-07-19 Thread Michael Tokarev
On 19.07.2012 13:59, Sedat Dilek wrote: > Can you label your patches, please? > Like this: > > "busybox.h: declare more strings with ALIGN1" The patch touches 3 files. Should I list them all? Thanks, /mjt ___ busybox mailing list busybox@busybox.net

Re: declare more strings with ALIGN1

2012-07-25 Thread Michael Tokarev
On 24.07.2012 17:57, Denys Vlasenko wrote: > On Thu, Jul 19, 2012 at 11:56 AM, Michael Tokarev wrote: >> As with messages in libbb/messages.c and their declarations >> in include/libbb.h, there are a few other places where >> ALIGN1 (force no alignment) is used in def

Re: [PATCH 2/3] remove unused variable opts

2012-07-31 Thread Michael Tokarev
31.07.2012 17:15, manuel.f.zerp...@ww.stud.uni-erlangen.de wrote: > From: Manuel Zerpies > > The variable "unsigned opts" is not used. Saves an unnecessary call to > getopt32(). > > Signed-off-by: Manuel Zerpies > --- > miscutils/flashcp.c |2 -- > 1 files changed, 0 insertions(+), 2 delet

Re: [PATCH 1/3] fix literal error warning

2012-07-31 Thread Michael Tokarev
31.07.2012 17:15, manuel.f.zerp...@ww.stud.uni-erlangen.de wrote: > From: Manuel Zerpies > > compiling with gcc >= 4.4.3 the warning "format not a string literal > and no format arguments" is thrown. This patch fixes that. > [] > index 0b1c4aa..a67e8b4 100644 > --- a/applets/usage_pod.c > +++ b/

Re: declare more strings with ALIGN1

2012-08-06 Thread Michael Tokarev
06.08.2012 15:50, Denys Vlasenko wrote: > > So, can you please tell me what "!defined(arch)" statements you used > to exclude s390[x]? It is just __s390__, which covers both: http://anonscm.debian.org/gitweb/?p=d-i/busybox.git;a=blob;f=debian/patches/dont-force-no-alignment-for-s390.patch;h=3520

Re: Busybox awk throws glibc failure if using standalone/preferred applet feature

2012-08-11 Thread Michael Tokarev
On 11.08.2012 14:03, Harald Becker wrote: > Hi Walter ! > >> perhaps you can create a busybox with awk only ? > > That wont't help. If Busybox awk is called direct or via symlink it > works correct. The problem arrise with the standalone/preferred applet > feature. Which I really want to work, as

Re: Bug in mountpoint applet?

2012-08-14 Thread Michael Tokarev
14.08.2012 16:33, Harald Becker wrote: > Hi all, > > looks like there is a bug in Busybox mountpoint: > > $ mkdir m r > $ mount -obind m r > $ touch m/a touch m/b > $ ls m/ > a b > $ ls r/ > a b > $ mountpoint r > r is a mountpoint > $ busybox mountpoint > r is not a mountpoint !!! > > Looks

Re: Bug in mountpoint applet?

2012-08-14 Thread Michael Tokarev
On 14.08.2012 22:54, Harald Becker wrote: [] > My request is, to have Busybox mountpoint give at least same result as > upstream ... not more, but not less! > ... so just see how GNU mountpoint does the check (can't do it > currently here on my absolutely overloaded notebook, hacking on this > to

Re: Bug in mountpoint applet?

2012-08-14 Thread Michael Tokarev
On 15.08.2012 10:12, Michael Tokarev wrote: > > $ mkdir /tmp/test > $ cd /tmp/test > $ mkdir -p a/b > $ mount -t tmpfs tmpfsb a/b > # here, a/b is a mountpont obvously. Now, we mount another dir over > everything: > $ mount -t tmpfs tmpfsa a > $ mkdir a

Re: Bug in mountpoint applet?

2012-08-15 Thread Michael Tokarev
On 15.08.2012 05:58, Harald Becker wrote: [] > The util linux version has the device node compare as a fallback > method. So why not have a global config option to enable the usage > of /mnt/self/mountinfo ... for those who neglect to use such kind of > interfaces. As I mentioned already, this met

busybox@busybox.net

2012-09-03 Thread Michael Tokarev
On 03.09.2012 20:40, Rich Felker wrote: > On Mon, Sep 03, 2012 at 12:58:37PM +0200, Denys Vlasenko wrote: >> On Sun, Sep 2, 2012 at 11:21 PM, Rich Felker wrote: >>> It seems busybox ash is misinterpreting "&>" as having some special >>> meaning rather than being a "&" token followed by a ">" token

Re: [vamos-dev] [PATCH 1/3] fix literal error warning

2012-09-10 Thread Michael Tokarev
On 10.09.2012 19:31, Manuel Zerpies wrote: > Hey guys, > > what about this patch? Is there anyone who can have a look at it? > [] >> -bb_perror_msg(filename); >> +bb_perror_msg("%s", filename); Please stop fixing a non-issue. This GCC warning is wrong. Th

Re: [vamos-dev] [PATCH 1/3] fix literal error warning

2012-09-10 Thread Michael Tokarev
On 10.09.2012 20:36, Michael Conrad wrote: > On 9/10/2012 11:46 AM, Michael Tokarev wrote: [] >>>> -bb_perror_msg(filename); >>>> +bb_perror_msg("%s", filename); >> Please stop fixing a non-issue. This GCC warning is wrong. &g

Re: [PATCH 19/19] scripts/kconfig/mconf: fix build error on Mac OS X

2012-09-25 Thread Michael Tokarev
On 25.09.2012 16:06, Florian Fainelli wrote: > From: Felix Fietkau > > SIGWINCH is not defined for this platform, provide a definition of it if > needed. > > Signed-off-by: Felix Fietkau > --- > scripts/kconfig/mconf.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/scripts/kc

Re: [PATCH 04/19] trylink: fix linking when /bin/sh is not bash

2012-09-25 Thread Michael Tokarev
On 25.09.2012 16:06, Florian Fainelli wrote: > From: Nicolas Thill > > See https://dev.openwrt.org/ticket/1115 for background on this issue. > > Signed-off-by: Nicolas Thill > --- > scripts/trylink |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/trylink b/s

Re: memory usage increases with redirection on loop

2012-10-10 Thread Michael Tokarev
On 10.10.2012 12:56, walter harms wrote: > Am 09.10.2012 23:08, schrieb Jon Tollefson: >> I have an ash script that I have stripped down to its simplest form >> below that still exhibits the behavior. While the script is running >> under busybox I look at 'top' output in another window and see the

[PATCH] udhcpc: allow trailing dot in names

2012-10-19 Thread Michael Tokarev
pose instead of by mistake. Signed-off-by: Michael Tokarev --- networking/udhcp/dhcpc.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index f72217c..01a9bf8 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c @

Re: XZ embedded bug unpacking linux-3.8.tar.xz

2013-02-25 Thread Michael Tokarev
26.02.2013 03:21, John Spencer wrote: > [ quoting the full mail of lasse since it didnt make its way into the bb > maillist yet ] Additionally there has been a discussion and attempts to cook up a patch in Debian, see http://bugs.debian.org/686502 , which I submitted as a bug to busybox bugzilla

Re: XZ embedded bug unpacking linux-3.8.tar.xz

2013-02-27 Thread Michael Tokarev
28.02.2013 04:22, Antonio Diaz Diaz wrote: [] > The history in a nutshell: "In 2008, Antonio Diaz released lzip, which uses a > proper container format with checksums and magic numbers instead of the raw > LZMA data stream, providing a complete Unix-style solution for using LZMA. > Nevertheless,

Re: [PATCH] grep: Don't bail out on first mismatch if '-w' option is set

2013-05-14 Thread Michael Tokarev
15.05.2013 01:01, Bartosz Golaszewski wrote: > This fixes bug 4520: 'grep -w fails when pattern is a strict substring > of a word'. If '-w' option is set - grep will retry to match against > the rest of the string after it finds a match not enclosed by delimiting > symbols. It's been fixed by com

running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Michael Tokarev
Hello. When running testsuite, we're trying to execute applets by their names, like "grep", "cp", "sh" and so on. When CONFIG_BUSYBOX_PREFER_APPLETS set to "y", busybox tries to exec itself. But this, in turn, depends on CONFIG_BUSYBOX_EXEC_PATH pointing to the right executable. On linux this i

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Michael Tokarev
Please excuse me for incomplete subject line. It was supposed to be .. and EXEC_PATH=/bin/busybox, not empty as it is now. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

testsuite and "bashisms"

2013-11-10 Thread Michael Tokarev
Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX either. So when the system /bin/sh does not implement this construct, los of tests fails li

Re: testsuite and "bashisms"

2013-11-10 Thread Michael Tokarev
10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX either. So when the system /bin/sh doe

Re: testsuite and "bashisms"

2013-11-10 Thread Michael Tokarev
10.11.2013 19:39, Michael Tokarev wrote: 10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX e

Re: testsuite and "bashisms"

2013-11-10 Thread Michael Tokarev
10.11.2013 20:09, Michael Tokarev wrote: 10.11.2013 19:39, Michael Tokarev wrote: 10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not

[PATCH] do not fail build if MAXSYMLINKS isn't defined

2013-12-09 Thread Michael Tokarev
This is needed for, eg, hurd, which is known to have no constraints. Signed-off-by: Michael Tokarev diff --git a/libbb/xreadlink.c b/libbb/xreadlink.c index ec95af2..a610de8 100644 --- a/libbb/xreadlink.c +++ b/libbb/xreadlink.c @@ -8,6 +8,12 @@ #include "libbb.h" +/* some system

[PATCH] expand: use printable_string instead of hard-coding implementation

2013-12-09 Thread Michael Tokarev
Signed-off-by: Michael Tokarev diff --git a/coreutils/expand.c b/coreutils/expand.c index 25bbffc..8d376ff 100644 --- a/coreutils/expand.c +++ b/coreutils/expand.c @@ -78,11 +78,7 @@ static void expand(FILE *file, unsigned tab_size, unsigned opt) unsigned len

Re: [PATCH] expand: use printable_string instead of hard-coding implementation

2013-12-09 Thread Michael Tokarev
That meant to be unicode_strwidth() not printable_string(). Typo in the subject. /mjt ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

busybox testsuite on non-linux

2013-12-09 Thread Michael Tokarev
Hello. Here are a few tests from the testsuite which fails on debian-hurd and debian-kfreebsd. awk handles non-existing file correctly on hurd ENOENT is 0x4002, the test expects 2. It is not portable to expect certain errno values. Different OSes may use different values for the same err

Re: busybox testsuite on non-linux

2013-12-09 Thread Michael Tokarev
09.12.2013 17:51, Michael Tokarev пишет: Forgot to comment on this: > tar symlinks mode (both kfreebsd and hurd) > --- expected > +++ actual > @@ -1,9 +1,9 @@ > input_dir/input_file > -input_dir/input_soft -> input_file > +input_dir/input_soft -> input_di

[PATCH] do not use gethostbyname() for hostname -s

2013-12-09 Thread Michael Tokarev
t entry in /etc/hosts: 127.0.0.1 localhost myname With this content of /etc/hosts, and uname being set to myname, busybox hostname -s will return localhost, while regular hostname utility returns myname. Fix this by not calling gethostbyname() for the simple `hostname -s' use. Si

Re: [PATCH] do not use gethostbyname() for hostname -s

2013-12-09 Thread Michael Tokarev
10.12.2013 01:40, Tito wrote: > On Monday 09 December 2013 18:56:43 Michael Tokarev wrote: >> There's no reason to call gethostbyname() on the value returned >> by uname() when asked just for a short name of a host. This may >> also be wrong, when uname is set to on

Re: [PATCH] do not use gethostbyname() for hostname -s

2013-12-16 Thread Michael Tokarev
16.12.2013 06:29, Denys Vlasenko пишет: > On Monday 09 December 2013 18:56, Michael Tokarev wrote: >> There's no reason to call gethostbyname() on the value returned >> by uname() when asked just for a short name of a host. This may >> also be wrong, when uname is set

Re: Why '-c DEV' option for switch_root?

2013-12-16 Thread Michael Tokarev
17.12.2013 01:57, Laurent Bercot wrote: > >> And here the question: How is it simpler to maintain? squashfs is >> a read only file system, so you can't change things directly. >> Same as in initramfs: You need a copy of the root file system >> tree to put in your changes, then you need to create y