jtouton abandoned this revision.
jtouton added a comment.
This change was introduced quite some time ago now.
https://reviews.llvm.org/D12664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
alexshap added a comment.
two separate observations:
1. **without my changes** :
I checked the following revision: r276508 | rsmith | 2016-07-22 19:32:21
(with gcc 4.7.4, g++ 4.7.4, Ubuntu 16.04.1 LTS)
build of llvm/clang failed, the logs are here: https://reviews.llvm.org/P6916
(emplace is one
Author: hahnfeld
Date: Mon Jul 25 03:04:26 2016
New Revision: 276618
URL: http://llvm.org/viewvc/llvm-project?rev=276618&view=rev
Log:
Update description for CLANG_DEFAULT_CXX_STDLIB and add comment. NFC
We agreed to call it "platform default" instead of "architecture default".
(see D17286)
Modi
ioeric added a comment.
ping :)
https://reviews.llvm.org/D21748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.
In general the idea looks good and takes this point off my personal todo list
:-)
With the changes applied and configured with `CLANG_DEFAULT_RTLIB=compiler-rt`
some tests fail
omtcyfz added a comment.
Just remove it then?
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Jul 25 03:56:11 2016
New Revision: 276620
URL: http://llvm.org/viewvc/llvm-project?rev=276620&view=rev
Log:
[clang-rename] fix typos in tests
TemplateFunctionFindBy{Declaration|Use}.cpp contained typos and therefore were
failing. clang-rename passes these tests after typ
Author: olista01
Date: Mon Jul 25 04:21:56 2016
New Revision: 276625
URL: http://llvm.org/viewvc/llvm-project?rev=276625&view=rev
Log:
[libunwind][ARM] Add support for Thumb1 targets
The Thumb1 version of the code for saving and restoring the unwind
context has a few bugs which prevent it from wo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276625: [libunwind][ARM] Add support for Thumb1 targets
(authored by olista01).
Changed prior to commit:
https://reviews.llvm.org/D22292?vs=65039&id=65317#toc
Repository:
rL LLVM
https://reviews.llv
Hi,
I hope I'm not breaking any mailing list etiquette by replying to this
mail, but if I am then please accept my apologies.
On Fri, Jun 3, 2016 at 8:36 PM, Steven Wu via llvm-dev
wrote:
> Hi everyone
>
> I am still in the process of upstreaming some improvements to the embed
> bitcode option.
vladisld added a subscriber: vladisld.
vladisld added a comment.
Have the alternatives to sub-modules and monolithic repository been discussed ?
Sub-modules have their disadvantages as described in the following blog post:
https://codingkilledthecat.wordpress.com/2012/04/28/why-your-company-shou
szepet updated this revision to Diff 65310.
szepet added a comment.
full diff submitted
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/EnumMisuseCheck.cpp
clang-tidy/misc/EnumMisuseCheck.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang-tidy/checks
Hi Simon (and all),
I noticed that this patch changes the definition of intrinsic _mm_cvtsd2_ss
in emmintrin.h. Is that intentional? My understanding is that your patch
should have only addressed float-to-integer conversions.
Was this change to _mm_cvtsd_ss motivated by the fact that (V)CVTSD2SS
alexfh added a subscriber: alexfh.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:36
@@ +35,3 @@
+(llvm::Twine("forward<") + TypeParmType->getDecl()->getName() +
+ llvm::Twine(">"))
+.str();
nit: The second `llvm::Twine` i
NoQ added a comment.
The idea with strings as keys is curious! I've got a few more minor comments :)
Comment at: lib/Analysis/CloneDetection.cpp:104
@@ +103,3 @@
+// Storage for the signatures of the direct child statements. This is only
+// needed if the current statemn
elsteveogrande added a comment.
Looks like I have the "accept" ability in this repo, wasn't sure since I just
registered for this recently :)
I think since the tests look good, it's a nice and elegant 1-line change, per
the reviewer's (@rsmith 's) comments, this should be ok to go.
This would
kzhuravl updated this revision to Diff 65343.
kzhuravl added a comment.
Remove metadata generation
https://reviews.llvm.org/D21724
Files:
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
===
--- lib/CodeGen/CGBuiltin.c
hjl.tools added a comment.
no_caller_saved_registers attribute can be used with any calling conventions.
https://reviews.llvm.org/D22045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
On Fri, Jul 22, 2016 at 2:42 PM, Clement Courbet via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: courbet
> Date: Fri Jul 22 07:42:19 2016
> New Revision: 276408
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276408&view=rev
> Log:
> [clang-tidy] new cppcoreguidelines-slicing
>
> F
On Mon, Jul 25, 2016 at 11:15 AM, H.J Lu wrote:
> hjl.tools added a comment.
>
> no_caller_saved_registers attribute can be used with any calling conventions.
Okay, so is it expected that use of this attribute through a function
pointer is not going to produce the same results as calling the
func
Author: alexfh
Date: Mon Jul 25 10:27:16 2016
New Revision: 276639
URL: http://llvm.org/viewvc/llvm-project?rev=276639&view=rev
Log:
MPI-Checker: move MPIFunctionClassifier.h
Summary:
This patch moves the MPIFunctionClassifier header to
`clang/include/clang/StaticAnalyzer/Checkers`,
in order to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276639: MPI-Checker: move MPIFunctionClassifier.h (authored
by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D22671?vs=65050&id=65348#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
etienneb added a comment.
some nits
Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:37
@@ +36,3 @@
+unsigned flag;
+flag = A | H; //OK, disjoint value intervalls in the enum types > probably
good use
+flag = B | F; //warning, have common values so they are probably misu
Author: alexfh
Date: Mon Jul 25 10:43:22 2016
New Revision: 276641
URL: http://llvm.org/viewvc/llvm-project?rev=276641&view=rev
Log:
Remove trailing spaces.
Modified:
clang-tools-extra/trunk/test/clang-tidy/mpi-type-mismatch.cpp
Modified: clang-tools-extra/trunk/test/clang-tidy/mpi-type-mism
Author: alexfh
Date: Mon Jul 25 10:43:14 2016
New Revision: 276640
URL: http://llvm.org/viewvc/llvm-project?rev=276640&view=rev
Log:
MPITypeMismatchCheck for Clang-Tidy
Summary:
This check verifies if buffer type and MPI (Message Passing Interface)
datatype pairs match. All MPI datatypes defined
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276640: MPITypeMismatchCheck for Clang-Tidy (authored by
alexfh).
Changed prior to commit:
https://reviews.llvm.org/D21962?vs=65222&id=65351#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21962
Prazek added a subscriber: Prazek.
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:19
@@ +18,3 @@
+
+// Stores a min and a max value which describe an interval.
+struct ValueRange {
s/\/\//\/\/\/
In other words, change // to /// (doxygen comment)
===
vsk added a comment.
Ping.
https://reviews.llvm.org/D7
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On Jul 25, 2016, at 3:24 AM, Jonas Devlieghere wrote:
>
> Hi,
>
> I hope I'm not breaking any mailing list etiquette by replying to this
> mail, but if I am then please accept my apologies.
>
> On Fri, Jun 3, 2016 at 8:36 PM, Steven Wu via llvm-dev
> wrote:
>> Hi everyone
>>
>> I am still
It'd be handy to include details of what's different about this commit than
the previous time it was committed - makes review easier by focusing on the
new changes. (for some commits where I've recommitted them a few times I
end up with a bit of a timeline/history in the commit message - "fixed thi
LokiAstari added a comment.
@djasper@klimek
Hi guys,
I am not sure how to move this PR forward.
I am not sure if you are uninterested or if this is two minor in comparison to
other issues.
If there is some other task I need to do to move this forward I more than happy
to do some leg wo
Alexander_Droste updated this revision to Diff 65359.
Alexander_Droste added a comment.
- remove trailing whitespace
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
clang-tidy/mpi/MPITidyModule.cp
jlebar added a comment.
In https://reviews.llvm.org/D22463#494568, @vladisld wrote:
> Have the alternatives to sub-modules and monolithic repository been discussed
> ?
Hi, Vlad.
Please see the ongoing thread in llvm-dev, entitled "[RFC] One or many git
repositories?".
Tools such as git-repo
hubert.reinterpretcast added a comment.
Minor concerns noted. I'd be okay with this patch, but would like someone else
to give the okay (or indicate what issues need to be addressed).
Comment at: include/regex:148
@@ -147,3 +147,3 @@
explicit basic_regex(const charT* p, fl
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Can you move this error message down instead of adding 6 l
Author: dougk
Date: Mon Jul 25 11:36:02 2016
New Revision: 276646
URL: http://llvm.org/viewvc/llvm-project?rev=276646&view=rev
Log:
[Myriad]: better compatibility with vendor source
- Accept ma{2100,2150,2150} for -mcpu
- Define more preprocessor macros
- Don't append "le/" to little-endian lib d
djasper added a comment.
Sorry, my bad. I should have replied sooner. I believe we can move further with
this seems to be used widely enough (though it really doesn't make sense in my
personal opinion ;) ).
My main concern is how we are going to configure this in the long run. This is
mostly m
hubert.reinterpretcast added a comment.
This looks straightforward. @mclow.lists, are you okay with me committing this
for Jason?
https://reviews.llvm.org/D22698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
wristow added a comment.
> @wristow, if this still patches cleanly against trunk (I see that this has
> been around a while) and test still pass, think this can be committed
> soon-ish?
It does still apply cleanly, and testing still looks good.
Given that the test was adjusted as suggested by
nandor added a comment.
ping?
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Should this revert be merged to 3.9?
Thanks,
Hans
On Thu, Jul 21, 2016 at 4:28 PM, Wolfgang Pieb via cfe-commits
wrote:
> Author: wolfgangp
> Date: Thu Jul 21 18:28:18 2016
> New Revision: 276361
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276361&view=rev
> Log:
> Reverting r275115 which ca
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc()
I see. Since it's not a regression and there are dependencies, let's
not merge it.
Thanks,
Hans
On Fri, Jul 22, 2016 at 12:39 PM, Craig Topper wrote:
> Most of these have been broken like this for a long time so I'm not sure.
> This patch as is depends on r276249 too since we were missing qualif
DavidKreitzer added a comment.
The example Aaron sent in email is a good one:
void func(int, int, int, int) __attribute__((no_caller_saved_registers,
cdecl));
int main() {
void (*fp)(int, int, int, int) __attribute__((cdecl)) = func;
func(1, 2, 3, 4);
fp(1, 2, 3, 4); // Not th
kparzysz created this revision.
kparzysz added reviewers: t.p.northover, echristo.
kparzysz added a subscriber: cfe-commits.
kparzysz set the repository for this revision to rL LLVM.
Herald added subscribers: mehdi_amini, aemerson.
Make -mlong-calls a general (i.e. non ARM-specific) option.
Repos
Yes, it should. I'm just now realizing that the original change got into 3.9.
Thanks,
Wolfgang
> -Original Message-
> From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of
> Hans Wennborg
> Sent: Monday, July 25, 2016 9:56 AM
> To: Pieb, Wolfgang
> Cc: cfe-commits
> Subjec
beanz added a subscriber: beanz.
beanz added a comment.
@rengolin, thank you for putting this all together. It is very well thought
out, and I really like the shape it took. I have a few minor nitpick comments
inline.
Thanks,
-Chris
Comment at: docs/Proposals/GitHub.rst:58
@@
NoQ updated this revision to Diff 65369.
NoQ marked 4 inline comments as done.
https://reviews.llvm.org/D20811
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
test/Analysis/std-l
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:191
@@ +190,3 @@
+// impossible to verify this precisely, but at least
+// this check avoids potential crashes.
+bool matchesCall(const CallExpr *CE) const;
--
Author: alexfh
Date: Mon Jul 25 12:08:18 2016
New Revision: 276651
URL: http://llvm.org/viewvc/llvm-project?rev=276651&view=rev
Log:
Revert "MPITypeMismatchCheck for Clang-Tidy"
This reverts commit r276640. Breaks multiple buildbots.
Removed:
clang-tools-extra/trunk/clang-tidy/mpi/CMakeLists
Author: alexfh
Date: Mon Jul 25 12:08:10 2016
New Revision: 276650
URL: http://llvm.org/viewvc/llvm-project?rev=276650&view=rev
Log:
Revert "Remove trailing spaces."
This reverts commit r276641. Breaks multiple buildbots.
Modified:
clang-tools-extra/trunk/test/clang-tidy/mpi-type-mismatch.cp
Ping?
On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
> What build problem did this cause? Did this just not compile (it looks as
> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
> problem might've been)
>
> On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe
Author: ssrivastava
Date: Mon Jul 25 12:17:06 2016
New Revision: 276653
URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
Log:
Support '#pragma once' in headers when using PCH
The '#pragma once' directive was erroneously ignored when encountered
in the header-file specified in gene
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276653: Support '#pragma once' in headers when using PCH
(authored by ssrivastava).
Changed prior to commit:
https://reviews.llvm.org/D19815?vs=57320&id=65372#toc
Repository:
rL LLVM
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276655: [cc1as] Add MCTargetOptions argument to
createAsmBackend (authored by joel_k_jones).
Changed prior to commit:
https://reviews.llvm.org/D16538?vs=62793&id=65374#toc
Repository:
rL LLVM
https:
Merged the revert to 3.9 in r276656.
Thanks,
Hans
On Mon, Jul 25, 2016 at 10:02 AM, Pieb, Wolfgang wrote:
> Yes, it should. I'm just now realizing that the original change got into 3.9.
>
> Thanks,
> Wolfgang
>
>> -Original Message-
>> From: hwennb...@google.com [mailto:hwennb...@google.
Author: joel_k_jones
Date: Mon Jul 25 12:18:44 2016
New Revision: 276655
URL: http://llvm.org/viewvc/llvm-project?rev=276655&view=rev
Log:
[cc1as] Add MCTargetOptions argument to createAsmBackend
Allow an assembler backend to get ABI options. This is to match the changes
to http://reviews.llvm.or
Actually, I now see the PR doesn't reproduce on 3.9, so this must have
broke after the branch point.
On Fri, Jul 22, 2016 at 7:02 AM, Hans Wennborg wrote:
> Richard: should we merge this to 3.9?
>
> On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> D
ashi1 created this revision.
ashi1 added reviewers: yaxunl, Anastasia.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Added CLK_ABGR definition for get_image_channel_order return value inside
opencl-c.h file
Repository:
rL LLVM
https://reviews.ll
etienneb added a subscriber: etienneb.
etienneb added a comment.
thx for the check
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:25
@@ +24,3 @@
+ const SourceManager &SM = Context->getSourceManager();
+ const LangOptions LangOpts = Context->getLangOpts();
+
yaxunl added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Anastasia wrote:
> Can you move this error message down inste
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D22767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Should we fix the diagnostic? Or is the code triggering it just esoteric
enough to not be a good justification for changing the warning?
On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Jul 19 15:35:09 2016
> New Revis
sepavloff updated this revision to Diff 65376.
sepavloff added a comment.
Added one more case in shouldLinkDependentDeclWithPrevious
https://reviews.llvm.org/D16989
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDecl.cpp
test/SemaCXX/PR25848.cpp
test/SemaCXX/friend2.cpp
Index: test/Sema
ashi1 added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
yaxunl wrote:
> Anastasia wrote:
> > Can you move this error m
On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Should we fix the diagnostic? Or is the code triggering it just esoteric
enough to not be a good justification for changing the warning?
Hmm, maybe we should. The case is something like
template voi
alexfh added a comment.
Alexander, FYI, the patch has been reverted, since it breaks multiple
buildbots, e.g.
-
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/13909/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Ampi-type-mismatch.cpp
-
http://lab.llvm.org:8011/builde
+Richard Trieu - worth fixing? If anyone does get
around to fixing this, would be good to remove the workaround committed
here in r276022.
On Mon, Jul 25, 2016 at 10:51 AM Richard Smith
wrote:
> On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:192
@@ +191,3 @@
+ };
+
+ // The map of all functions supported by the checker. It is initialized
Even though there are some doxygen-style comments in the checkers,
Eugene.Zelenko updated this revision to Diff 65379.
Eugene.Zelenko added a comment.
Don't include DiagnosticIDs.h
Repository:
rL LLVM
https://reviews.llvm.org/D22654
Files:
clang-rename/tool/ClangRename.cpp
test/clang-rename/InvalidNewName.cpp
Index: test/clang-rename/InvalidNewName.cpp
bittnerbarni updated this revision to Diff 65384.
bittnerbarni marked an inline comment as done.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationC
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:55
@@ +54,3 @@
+ hasDeclaration(decl(equalsBoundNode("lhsStrT"))),
+ hasDescendant(BasicStringPlusOperator));
+
Yes this
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
The FunctionScopeInfo stack in Sema uses an optimization where the memory for
the top-level functions is reused. The function FunctionScopeInfo::Clear() is
used to re
Hi all, my first potential-contribution, so I apologize if I'm submitting this
improperly, I'm unfamiliar with the 'type' keys that you use in the topic, so
hopefully I have this right.
As reported in bug 28473, GCC supports 'final' functionality in pre-C++11 code
using the __final keyword. Cl
lefticus updated this revision to Diff 65390.
lefticus added a comment.
Fixed syntax errors in test files.
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/
alexfh added a comment.
A couple of nits.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:51
@@ +50,3 @@
+ hasArgument(
+ 0, declRefExpr(BasicStringType),
+ declRefExpr(hasDeclaration(decl().bind("lhsStrT"))).bind("lhsStr")),
---
hfinkel added a comment.
In https://reviews.llvm.org/D19544#492258, @mmasten wrote:
> I think this is just saying that some of the weird types are not supported on
> all targets. For now, is it ok to proceed with checking this code in?
Correct.
In https://reviews.llvm.org/D19544#493403, @mmas
omtcyfz added a comment.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D22654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lefticus marked 3 inline comments as done.
lefticus added a comment.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lefticus added a comment.
I believe I messed up the context for the files, will attempt to resubmit the
patch.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
LokiAstari added a comment.
Hope you don't mind me chiming in:
> Roughly go ahead with what you are suggesting, although the option should not
> be called AccessModifierStandardIndent, as that carries no meaning and
> actually is far from the "standard" way. Reasonable names that spring to mind
Author: cbieneman
Date: Mon Jul 25 13:54:30 2016
New Revision: 276674
URL: http://llvm.org/viewvc/llvm-project?rev=276674&view=rev
Log:
[CMake] Cleaning up some CMake warnings
In Bootstrap builds Clang logs some warnings. These are caused because Clang
passes CLANG_STAGE and BOOTSTRAP_DEFAULT_PA
lefticus updated this revision to Diff 65398.
lefticus added a comment.
Correct context from last patch
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/con
lefticus added a comment.
I believe all or most of the "untested" comments are correctly tested in the
updated test files via static_asserts with contexpr. I've commented on just the
first one to make sure I understand correctly.
Comment at: include/array:156
@@ -155,3 +155,3
CrisCristescu updated this revision to Diff 65401.
CrisCristescu marked 3 inline comments as done.
CrisCristescu added a comment.
Addressing some sugesstions.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsum
I'd rename VS_Alt_Final to VS_GNU_Final.
On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all, my first potential-contribution, so I apologize if I’m submitting
> this improperly, I’m unfamiliar with the ‘type’ keys that you use in the
> topi
CrisCristescu updated this revision to Diff 65403.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
PP CodeCompletionII initialisation.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeComplet
Alexander_Droste removed rL LLVM as the repository for this revision.
Alexander_Droste updated this revision to Diff 65404.
Alexander_Droste added a comment.
Hi, thanks for the notification! Obviously, on some systems `char` is unsigned
by default
which is why the check now tolerates distinct si
manmanren created this revision.
manmanren added a reviewer: benlangmuir.
manmanren added a subscriber: cfe-commits.
With PCH+Module, sometimes compiler gives a hard error:
"Module file ‘.pcm' is out of date and needs to be rebuilt"
This happens when we have a PCH importing a module and the modul
Thanks for the quick review! I’ve updated the patch with the name changes in
the attached diff file.
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Monday, July 25, 2016 12:40 PM
To: Keane, Erich
Cc: cfe-commits@lists.llvm.org
Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compati
On Mon, Jul 25, 2016 at 1:03 PM, Vlad Dovlekaev via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> vladisld added a comment.
>
> In https://reviews.llvm.org/D22463#494828, @jlebar wrote:
>
> > I think the general feeling is that most of us (myself included) would
> rather not learn a new too
You've added a comment describing the new enum value. Please make sure the
comment starts with a cap letter and ends with a period.
On Mon, Jul 25, 2016 at 4:09 PM, Keane, Erich wrote:
> Thanks for the quick review! I’ve updated the patch with the name changes
> in the attached diff file.
>
>
Done! Attached a new diff.
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Monday, July 25, 2016 1:18 PM
To: Keane, Erich
Cc: cfe-commits@lists.llvm.org
Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for
__final specifier
You've added a comment describ
mstorsjo created this revision.
mstorsjo added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
This fixes compiling with headers from the Windows SDK for ARM, where the
YieldProcessor function (in winnt.h) refers to _ARM_BARRIER_ISHST.
The actual MSVC armintr.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276684: [Clang-rename] Remove custom version, fix extra
space in error message. (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D22654?vs=65379&id=65412#toc
Repository:
Author: eugenezelenko
Date: Mon Jul 25 15:30:13 2016
New Revision: 276684
URL: http://llvm.org/viewvc/llvm-project?rev=276684&view=rev
Log:
[Clang-rename] Remove custom version, fix extra space in error message.
Also fixed some Include What You Use Warnings.
Differential revision: https://review
Should this be merged to 3.9?
On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits
wrote:
> Author: vvassilev
> Date: Fri Jul 22 16:08:24 2016
> New Revision: 276473
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276473&view=rev
> Log:
> [modules] Teach the ASTWriter to ignore mutat
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 65414.
jbcoe marked an inline comment as done.
jbcoe added a comment.
Rename to cppcoreguidelines-special-member-functions to avoid the duplication
required with naming it rule-of-3 and rule-of-5.
Reduce c
Should me merge this to 3.9?
On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits
wrote:
> Author: ssrivastava
> Date: Mon Jul 25 12:17:06 2016
> New Revision: 276653
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
> Log:
> Support '#pragma once' in headers when usi
Eugene.Zelenko added inline comments.
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst:4
@@ +3,3 @@
+cppcoreguidelines-special-member-functions
+===
+
Size should be same as size of name above.
1 - 100 of 147 matches
Mail list logo
