[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske updated this revision to Diff 159458. balazske marked an inline comment as done. balazske added a comment. - Renamed methods, simplified code, comments updated. Repository: rC Clang https://reviews.llvm.org/D49223 Files: include/clang/AST/ASTStructuralEquivalence.h lib/AST/ASTSt

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

ebevhan added a comment. I think the solution to a lot of diagnostic and behavior issues with address spaces is to remove predication on OpenCL. It's a bit odd to have a language feature that is enabled out of the box regardless of langoptions (address spaces) but won't actually work properly u

[PATCH] D46892: [X86] Lowering adds/addus/subs/subus intrinsics to native IR (Clang part)

tkrupa updated this revision to Diff 159461. tkrupa added a comment. Removed signed intrinsics lowering due to the pattern being too complicated - instead some minor optimizations were introduced on LLVM side. Repository: rC Clang https://reviews.llvm.org/D46892 Files: lib/CodeGen/CGBuilt

r339109 - AMDGPU: Add builtin for s_dcache_inv_vol

Author: arsenm Date: Tue Aug 7 00:49:04 2018 New Revision: 339109 URL: http://llvm.org/viewvc/llvm-project?rev=339109&view=rev Log: AMDGPU: Add builtin for s_dcache_inv_vol Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-ci.cl cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-ci.cl Mod

r339110 - AMDGPU: Add builtin for s_dcache_wb

Author: arsenm Date: Tue Aug 7 00:49:13 2018 New Revision: 339110 URL: http://llvm.org/viewvc/llvm-project?rev=339110&view=rev Log: AMDGPU: Add builtin for s_dcache_wb Added: cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-vi.cl Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D50321: AMDGPU: Add builtin for s_dcache_wb

arsenm closed this revision. arsenm added a comment. r339110 https://reviews.llvm.org/D50321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50320: AMDGPU: Add builtin for s_dcache_inv_vol

arsenm closed this revision. arsenm added a comment. r339109 https://reviews.llvm.org/D50320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

theraven added a comment. I'd like to commit this, unless @rjmccall has any objections. Repository: rC Clang https://reviews.llvm.org/D50144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

r339112 - Fix clash of gcc toolchains in driver regression tests

Author: karka Date: Tue Aug 7 01:10:33 2018 New Revision: 339112 URL: http://llvm.org/viewvc/llvm-project?rev=339112&view=rev Log: Fix clash of gcc toolchains in driver regression tests For some regression tests the path to the right toolchain is specified using the -sysroot switch. However, if

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

yroux added a comment. I dug a bit and can give more context. The usage of _LIBUNWIND_ARM_EHABI was introduced by https://reviews.llvm.org/D31178 but from what we are seeing with the release builds, libunwind headers are not picked up (at least in these configs) and since r309226

[PATCH] D50337: [clangd] DexIndex implementation prototype

kbobyrev updated this revision to Diff 159463. kbobyrev added a comment. Don't resize retrieved symbols vector, simply let callback process at most `MaxCandidateCount` items. https://reviews.llvm.org/D50337 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/MemIn

[PATCH] D50375: [clangd] Share getSymbolID implementation.

hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. And remove all duplicated implementation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50375 Files: clangd/AST.cpp clangd/AST.h clangd/Cod

[PATCH] D50375: [clangd] Share getSymbolID implementation.

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/AST.cpp:59 + llvm::SmallString<128> USR; + if (index::generateUSRForDecl(D, USR)) { +return None; nit: no braces =

[PATCH] D50375: [clangd] Share getSymbolID implementation.

hokein added inline comments. Comment at: clangd/CodeComplete.cpp:399 case CodeCompletionResult::RK_Pattern: { -llvm::SmallString<128> USR; -if (/*Ignore=*/clang::index::generateUSRForDecl(R.Declaration, USR)) - return None; -return SymbolID(USR); +return

[PATCH] D50375: [clangd] Share getSymbolID implementation.

hokein updated this revision to Diff 159466. hokein marked 3 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50375 Files: clangd/AST.cpp clangd/AST.h clangd/CodeComplete.cpp clangd/XRefs.cpp clangd/inde

[PATCH] D49796: [ASTImporter] Load external Decls when getting field index.

balazske updated this revision to Diff 159467. balazske added a comment. - Added common getFieldIndex. Repository: rC Clang https://reviews.llvm.org/D49796 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp test/ASTMerge/unnamed_fields/Inputs/il.cpp test/ASTMerge/unnamed_

[clang-tools-extra] r339116 - [clangd] Share getSymbolID implementation.

Author: hokein Date: Tue Aug 7 01:57:52 2018 New Revision: 339116 URL: http://llvm.org/viewvc/llvm-project?rev=339116&view=rev Log: [clangd] Share getSymbolID implementation. Summary: And remove all duplicated implementation. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arph

[PATCH] D50375: [clangd] Share getSymbolID implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339116: [clangd] Share getSymbolID implementation. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50375 Files: clang-tool

[PATCH] D50376: AMDGPU: Fix enabling denormals by default on pre-VI targets

arsenm created this revision. arsenm added reviewers: b-sumner, kzhuravl. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng. Fast FMAF is not a sufficient condition to enable denormals. Before VI, enabling denormals caused https://reviews.llvm.org/F32 instructions to run at

[PATCH] D50337: [clangd] DexIndex implementation prototype

kbobyrev added a comment. As discussed offline, incomplete trigrams (unigrams and bigrams generation) should be a blocker for this patch, because otherwise it isn't functional. Once incomplete trigrams are in, `MemIndex` tests can be reused for `DexIndex` to ensure stability. https://reviews.

[PATCH] D50378: [clang-format] comment reflow: add last line's penalty when ending broken

krasimir created this revision. Herald added a subscriber: cfe-commits. This fixes a bug in clang-format where the last line's penalty is not taken into account when its ending is broken. Usually the last line's penalty is handled by addNextStateToQueue, but in cases where the trailing `*/` is put

r339123 - [clang-format] comment reflow: add last line's penalty when ending broken

Author: krasimir Date: Tue Aug 7 03:23:24 2018 New Revision: 339123 URL: http://llvm.org/viewvc/llvm-project?rev=339123&view=rev Log: [clang-format] comment reflow: add last line's penalty when ending broken Summary: This fixes a bug in clang-format where the last line's penalty is not taken int

[PATCH] D50378: [clang-format] comment reflow: add last line's penalty when ending broken

This revision was automatically updated to reflect the committed changes. Closed by commit rC339123: [clang-format] comment reflow: add last line's penalty when ending broken (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D50378?vs=159474&id=159476#toc

[PATCH] D50378: [clang-format] comment reflow: add last line's penalty when ending broken

This revision was automatically updated to reflect the committed changes. Closed by commit rL339123: [clang-format] comment reflow: add last line's penalty when ending broken (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D50380: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, hans. Herald added a subscriber: chrib. This matches how GCC defines this struct. Repository: rC Clang https://reviews.llvm.org/D50380 Files: lib/Headers/unwind.h Index: lib/Headers/unwind.h

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Hi, I'm generating these labels from the Rust compiler, which is far from a minimal example. I'm actually conflicted about what should happen if code containing a label is removed, but the label is marked to be "retained". Maybe it does make sense for those to stay wit

r339128 - [objc-gnustep] Don't emit .guess ivar offset vars.

Author: theraven Date: Tue Aug 7 05:02:46 2018 New Revision: 339128 URL: http://llvm.org/viewvc/llvm-project?rev=339128&view=rev Log: [objc-gnustep] Don't emit .guess ivar offset vars. These were intended to allow non-fragile and fragile ABI code to be mixed, as long as the fragile classes were

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Szelethus updated this revision to Diff 159486. Szelethus added a comment. Added the TODO we were discussing. https://reviews.llvm.org/D49438 Files: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp test/Analysis/cxx-uninitialized-object-inheritance.cpp test/Analysis/cxx-uninitia

r339132 - [AST][NFC] Use unsigned in the bit-fields of PrintingPolicy

Author: brunoricci Date: Tue Aug 7 05:23:41 2018 New Revision: 339132 URL: http://llvm.org/viewvc/llvm-project?rev=339132&view=rev Log: [AST][NFC] Use unsigned in the bit-fields of PrintingPolicy Avoid the mix between bools and unsigned since MSVC pack this poorly. Modified: cfe/trunk/incl

[PATCH] D50382: [analyzer] Fix a typo in `RegionStore.txt`.

MTC created this revision. MTC added reviewers: NoQ, george.karpenkov. Herald added subscribers: mikhail.ramalho, a.sidorin, szepet, xazax.hun. The typo of the description for default bindings can be confusing. Repository: rC Clang https://reviews.llvm.org/D50382 Files: docs/analyzer/Regio

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

JDevlieghere added inline comments. Comment at: docs/CodingStandards.rst:514-516 +line of code. Some common editors will automatically remove trailing whitespace +when saving a file which causes unrelated changes to appear in diffs and +commits. chandlerc wrote:

r339134 - [AST][NFC] Use unsigned in the bit-fields of IdentifierInfo

Author: brunoricci Date: Tue Aug 7 05:40:41 2018 New Revision: 339134 URL: http://llvm.org/viewvc/llvm-project?rev=339134&view=rev Log: [AST][NFC] Use unsigned in the bit-fields of IdentifierInfo Avoid mixing bool and unsigned in the bit-fields of IdentifierInfo since MSVC packs this poorly. Als

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vext01 added a comment. Got one! Here's a dumb program which simply adds 3 to 1 using a function. There is one label in the `add_3` function, named `XXXYYYZZZ`: ; ModuleID = 'mymod' source_filename = "mymod" define i32 @add_3(i32 %x) !dbg !3 { entry: %res = add i32 %x, 3, !dbg !9

r339135 - [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Author: szelethus Date: Tue Aug 7 05:55:26 2018 New Revision: 339135 URL: http://llvm.org/viewvc/llvm-project?rev=339135&view=rev Log: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing Even for a checker being in alpha, some reports about pointees held so little value to

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

This revision was automatically updated to reflect the committed changes. Closed by commit rC339135: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing (authored by Szelethus, committed by ). Repository: rC Clang https://reviews.llvm.org/D49438 Files: lib/StaticAnalyz

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

Szelethus added a comment. Polite ping :) https://reviews.llvm.org/D48436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50385: [clangd] Collect symbol occurrences from AST.

hokein created this revision. hokein added reviewers: ilya-biryukov, ioeric. Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, mgorny. This patch implements a SymbolOccurenceCollector, which will be used to: - Find all occurrences in AST - Find all occurrences in MemIndex Repository

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

ilya-biryukov added a comment. Thanks! The only major comment I have is about the `FixItsScore`, others are mostly NITs. Comment at: clangd/Quality.cpp:298 +FixItCount += FixIt.CodeToInsert.size(); + } } NIT: remove braces around single-statement loop bo

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. I would like to have this patch in, because i currently have a 1MB output file, and the missing synchronization really destroys cleaning with grep and sed :( Comment at: clang-tidy/tool/run-clang-tidy.py:167 +output, err = proc.communicate() +

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. I forgot: Did you measure how much of a time penalty this brings? Just out of curiosity, correct script is more important then fast script :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49851 ___ cfe-c

[PATCH] D50376: AMDGPU: Fix enabling denormals by default on pre-VI targets

b-sumner added a comment. This approach seems fine to me. https://reviews.llvm.org/D50376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

kadircet updated this revision to Diff 159510. kadircet marked 6 inline comments as done. kadircet added a comment. - Resolve discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50193 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/Diagnostics.cpp cl

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Abpostelnicu updated this revision to Diff 159511. https://reviews.llvm.org/D49851 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Abpostelnicu marked 2 inline comments as done. Abpostelnicu added a comment. Regarding the time penalty it depends very much on how many files you have. But I would choose anytime to have this in the detriment of having "obfuscated" output. https://reviews.llvm.org/D49851 __

[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

scott.linder updated this revision to Diff 159512. scott.linder added a comment. Address feedback https://reviews.llvm.org/D50099 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenOpenCL/blocks.cl Index: test/CodeGenOpenCL/blocks.cl

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. Lets say running it over whole LLVM for one check? I will apply this path locally, because i have to analyze llvm right now anyway. For me this looks good, but @alexfh or @aaron.ballman should accept it. https://reviews.llvm.org/D49851

[PATCH] D50337: [clangd] DexIndex implementation prototype

kbobyrev updated this revision to Diff 159515. kbobyrev added a comment. Continue implementing Proof of Concept Dex-based static index replacement. This diff adds short query processing, the current solution does not utilize iterators framework (unlike the general queries) yet and is a subject t

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

Hahnfeld added a comment. Do we still need this? I think what we really need to solve is the problem of (host) inline assembly in the header files... Repository: rC Clang https://reviews.llvm.org/D47849 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

Meinersbur added inline comments. Comment at: docs/CodingStandards.rst:514-516 +line of code. Some common editors will automatically remove trailing whitespace +when saving a file which causes unrelated changes to appear in diffs and +commits. JDevlieghere wrote:

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

bricci added a comment. Just to provide a bit of additional context: My comment about fsyntax-only is not specific to fsyntax-only. This is just an handy way to benchmark the frontend without noise from LLVM. It is important to keep all frequently used structures small (within reason) even if thi

[PATCH] D50390: [SEMA]Uniform printing of Attributes

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, rjmccall. The recent patch that reordered parsed attributes made it clear that the diagnostics when printing attributes were incredibly inconsistent. in the mutual-exclusion case, the order of the attributes would chang

[PATCH] D50390: [SEMA]Uniform printing of Attributes

erichkeane added inline comments. Comment at: include/clang/Sema/ParsedAttr.h:956 + +inline const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB, + const ParsedAttr *At) { Note that the pointer-overload is requ

r339150 - [OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return

Author: scott.linder Date: Tue Aug 7 08:52:49 2018 New Revision: 339150 URL: http://llvm.org/viewvc/llvm-project?rev=339150&view=rev Log: [OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return Always emit alloca in entry block for enqueue_kernel builtin. Ensures the stati

r339152 - [OPENMP] Mark variables captured in declare target region as implicitly

Author: abataev Date: Tue Aug 7 09:14:36 2018 New Revision: 339152 URL: http://llvm.org/viewvc/llvm-project?rev=339152&view=rev Log: [OPENMP] Mark variables captured in declare target region as implicitly declare target. According to OpenMP 5.0, variables captured in lambdas in declare target re

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. In https://reviews.llvm.org/D47849#1190903, @Hahnfeld wrote: > Do we still need this? I think what we really need to solve is the problem of > (host) inline assembly in the header files... Don't we want to use device specific math functions? It's not just about avoidi

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

What's the motivation for clangd to differ from clang here? (& if the first letter is going to be capitalized, should there be a period at the end? But also the phrasing of most/all diagnostic text isn't in the form of complete sentences, so this might not make sense) On Fri, Aug 3, 2018 at 1:44 P

[PATCH] D50154: [clangd] capitalize diagnostic messages

dblaikie added subscribers: ilya-biryukov, dblaikie. dblaikie added a comment. What's the motivation for clangd to differ from clang here? (& if the first letter is going to be capitalized, should there be a period at the end? But also the phrasing of most/all diagnostic text isn't in the form of

Re: r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

Reckon there's a chance of improved diagnostic text in cases like this? Will users understand what the problem is/how to fix it when they read "temporary implicitly bound to local reference will be destroyed at the end of the full-expression" - feels very standard-ese-y to me? & I appreciate teh de

Re: r338732 - [analyzer] Make RegionVector use const reference

Looks good! Though it may be useful in the future to describe, in the commit message, the motivation for a change - how'd you find this? What motivated you to make this particular fix just now, etc? ("identified using clang-tidy" or "spotted during post-commit review of change r", etc...) On T

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

greened added a comment. In https://reviews.llvm.org/D49897#1189688, @sbc100 wrote: > But in the CL description you say "..when configuring clang to use a > different linker by default". How is this possible?i.e. do you have a > config where these tests are currently failing? Yes, I do.

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. I see. This seems a little strange to me. I'm not sure it makes sense for CLANG_DEFAULT_LINKER to effect targets like WebAssembly that only have single supported linker. I'm OK with landing

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, dschuff. This flag is deprecated. The prefered way to select the lld flavor is by calling it by one of its aliases. Repository: rC Clang https://reviews.llvm.org/D50395 Files: lib/Driv

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

sbc100 updated this revision to Diff 159533. sbc100 added a comment. - update test Repository: rC Clang https://reviews.llvm.org/D50395 Files: lib/Driver/ToolChains/WebAssembly.cpp lib/Driver/ToolChains/WebAssembly.h test/Driver/wasm-toolchain.c test/Driver/wasm-toolchain.cpp Index

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. I do run it over llvm/lib, there is no visible effect. from my experience maybe 1-5% of the lines are interleafed without the patch, too. https://reviews.llvm.org/D49851 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:664 + // Anything that's not a file name is potentially a static library + // so treat it as such. + if (C.canSkipOffloadBundler()) sfantao wrote: > So, what if it is not a

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea updated this revision to Diff 159536. gtbercea marked 3 inline comments as done. gtbercea added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D47394 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Opti

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D48896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Abpostelnicu added a comment. Did you notice any significant speed degradation? https://reviews.llvm.org/D49851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, with a few NITs. Thanks for the change! Comment at: clangd/Quality.h:81 + bool NeedsFixIts = + false; // Whether fixits needs to be applied for that

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. No nothing. I think it is barely noticable in general. From prior long runs i notices the scrambled messages, but it was only a small fraction. So most of the time the threads dont seem to interfere, which makes the lock kinda low-cost. Am 07.08.2018 um 19:17 schrieb An

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159537. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/clang-tidy/checks/abseil-duration-division.rst docs/clang-tidy/chec

[PATCH] D50154: [clangd] capitalize diagnostic messages

arphaman added a comment. In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > What's the motivation for clangd to differ from clang here? (& if the first > letter is going to be capitalized, should there be a period at the end? But > also the phrasing of most/all diagnostic text isn'

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

craig.topper added a comment. Ping https://reviews.llvm.org/D50168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r339158 - [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

Author: greened Date: Tue Aug 7 10:44:43 2018 New Revision: 339158 URL: http://llvm.org/viewvc/llvm-project?rev=339158&view=rev Log: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp) lld is the only supported linker that works for WebAssembly, so ensure clang is using it for th

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

This revision was automatically updated to reflect the committed changes. Closed by commit rC339158: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp) (authored by greened, committed by ). Repository: rC Clang https://reviews.llvm.org/D49897 Files: test/Driver/wasm-toolcha

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 159546. ahatanak marked an inline comment as done. ahatanak added a reviewer: rsmith. ahatanak added a comment. Herald added a subscriber: jfb. Address review comments. Repository: rC Clang https://reviews.llvm.org/D50152 Files: include/clang/AST/Comp

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < revi...@reviews.llvm.org> wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > > > What's the motivation for clangd to differ from clang here? (& if the > first > > letter is going to be

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; rjmccall wrote: > ahatanak wrote: > > ahatanak wrote: > > > rjmccall wrote: > > > > Can you just ask Sema to chec

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159550. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst docs/clang-tidy/checks/abseil-duration-division.rs

[PATCH] D50361: [NFC] Test automatic variable initialization

jfb added a comment. Further fixes in r339090 and r339093. Repository: rC Clang https://reviews.llvm.org/D50361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 159553. ahatanak added a comment. Remove a stale comment and add an assertion to check the destructor's exception specification has been resolved. Repository: rC Clang https://reviews.llvm.org/D50152 Files: include/clang/AST/ComputeExceptionSpec.h

[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/VirtualFileSystem.cpp:1391 + error(NameValueNode, +"entry with relative path at the root level is not discoverable"); + r

[PATCH] D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the clean up! LGTM https://reviews.llvm.org/D50118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added a comment. That is a change that Richard should definitely sign off on. Also, I'm not sure this works — is it really okay to skip the work done by `ResolveExceptionSpec` in IRGen? What does that mean, that we're just somewhat more conservative than we would otherwise be? And w

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < > revi...@reviews.llvm.org> wrote: > >> arphaman added a comment. >> >> In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: >

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D50395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

leonardchan added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6943 +def err_typecheck_incompatible_conditional_pointer_operands : Error< + "unable to find common type between %0 and %1 for conditional operation">; ebevhan wrote: > T

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

leonardchan updated this revision to Diff 159559. leonardchan marked an inline comment as done. leonardchan added a comment. - Removed checks for OpenCL in `checkConditionalPointerCompatibility`. This allows for the error `err_typecheck_op_on_nonoverlapping_address_space_pointers` to be dumped o

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall added a comment. In https://reviews.llvm.org/D50278#1190544, @ebevhan wrote: > I think the solution to a lot of diagnostic and behavior issues with address > spaces is to remove predication on OpenCL. It's a bit odd to have a language > feature that is enabled out of the box regardless

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Sema/SemaExpr.cpp:6522 +bool HasDifferingLAddrSpace = LAddrSpace != ResultAddrSpace; +bool HasDifferingRAddrSpace = RAddrSpace != ResultAddr

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> arphaman added a comment. >>> >>> I

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added a comment. I thought it was okay to skip the work done by `ResolveExceptionSpec` in IRGen as long as the exception specifications that are needed have already been resolved in Sema. But calling Sema::canThrow in Sema::CheckCompleteVariableDeclaration and storing the result in Bl

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

sbc100 updated this revision to Diff 159562. sbc100 added a comment. - update tests Repository: rC Clang https://reviews.llvm.org/D50395 Files: lib/Driver/ToolChains/WebAssembly.cpp lib/Driver/ToolChains/WebAssembly.h test/Driver/wasm-toolchain.c test/Driver/wasm-toolchain.cpp Inde

r339163 - [WebAssembly] Remove use of lld -flavor flag

Author: sbc Date: Tue Aug 7 11:55:41 2018 New Revision: 339163 URL: http://llvm.org/viewvc/llvm-project?rev=339163&view=rev Log: [WebAssembly] Remove use of lld -flavor flag This flag is deprecated. The preferred way to select the lld flavor is by calling it by one of its aliases. Differential

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL339163: [WebAssembly] Remove use of lld -flavor flag (authored by sbc, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50395 Files: cfe/trunk/l

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

george.karpenkov added a comment. @rnk As discussed, would it be acceptable for you to just have empty sanitizer runtime files in the resource directory? Repository: rL LLVM https://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commit

r339164 - [VFS] Emit an error when entry at root level uses a relative path.

Author: vsapsai Date: Tue Aug 7 12:05:41 2018 New Revision: 339164 URL: http://llvm.org/viewvc/llvm-project?rev=339164&view=rev Log: [VFS] Emit an error when entry at root level uses a relative path. Entries with only a filename prevent us from building a file system tree and cause the assertion

[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339164: [VFS] Emit an error when entry at root level uses a relative path. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D49518?vs=157311&id=159567#toc Reposit

[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

vsapsai added a comment. Thanks for the review, Bruno. Repository: rC Clang https://reviews.llvm.org/D49518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH]Clang-format AlignConsecutiveAssignment

In testing clang-format with our code base QMCPACK (https://github.com/QMCPACK/qmcpack) we realized we would like consecutive identical compound assignments to be aligned as tok::equal assignments were. The following patch accomplishes this. Not sure if this is the correct way to submit this,

  1   2   3   >