[PATCH] D63607: [clang][driver] Add basic --driver-mode=fortran support for flang

peterwaller-arm updated this revision to Diff 219666. peterwaller-arm added a comment. Fixed assertion message "Input output." => "Invalid output". The erroneous text came was copied from: https://github.com/llvm/llvm-project/blob/6b9df910d04fae62dacc22c1c84f66c0f126cde0/clang/lib/Driver/ToolCha

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/test/clang-tidy/performance-inefficient-vector-operation.cpp:315 +foo.mutable_x(); +// CHECK-FIXES-NOT: foo.mutable

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 219670. krisb added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/ARM.cpp test/

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

dnsampaio marked 4 inline comments as done. dnsampaio added a comment. Hi @jfb. In a example such as: struct { int a : 1; int b : 16; } S; extern int expensive_computaion(int v); void foo(volatile S* s){ s->b = expensive_computation(s->b); } There is no guarantee that `s->a` is not m

r371597 - [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

Author: dnsampaio Date: Wed Sep 11 02:06:17 2019 New Revision: 371597 URL: http://llvm.org/viewvc/llvm-project?rev=371597&view=rev Log: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature Submittin in behalf of krisb (Kristina Bessonova) Summary: '+crypto' means '+ae

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL371597: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature (authored by dnsampaio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repo

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. @RKSimon I'm busy with other stuff and my colleague: LiuChen3 will help finish the work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

chandlerc added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + Sorry folks, but you can't do this. You can't depend on ADT from compiler-rt currently. There are at l

r371598 - Revert "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM"

Author: gribozavr Date: Wed Sep 11 02:16:17 2019 New Revision: 371598 URL: http://llvm.org/viewvc/llvm-project?rev=371598&view=rev Log: Revert "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM" This reverts commit r371584. It introduced a dependency from compiler-rt

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

gribozavr added a comment. Reverted in r371598. Another concern that I have is cross-compilation. LLVM's ADT is not set up to be cross-compiled like the rest of compiler-rt is. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar updated this revision to Diff 219673. andwar marked 6 inline comments as done. andwar added a comment. - Removed `declare variant` from Attr.td - Moved the 'vector-var-id' lookup from ParseOpenMP.cpp to SemaOpenMP.cpp - Parsing 'vector-var-id' as an expression - Removed the creation of the

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar added a comment. I've addressed most of the comments except for those related to templates. I'd like to clarify as what is the expected behaviour there before proceeding with implementation. Comment at: include/clang/Basic/Attr.td:3220 +private: + NamedDecl *V

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#1665773 , @gribozavr wrote: > Reverted in r371598. > > Another concern that I have is cross-compilation. LLVM's ADT is not set up to > be cross-compiled like the rest of compiler-rt is. Uhm, i have a better question

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

jdoerfert added a comment. I left some minor notes but overall I think we should put this in and improve on it in-tree. @ABataev, would that be OK with you? Comment at: lib/Parse/ParseOpenMP.cpp:748 } +/// Parses clauses for 'declare variant' directive. Rem

[PATCH] D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Sure! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67418/new/ https://reviews.llvm.org/D67418 ___ cfe-com

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

ABataev added inline comments. Comment at: include/clang/Basic/Attr.td:3220 +private: + NamedDecl *VecVarNamedDecl; + andwar wrote: > ABataev wrote: > > This is definitely wrong, especially if we need to handle templates. > What else would you use? Also,

r371605 - [Diagnostics] Add -Wsizeof-array-div

Author: xbolva00 Date: Wed Sep 11 03:59:47 2019 New Revision: 371605 URL: http://llvm.org/viewvc/llvm-project?rev=371605&view=rev Log: [Diagnostics] Add -Wsizeof-array-div Summary: Clang version of https://www.viva64.com/en/examples/v706/ Reviewers: rsmith Differential Revision: https://reviews

[PATCH] D67436: CodeGen: set correct result for atomic compound expressions

t.p.northover created this revision. Herald added subscribers: jfb, mcrosier. Herald added a project: clang. Atomic compound expressions try to use atomicrmw if possible, but this path doesn't set the `Result` variable, leaving it to crash in later code if anything ever tries to use the result o

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. > I'm open to discuss a better design here. Eg., i thought about making it part > of the visitor interface instead, but i don't immediately see how to do this > without breaking the logi

r371497 - Revert Remove REQUIRES:shell from tests that pass for me on Windows

Author: jhenderson Date: Tue Sep 10 01:48:33 2019 New Revision: 371497 URL: http://llvm.org/viewvc/llvm-project?rev=371497&view=rev Log: Revert Remove REQUIRES:shell from tests that pass for me on Windows This reverts r371478 (git commit a9980f60ce083fa6d5fd03c12c58ca0b293e3d60) Modified: cf

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hi David, Does this still reproduce? I'm seeing the load after the call to autoreleasePoolPop at ToT, but perhaps I'm not using the proper flags? I only checked out the github repo and did "clang -fobjc-runtime=gnustep-2.0 -O3 -emit-llvm -S libobjc2/Test/AssociatedObject.m" with a ToT clang. Than

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore requested changes to this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:30 +Cl

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham updated this revision to Diff 219691. simon_tatham added a comment. New version which renames the attribute to be MVE-specific, and locks it down as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https://reviews.l

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham updated this revision to Diff 219692. simon_tatham added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Dri

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! I think code readability improved geatly. > This creates a certain problem in `RetainCountChecker` (surprise!!~) We constantly bully this checker, but still not enough :^) =

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

Szelethus added a comment. Looks great! Are we sure that `PathDiagnostic.h` is a good header name? Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" --

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/F

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

gribozavr added a comment. Are you planning to move users of these options -- like `PlistDiagnostics` -- to libAnalysis? Comment at: clang/include/clang/Analysis/PathDiagnostic.h:81 + /// because deterministic mode is always superior when done right, but + /// for some consu

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

gribozavr requested changes to this revision. gribozavr added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37 const cross_tu::CrossTranslationUnitContext &CTU); -#include "clang

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

gribozavr added a comment. The "bugtype" in IssueHash is specific to Static Analyzer (or at least not documented sufficiently abstractly). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 ___

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 _

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. > @Szelethus: I could have stored `PathDiagnosticConsumerOptions` in > `AnalyzerOptions` by value and pass a const reference around, but it wasn't > pleasant to integrate with `AnalyzerOptions.def`. I.e., i'd have to implement > a new kind of option that doesn't alloc

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. rebase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

r371627 - [OPENMP]Updated status page, NFC.

Author: abataev Date: Wed Sep 11 07:44:30 2019 New Revision: 371627 URL: http://llvm.org/viewvc/llvm-project?rev=371627&view=rev Log: [OPENMP]Updated status page, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D67294: Register and parse a simplified version of '#pragma omp declare variant'

andwar marked 2 inline comments as done. andwar added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:779-783 + auto Identinfo = PP.getIdentifierInfo(VectorVariantId.Ident->getName()); + LookupResult Lookup(Actions, Identinfo, VectorVariantId.Loc, +

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. @dnsampaio, many thanks for committing this! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

r371633 - [Clang][Bundler] Fix for a potential memory leak [NFC]

Author: sdmitriev Date: Wed Sep 11 09:03:21 2019 New Revision: 371633 URL: http://llvm.org/viewvc/llvm-project?rev=371633&view=rev Log: [Clang][Bundler] Fix for a potential memory leak [NFC] Bundler leaks memory if it is called with -type=o but given input isn't an object file (though it has to

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + chandlerc wrote: > Sorry folks, but you can't do this. > >

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + paulkirth wrote: > chandlerc wrote: > > Sorry folks, but you can't do this. > > > > You can't depend on AD

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a comment. In D66324#1665784 , @lebedev.ri wrote: > In D66324#1665773 , @gribozavr wrote: > > > Reverted in r371598. > > > > Another concern that I have is cross-compilation. LLVM's ADT is not set up

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 219728. paulkirth added a comment. Revert mismerge when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/Di

r371635 - Reland "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM"

Author: phosek Date: Wed Sep 11 09:19:50 2019 New Revision: 371635 URL: http://llvm.org/viewvc/llvm-project?rev=371635&view=rev Log: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM" This patch contains the basic functionality for reporting potentially incorr

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371635: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D66324?vs=219728&id=219733#t

r371637 - [Clang][Bundler] Replace std::vector by SmallVector [NFC]

Author: sdmitriev Date: Wed Sep 11 09:28:47 2019 New Revision: 371637 URL: http://llvm.org/viewvc/llvm-project?rev=371637&view=rev Log: [Clang][Bundler] Replace std::vector by SmallVector [NFC] Differential Revision: https://reviews.llvm.org/D67413 Modified: cfe/trunk/tools/clang-offload-bun

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

mgorny created this revision. mgorny added reviewers: sammccall, gribozavr, compnerd. Herald added subscribers: kadircet, ilya-biryukov. Add LLVMTestingSupport directory from LLVM_MAIN_SRC_DIR when building clang stand-alone and LLVMTestingSupport library is not present. This is needed to fix sta

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. Up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 219742. sdmitriev added a reviewer: Hahnfeld. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offloa

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp:34 #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h" -#include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h" #include "llvm/ADT/Arr

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

thakis added a comment. Do you think this should land with the comment FIXME for now? It improves formatting of this language feature when that heuristic is not used, and changing the heuristic is independent of the rest of this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6724

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185 } else { -assert(ErrorNode); -hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode)); Szelethus wrote: > Why delete the assert

r371642 - [MS] Consder constexpr globals to be inline, as in C++17

Author: rnk Date: Wed Sep 11 11:09:10 2019 New Revision: 371642 URL: http://llvm.org/viewvc/llvm-project?rev=371642&view=rev Log: [MS] Consder constexpr globals to be inline, as in C++17 Summary: Microsoft seems to do this regardless of the language mode, so we must also do it in order to be ABI

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL371642: [MS] Consder constexpr globals to be inline, as in C++17 (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185 } else { -assert(ErrorNode); -hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode)); NoQ wrote: > Szelethus wrote: > > Why de

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

aaron.ballman added a comment. Thank you for doing all this work -- in general, this is looking great and really cleans things up! Comment at: clang/include/clang/Basic/Attr.td:2266 let Spellings = [CXX11<"", "maybe_unused", 201603>, GCC<"unused">, - C2x<"

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ added a comment. In D67421#1666058 , @gribozavr wrote: > The "bugtype" in IssueHash is specific to Static Analyzer (or at least not > documented sufficiently abstractly). Yeah, i'll need to document this. That's basically the warning message; it do

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37 const cross_tu::CrossTranslationUnitContext &CTU); -#include "clang/StaticAnalyzer/Core/Analyses.def" +#include "clang/Analysis/

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666141 , @Szelethus wrote: > I do! Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to use the same set of flags to control these options (?) Much like `-analyzer-config`, these flags will have di

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

Hi David, This commit broken ARMv7 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/10203/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adiv-sizeof-array.cpp Thanks, Yvan On Wed, 11 Sep 2019 at 12:58, David Bolvansky via cfe-commits wrote: >

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666141 , @Szelethus wrote: > - For these select 4 options that suffer compatibility issues, manually check > `AnalyzerOptions::ConfigTable`. *3 options. `ToolInvocation` is not really an option that you're ever supposed

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666050 , @gribozavr wrote: > Are you planning to move users of these options -- like `PlistDiagnostics` -- > to libAnalysis? Yup, i was supposed to do that in D67422 :) Repository: rC

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

rnk created this revision. rnk added a reviewer: amccarth. Herald added a subscriber: arphaman. Herald added a project: clang. Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit substitutions isn't an issue. 2. Use the %/t and %/

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 219750. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/CMakeLists.txt clang/tools/clang-offload-wrapper

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. r369705 did not consider the addition of gnu_inline on function declarations of alias attributed functions. This resulte

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. In D66856#1650803 , @aaron.ballman wrote: > To me, actual problems at runtime belong in -Wformat and logical > inconsistencies that don't cause runtime problems belong in > -Wformat-pedantic. However, I think it's a defect

[PATCH] D52524: Add -Wpoison-system-directories warning

denik added a comment. Ping @aaron.ballman , please verify the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

andrewrk requested changes to this revision. andrewrk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Decl.cpp:3352 + assert((doesThisDeclarationHaveABody() || willHaveBody()) || + hasAttr() && "Must be a function definitio

r371646 - [NFC] Added triple to test file to avoid arm buildbots failures

Author: xbolva00 Date: Wed Sep 11 11:55:56 2019 New Revision: 371646 URL: http://llvm.org/viewvc/llvm-project?rev=371646&view=rev Log: [NFC] Added triple to test file to avoid arm buildbots failures Modified: cfe/trunk/test/Sema/div-sizeof-array.cpp Modified: cfe/trunk/test/Sema/div-sizeof-a

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added a comment. Hmm, does anybody want me to write an example tool that emits path diagnostics but doesn't link to `libStaticAnalyzer*`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

Thanks, Reproduced with -triple armv7–. Added triple to run line, hopefully it will fix the bots. I will check this buildbot if all ok. rL371646 Dňa 11. 9. 2019 o 20:35 užívateľ Yvan Roux napísal: > Hi David, > > This commit broken ARMv7 bots, logs are available here: > > http://lab.llvm.or

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. I'm not sure copying the crtbegin/crtend mechanism from the early days of C runtime is ideal. Since the data is stored in a common section anyway, please could we rename it to __omp_offloading_entries in which case the linker will provide start/end symbols autom

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

rjmccall added a comment. Right, that sounds reasonable. You should be making them link up exactly like a normal method implementation, so if SemaObjC doesn't consider normal method implementations to be redeclarations, then I guess these aren't either. And if we want to change that in the fu

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 219756. Quuxplusone added a comment. Herald added a subscriber: dexonsmith. Rebased on master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/new/ https://reviews.llvm.org/D47111 Files: include/experimental/mem

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 219758. Quuxplusone added a comment. Rebased on master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource src/experimental/memory_

[PATCH] D67429: Improve code generation for thread_local variables:

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commi

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. > OpenMP linker script is known to cause problems for gold and lld linkers on > Linux and it will also cause problems for Windows enabling in future What are the known problems with the linker script? I'm wondering if they can be resolved without the overhead of

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#158 , @JonChesterfield wrote: > > OpenMP linker script is known to cause problems for gold and lld linkers on > > Linux and it will also cause problems for Windows enabling in future > > What are the known problems

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp:302-303 // Find the node's current statement in the CFG. - if (const Stmt *S = PathDiagnosticLocation::getStmt(this)) + // FIXME: getStmtForDiagnostic

[PATCH] D52524: Add -Wpoison-system-directories warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, this LGTM. However, I'm not the most familiar with how cross-compiling works in the first place, so I may be the wrong one to approve this. ===

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#173 , @ABataev wrote: > In D64943#158 , @JonChesterfield > wrote: > > > > OpenMP linker script is known to cause problems for gold and lld linkers > > > on Linux

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#178 , @JonChesterfield wrote: > In D64943#173 , @ABataev wrote: > > > In D64943#158 , > > @JonChesterfield wrote: > > > > > >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#179 , @ABataev wrote: > In D64943#178 , @JonChesterfield > wrote: > > > In D64943#173 , @ABataev wrote: > > > > > In D

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc created this revision. poelmanc added reviewers: alexfh, alexfh_. poelmanc added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-tidy's modernize-use-using feature is great! But if it finds any commas that are not within parenthe

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#193 , @JonChesterfield wrote: > In D64943#179 , @ABataev wrote: > > > In D64943#178 , > > @JonChesterfield wrote: > > > > >

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

rnk created this revision. rnk added reviewers: thakis, hans. Herald added a project: clang. C++ does not allow shadowing template parameters, but previously we allowed it under -fms-extensions. Now this behavior is controlled by -fms-compatibility, and we emit a -Wmicrosoft-template warning when

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67454/new/ https://reviews.llvm.org/D67454 ___

RE: [PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

Microsoft linker does not support linker script. We need to solution that works with all linkers. The begin/end is supported by most linker of interest. -Original Message- From: Jon Chesterfield via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Wednesday, September 11, 2019 12:2

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively updated this revision to Diff 219784. tlively added a comment. - Make narrows binary ops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#136 , @JonChesterfield wrote: > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > runtime is ideal. Since the data is stored in a common section anyway, please > could we rename it to

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai marked 2 inline comments as done. vsapsai added a comment. Thanks for the review. Comment at: clang/lib/Lex/HeaderSearch.cpp:892-902 +IsInHeaderMap, MappedName); +if (!MappedName.empty()) { + assert(IsInHeaderMap && "MappedName should come from a header

r371655 - Fix -Wnonportable-include-path suppression for header maps with absolute paths.

Author: vsapsai Date: Wed Sep 11 13:39:04 2019 New Revision: 371655 URL: http://llvm.org/viewvc/llvm-project?rev=371655&view=rev Log: Fix -Wnonportable-include-path suppression for header maps with absolute paths. In `DirectoryLookup::LookupFile` parameter `HasBeenMapped` doesn't cover the case w

r371656 - [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

Author: arphaman Date: Wed Sep 11 13:40:31 2019 New Revision: 371656 URL: http://llvm.org/viewvc/llvm-project?rev=371656&view=rev Log: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization This commit adds an optimization to clang-scan-deps and clang's pre

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371655: Fix -Wnonportable-include-path suppression for header maps with absolute paths. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rL371656: [clang-scan-deps] add skip excluded conditional preprocessor block… (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

nickdesaulniers updated this revision to Diff 219790. nickdesaulniers added a comment. - adjust parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67455/new/ https://reviews.llvm.org/D67455 Files: clang/lib/AST/Decl.cpp clang/test/CodeGen/al

r371660 - [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter.

Author: dergachev Date: Wed Sep 11 13:54:24 2019 New Revision: 371660 URL: http://llvm.org/viewvc/llvm-project?rev=371660&view=rev Log: [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter. This method of PathDiagnostic is a part of Static Analyzer's particular path diagnostic

r371658 - [analyzer] NFC: Re-implement stack hints as a side map in BugReport.

Author: dergachev Date: Wed Sep 11 13:54:17 2019 New Revision: 371658 URL: http://llvm.org/viewvc/llvm-project?rev=371658&view=rev Log: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. That's one of the few random entities in the PathDiagnostic interface that are specific to t

r371659 - [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

Author: dergachev Date: Wed Sep 11 13:54:21 2019 New Revision: 371659 URL: http://llvm.org/viewvc/llvm-project?rev=371659&view=rev Log: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic. These static functions deal with ExplodedNodes which is something we don't want the P

[clang-tools-extra] r371661 - [analyzer] NFC: Move PathDiagnostic classes to libAnalysis.

Author: dergachev Date: Wed Sep 11 13:54:27 2019 New Revision: 371661 URL: http://llvm.org/viewvc/llvm-project?rev=371661&view=rev Log: [analyzer] NFC: Move PathDiagnostic classes to libAnalysis. At this point the PathDiagnostic, PathDiagnosticLocation, PathDiagnosticPiece structures no longer re

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67381#1665930 , @Szelethus wrote: > Side note, now that you had to work with the freshly rewritten file, do you > have any feedback on it? Dunno, i'm a very functional / pure / stateless per

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67419#1665993 , @Szelethus wrote: > Looks great! Are we sure that `PathDiagnostic.h` is a good header name? Not really, but i haven't come up with a better name yet (see also the summary of

  1   2   >