[PATCH] D50815: Establish the header

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted r339971 as it breaks sanitizer bots https://reviews.llvm.org/D50815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D38525: Cleanup and generalize -shared-libasan.

vitalybuka added a comment. In https://reviews.llvm.org/D38525#26, @rsmith wrote: > Could we perhaps rename these flags to e.g. `-static-libsan` (with a > `-static-libasan` alias for compatibility)? It seems confusing that the way > to enable a static tsan runtime would be with `-static-lib

[PATCH] D38525: Cleanup and generalize -shared-libasan.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/SanitizerArgs.cpp:614 + if (Arg *A = Args.getLastArg(options::OPT_shared_libsan, + options::OPT_static

[PATCH] D51049: Driver: Enable address-significance tables by default when targeting COFF.

vitalybuka added a comment. This breaks Windows bot http://lab.llvm.org:8011/builders/sanitizer-windows/builds/33846/steps/run%20check-asan/logs/stdio 742542.065 [0/1/37] Running the AddressSanitizer tests -- Testing: 607 tests, 16 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50 FAIL: A

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132876. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. empty file test https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133111. vitalybuka added a comment. Create valid empty object file https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_b

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133116. vitalybuka added a comment. set triple https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll Index: c

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka created this revision. vitalybuka added reviewers: pcc, tejohnson. Herald added subscribers: eraman, inglorion, mehdi_amini. Empty ThinLTOIndexFile signals that we don't need this module during linking. So we should not run ThinLTO backend even if it contains the ThinLTO module. Backend

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka added a comment. In https://reviews.llvm.org/D42995#125, @tejohnson wrote: > > Empty ThinLTOIndexFile signals that we don't need this module during > > linking. > > Not the only case actually. We now also pass an empty index file when we want > to compile the bitcode down to obje

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka added a comment. In https://reviews.llvm.org/D42995#1000155, @vitalybuka wrote: > In https://reviews.llvm.org/D42995#125, @tejohnson wrote: > > > > Empty ThinLTOIndexFile signals that we don't need this module during > > > linking. > > > > Not the only case actually. We now also p

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. ping https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133966. vitalybuka added a comment. fix rebase issues introduced in the last patch https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/C

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka planned changes to this revision. vitalybuka added a comment. https://reviews.llvm.org/D42995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

This revision was automatically updated to reflect the committed changes. Closed by commit rC325182: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

This revision was automatically updated to reflect the committed changes. Closed by commit rL325182: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42611?vs=134317&id=134321#toc Re

[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:59 + ; Check that the call was devirtualized. + ; CHECK-IR: %call = tail call i32 @_ZN1A1nEi + %1 = tail call { i8*, i1 } @llvm.type.

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka updated this revision to Diff 134385. vitalybuka added a comment. Herald added a subscriber: hiraditya. Don't use empty index file https://reviews.llvm.org/D42995 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/Inputs/thinlto-distributed-backend-skip.bc clang/test/C

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

vitalybuka updated this revision to Diff 134657. vitalybuka marked 6 inline comments as done. vitalybuka added a comment. addressed comments https://reviews.llvm.org/D42995 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/Inputs/thinlto-distributed-backend-skip.bc clang/test/Co

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. @pcc Could you please take a look? https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 134752. vitalybuka marked an inline comment as done. vitalybuka added a comment. use count 0 https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp cl

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rC325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42680?vs=134752&id=13

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rL325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

This revision was automatically updated to reflect the committed changes. Closed by commit rC325411: [ThinLTO] Allow indexing to request backend to ignore the module (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42995?vs=134657&id=134755#toc Reposi

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:109 static cl::opt MergeCondStores( "simplifycfg-merge-cond-stores", cl::Hidden, cl::init(true), why metadata instead of cl:opt like these? https://reviews.llvm.org/

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6056 SmallPtrSetImpl *LoopHeaders) { + const Function *Fn = BB->getParent(); + if (Fn && Fn->getMetadata("no_simplify_cfg")) So maybe Attribute::Sani

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/SanitizerArgs.cpp:384 +KernelAddress | Efficiency), + std::make_pair(SafeStack, Address | HWAddr

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000];

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added inline comments. Comment at: test/asan/TestCases/intercept-rethrow-exception.cc:48 + // memcpy is intercepted by asan which performs checks on src and dst + using T = int[1000]; + T x {}; robot wrote: > vitalybuka wrote: > > You can include #i

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT326132: [asan] Intercept std::rethrow_exception indirectly (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42644?vs=132990&id=135965#toc Repository: rCRT

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

vitalybuka added a comment. Can you please add some details about why someone wants to customize LIBXX here? Or even better attach a patch which uses this. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 ___ cfe-commits mailing

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. I assume this is going to be abandoned in favor of https://reviews.llvm.org/D44057 https://reviews.llvm.org/D43423 ___ cfe-com

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:369 // Check that LTO is enabled if we need it. if ((Kinds & NeedsLTO) && !D.isUsingLTO()) { D.Diag(diag::err_drv_argument_only_allowed_with) Is this change needed to avoi

[PATCH] D47665: Refactored clang-fuzzer in preparation for adding new loop-proto-fuzzer

vitalybuka added inline comments. Comment at: tools/clang-fuzzer/CMakeLists.txt:17 ExampleClangProtoFuzzer.cpp + FuzzerInitialize.cpp ) this file is missing Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:29 +/* static std:

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka added a comment. Good practice is to avoid merging changes into a single one. Here one patch should be "refactoring" and the second for "loop-proto-fuzzer." Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:29 +/* static std::vector CLArgs; --

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka added a comment. In https://reviews.llvm.org/D47666#1119821, @vitalybuka wrote: > Good practice is to avoid merging changes into a single one. > Here one patch should be "refactoring" and the second for > "loop-proto-fuzzer." We are doing this for several reasons: 1. smaller patch

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:11 /// \file /// This file implements a function that runs Clang on a single /// input and uses

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp:23 + +namespace clang_fuzzer { + I guess you already committed t

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

vitalybuka updated this revision to Diff 150380. vitalybuka added a comment. git clang-format -f --style=file HEAD^ Repository: rC Clang https://reviews.llvm.org/D47843 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp tools/clang-fuzzer/cxx_lo

[PATCH] D47843: Introducing single for loop into clang_proto_fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL334216: Introducing single for loop into clang_proto_fuzzer (authored by vitalybuka, committed by ). Repository: rL LLVM https://reviews.llvm.org/D47843 Files: cfe/trunk/tools/clang-fuzzer/CMakeList

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vitalybuka added a comment. Is this stale? Repository: rC Clang https://reviews.llvm.org/D42043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60807: Test for Oz fail

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -Oz builds are usually significantly large than -Os build Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60807 Files: clang/test/CodeGen/oz.cpp __

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

vitalybuka added a comment. fixed with r359366 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

vitalybuka added subscribers: hctim, vitalybuka. vitalybuka added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12035 -- Testing: 14692 tests, 96 threads -- Testing: FAIL: Clang :: AST/float16.cpp (132 of 14692) TEST 'Clang

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

vitalybuka added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:305 enum ImplicitConversionCheckKind : unsigned char { -ICCK_IntegerTruncation = 0, +ICCK_IntegerTruncation = 0, // Legacy, no longer used. +ICCK_UnsignedIntegerTruncation = 1, -

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

vitalybuka added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:305 enum ImplicitConversionCheckKind : unsigned char { -ICCK_IntegerTruncation = 0, +ICCK_IntegerTruncation = 0, // Legacy, no longer used. +ICCK_UnsignedIntegerTruncation = 1, -

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

vitalybuka reopened this revision. vitalybuka added a comment. Reverted in r343183 https://bugs.llvm.org/show_bug.cgi?id=39094 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/29356/steps/build%20release%20tsan%20with%20clang/logs/stdio Repository: rL LLVM https://revi

[PATCH] D52589: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:7 +////

[PATCH] D37860: [MSan] Enable use-after-dtor instrumentation by default.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:854 HelpText<"Enable use-after-destroy detection in MemorySanitizer">; +def fno_sanitize_memory_use_after_dtor : Flag<["-"], "fno-sanitize-memory-use-after-

[PATCH] D37860: [MSan] Enable use-after-dtor instrumentation by default.

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/fsanitize.c:175 -// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory -fsanitize-memory-use-after-dtor -pie %s -##

[PATCH] D37860: [MSan] Enable use-after-dtor instrumentation by default.

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/use-after-dtor.cc:13 #include #include morehouse wrote: > vitalybuka wrote: > > Probably we need one test which check that we stop detecting bugs with > > -fno-sanitize-memory-track-origin

[PATCH] D37867: [MSan] Add flag to disable use-after-dtor.

vitalybuka added a comment. In https://reviews.llvm.org/D37867#871353, @eugenis wrote: > Have you looked at performance? Not the answer to your question, but this patch just adds negative flag without changing defaults. https://reviews.llvm.org/D37867 _

[PATCH] D37867: [MSan] Add flag to disable use-after-dtor.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/SanitizerArgs.cpp:494 + options::OPT_fno_sanitize_memory_use_after_dtor, + false); NeedP

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: llvm/lib/Analysis/ValueTracking.cpp:3222 + if (auto *CE = dyn_cast(C)) { +if (CE->getOpcode() == Instruction::IntToPtr) { @pcc BTW, your original patch just gave up

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis, glider, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Patch extends effect of D63967 to 32bit platforms and improves pattern initialization there.

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL365858: Handle IntToPtr in isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63967?vs=207180&id=209394#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka added a comment. In D64597#1581654 , @jfb wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When I discussed t

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209400. vitalybuka added a comment. 0x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeGenCXX/aut

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209401. vitalybuka added a comment. undo unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeG

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

This revision was automatically updated to reflect the committed changes. Closed by commit rL365921: CodeGet: Init 32bit pointers with 0x (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D64675: WIP: Disable optimization in emitStoresForConstant

vitalybuka created this revision. vitalybuka added reviewers: glider, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Not rely a review, but removing this code I see slight improvements in binary size on CTMark. Looks like with "ptr" patches MemCpyOptPass is

[PATCH] D64675: WIP: Disable optimization in emitStoresForConstant

vitalybuka updated this revision to Diff 209638. vitalybuka added a comment. Remove single store Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64675/new/ https://reviews.llvm.org/D64675 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/Code

[PATCH] D64675: WIP: Disable optimization in emitStoresForConstant

vitalybuka added a comment. In D64675#1584016 , @jfb wrote: > I would keep single stores because it's pretty silly codegen to copy from a > global for that. > > I would also verify that `-O0` isn't affected too badly by this change. I will. And maybe I'

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 209942. vitalybuka added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/test/CodeGenCXX/union-tbaa2.cpp llvm/include/llvm/In

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:27 +static const char GlobalArgumentMemAccess[] = { +// grep -P -o "(?<=FUNCTION_INFO: ).*" | sort -u > +// ../llvm-project/ll

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 210950. vitalybuka added a comment. fix LTO on kernel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/test/CodeGenCXX/union-tbaa2.cpp llvm/include/l

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:221 + s32 gv_relptr; + u32 info; +}; Can this be just following? u32 size:24; u8 tag; Comment at: compiler-rt/lib/hwasan/hwasan.cpp:236 -using namespace __h

[PATCH] D65770: hwasan: Instrument globals.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1203 + Constant *Initializer = GV->getInitializer(); + uint64_t SizeInBytes = + M.getDataLayout().getTypeAllocSize(Initializer->getType()); what is goi

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 214183. vitalybuka added a comment. Fix https://godbolt.org/z/-PinQP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/test/CodeGenCXX/member-function-p

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 206365. vitalybuka added a comment. Herald added subscribers: asbirlea, george.burgess.iv. Bugfixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/te

[PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka created this revision. vitalybuka added a reviewer: pcc. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CodeGenFunc

[PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka updated this revision to Diff 206771. vitalybuka added a comment. remove unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63854/new/ https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/C

[PATCH] D63940: [NFC] Pass DataLayout into isBytewiseValue

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. vitalybuka added a parent revision: D63854: [NFC] Convert large lambda into method. We will need to handle IntToPtr which I will submit in a separate patch as it's

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This helps with more efficient use of memset for pattern initialization Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63967 Files: clang/tes

[PATCH] D64169: ARM MTE stack sanitizer.

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:28 + if (!CGM.getLangOpts().Sanitize.hasOneOf( + SanitizerKind::Address | SanitizerKind::KernelAddress | + SanitizerKind::HWAddress | Saniti

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

vitalybuka added a comment. is the patch description still correct? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1109 // else. -if (MemoryPhi *MP = dyn_cast(Access)) +if (const MemoryPhi *MP = dyn_cast(Access)) return MP->getIncomingValue(ArgN

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. In D63602#1570884 , @ro wrote: > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > remained unreviewed for two weeks.

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka added a parent revision: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation. Previous implementatio

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208583. vitalybuka added a comment. Reverted debug logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/Co

[PATCH] D64385: GodeGen: Add test to track emitStoresForConstant behavior

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64385 Files: clang/test/CodeGen/init-memset.c Index: clang/test/CodeGen/init-mems

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka updated this revision to Diff 208593. vitalybuka added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64385/new/ https://reviews.llvm.org/D64385 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGen/init-memset.c

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208594. vitalybuka added a comment. undo some behavior change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib

[PATCH] D64386: CodeGen: Use memset in initializers for non-zeros

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64386 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGen/init

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka updated this revision to Diff 208598. vitalybuka added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64385/new/ https://reviews.llvm.org/D64385 Files: clang/test/CodeGen/init-memset.c Index: clang/test/CodeGen/in

[PATCH] D64387: CodeGen: Do not memset if following stores will overwrite entire variable

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. In some cases llvm::getMostFrequentByte can't analyze a constant so we write zeros and then override the rest with stores. These zeros

[PATCH] D64392: CodeGen: Use memset for bytewise values with any size

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith, javed.absar. Herald added a project: clang. It was already done for zeros, now we support any bytes Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208617. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka marked 4 inline comments as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:865 +/// initializer with equal or fewer than NumStores scalar stores. +static bool canEmitStoresForInitAfterMemset(CodeGenModule &CGM, +

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:873 return true; - if (isa(Init) || isa(Init) || + if (BWInit || isa(Init) || isa(Init) || isa(Init) || isa(Init) || vitalybuka w

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/init-memset.c:36 + int a[16] = {0, 0, 1}; + // CHECK: call void @llvm.memset.{{.*}} + // CHECK: store i32 1 eugenis wrote: > Would it be useful to che

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL365706: GodeGen, NFC: Add test to track emitStoresForConstant behavior (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D63854: NFC: Convert large lambda into method

This revision was automatically updated to reflect the committed changes. Closed by commit rL365708: NFC: Convert large lambda into method (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D63940: NFC: Pass DataLayout into isBytewiseValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL365709: NFC: Pass DataLayout into isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63940?vs=207092&id=209086#toc Repository: rL LLVM CHANGE

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, modocache, hiraditya, eraman, mgorny, mehdi_amini. Herald added projects: clang, LLVM. vitalybuka planned changes to this revision. I don't want to invest into improving this patch.

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory) http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21622/steps/check-cfi-and-supported%20in%20gcc%20build/logs/stdio 100%] Running the cfi regression tests

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. In D62050#1509384 , @vitalybuka wrote: > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in > empty directory) I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right appro

[PATCH] D55621: [asan] Don't check ODR violations for particular types of globals

This revision was automatically updated to reflect the committed changes. Closed by commit rC349015: [asan] Don't check ODR violations for particular types of globals (authored by vitalybuka, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D55616: Emit ASM input in a constant context

vitalybuka added a comment. Looks like it's broken by this patch clang: /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm/tools/clang/lib/AST/ExprConstant.cpp:11055: llvm::APSInt clang::Expr::EvaluateKnownConstInt(const clang::ASTContext &, SmallVectorImpl *) const: Assertion `Result && "

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

vitalybuka added a comment. In D47817#1341490 , @krytarowski wrote: > Looks good to me, but I will let a Linux person to accept it. LGTM as well, but would be nice to have input from @ygribov who added this code. CHANGES SINCE LAST ACTION https://rev

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

vitalybuka added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:49 + + fclose(fp); + return 0; why does this close file only on success? I assume normal test behavior is return 0; So please replace all return N with as

  1   2   3   4   5   6   7   8   >