eladkal merged PR #38287:
URL: https://github.com/apache/airflow/pull/38287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ferruzzi commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1609211092
##
tests/providers/amazon/aws/operators/test_neptune.py:
##
@@ -100,11 +102,113 @@ def test_start_cluster_cluster_available(self,
mock_waiter, mock_get_cluster_sta
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1609193496
##
tests/providers/amazon/aws/operators/test_neptune.py:
##
@@ -100,11 +102,113 @@ def test_start_cluster_cluster_available(self,
mock_waiter, mock_get_cluster_sta
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1608731192
##
tests/providers/amazon/aws/operators/test_neptune.py:
##
@@ -150,3 +257,114 @@ def test_stop_cluster_cluster_stopped(self, mock_waiter,
mock_get_cluster_status
ferruzzi commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1608627264
##
airflow/providers/amazon/aws/hooks/neptune.py:
##
@@ -83,3 +89,32 @@ def get_cluster_status(self, cluster_id: str) -> str:
:return: The status of the
eladkal commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1607748032
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -32,6 +36,50 @@
from airflow.utils.context import Context
+def handle_waitable_exception(
+
vincbeck commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1567522373
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -32,6 +36,51 @@
from airflow.utils.context import Context
+def handle_waitable_exception(
+
ellisms commented on PR #38287:
URL: https://github.com/apache/airflow/pull/38287#issuecomment-2058968244
This is ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1550288490
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -174,17 +253,91 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1550287756
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
ellisms commented on PR #38287:
URL: https://github.com/apache/airflow/pull/38287#issuecomment-2035343869
@eladkal Not yet, just getting back into the office. Working on making the
suggested changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
eladkal commented on PR #38287:
URL: https://github.com/apache/airflow/pull/38287#issuecomment-2035336034
@ellisms is the PR ready for re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
syedahsn commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1538210793
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
Taragolis commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532840938
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532635341
##
airflow/providers/amazon/aws/hooks/neptune.py:
##
@@ -83,3 +89,32 @@ def get_cluster_status(self, cluster_id: str) -> str:
:return: The status of the
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532625228
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,92 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
syedahsn commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532521802
##
airflow/providers/amazon/aws/hooks/neptune.py:
##
@@ -83,3 +89,32 @@ def get_cluster_status(self, cluster_id: str) -> str:
:return: The status of the
o-nikolas commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532511061
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -174,17 +253,91 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
syedahsn commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532511739
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
syedahsn commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1532511739
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
ellisms commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1530496624
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
Taragolis commented on code in PR #38287:
URL: https://github.com/apache/airflow/pull/38287#discussion_r1530439992
##
airflow/providers/amazon/aws/operators/neptune.py:
##
@@ -81,17 +85,86 @@ def __init__(
self.delay = waiter_delay
self.max_attempts =
ellisms commented on PR #38287:
URL: https://github.com/apache/airflow/pull/38287#issuecomment-2007195287
@ferruzzi This is the PR for the neptune operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ellisms opened a new pull request, #38287:
URL: https://github.com/apache/airflow/pull/38287
---
closes #38120
Handles case where the stop cluster api returns either InvalidClusterState
or InvalidDBInstanceState exceptions. The operator now uses the waiter to wait
24 matches
Mail list logo
