danny0405 commented on a change in pull request #1645: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1645#discussion_r356437555
##
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlExtractValueFunction.java
##
@@
yanlin-Lynn closed pull request #1396: [CALCITE-3278] Simplify the use to
translate RexNode to Expression for evaluating.
URL: https://github.com/apache/calcite/pull/1396
This is an automated message from the Apache Git Serv
yanlin-Lynn commented on issue #1396: [CALCITE-3278] Simplify the use to
translate RexNode to Expression for evaluating.
URL: https://github.com/apache/calcite/pull/1396#issuecomment-564414426
Use `RexExecutor` to evaluate constant RexNode will be more appropriateļ¼
I'll just close this PR.
danny0405 commented on issue #1640: [CALCITE-3552] Support MySQL ExtractValue
function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564412873
Thanks @ritesh-kapoor , next time we better rebase on existing PR branch
which has all the history review comments.
--
ritesh-kapoor closed pull request #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640
This is an automated message from the Apache Git Service.
To respond to the message
ritesh-kapoor commented on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564367879
I have raised a new pull request
https://github.com/apache/calcite/pull/1645. Closing this one
---
ritesh-kapoor opened a new pull request #1645: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1645
This is an automated message from the Apache Git Service.
To respond to the m
DonnyZone edited a comment on issue #1644: [CALCITE-3564] Unify function's
operands type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644#issuecomment-564351806
> DATE is represented as int. TIMESTAMP is represented as long. DECIMAL is
represented as long.
DonnyZone commented on issue #1644: [CALCITE-3564] Unify function's operands
type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644#issuecomment-564351806
> DATE is represented as int. TIMESTAMP is represented as long. DECIMAL is
represented as long.
@juli
danny0405 commented on issue #1640: [CALCITE-3552] Support MySQL ExtractValue
function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564347157
I just notice that there are some commits in this branch that does not
belong to you, you need to rebase that out.
---
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356372796
##
File path: core/src/test/resources/sql/mysql-func.iq
##
@@ -0,0 +1,33 @@
+# misc.iq - Mis
julianhyde commented on issue #1644: [CALCITE-3564] Unify function's operands
type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644#issuecomment-564302277
See also my comments in https://issues.apache.org/jira/browse/CALCITE-3562.
This PR is going in t
julianhyde commented on issue #1644: [CALCITE-3564] Unify function's operands
type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644#issuecomment-564301613
Methods in `SqlFunctions` should never have `BigDecimal` or `BigInteger`
arguments or return types. Enu
amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356326903
##
File path: core/src/main/java/org/apache/calcite/rel/e
amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356326903
##
File path: core/src/main/java/org/apache/calcite/rel/e
julianhyde commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356324339
##
File path: core/src/main/java/org/apache/calcite/rel/
julianhyde commented on a change in pull request #1640: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356320605
##
File path: core/src/test/resources/sql/mysql-func.iq
##
@@ -0,0 +1,33 @@
+# misc.iq - Miscel
amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support
serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356282226
##
File path: core/src/main/java/org/apache/calcite/rel/e
This is an automated email from the ASF dual-hosted git repository.
hyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new db36758 Revert "[CALCITE-3576] Remove enumerabl
amaliujia commented on a change in pull request #1640: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356280124
##
File path: core/src/test/resources/sql/mysql-func.iq
##
@@ -0,0 +1,33 @@
+# misc.iq - Miscell
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-564167785
@danny0405 Thank you!
conflict solved and indentation fi
zabetak commented on issue #1596: Add guidance of how to run gradle
command(e.g. check) in a
URL: https://github.com/apache/calcite/pull/1596#issuecomment-564088626
Thanks for the PR @amaliujia !
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from abb4fef [CALCITE-3576] Remove enumerable convention check in
FilterIntoJoinRule
add 0fd7628 Site: Add two l
zabetak closed pull request #1596: Add guidance of how to run gradle
command(e.g. check) in a
URL: https://github.com/apache/calcite/pull/1596
This is an automated message from the Apache Git Service.
To respond to the messa
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method
in RelBuilder for conveniently projecting out expressions
URL: https://github.com/apache/calcite/pull/1554#discussion_r356090038
##
File path: core/src/test/java/org/apache/calcite/test/RelBuilderTest.jav
ritesh-kapoor commented on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564067359
> Thanks @ritesh-kapoor for a good xml functions start, can we also add a
test in `.iq` file ?
Done :). Kindly review if
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356079548
##
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##
@@ -7158,6 +7158,1
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355940307
##
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##
@@ -7158,6 +7158,1
ritesh-kapoor removed a comment on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564052258
> Thanks @ritesh-kapoor for a good xml functions start, can we also add a
test in `.iq` file ?
Tried adding test
ritesh-kapoor edited a comment on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564052258
> Thanks @ritesh-kapoor for a good xml functions start, can we also add a
test in `.iq` file ?
Tried adding test
ritesh-kapoor edited a comment on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564052258
> Thanks @ritesh-kapoor for a good xml functions start, can we also add a
test in `.iq` file ?
Tried adding test
ritesh-kapoor commented on issue #1640: [CALCITE-3552] Support MySQL
ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564052258
> Thanks @ritesh-kapoor for a good xml functions start, can we also add a
test in `.iq` file ?
Tried adding test to
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356051459
##
File path:
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356051493
##
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##
@@
danny0405 commented on issue #1640: [CALCITE-3552] Support MySQL ExtractValue
function
URL: https://github.com/apache/calcite/pull/1640#issuecomment-564011180
Thanks @ritesh-kapoor for a good xml functions start, can we also add a test
in `.iq` file ?
-
danny0405 commented on a change in pull request #1640: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356008324
##
File path:
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##
@@ -
danny0405 commented on a change in pull request #1640: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r356007470
##
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##
@@ -51
yanlin-Lynn commented on issue #1644: [CALCITE-3564] Unify function's operands
type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644#issuecomment-564002402
You are just updating *mod* and *rand* function, not all the functions.
I think the name of the pr a
zabetak commented on a change in pull request #1554: [CALCITE-3462] Add method
in RelBuilder for conveniently projecting out expressions
URL: https://github.com/apache/calcite/pull/1554#discussion_r355979047
##
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
DonnyZone opened a new pull request #1644: [CALCITE-3564] Unify function's
operands type check in validation and runtime
URL: https://github.com/apache/calcite/pull/1644
SqlFunction(MOD) allows `OperandTypes.EXACT_NUMERIC_EXACT_NUMERIC`, but it
does not implement interfaces for `(long, dec
danny0405 commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-563974829
Thanks @amaliujia for firing this PR, i'm planning to give a r
danny0405 commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r355957176
##
File path:
core/src/main/java/or
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355941460
##
File path: site/_docs/reference.md
##
@@ -2288,6 +2288,7 @@ semantics.
| m | JSON_KEYS(j
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355941460
##
File path: site/_docs/reference.md
##
@@ -2288,6 +2288,7 @@ semantics.
| m | JSON_KEYS(j
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355940307
##
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##
@@ -7158,6 +7158,1
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355940307
##
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##
@@ -7158,6 +7158,1
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938905
##
File path: core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java
##
@@ -0,0 +1,
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938881
##
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
##
@@
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938933
##
File path: core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java
##
@@ -0,0 +1,
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938687
##
File path:
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##
@@ -
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938781
##
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
#
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938583
##
File path: core/src/test/java/org/apache/calcite/test/SqlXmlFunctionsTest.java
##
@@ -0,0
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938631
##
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##
@@ -11094,
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938853
##
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##
@@
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938824
##
File path: core/src/main/java/org/apache/calcite/util/BuiltInMethod.java
##
@@ -321,6 +32
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938749
##
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##
@@ -855
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938347
##
File path: site/_docs/reference.md
##
@@ -2331,6 +2332,7 @@ Note:
* `JSON_LENGTH` define
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938522
##
File path: core/src/test/java/org/apache/calcite/test/SqlXmlFunctionsTest.java
##
@@ -0,0
ritesh-kapoor commented on a change in pull request #1640: [CALCITE-3552]
Support MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355938265
##
File path: site/_docs/reference.md
##
@@ -2288,6 +2288,7 @@ semantics.
| m | JSON_KEYS(j
danny0405 opened a new pull request #1643: [CALCITE-3584] Support SQL hints
propagation for decorrelation
URL: https://github.com/apache/calcite/pull/1643
* Add a new interface Hintable#setHints(List) to set up the rel node
hists;
* Move RelHintPropagateShuttle from SqlToRelConverter
60 matches
Mail list logo