MYNEWT-778.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
in individual drivers.
- Removing the sensor_shell_stol() API.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
. Reaching through that will be a bit cumbersome.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about th
takes a function pointer which gets called for each registered
service. The new print code could go in a new file and be implemented with a
call to the new foreach function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
mment over there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Similar we could do for description to conn_handle, but int this case we
have only couple of obj_types valid.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
ces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ssage from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
vrahane closed pull request #330: MYNEWT-781 BNO055 Shell: throw error on no
type
URL: https://github.com/apache/incubator-mynewt-core/pull/330
This is an automated message from the Apache Git Service.
To respond
be used for reading instead of
os_time_delay().
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
.
1) Removed the blinky shell example
2) Added a link the the enabling the Console and Shell tutorial as an
example.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
t?
Also, you'll want to remove the timer from the list before calling the
handler; the intent is that the called callback function will be able to
restart this same timer.
This is an automated message from the Apache Git Service.
To
are going to be missed when someone else is blocking
interrupts for some amount of time.
It would be useful to look at other hal_timer implementations to see how
they deal with this issue.
This is an automated message from t
aditihilbert closed pull request #199: warning: same priority for two tasks is
not allowed, fires an assert.
URL: https://github.com/apache/incubator-mynewt-site/pull/199
This is an automated message from the Apache Git
names.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
mkiiskila closed pull request #328: boot/bootutil; security fix - if
BOOTUTIL_VALIDATE_SLOT0 was set,
URL: https://github.com/apache/incubator-mynewt-core/pull/328
This is an automated message from the Apache Git Service
e can improve it going forward.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ype, uint16_t conn_handle);
```
and made `ble_store_status` static.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comm
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
mkiiskila closed pull request #329: Wi-Fire: Implement hal_timer
URL: https://github.com/apache/incubator-mynewt-core/pull/329
This is an automated message from the Apache Git Service.
To respond to the message, please log
with nRF52-DK
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
-packet-structure
https://en.wikipedia.org/wiki/IBeacon
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
spoonofpower opened a new pull request #188: newtmgr also moved to github
URL: https://github.com/apache/incubator-mynewt-site/pull/188
This is an automated message from the Apache Git Service.
To respond to the message
, for example.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
mkiiskila closed pull request #284: hw: mcu: pic32mz2048efg100: Rename ppc to
pps
URL: https://github.com/apache/incubator-mynewt-core/pull/284
This is an automated message from the Apache Git Service.
To respond
mkiiskila closed pull request #286: Wi-Fire: Add SPI support (master mode only)
URL: https://github.com/apache/incubator-mynewt-core/pull/286
This is an automated message from the Apache Git Service.
To respond
it in the Go playground. I did that test a while ago
and no longer have the exact code I tested, though.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
(data_off < fa->fa_size)
+{
Review comment:
Can you fix the coding style?
See
https://github.com/apache/incubator-mynewt-core/blob/master/CODING_STANDARDS.md
This is an automated message from the Apache Git Serv
op is needed. I have not encountered a flash
sector which would not be a multiple of minimally 4 bytes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
@@
#include
#include
+#include
Review comment:
Do we need this inclusion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
return MGMT_ERR_EINVAL;
+}
+rc = flash_area_erase(imgr_state.upload.fa, 0,
+ imgr_state.upload.fa->fa_size);
Review comment:
Could call flash_area_close() for completeness.
This is an automated message from th
ccollins476ad closed pull request #55: MYNEWT-583; newt - allow use of specific
tag/repository revision.
URL: https://github.com/apache/incubator-mynewt-newt/pull/55
This is an automated message from the Apache Git Service
, s)
}
```
Output:
```
s={%!s(int=5)}
Program exited.
```
Maybe there is something different in this example?
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
@@
#include
#include
+#include
Review comment:
yes for min, though that could be duplicated so os isnt needed, or put
somewhere else
This is an automated message from the Apache Git Service.
To respond to the message, please
ed message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ld include
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ed message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
back up cleanly and advertise after a flash_erase
disconnect.
Its interesting though if I break and step a bit it does come back, so it
seems like a timing issue?
This is an automated message from the Apache Git Service
return MGMT_ERR_EINVAL;
+}
+rc = flash_area_erase(imgr_state.upload.fa, 0,
+ imgr_state.upload.fa->fa_size);
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to
mkiiskila closed pull request #295: Wrap RTT console buffer if full
URL: https://github.com/apache/incubator-mynewt-core/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please
mkiiskila closed pull request #289: Shell fixes from review #256
URL: https://github.com/apache/incubator-mynewt-core/pull/289
This is an automated message from the Apache Git Service.
To respond to the message, please log
comments/critics
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
PierreKircher closed pull request #193: Slack logo + link in footer
URL: https://github.com/apache/incubator-mynewt-site/pull/193
This is an automated message from the Apache Git Service.
To respond to the message, please
). At the moment we don't have this facility.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
aditihilbert closed pull request #188: newtmgr also moved to github
URL: https://github.com/apache/incubator-mynewt-site/pull/188
This is an automated message from the Apache Git Service.
To respond to the message, please
return fmt.Sprintf("%d", s.a)
}
func main() {
s := {5}
fmt.Printf("s=%s\n", s)
}
```
```
s=5
Program exited.
```
This is an automated message from the Apache Git Serv
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
rymanluk closed pull request #255: BLE Host - Fix peer OTA addr and type on
pairing.
URL: https://github.com/apache/incubator-mynewt-core/pull/255
This is an automated message from the Apache Git Service.
To respond
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ed devices.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastruct
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
, const union ble_store_key
*key,
{
int rc;
+ble_hs_lock();
Review comment:
Is this related to this patch? BTW why we need it in ble_store?
This is an automated message from the Apache Git Service.
To respond
+= ble_sm_num_procs();
Review comment:
count is not initialized
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
aditihilbert closed pull request #194: slack logo in footer
URL: https://github.com/apache/incubator-mynewt-site/pull/194
This is an automated message from the Apache Git Service.
To respond to the message, please log
aditihilbert commented on issue #194: slack logo in footer
URL:
https://github.com/apache/incubator-mynewt-site/pull/194#issuecomment-305171005
Thanks - This is cool!
This is an automated message from the Apache Git Service
shortage situation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
ccollins476ad closed pull request #301: oic - Fix for missing 128-bit iotivity
svc.
URL: https://github.com/apache/incubator-mynewt-core/pull/301
This is an automated message from the Apache Git Service.
To respond
PierreKircher opened a new pull request #195: community slack link
URL: https://github.com/apache/incubator-mynewt-site/pull/195
community slack link . req by sterling
This is an automated message from the Apache Git Service
service UUID which we want to support. This commit adds the 128-bit
UUID back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
aditihilbert closed pull request #185: MYNEWT-761 Update 1.1 doc for newtmgr
taskstats/mpstats commands.
URL: https://github.com/apache/incubator-mynewt-site/pull/185
This is an automated message from the Apache Git
aditihilbert closed pull request #191: MYNEWT-763 1.1 Doc for newt target amend
command.
URL: https://github.com/apache/incubator-mynewt-site/pull/191
This is an automated message from the Apache Git Service.
To respond
-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
PierreKircher opened a new pull request #196: Develop
URL: https://github.com/apache/incubator-mynewt-site/pull/196
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
PierreKircher closed pull request #196: Develop
URL: https://github.com/apache/incubator-mynewt-site/pull/196
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
, the Runtime characteristics were overwriting the iotivity value
handle variables. This caused notifications to be sent for the wrong
characteristic.
This is an automated message from the Apache Git Service.
To respond
omated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
omated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
aditihilbert closed pull request #195: community slack link
URL: https://github.com/apache/incubator-mynewt-site/pull/195
This is an automated message from the Apache Git Service.
To respond to the message, please log
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
francois-berder opened a new pull request #305: Wi-Fire: Implement watchdog
URL: https://github.com/apache/incubator-mynewt-core/pull/305
This is an automated message from the Apache Git Service.
To respond to the message
aditihilbert closed pull request #197: Fix broken link to task_lesson.png
URL: https://github.com/apache/incubator-mynewt-site/pull/197
This is an automated message from the Apache Git Service.
To respond to the message
wes3 closed pull request #304: make uart1 on rb-blend2 bitbanged
URL: https://github.com/apache/incubator-mynewt-core/pull/304
This is an automated message from the Apache Git Service.
To respond to the message, please log
mkiiskila closed pull request #303: hw: mcu: pic32mz2048efg100: Implement
hal_system_reset
URL: https://github.com/apache/incubator-mynewt-core/pull/303
This is an automated message from the Apache Git Service.
To respond
mkiiskila closed pull request #305: Wi-Fire: Implement watchdog
URL: https://github.com/apache/incubator-mynewt-core/pull/305
This is an automated message from the Apache Git Service.
To respond to the message, please log
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
directories. This can be overridden by the bsp, app,
or target. Some bsps used different settings for the console uart
and those bsps override the default uart (which is uart0).
This is an automated message from the Apache Git
)
return;
}
+#if 0
Review comment:
Removed, thanks for pointing it out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
vrahane closed pull request #258: MYNEWT-744 SensorAPI: improvements
URL: https://github.com/apache/incubator-mynewt-core/pull/258
This is an automated message from the Apache Git Service.
To respond to the message, please
)
return;
}
+#if 0
Review comment:
If it's #if 0, maybe you should consider removing the code block altogether?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
onsensus was, there would be an initial config that happens at the bsp
level. The user of the sensor can then go and re-config the sensor in the app
if needed.
----
This is an automated message from the Apache Git Service.
To respond to
();
Review comment:
Sensor config is not done by the user of the sensor?
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
e CONSOLE_UART "uart0"
Review comment:
Dont' forget to remove this line, and the other one in native-mips bsp when
pull request #314 gets merged.
--------
This is an automated message from the Apache Git Service.
To
wes3 closed pull request #314: MYNEWT_689: Make CONSOLE_UART a syscfg variable.
URL: https://github.com/apache/incubator-mynewt-core/pull/314
This is an automated message from the Apache Git Service.
To respond
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
by the bootloader this could be made the default.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
, setting the
DISABLEINDEBUG register.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
utzig closed pull request #315: BSP for STM32F7-Discovery board
URL: https://github.com/apache/incubator-mynewt-core/pull/315
This is an automated message from the Apache Git Service.
To respond to the message, please log
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
did not manage to cause a BOR
reset.
Signed-off-by: Francois Berder <fber...@outlook.fr>
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
1 - 100 of 212 matches
Mail list logo