RE: Why there are so many revert operations on trunk?

2016-06-07 Thread Zheng, Kai
sday, June 08, 2016 3:33 AM To: common-dev@hadoop.apache.org Subject: Re: Why there are so many revert operations on trunk? One anti-pattern that keeps coming up over and over again is people trying to do big and complex features without feature branches. This happened with HDFS truncate as w

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread Colin McCabe
o work in a more friendly > > > environment. In many cases, -1 without solid reason will frustrate people > > > who are doing contributions. I think we should restraint our -1 unless it > > > is really necessary. > > > > > > > > > > > > Tha

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread Ravi Prakash
without solid reason will frustrate >> people >> > who are doing contributions. I think we should restraint our -1 unless >> it >> > is really necessary. >> > >> > >> > >> > Thanks, >> > >> > >> > Junping >> > >>

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread larry mccay
> who are doing contributions. I think we should restraint our -1 unless it > > is really necessary. > > > > > > > > Thanks, > > > > > > Junping > > > > > > ________ > > From: Vinod Kumar Vavilapalli

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread Ravi Prakash
lapalli > Sent: Monday, June 06, 2016 9:36 PM > To: Andrew Wang > Cc: Junping Du; Aaron T. Myers; common-dev@hadoop.apache.org; > hdfs-...@hadoop.apache.org; mapreduce-...@hadoop.apache.org; > yarn-...@hadoop.apache.org > Subject: Re: Why there are so many revert operations on trunk? >

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread Junping Du
ng Du; Aaron T. Myers; common-dev@hadoop.apache.org; hdfs-...@hadoop.apache.org; mapreduce-...@hadoop.apache.org; yarn-...@hadoop.apache.org Subject: Re: Why there are so many revert operations on trunk? Folks, It is truly disappointing how we are escalating situations that can be resolved through

Re: Why there are so many revert operations on trunk?

2016-06-07 Thread Steve Loughran
+1 This is a good summary, And we are better off resolving issues through discussions on emails, rather than JIRA, and everyone behaving amicably towards each other. I think we should be more willing to do feature branches, especially for things like - anything deep into the codebase - self

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread larry mccay
inline On Mon, Jun 6, 2016 at 4:36 PM, Vinod Kumar Vavilapalli wrote: > Folks, > > It is truly disappointing how we are escalating situations that can be > resolved through basic communication. > > Things that shouldn’t have happened > - After a few objections were raised, commits should ha

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Vinod Kumar Vavilapalli
Folks, It is truly disappointing how we are escalating situations that can be resolved through basic communication. Things that shouldn’t have happened - After a few objections were raised, commits should have simply stopped before restarting again but only after consensus - Reverts (or revert

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread larry mccay
This seems like something that is going to probably happen again if we continue to cut releases from trunk. I know that this has been discussed at length in a separate thread but I think it would be good to recognize that it is the core of the issue here. Either we: * need to define what will hap

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Andrew Wang
To clarify what happened here, I moved the commits to a feature branch, not just reverting the commits. The intent was to make it easy to merge back in later, and also to unblock the 2.8 and 3.0 releases we've been trying very hard to wrap up for weeks. This doesn't slow down development since you

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Jitendra Pandey
ll community. Only through >> this, the success of Hadoop in age of 3.0 are guranteed. >> >> >> Thanks, >> >> >> Junping >> >> >> ____________________ >> From: Aaron T. Myers >> Sent: Monday, June 06,

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Chris Douglas
> > From: Aaron T. Myers > Sent: Monday, June 06, 2016 4:46 PM > To: Junping Du > Cc: Andrew Wang; common-dev@hadoop.apache.org; hdfs-...@hadoop.apache.org; > mapreduce-...@hadoop.apache.org; yarn-...@hadoop.apache.org > Subject: Re: Why there

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Junping Du
u Cc: Andrew Wang; common-dev@hadoop.apache.org; hdfs-...@hadoop.apache.org; mapreduce-...@hadoop.apache.org; yarn-...@hadoop.apache.org Subject: Re: Why there are so many revert operations on trunk? Junping, All of this is being discussed on HDFS-9924. Suggest you follow the conversation

Re: Why there are so many revert operations on trunk?

2016-06-06 Thread Aaron T. Myers
Junping, All of this is being discussed on HDFS-9924. Suggest you follow the conversation there. -- Aaron T. Myers Software Engineer, Cloudera On Mon, Jun 6, 2016 at 7:20 AM, Junping Du wrote: > Hi Andrew, > > I just noticed you revert 8 commits on trunk last Friday: > > HADOOP-13226 > >

Why there are so many revert operations on trunk?

2016-06-06 Thread Junping Du
Hi Andrew, I just noticed you revert 8 commits on trunk last Friday: HADOOP-13226 HDFS-10430 HDFS-10431 HDFS-10390 HADOOP-13168 HDFS-10390 HADOOP-13168 HDFS-10346 HADOOP-12957 HDFS-10224 And I didn't see you have any comments on JIRA or email discussion before you did this. I d