[GitHub] [hadoop] hadoop-yetus commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh URL: https://github.com/apache/hadoop/pull/1284#issuecomment-520720481 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HADOOP-16403) Start a new statistical rpc queue and make the Reader's pendingConnection queue runtime-replaceable

2019-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905897#comment-16905897 ] Hadoop QA commented on HADOOP-16403: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16377) Moving logging APIs over to slf4j

2019-08-13 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905905#comment-16905905 ] Prabhu Joseph commented on HADOOP-16377: [~jojochuang] [~ste...@apache.org] Can

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-08-13 Thread Jinglun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905932#comment-16905932 ] Jinglun commented on HADOOP-15565: -- Hi [~jojochuang] [~xkrogen] [~gabor.bota] [~hexiao

[jira] [Commented] (HADOOP-16403) Start a new statistical rpc queue and make the Reader's pendingConnection queue runtime-replaceable

2019-08-13 Thread Jinglun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905934#comment-16905934 ] Jinglun commented on HADOOP-16403: -- Hi [~jojochuang] [~xkrogen], patch-008 is ready no

[GitHub] [hadoop] adoroszlai opened a new pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai opened a new pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287 ## What changes were proposed in this pull request? 1. Aged IO thread exits on first read due to `ArrayIndexOutOfBoundsException`. This is cause

[GitHub] [hadoop] adoroszlai commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#issuecomment-520743106 @mukul1987 This is an automated message from the Apache Git Service. T

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905993#comment-16905993 ] Adam Antal commented on HADOOP-16503: - Indeed, sorry. I remember uploading it and

[jira] [Updated] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated HADOOP-16503: Attachment: HADOOP-16503.001.patch > [JDK11] TestLeafQueue tests are failing due to WrongTypeOfRe

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905995#comment-16905995 ] Adam Antal commented on HADOOP-16503: - For the verification of the patch one may us

[GitHub] [hadoop] adoroszlai commented on issue #1273: HDDS-1951. Wrong symbolic release name on 0.4.1 branch

2019-08-13 Thread GitBox
adoroszlai commented on issue #1273: HDDS-1951. Wrong symbolic release name on 0.4.1 branch URL: https://github.com/apache/hadoop/pull/1273#issuecomment-520761720 @nandakumar131 This is an automated message from the Apache G

[GitHub] [hadoop] bshashikant commented on a change in pull request #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul K

2019-08-13 Thread GitBox
bshashikant commented on a change in pull request #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/1281#discussion_r313302193 ## File path: had

[GitHub] [hadoop] bshashikant commented on issue #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul Kumar Singh.

2019-08-13 Thread GitBox
bshashikant commented on issue #1281: HDDS-1955. TestBlockOutputStreamWithFailures#test2DatanodesFailure failing because of assertion error. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/1281#issuecomment-520763229 The patch overall looks good to me. I have j

[GitHub] [hadoop] adoroszlai commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh

2019-08-13 Thread GitBox
adoroszlai commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh URL: https://github.com/apache/hadoop/pull/1284#issuecomment-520769904 Thanks @mukul1987 for reviewing it. Unfortunately `excludes` only works in `pom.xml`, not in the command-line. The up

[jira] [Commented] (HADOOP-16264) [JDK11] Track failing Hadoop unit tests

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906029#comment-16906029 ] Adam Antal commented on HADOOP-16264: - Created a few Yarn-related test fixing jiras

[GitHub] [hadoop] nandakumar131 closed pull request #1273: HDDS-1951. Wrong symbolic release name on 0.4.1 branch

2019-08-13 Thread GitBox
nandakumar131 closed pull request #1273: HDDS-1951. Wrong symbolic release name on 0.4.1 branch URL: https://github.com/apache/hadoop/pull/1273 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] bshashikant commented on issue #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing

2019-08-13 Thread GitBox
bshashikant commented on issue #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing URL: https://github.com/apache/hadoop/pull/1282#issuecomment-520773739 Thanks @adoroszlai for working on this. The change looks good to me. +1

[GitHub] [hadoop] bshashikant merged pull request #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing

2019-08-13 Thread GitBox
bshashikant merged pull request #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing URL: https://github.com/apache/hadoop/pull/1282 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing.

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing. URL: https://github.com/apache/hadoop/pull/1234#issuecomment-520777483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[jira] [Commented] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-08-13 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906051#comment-16906051 ] Junping Du commented on HADOOP-15616: - [~Sammi], could you help to drive this revie

[GitHub] [hadoop] adoroszlai commented on issue #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing

2019-08-13 Thread GitBox
adoroszlai commented on issue #1282: HDDS-1908. TestMultiBlockWritesWithDnFailures is failing URL: https://github.com/apache/hadoop/pull/1282#issuecomment-520781050 Thank you @bshashikant for reviewing and committing it. This

[GitHub] [hadoop] hadoop-yetus commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#issuecomment-520783651 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[GitHub] [hadoop] bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log)

2019-08-13 Thread GitBox
bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-520787365 - [x] - Fixed most of the checkstyle issues, however I left the long line length as it i

[GitHub] [hadoop] bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log)

2019-08-13 Thread GitBox
bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-520787365 - [x] - Fixed most of the checkstyle issues, however I left the long line length as it i

[GitHub] [hadoop] bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log)

2019-08-13 Thread GitBox
bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-520787365 - [x] - Fixed most of the checkstyle issues, however I left the long line length as it i

[GitHub] [hadoop] bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log)

2019-08-13 Thread GitBox
bgaborg edited a comment on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-520787365 - [x] - Fixed most of the checkstyle issues, however I left the long line length as it i

[GitHub] [hadoop] bgaborg commented on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log)

2019-08-13 Thread GitBox
bgaborg commented on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-520787365 - [ ] - Fixed most of the checkstyle issues, however I left the long line length as it is becau

[GitHub] [hadoop] nandakumar131 commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing.

2019-08-13 Thread GitBox
nandakumar131 commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing. URL: https://github.com/apache/hadoop/pull/1234#issuecomment-520797332 @xiaoyuyao The problem is that we are not considering `OzoneAclType` while checking if a OzoneKey already has the ACL or not.

[jira] [Updated] (HADOOP-16492) Support HuaweiCloud Object Storage - as a file system in Hadoop

2019-08-13 Thread zhongjun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhongjun updated HADOOP-16492: -- Attachment: huaweicloud-obs-integrate.pdf > Support HuaweiCloud Object Storage - as a file system in

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906132#comment-16906132 ] Hadoop QA commented on HADOOP-16503: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1279: HDDS-1942. Support copy during S3 multipart upload part creation

2019-08-13 Thread GitBox
lokeshj1703 commented on a change in pull request #1279: HDDS-1942. Support copy during S3 multipart upload part creation URL: https://github.com/apache/hadoop/pull/1279#discussion_r313367705 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/Obj

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-13 Thread GitBox
lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#discussion_r313386459 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerIm

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts

2019-08-13 Thread GitBox
lokeshj1703 commented on a change in pull request #1278: HDDS-1950. S3 MPU part-list call fails if there are no parts URL: https://github.com/apache/hadoop/pull/1278#discussion_r313388730 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyManag

[GitHub] [hadoop] hadoop-yetus commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart.

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1226: HDDS-1610. applyTransaction failure should not be lost on restart. URL: https://github.com/apache/hadoop/pull/1226#issuecomment-520836222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hadoop] nandakumar131 closed pull request #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh

2019-08-13 Thread GitBox
nandakumar131 closed pull request #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh URL: https://github.com/apache/hadoop/pull/1284 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] adoroszlai commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh

2019-08-13 Thread GitBox
adoroszlai commented on issue #1284: HDDS-1952. Disable TestMiniChaosOzoneCluster in integration.sh URL: https://github.com/apache/hadoop/pull/1284#issuecomment-520839636 Thank you @nandakumar131 for reviewing and merging it.

[jira] [Updated] (HADOOP-16416) mark DynamoDBMetadataStore.deleteTrackingValueMap as final

2019-08-13 Thread kevin su (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kevin su updated HADOOP-16416: -- Status: Patch Available (was: Open) > mark DynamoDBMetadataStore.deleteTrackingValueMap as final > -

[GitHub] [hadoop] adoroszlai commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler

2019-08-13 Thread GitBox
adoroszlai commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler URL: https://github.com/apache/hadoop/pull/1283#issuecomment-520848774 @anuengineer @dineshchitlangia please review when you have some time ---

[GitHub] [hadoop] hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing.

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing. URL: https://github.com/apache/hadoop/pull/1234#issuecomment-520859188 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hadoop] bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-13 Thread GitBox
bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r313424521 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java #

[GitHub] [hadoop] bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-13 Thread GitBox
bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r313422737 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ##

[GitHub] [hadoop] bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-13 Thread GitBox
bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r313423481 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ##

[GitHub] [hadoop] bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-13 Thread GitBox
bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r313421971 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ##

[GitHub] [hadoop] bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-08-13 Thread GitBox
bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#discussion_r313354887 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/RemoteFileChangedException

[jira] [Commented] (HADOOP-16416) mark DynamoDBMetadataStore.deleteTrackingValueMap as final

2019-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906284#comment-16906284 ] Hadoop QA commented on HADOOP-16416: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16264) [JDK11] Track failing Hadoop unit tests

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906297#comment-16906297 ] Adam Antal commented on HADOOP-16264: - I also add my findings for the hadoop-yarn-p

[jira] [Updated] (HADOOP-16264) [JDK11] Track failing Hadoop unit tests

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated HADOOP-16264: Attachment: test-run-openjdk11.0.4-macos10.14.5.txt > [JDK11] Track failing Hadoop unit tests > -

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-08-13 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906301#comment-16906301 ] Adam Antal commented on HADOOP-16503: - Verification failed, I still managed to see

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313465776 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313464607 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313467570 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313470272 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-08-13 Thread GitBox
sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r313481427 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/had

[GitHub] [hadoop] sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-08-13 Thread GitBox
sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r313482053 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/had

[jira] [Commented] (HADOOP-16448) Connection to Hadoop homepage is not secure

2019-08-13 Thread Sandeep Nemuri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906349#comment-16906349 ] Sandeep Nemuri commented on HADOOP-16448: - Apart from the reported urls, update

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313487361 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing.

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1234: HDDS-1917. TestOzoneRpcClientAbstract is failing. URL: https://github.com/apache/hadoop/pull/1234#issuecomment-520903069 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hadoop] sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-08-13 Thread GitBox
sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r313491763 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/had

[GitHub] [hadoop] sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index

2019-08-13 Thread GitBox
sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve fsimage load time by writing sub-sections to the fsimage index URL: https://github.com/apache/hadoop/pull/1028#discussion_r313493210 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/had

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313494917 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313494917 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[jira] [Updated] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HADOOP-16459: - Fix Version/s: 3.1.3 3.2.1 3.0.4 > Backport [HADOOP-16266

[GitHub] [hadoop] mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
mukul1987 commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313496805 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] nandakumar131 opened a new pull request #1288: HDDS-1961. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is flaky.

2019-08-13 Thread GitBox
nandakumar131 opened a new pull request #1288: HDDS-1961. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is flaky. URL: https://github.com/apache/hadoop/pull/1288 This is an automated message from the Apache Git

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#discussion_r313497795 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneLoadGenerator.java

[GitHub] [hadoop] avijayanhwx commented on issue #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager

2019-08-13 Thread GitBox
avijayanhwx commented on issue #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager URL: https://github.com/apache/hadoop/pull/1259#issuecomment-520921949 cc @mukul1987 This is a

[jira] [Updated] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HADOOP-16459: - Attachment: HADOOP-16266-branch-2.002.patch > Backport [HADOOP-16266] "Add more fine-grained pr

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906420#comment-16906420 ] Erik Krogen commented on HADOOP-16459: -- Re-visiting this branch-2 backport now tha

[jira] [Commented] (HADOOP-16351) Change ":" to ApplicationConstants.CLASS_PATH_SEPARATOR

2019-08-13 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906424#comment-16906424 ] Wei-Chiu Chuang commented on HADOOP-16351: -- [~pingsutw] this looks good. Have

[GitHub] [hadoop] sunchao commented on a change in pull request #1253: HDFS-8631. WebHDFS : Support setQuota

2019-08-13 Thread GitBox
sunchao commented on a change in pull request #1253: HDFS-8631. WebHDFS : Support setQuota URL: https://github.com/apache/hadoop/pull/1253#discussion_r313517504 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager

2019-08-13 Thread GitBox
avijayanhwx commented on a change in pull request #1259: HDDS-1105 : Add mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager URL: https://github.com/apache/hadoop/pull/1259#discussion_r313542436 ## File path: hadoop-ozone/ozone-recon/src/main/java/org/apache

[jira] [Created] (HADOOP-16513) Upgrade Bootstrap, jquery and wildfly

2019-08-13 Thread Vivek Ratnavel Subramanian (JIRA)
Vivek Ratnavel Subramanian created HADOOP-16513: --- Summary: Upgrade Bootstrap, jquery and wildfly Key: HADOOP-16513 URL: https://issues.apache.org/jira/browse/HADOOP-16513 Project: Hadoop

[jira] [Assigned] (HADOOP-16513) Upgrade Bootstrap, jquery and wildfly

2019-08-13 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey reassigned HADOOP-16513: - Assignee: Vivek Ratnavel Subramanian > Upgrade Bootstrap, jquery and w

[GitHub] [hadoop] hadoop-yetus commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1287: HDDS-1956. Aged IO Thread exits on first read URL: https://github.com/apache/hadoop/pull/1287#issuecomment-520953642 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906520#comment-16906520 ] Erik Krogen commented on HADOOP-15565: -- Thanks for working on this [~LiJinglun]! S

[GitHub] [hadoop] hadoop-yetus commented on issue #1288: HDDS-1961. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is flaky.

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1288: HDDS-1961. TestStorageContainerManager#testScmProcessDatanodeHeartbeat is flaky. URL: https://github.com/apache/hadoop/pull/1288#issuecomment-520966378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HADOOP-13868) New defaults for S3A multi-part configuration

2019-08-13 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Mackrory updated HADOOP-13868: --- Resolution: Fixed Status: Resolved (was: Patch Available) > New defaults for S3A m

[GitHub] [hadoop] avijayanhwx commented on a change in pull request #1286: Add filter to scmcli listPipelines.

2019-08-13 Thread GitBox
avijayanhwx commented on a change in pull request #1286: Add filter to scmcli listPipelines. URL: https://github.com/apache/hadoop/pull/1286#discussion_r313576403 ## File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ListPipelinesSubcommand.java ###

[GitHub] [hadoop] avijayanhwx commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler

2019-08-13 Thread GitBox
avijayanhwx commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler URL: https://github.com/apache/hadoop/pull/1283#issuecomment-520978220 LGTM +1 (non binding) This is an automated message fro

[GitHub] [hadoop] dineshchitlangia commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler

2019-08-13 Thread GitBox
dineshchitlangia commented on issue #1283: HDDS-1954. StackOverflowError in OzoneClientInvocationHandler URL: https://github.com/apache/hadoop/pull/1283#issuecomment-520979717 LGTM +1 (non binding), also I do not think the test failures are related. I have seen those tests fail of late in

[GitHub] [hadoop] avijayanhwx commented on issue #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

2019-08-13 Thread GitBox
avijayanhwx commented on issue #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#issuecomment-520979879 This is a very useful addition @elek. Is there any documentation or slides that I can look at to understand this more? ---

[GitHub] [hadoop] dineshchitlangia commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario

2019-08-13 Thread GitBox
dineshchitlangia commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#discussion_r313579214 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzon

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager

2019-08-13 Thread GitBox
bharatviswa504 commented on a change in pull request #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager URL: https://github.com/apache/hadoop/pull/1204#discussion_r313582727 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRp

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario

2019-08-13 Thread GitBox
adoroszlai commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#discussion_r313582830 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAudit

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager

2019-08-13 Thread GitBox
bharatviswa504 commented on a change in pull request #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager URL: https://github.com/apache/hadoop/pull/1204#discussion_r313587300 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ###

[GitHub] [hadoop] avijayanhwx commented on issue #1268: HDDS-1910. Cannot build hadoop-hdds-config from scratch in IDEA

2019-08-13 Thread GitBox
avijayanhwx commented on issue #1268: HDDS-1910. Cannot build hadoop-hdds-config from scratch in IDEA URL: https://github.com/apache/hadoop/pull/1268#issuecomment-520991112 LGTM +1 This is an automated message from the Apache

[GitHub] [hadoop] jojochuang commented on issue #1267: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

2019-08-13 Thread GitBox
jojochuang commented on issue #1267: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields URL: https://github.com/apache/hadoop/pull/1267#issuecomment-520991334 Ok. Let's spend some time on the doc, and raise a new jira to update the doc. +1 for the change in the PR, p

[GitHub] [hadoop] jojochuang opened a new pull request #1289: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

2019-08-13 Thread GitBox
jojochuang opened a new pull request #1289: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields URL: https://github.com/apache/hadoop/pull/1289 Fork from PR #1267 This is an automated message from the Apa

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906601#comment-16906601 ] Hadoop QA commented on HADOOP-16459: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906608#comment-16906608 ] Íñigo Goiri commented on HADOOP-16459: -- The differences between [^HADOOP-16266-br

[GitHub] [hadoop] LeonGao91 commented on issue #1252: HDFS-14678. Allow triggerBlockReport to a specific namenode.

2019-08-13 Thread GitBox
LeonGao91 commented on issue #1252: HDFS-14678. Allow triggerBlockReport to a specific namenode. URL: https://github.com/apache/hadoop/pull/1252#issuecomment-521013444 Thanks @jojochuang ! looks like the # of test failures reduced to 1 with re-run, and it is not related, could you take a l

[GitHub] [hadoop] hadoop-yetus commented on issue #1289: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1289: HDFS-14665. HttpFS: LISTSTATUS response is missing HDFS-specific fields URL: https://github.com/apache/hadoop/pull/1289#issuecomment-521013567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::

[GitHub] [hadoop] jojochuang commented on issue #1252: HDFS-14678. Allow triggerBlockReport to a specific namenode.

2019-08-13 Thread GitBox
jojochuang commented on issue #1252: HDFS-14678. Allow triggerBlockReport to a specific namenode. URL: https://github.com/apache/hadoop/pull/1252#issuecomment-521015474 I gave it a quick review and from that quick look it looks good. Thanks. I'll try to look at it harder, especially the te

[jira] [Commented] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906628#comment-16906628 ] Erik Krogen commented on HADOOP-16459: -- Thanks [~elgoiri]! Just committed this to

[jira] [Updated] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HADOOP-16459: - Resolution: Fixed Fix Version/s: 2.10.0 Status: Resolved (was: Patch Availabl

[jira] [Updated] (HADOOP-16266) Add more fine-grained processing time metrics to the RPC layer

2019-08-13 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik Krogen updated HADOOP-16266: - Fix Version/s: 2.10.0 > Add more fine-grained processing time metrics to the RPC layer > --

[GitHub] [hadoop] anuengineer commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario

2019-08-13 Thread GitBox
anuengineer commented on a change in pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#discussion_r313627412 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAudi

[GitHub] [hadoop] anuengineer closed pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario

2019-08-13 Thread GitBox
anuengineer closed pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] dineshchitlangia commented on issue #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager

2019-08-13 Thread GitBox
dineshchitlangia commented on issue #1204: HDDS-1768. Audit xxxAcl methods in OzoneManager URL: https://github.com/apache/hadoop/pull/1204#issuecomment-521029139 @bharatviswa504 Thanks for reviewing. Updated PR to address review comments. ---

[GitHub] [hadoop] hadoop-yetus commented on issue #1253: HDFS-8631. WebHDFS : Support setQuota

2019-08-13 Thread GitBox
hadoop-yetus commented on issue #1253: HDFS-8631. WebHDFS : Support setQuota URL: https://github.com/apache/hadoop/pull/1253#issuecomment-521029852 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

  1   2   >