Re: FYI - fix for JDK-8062849 -- Optimize EnumMap.equals

Hi Steve, Is this an FYI or an actual Request for Review? There are processes that need to be followed for official reviews prior to pushing. If you don't yet have Author status you will need someone to host your webrev on cr.openjdk.java.net for you. Cheers, David On 28/07/2015 2:38 AM, St

Re: ProcessBuilder support for pipelines

In the past, when I contemplated doing this, I generally thought that there wasn't enough value in such a feature for the effort, given that one can start a subprocess shell that supports pipelines. Does this feature pull its weight? You don't need this to re-implement emacs in java, which has al

Re: One more minor addition to ProcessBuilder

Seems reasonable. On Mon, Jul 27, 2015 at 11:09 AM, David M. Lloyd wrote: > Roger & co.: > > Since you're already on the topic of manipulating pipes, I thought I'd > mention one very small yet very useful potential enhancement. > > It would be very handy to be able to specify a NULL/bit-bucket >

Fwd: Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

Hi Volker, Thanks for the refactoring and the AIX implementation. We still need a tie-breaker with respect to the issue of truncated/incomplete argument and executable values. On 7/24/2015 9:30 AM, Volker Simonis wrote: Hi, so here comes the new webrev which cleanly applies to the current j

Re: RFR: JDK-8114832 it.next on ArrayList throws wrong type of Exception after remove(-1)

On Mon, Jul 27, 2015 at 1:19 AM, Paul Sandoz wrote: > > My guiding principle here was that argument validation should not result > in side-effects. Thus the state of a collection should remain unchanged if > an exception is thrown due to an invalid argument of an operation. > > That is indeed a g

Re: RFR(XS): 8132374: AIX: fix value of os.version property

Hi Volker, Yes, it looks fine. I did'nt know if it was a reasonable request across os versions. Thanks, Roger On 7/27/2015 1:54 PM, Volker Simonis wrote: Hi Roger, I've added the requested test. See: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132374.v1/ I've tested it on Solaris

One more minor addition to ProcessBuilder

Roger & co.: Since you're already on the topic of manipulating pipes, I thought I'd mention one very small yet very useful potential enhancement. It would be very handy to be able to specify a NULL/bit-bucket source/destination for pipes. For the target process' input, the user can generall

Re: RFR(XS): 8132374: AIX: fix value of os.version property

Hi Roger, I've added the requested test. See: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132374.v1/ I've tested it on Solaris 10/11, Linux SLES 12/Ubuntu 12.04, MaxOS X 10.9 and 10.10, Windows 7 and AIX 7.1 I think it should work on all supported platforms. OK now? Regards, Volker On M

Re: FYI - fix for JDK-8062849 -- Optimize EnumMap.equals

Hi Steve, Only a few attachment types, all text, are allowed through to core-libs. The usual technique is to copy the webrev to cr.openjdk.java.net frequently with scp. Roger On 7/27/2015 1:31 PM, Steve Drach wrote: Well this is strange. The attachments seem to have been discarded by some pa

Re: FYI - fix for JDK-8062849 -- Optimize EnumMap.equals

Well this is strange. The attachments seem to have been discarded by some part of the mail system. I will provide them to anyone who requests them. Sorry for that. > On Jul 27, 2015, at 9:38 AM, Steve Drach wrote: > > Hi, > > I’ve fixed the issue reported in > https://bugs.openjdk.java.ne

FYI - fix for JDK-8062849 -- Optimize EnumMap.equals

Hi, I’ve fixed the issue reported in https://bugs.openjdk.java.net/browse/JDK-8062849 . It’s been reviewed by Brent Christian and Paul Sandoz. Both the changeset and webrev.zip are attached. Steve

ProcessBuilder support for pipelines

On most operating systems, creating pipelines of processes is simple and direct. That same function is missing from the Java Process support and can be provided by java.lang.ProcessBuilder by enabling the pipes created for stdout to be used for standard input when the processes are created. Comm

Re: RFR(XS): 8132374: AIX: fix value of os.version property

Hi Volker, I doubt there is a test for any of the OS's but is it possible to write a test that would compare that string to the version string produced by one of the os provided tools. For example uname? Thanks, Roger On 7/27/2015 9:29 AM, Volker Simonis wrote: Thanks, Alan. We've done th

Re: RFR(XS): 8132374: AIX: fix value of os.version property

Thanks, Alan. We've done this correctly in our SAP JVM as well as IBM in their J9 but for some reason we've missed the fixed in the initial OpenJDK port. Regards, Volker On Mon, Jul 27, 2015 at 3:02 PM, Alan Bateman wrote: > > > On 27/07/2015 13:54, Volker Simonis wrote: >> >> Hi, >> >> can so

Re: RFR(XS): 8132374: AIX: fix value of os.version property

On 27/07/2015 13:54, Volker Simonis wrote: Hi, can somebody please review this tiny fix to get the value of the 'os.version' property correct on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132374/ https://bugs.openjdk.java.net/browse/JDK-8132374 This looks okay to me, assuming ap

RFR(XS): 8132374: AIX: fix value of os.version property

Hi, can somebody please review this tiny fix to get the value of the 'os.version' property correct on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132374/ https://bugs.openjdk.java.net/browse/JDK-8132374 Thank you and best regards, Volker

Re: RFR: JDK-8114832 it.next on ArrayList throws wrong type of Exception after remove(-1)

Hi Paul, > > I'm mildly opposed to this change - I added comments to the bug. > > > > It looks like you are not the only one. I am outnumbered :-) > > The behaviour of ArrayList.remove, and also ArrayList.removeRange, are > outliers [*]. It?s also a rather obscure difference behaviour with likely

Re: RFR: JDK-8114832 it.next on ArrayList throws wrong type of Exception after remove(-1)

On 24 Jul 2015, at 20:30, Martin Buchholz wrote: > Hi Steve, pleased to meet you! > > (are you a new maintainer of java.util collections?) > I suggested that Steve look at some “simple” issues to build up credits for a committer role, so i threw this and some others over the fence for Steve