Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-18 Thread Christian Perrier
Quoting Raphael Hertzog ([EMAIL PROTECTED]): > (I have the feeling we already require translation of too many strings > that users won't never see) Shared. The dpkg POT file is, ahem, scary. Frank objects that translators may choose what they translate and what they don't. However, most of us h

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-18 Thread Raphael Hertzog
Hi, the latest version of my branch is online: http://git.debian.org/?p=users/hertzog/dpkg.git;a=shortlog;h=deps-rewrite git://git.debian.org/~hertzog/dpkg.git On Thu, 18 Oct 2007, Guillem Jover wrote: > No need to call textdomain inside the modules (those can only be used > in dpkg-dev programs)

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-17 Thread Guillem Jover
Hi, On Mon, 2007-10-15 at 15:55:13 +0200, Raphael Hertzog wrote: > Please review and run it. I think it can be merged soon, just tell me to > go ahead when you're confident. It would be nice to include it in the > upcoming release as it automatically removes duplicate dependencies > potentially in

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-17 Thread Frank Lichtenheld
On Wed, Oct 17, 2007 at 11:01:04PM +0200, Raphael Hertzog wrote: > On Wed, 17 Oct 2007, Frank Lichtenheld wrote: > > Some notes: > > - Should the parsing algorithm enforce the negated arch syntax, i.e. > >that either none or all architectures need to be negated? > > I have no opinion here. Th

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-17 Thread Raphael Hertzog
On Wed, 17 Oct 2007, Frank Lichtenheld wrote: > A short review turned up no obious flaws. I have no objections against > merging it into master for inclusion in the next release. Cool! > Some notes: > - Should the parsing algorithm enforce the negated arch syntax, i.e. >that either none or a

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-17 Thread Russ Allbery
Frank Lichtenheld <[EMAIL PROTECTED]> writes: > - Lack of attribution: I know the lintian code contains no >attributions, which doesn't neccessarily mean that this is a good >idea. You probably should add at least your name and the complete >attribution from lintian's debian/copyright

Re: [PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-17 Thread Frank Lichtenheld
On Mon, Oct 15, 2007 at 03:55:13PM +0200, Raphael Hertzog wrote: > I'm running this code and up to now it seems to work fine. During the > development, I also discovered a number of little bugs and oddities that I > took the liberty to commit directly on the master branch. > > Please review and ru

[PATCH] New Dpkg::Deps module to replace parsedep() and showdep()

2007-10-15 Thread Raphael Hertzog
Hello everybody, last week-end and today I worked on creating a new Dpkg::Deps module which is able to parse dependencies, simplify them. I based my work on lintian's lib/Dep.pm, expanded it and created an object-oriented interface for it. The attached patch-set is the result of this work and rep