RE: [PATCH] test/crypto: fix authentication IV for zuc SGL

2022-06-24 Thread De Lara Guarch, Pablo
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Thursday, June 23, 2022 4:32 PM > To: Akhil Goyal ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara ; > sta...@dpdk.org > Subject: [PATCH] test/crypto: fix authentication IV for zuc SGL > >

RE: [PATCH 0/2] fix wireless algorithm IVs

2022-06-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: Power, Ciara > Sent: Thursday, June 23, 2022 4:43 PM > Cc: dev@dpdk.org; Ji, Kai ; Zhang, Roy Fan > ; De Lara Guarch, Pablo > ; ktejas...@marvell.com; > gak...@marvell.com; Power, Ciara > Subject: [PATCH 0/2] fix wireless algorithm IVs > > Some of the ZUC

dev@dpdk.org

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1029 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONF

[Bug 1023] [dpdk-22.07][meson test] perf-tests/ipsec_perf_autotest: Failed to test

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1023 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

dev@dpdk.org

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1032 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

RE: [PATCH] vhost: fix sync dequeue offload

2022-06-24 Thread Ling, WeiX
> -Original Message- > From: Ding, Xuan > Sent: Friday, June 24, 2022 1:38 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ling, WeiX > ; Ding, Xuan > Subject: [PATCH] vhost: fix sync dequeue offload > > From: Xuan Ding > > This patch fixes the missing

Re: [PATCH v4] lib/eal: fix segfaults due to thread exit order

2022-06-24 Thread David Marchand
On Fri, Jun 24, 2022 at 3:42 AM Zeng, ZhichaoX wrote: > > Hi David, Harman > Please review this patch at your convenience, it's been about a month > since the v1 version. > Thanks! Yes, it's been a month. Feel free to help on reviewing patches from others so that reviews can be quicker f

RE: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog guide

2022-06-24 Thread Xia, Chenbo
> -Original Message- > From: Lipiec, Herakliusz > Sent: Thursday, June 23, 2022 9:57 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > sta...@dpdk.org > Subject: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog > guide > > fix grammar

Re: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-24 Thread Bruce Richardson
On Thu, Jun 23, 2022 at 08:48:21PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Thursday, 23 June 2022 20.40 > > > > On Thu, 23 Jun 2022 20:34:07 +0200 > > Morten Brørup wrote: > > > > > > From: Bruce Richardson [mailto:bruce.richard...@in

Re: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-24 Thread Bruce Richardson
On Thu, Jun 23, 2022 at 08:34:07PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 23 June 2022 18.43 > > > > For string values returned from telemetry, escape any values that > > cannot > > normally appear in a json string. According

Re: [RFC PATCH 0/6] add json string escaping to telemetry

2022-06-24 Thread Bruce Richardson
On Thu, Jun 23, 2022 at 09:04:31PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 23 June 2022 18.43 > > > > This RFC shows one possible approach for escaping strings for the json > > output of telemetry library. For now this RFC supp

RE: [PATCH 3/3] dma/idxd: fix non-AVX builds with older compilers

2022-06-24 Thread Jiang, YuX
> -Original Message- > From: Bruce Richardson > Sent: Thursday, June 23, 2022 9:50 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH 3/3] dma/idxd: fix non-AVX builds with older compilers > > When building without AVX2 support using an older compiler e.g. gcc 4.8 on > Cento

[Bug 800] rte_malloc fails to allocate memory block, but succeeds allocating bigger block

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=800 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Bug 929] rte_dump_stack() is not safe to call from signal handler

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=929 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED Sta

[Bug 848] gcc12 build error, app/test

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=848 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Bug 861] gcc12 build error, common/cpt

2022-06-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=861 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED

Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-06-24 Thread Thomas Monjalon
24/06/2022 08:06, Ciara Loftus: > Linking with libbpf v0.8.0 causes deprication warnings. As a temporary > measure, prevent linking with libbpf versions v0.8.0 and greater. This > limitation should be removed in the future when appropriate > compatibility measures are introduced. > > Signed-off-by

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-24 Thread Emil Berg
> -Original Message- > From: Morten Brørup > Sent: den 23 juni 2022 09:01 > To: Emil Berg ; Bruce Richardson > > Cc: Stephen Hemminger ; > sta...@dpdk.org; bugzi...@dpdk.org; hof...@lysator.liu.se; > olivier.m...@6wind.com; dev@dpdk.org > Subject: RE: [PATCH] net: fix checksum with una

RE: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-06-24 Thread Loftus, Ciara
> > 24/06/2022 08:06, Ciara Loftus: > > Linking with libbpf v0.8.0 causes deprication warnings. As a temporary > > measure, prevent linking with libbpf versions v0.8.0 and greater. This > > limitation should be removed in the future when appropriate > > compatibility measures are introduced. > > >

Re: DPDK compile problem

2022-06-24 Thread David Marchand
On Fri, Jun 24, 2022 at 10:34 AM wrote: > > hello, >we are seeing DPDK compile issue when we execute ninja at the "build" > directory,there exists the following problem: > but I can not find rxp-compiler.h online.please help me ,thanks a lot! Cc: maintainer. This driver is not in the main r

[PATCH v3 1/5] usertools: add option to select hugetlbfs directory

2022-06-24 Thread Dmitry Kozlyuk
dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. It may be desirable to setup hugepage directory at another path, for example, when using hugepages of multiple sizes in different directories or when granting different permissions to mount points. Add --directory/-d option to the s

[PATCH v3 0/5] Improve documentation for running as non-root

2022-06-24 Thread Dmitry Kozlyuk
v3: Address comments by Bruce Richardson: - Remove the section for using UIO with older kernels. - Move the note about legacy virtio to virtio doc. - Advertise vfio-pci usage to avoid physical addresses (still unclear whether and when it requires IPC_LOCK). - Fix typo. v2: Ad

[PATCH v3 2/5] usertools: add option to change mount point owner

2022-06-24 Thread Dmitry Kozlyuk
Per mount(8), the previous owner and mode of the mount point become invisible as long as this filesystem remains mounted. Because dpdk-hugepages.py must be run as root, the new owner would be root. This is undesirable if the hugepage directory is being set up by the administrator for an unprivilege

[PATCH v3 3/5] doc: give specific instructions for running as non-root

2022-06-24 Thread Dmitry Kozlyuk
The guide to run DPDK applications as non-root in Linux did not provide specific instructions to configure the required access and did not explain why each bit is needed. The latter is important because running as non-root is one of the ways to tighten security and grant minimal permissions. Cc: s

[PATCH v3 4/5] doc: update instructions for running as non-root for MLX5

2022-06-24 Thread Dmitry Kozlyuk
Reference the common guide for generic setup. Remove excessive capabilities from the recommended list. Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- doc/guides/platform/mlx5.rst | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/doc/gui

[PATCH v3 5/5] doc: add note about running virtio-legacy as non-root

2022-06-24 Thread Dmitry Kozlyuk
The requirement of SYS_ADMIN capability in legacy virtio mode was missing. Add it to the driver-specific page. Signed-off-by: Dmitry Kozlyuk --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 7c0ae2b

RE: [PATCH v2 3/4] doc: give specific instructions for running as non-root

2022-06-24 Thread Dmitry Kozlyuk
> From: Bruce Richardson > Sent: Monday, June 20, 2022 11:38 AM > [...] > > > > +For ``virtio`` PMD in legacy mode, ``SYS_RAWIO`` capability is > > > required > > > > +for ``iopl()`` call to enable access to PCI IO ports. > > > > > > > > > > How "legacy" is legacy-mode? Is it still likely in wides

Re: [PATCH V5 0/7] app/testpmd: fix RSS and flow type

2022-06-24 Thread David Marchand
On Fri, Jun 24, 2022 at 10:55 AM lihuisong (C) wrote: > > Hi Ferruh, > > This patchset has been sent. However, a merge conflict is displayed on > the CI. > In fact, I'm do it based on the latest mainline, and there are nothing > conflict. > > Can you help me re-trigger the build? There may be dif

Re: [PATCH v3 1/5] usertools: add option to select hugetlbfs directory

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 11:48:13AM +0300, Dmitry Kozlyuk wrote: > dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. > It may be desirable to setup hugepage directory at another path, > for example, when using hugepages of multiple sizes in different > directories or when granting d

Re: [PATCH v3 2/5] usertools: add option to change mount point owner

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 11:48:14AM +0300, Dmitry Kozlyuk wrote: > Per mount(8), the previous owner and mode of the mount point > become invisible as long as this filesystem remains mounted. > Because dpdk-hugepages.py must be run as root, > the new owner would be root. > This is undesirable if the

Re: [PATCH v3 3/5] doc: give specific instructions for running as non-root

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 11:48:15AM +0300, Dmitry Kozlyuk wrote: > The guide to run DPDK applications as non-root in Linux > did not provide specific instructions to configure the required access > and did not explain why each bit is needed. > The latter is important because running as non-root > is

[PATCH] doc: announce name change of stop flush callback

2022-06-24 Thread pbhagavatula
From: Pavan Nikhilesh Stop flush callback is missing `rte_` prefix and might conflict with application declarations. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides

[PATCH] doc: announce change in event vector structure

2022-06-24 Thread pbhagavatula
From: Pavan Nikhilesh The field `*u64s` in the structure `rte_event_vector` will be replaced with `u64s`. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/

RE: [RFC PATCH 0/6] add json string escaping to telemetry

2022-06-24 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 24 June 2022 10.14 > > On Thu, Jun 23, 2022 at 09:04:31PM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 23 June 2022 18.43 > > > > > > This RFC shows on

Re: [RFC PATCH 0/6] add json string escaping to telemetry

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 11:12:05AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 24 June 2022 10.14 > > > > On Thu, Jun 23, 2022 at 09:04:31PM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.co

Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-06-24 Thread Thomas Monjalon
24/06/2022 10:37, Loftus, Ciara: > > > > 24/06/2022 08:06, Ciara Loftus: > > > Linking with libbpf v0.8.0 causes deprication warnings. As a temporary > > > measure, prevent linking with libbpf versions v0.8.0 and greater. This > > > limitation should be removed in the future when appropriate > > >

RE: [RFC PATCH 0/6] add json string escaping to telemetry

2022-06-24 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 24 June 2022 11.17 > > On Fri, Jun 24, 2022 at 11:12:05AM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Friday, 24 June 2022 10.14 > > > > > > On Thu, Jun 23, 202

[PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-06-24 Thread Ciara Loftus
libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach and bpf_xdp_detach which are available to use since libbpf v0.7.0. Also preven

Re: [PATCH V5 0/7] app/testpmd: fix RSS and flow type

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 10:54 AM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Hi David, 在 2022/6/24 16:59, David Marchand 写道: On Fri, Jun 24, 2022 at 10:5

Re: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 09:00:38AM +0100, Bruce Richardson wrote: > On Thu, Jun 23, 2022 at 08:48:21PM +0200, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Thursday, 23 June 2022 20.40 > > > > > > On Thu, 23 Jun 2022 20:34:07 +0200 > > > Morten

RE: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-24 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 24 June 2022 13.17 > > On Fri, Jun 24, 2022 at 09:00:38AM +0100, Bruce Richardson wrote: > > On Thu, Jun 23, 2022 at 08:48:21PM +0200, Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.or

[PATCH] doc: add list of environment variables used by cnxk

2022-06-24 Thread Nithin Dabilpuram
Add list of environment variables used by cnxk drivers. Signed-off-by: Nithin Dabilpuram --- doc/guides/platform/cnxk.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/platform/cnxk.rst b/doc/guides/platform/cnxk.rst index 423b3d7..97b2be5 100644 --- a/doc/guide

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-06-24 Thread Andrew Rybchenko
On 6/24/22 13:23, Ciara Loftus wrote: libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach and bpf_xdp_detach which are available

Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-06-24 Thread Andrew Rybchenko
On 6/24/22 13:10, Thomas Monjalon wrote: 24/06/2022 10:37, Loftus, Ciara: 24/06/2022 08:06, Ciara Loftus: Linking with libbpf v0.8.0 causes deprication warnings. As a temporary measure, prevent linking with libbpf versions v0.8.0 and greater. This limitation should be removed in the future whe

Re: [PATCH] rte_rib6: fix references to rte_rib

2022-06-24 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 22/06/2022 21:41, Stephen Hemminger wrote: The comments in rte_rib6 were cut-and-pasted from rte_rib and because of that some references to rte_rib_node were not updated. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.h | 6 +++--- 1 file changed, 3 i

Re: [PATCH] maintainers: update for hns3 pmd

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 7:52 AM, Yisen Zhuang wrote: On 2022/6/22 18:49, Dongdong Liu wrote: Lijun Ou and Min Hu current do not work for the hns3 pmd. I will do the work, so update the hns3 maintainers. Signed-off-by: Dongdong Liu Acked-by: Yisen Zhuang Applied to dpdk-next-net/main, thanks.

Re: [PATCH 1/2] net/hns3: fix fail to obtain VF LSC capability

2022-06-24 Thread Ferruh Yigit
On 6/11/2022 8:42 AM, Dongdong Liu wrote: From: Huisong Li Currently, the VF LSC capability is obtained from PF driver in the interrupt mailbox interrupt thread, it is asynchronous. The VF driver waits for 500ms to get this capability in probe process. The primary process will receive a messag

Re: [PATCH V3 2/2] net/hns3: support backplane media type

2022-06-24 Thread Ferruh Yigit
On 6/22/2022 11:59 AM, Dongdong Liu wrote: From: Chengwen Feng The 802.11 physical PMA sub-layer defines three media: copper, fiber and backplane. For PMD, the backplane is similar to the fiber, the main differences are that backplane doesn't have optical module. Because the interface of firmw

Re: [PATCH 0/2] remove unnecessary words in function documention

2022-06-24 Thread David Marchand
On Wed, Jun 22, 2022 at 10:27 PM Stephen Hemminger wrote: > > The phrase "This API is used to" is unnecessary and changes the > documentation into passive voice. > > Stephen Hemminger (2): > rawdev, dmadev: remove passive voice in function doc > eal: remove passive voice from interrupt functio

[RFC PATCH] cryptodev: add return parameter to callback process API

2022-06-24 Thread Srujana Challa
Adds a return parameter "uint16_t qp_id" to the functions rte_cryptodev_pmd_callback_process and rte_cryptodev_cb_fn. The new parameter is used to return queue pair ID to the application when it gets error interrupt, so that application can disable and enable the queue pair, to bring the queue back

[RFC PATCH] cryptodev: add return parameter to callback process API

2022-06-24 Thread Srujana Challa
Adds a return parameter "uint16_t qp_id" to the functions rte_cryptodev_pmd_callback_process and rte_cryptodev_cb_fn. The new parameter is used to return queue pair ID to the application when it gets error interrupt, so that application can disable and enable the queue pair, to bring the queue back

Re: [PATCH v4] lib: document existing free functions

2022-06-24 Thread David Marchand
On Wed, Jun 22, 2022 at 10:53 PM Stephen Hemminger wrote: > > Make sure all functions which use the convention that XXX_free(NULL) > is a nop are all documented. > > The wording is chosen to match the documentation of free(3). > "If ptr is NULL, no operation is performed." > > Signed-off-by: Steph

Re: [PATCH 0/6] some bugfixes for hns3

2022-06-24 Thread Andrew Rybchenko
On 6/24/22 11:59, Dongdong Liu wrote: The patchset include some bugfixes and clean code for hns3. The patchset depend on the below patchset to avoid confilict. [PATCH 0/2] net/hns3: support backplane media type https://lore.kernel.org/all/8689c6e8-935b-e2dc-3276-d2970a8bd...@xilinx.com/T/ Cheng

Re: [PATCH 0/3] more null pointer check removal

2022-06-24 Thread David Marchand
On Wed, Jun 22, 2022 at 8:52 PM Stephen Hemminger wrote: > > Reran the Cocci script to check for unnecessary null > pointer comparisons before free related functions. Applied with series https://patchwork.dpdk.org/project/dpdk/list/?series=21752&state=* -- David Marchand

Re: [PATCH v3 0/8] yet more unnecessary NULL checks

2022-06-24 Thread David Marchand
On Sun, Feb 20, 2022 at 7:22 PM Stephen Hemminger wrote: > > Thomas suggested there are some other functions that could > use the nullfree cleanup; this covers the rest of the story. > > Note: this does not change existing API/ABI, there are still > some outliers that don't use the convention but

Re: [PATCH v5 1/1] app/testpmd: support different input color method

2022-06-24 Thread Andrew Rybchenko
On 6/23/22 15:57, sk...@marvell.com wrote: From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update V

Re: [PATCH V5 1/7] app/testpmd: fix supported RSS offload display

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 8:23 AM, Huisong Li wrote: The rte_eth_dev_info.flow_type_rss_offloads is populated in terms of RTE_ETH_RSS_* bits. If PMD sets RTE_ETH_RSS_L3_SRC_ONLY to dev_info->flow_type_rss_offloads. testpmd will display "user defined 63" when run 'show port info 0'. Because testpmd use flowty

[PATCH v4 0/5] Improve documentation for running as non-root

2022-06-24 Thread Dmitry Kozlyuk
v4: Same, - Split dpdk-hugepages.py option --owner/-o into --user/-U and --group/-G. - Move vfio-pci note to the beginning of section. v3: Address comments by Bruce Richardson: - Remove the section for using UIO with older kernels. - Move the note about legacy virtio to virti

[PATCH v4 1/5] usertools: add option to select hugetlbfs directory

2022-06-24 Thread Dmitry Kozlyuk
dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. It may be desirable to setup hugepage directory at another path, for example, when using hugepages of multiple sizes in different directories or when granting different permissions to mount points. Add --directory/-d option to the s

[PATCH v4 2/5] usertools: add options to change mount point owner

2022-06-24 Thread Dmitry Kozlyuk
Per mount(8), the previous owner and mode of the mount point become invisible as long as this filesystem remains mounted. Because dpdk-hugepages.py must be run as root, the new owner would be root. This is undesirable if the hugepage directory is being set up by the administrator for an unprivilege

[PATCH v4 3/5] doc: give specific instructions for running as non-root

2022-06-24 Thread Dmitry Kozlyuk
The guide to run DPDK applications as non-root in Linux did not provide specific instructions to configure the required access and did not explain why each bit is needed. The latter is important because running as non-root is one of the ways to tighten security and grant minimal permissions. Cc: s

[PATCH v4 4/5] doc: update instructions for running as non-root for MLX5

2022-06-24 Thread Dmitry Kozlyuk
Reference the common guide for generic setup. Remove excessive capabilities from the recommended list. Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- doc/guides/platform/mlx5.rst | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/doc/gui

[PATCH v4 5/5] doc: add note about running virtio-legacy as non-root

2022-06-24 Thread Dmitry Kozlyuk
The requirement of SYS_ADMIN capability in legacy virtio mode was missing. Add it to the driver-specific page. Signed-off-by: Dmitry Kozlyuk --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 7c0ae2b

Re: [PATCH v4 2/5] usertools: add options to change mount point owner

2022-06-24 Thread Bruce Richardson
On Fri, Jun 24, 2022 at 04:19:53PM +0300, Dmitry Kozlyuk wrote: > Per mount(8), the previous owner and mode of the mount point > become invisible as long as this filesystem remains mounted. > Because dpdk-hugepages.py must be run as root, > the new owner would be root. > This is undesirable if the

[PATCH 1/1] doc: notice to add new ipsec event subtypes

2022-06-24 Thread Vamsi Attunuru
Based on discussion in below email thread, the new event subtypes can be added in 22.11 release with fixing any compatability issues mentioned in the mail thread. https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gak...@marvell.com/ Signed-off-by: Vamsi Attunuru --- doc/guides

[PATCH] doc: announce change to cryptodev cb function prototype

2022-06-24 Thread Srujana Challa
Function rte_cryptodev_cb_fn prototype will be extended to add new parameter qp_id, to return queue pair ID, which got error interrupt to the application, so that application can reset that particular queue pair. https://mails.dpdk.org/archives/dev/2022-June/245428.html Signed-off-by: Srujana Cha

Re: [PATCH V5 2/7] app/testpmd: unify the name of L2 payload offload

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 8:23 AM, Huisong Li wrote: Currently, the "port config all rss xx" command uses 'ether' name to match and to set 'RTE_ETH_RSS_L2_PAYLOAD' offload. However, others RSS command, such as, "port config rss-hash-key" and "show port rss-hash key", use 'l2-payload' to represent this offlo

Re: [PATCH V5 3/7] app/testpmd: refactor config all RSS command

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 8:23 AM, Huisong Li wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. The "port config rss-hash-key" and "show port rss-hash key" commands both use t

Re: [PATCH V5 6/7] app/testpmd: reorder elements in RSS type table array

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 8:24 AM, Huisong Li wrote: There are group and individual types in rss_type_table[]. However, group types are very scattered, and individual types are not arranged based on the bit number order in 'RTE_ETH_RSS_xxx'. For a clear distribution of types and better maintenance, this patch

Re: [PATCH V5 5/7] app/testpmd: compact RSS types output in some commands

2022-06-24 Thread Ferruh Yigit
On 6/24/2022 8:23 AM, Huisong Li wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Ferruh Yigit In port info command output, 'show port info all', supported

Re: [RFC PATCH 2/6] telemetry: fix escaping of invalid json characters

2022-06-24 Thread Stephen Hemminger
On Fri, 24 Jun 2022 13:29:46 +0200 Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 24 June 2022 13.17 > > > > On Fri, Jun 24, 2022 at 09:00:38AM +0100, Bruce Richardson wrote: > > > On Thu, Jun 23, 2022 at 08:48:21PM +0200, Morten Brørup wr

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-24 Thread Konstantin Ananyev
23/06/2022 03:35, Stephen Hemminger пишет: On Wed, 22 Jun 2022 23:49:39 +0100 Konstantin Ananyev wrote: @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct rte_ipv4_hdr *dst, const struct rte_ipv4_hdr *src, uint16_t header_len, uint16_t len, uint16_

RE: [PATCH] doc: announce change to cryptodev cb function prototype

2022-06-24 Thread Akhil Goyal
> Subject: [PATCH] doc: announce change to cryptodev cb function prototype > > Function rte_cryptodev_cb_fn prototype will be extended to > add new parameter qp_id, to return queue pair ID, which got > error interrupt to the application, so that application can > reset that particular queue pair.

RE: [PATCH 1/1] doc: notice to add new ipsec event subtypes

2022-06-24 Thread Akhil Goyal
> Subject: [PATCH 1/1] doc: notice to add new ipsec event subtypes Title should be doc: announce addition of new IPsec event subtypes > > Based on discussion in below email thread, the new event subtypes can be > added in 22.11 release with fixing any compatability issues mentioned in > the mail

[PATCH] common/mlx5: fix non-expandable global MR cache

2022-06-24 Thread Dmitry Kozlyuk
The number of memory regions (MR) that MLX5 PMD can use was limited by 512 per IB device, the size of the global MR cache that was fixed at compile time. The cache allows to search MR LKey by address efficiently, therefore it is the last place searched on data path (skipped is the global MR databas

Re: [PATCH 01/20] baseband/acc100: fix a memory leak in acc100 queue setup

2022-06-24 Thread David Marchand
On Tue, Feb 22, 2022 at 7:18 PM Weiguo Li wrote: > > We allocated memory for 'q', we don't free it when null check for 'd' fails > and it will lead to memory leak. > We can move null check for 'd' ahead of the memory allocation to fix it. > > Fixes: 060e76729302 ("baseband/acc100: add queue config

Re: [PATCH 03/20] crypto/dpaa2_sec: fix memory leaks in error handlings

2022-06-24 Thread David Marchand
On Tue, Feb 22, 2022 at 7:19 PM Weiguo Li wrote: > > When function returned from error handling branches, the memories were > not freed which caused a memory leak. > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") This is backport material. Please add Cc: sta...@dpdk.org in n

Re: [PATCH 04/20] crypto/qat: fix a memory leak when set encrypt key fail

2022-06-24 Thread David Marchand
On Tue, Feb 22, 2022 at 7:19 PM Weiguo Li wrote: > > We allocated memory for 'in', we don't free it when AES_set_encrypt_key() > fails and it will lead to memory leak. > We can move set_encrypt_key() ahead of the memory allocation to fix it. This move seems to fix the leak indeed. But this change

Re: [PATCH 00/20] fix memory leaks in error handling

2022-06-24 Thread David Marchand
On Tue, Feb 22, 2022 at 7:18 PM Weiguo Li wrote: > > This series fix some memory leaks in error handling. > > I write a coccinelle script to detect these issues, and > fix them after exclude a small number of false positives. > > FYI, the script is as follows: > // > // Find possible memory leaks

dpdk-devbind.py ./. bonding interfaces

2022-06-24 Thread qcqx-obaq . 6cba8489
To whom it may concern. usertools/dpdk-devbind.py currently does not recognize interfaces that are part of a bond as active. that can be a nuisance if you are using something like libmoon which proactively rebinds drivers for all "not active" interfaces. yes, i am aware of the dpdk contributio

[PATCH v1] baseband/acc100: remove file prefix for internal file

2022-06-24 Thread Nicolas Chautru
File renamed to avoid the rte_ file prefix since rte_acc100_pmd.h is actually internal only. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/acc100_pmd.h | 624 +++ drivers/baseband/acc100/rte_acc100_pmd.c | 2 +- drivers/baseband/acc100/rte_acc100_pm

[PATCH v1] baseband/turbo_sw: Remove flexran_sdk meson option

2022-06-24 Thread Nicolas Chautru
Hi Thomas, This is change you requested earlier this year. This is targeting 22.11. Basically we no longer pass a specific option but rely on pkgconfig. There is small change to generate the .pc files that Intel will make available by end of year. Still the related change in DPDK is available now.

[PATCH v1] baseband/turbo_sw: remove Flexran SDK meson option

2022-06-24 Thread Nicolas Chautru
The related dependency to build the PMD based on the SDK libraries is now enabled through pkfconfig. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/turbo_sw.rst| 6 -- drivers/baseband/turbo_sw/meson.build | 36 +-- meson_options.txt