Re: Review Request: Review request for HIVE-2225

> On 2011-06-22 23:18:43, John Sichi wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 259 > > > > > > Why is this using a Thread instead of a Timer? Agreed timer is better

Re: Review Request: Review request for HIVE-2225

> On 2011-06-22 23:12:49, John Sichi wrote: > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 222 > > > > > > Existing property names are "hive.metastore..." instead of just > > "metastore..." don

Re: Review Request: Review request for HIVE-2225

> On 2011-06-22 23:07:46, John Sichi wrote: > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 221 > > > > > > If you agree about making this disabled by default, we could use a > > special value su

Re: Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/ --- (Updated 2011-06-23 02:55:08.540561) Review request for hive, Carl Steinbach and

Re: Review Request: Review request for HIVE-2225

> On 2011-06-22 23:07:05, John Sichi wrote: > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerThread.java, > > line 1 > > > > > > New files need Apache headers Added. - Ashutosh -

Re: Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review891 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore

Re: Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review890 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review889 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review888 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventC

Review Request: Review request for HIVE-2225

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/ --- Review request for hive, Carl Steinbach and John Sichi. Summary --- This add