Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Abhishek Bafna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/ --- (Updated July 23, 2016, 5:01 a.m.) Review request for oozie. Bugs: OOZIE-2520

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Jaydeep Vishwakarma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/#review143257 --- Ship it! Ship It! - Jaydeep Vishwakarma On June 9, 2016, 6:0

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Jaydeep Vishwakarma
> On July 22, 2016, 10:36 a.m., Jaydeep Vishwakarma wrote: > > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 261 > > > > > > i think validation should come during parsing the filter > > Abhi

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Abhishek Bafna
> On July 22, 2016, 10:36 a.m., Jaydeep Vishwakarma wrote: > > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 261 > > > > > > i think validation should come during parsing the filter This val

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Abhishek Bafna
> On July 22, 2016, 10:35 a.m., Jaydeep Vishwakarma wrote: > > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 259 > > > > > > remove extra bracket Done. > On July 22, 2016, 10:35 a.m., Jayd

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Jaydeep Vishwakarma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/#review143213 --- core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java

Re: Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-07-22 Thread Jaydeep Vishwakarma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/#review143209 --- core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java

Review Request 48470: OOZIE-2520 SortBy filter for ordering the jobs query results

2016-06-08 Thread Abhishek Bafna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/ --- Review request for oozie. Bugs: OOZIE-2520 https://issues.apache.org/jira/b