123)
<https://reviews.apache.org/r/39806/#comment162817>
I think scala prefers to use the companion object as the factory to create
new instance (code before change). Is there any reason for this change?
- Xinyu Liu
On Oct. 30, 2015, 7:09 a.m., N
> On Oct. 30, 2015, 6:06 p.m., Xinyu Liu wrote:
> > samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala,
> > line 132
> > <https://reviews.apache.org/r/39806/diff/1/?file=1112956#file1112956line132>
> >
> > I think scala pre
ing
---
Thanks,
Xinyu Liu
+1 on my side. I also ran the gradle build and unit tests without failure.
Thanks,
Xinyu
On Wed, Dec 9, 2015 at 9:54 AM, Tao Feng wrote:
> +1 from my side(non-binding). I download the package and successfully run
> all the unit tests without failure.
>
> On Tue, Dec 8, 2015 at 3:38 PM, Yi Pan
org/r/41912/diff/
Testing
---
Unit tests added to cover all the new methods/classes.
Thanks,
Xinyu Liu
-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala (line 162)
<https://reviews.apache.org/r/43053/#comment178367>
nitpick: the var name of "msg1" seems not very well chosen. Shall we do
warn(msg + "...") instead?
- Xinyu Liu
On Feb. 1, 2016, 6:25
ception.java
(line 27)
<https://reviews.apache.org/r/43350/#comment181838>
is serialVersionUID needed here? If so please use the autogenerated one.
- Xinyu Liu
On Feb. 23, 2016, 9:43 p.m., Jake Maes wrote:
>
> ---
&g
Hi, David,
I didn't find a wiki page that contains the descriptions of all Samza
metrics. You can find the basic metrics by googling the following classes:
SamzaContainerMetrics, TaskInstanceMetrics, SystemConsumersMetrics and
SystemProducersMetrics. For your example, you can use the "process-call
ss null
> messages. So I don't trust the accuracy of that metric.
>
> Each metric emitted by Samza contains a header which includes job name,
> job
> id, container name and metric timestamp. You can use it to calculate
> messages per second values.
>
> If you are using K
This is awesome! Samza will be able to run standalone or on different kinds
of clusters, which can serve a wide range of applications. Glad to see this
is happening.
Thanks,
Xinyu
On Tue, Mar 1, 2016 at 8:48 AM, Jagadish Venkatraman wrote:
> Hi all,
>
> Currently, the only way to run distribute
/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
23f8a1a6bee8ef38e0640a4e90778e53d982deeb
Diff: https://reviews.apache.org/r/48182/diff/
Testing
---
Unit tests and local deployment.
Thanks,
Xinyu Liu
/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
Unit tests and local deployment.
Thanks,
Xinyu Liu
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48182/#review136075
-------
On June 3, 2016, 9:30 p.m., Xinyu Liu wrote:
>
> ---
.java
04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
g the producer
will get the error of closed producer, instead of NPE.
- Xinyu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48213/#review136097
----------
/scala/org/apache/samza/system/TestSystemConsumers.scala
09da62e0f9a10f7c3683345a309c6278ff01fb4b
Diff: https://reviews.apache.org/r/48243/diff/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
of volatile reads you need to make.
Right, a simple null check should do it. Thanks for the suggestion.
- Xinyu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48213/#review136338
---
On June
04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48213/#review136654
---
On June 8, 2016, 11:53 p.m., Xinyu Liu wrote:
>
> ---
Unit tests and local deployment.
Thanks,
Xinyu Liu
To reply, visit:
https://reviews.apache.org/r/48182/#review136335
-------
On June 9, 2016, 12:33 a.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail.
2/?file=1406146#file1406146line109>
> >
> > nit: unused variable?
Good catch! Removed it.
- Xinyu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48182/#
28e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala
09da62e0f9a10f7c3683345a309c6278ff01fb4b
Diff: https://reviews.apache.org/r/48243/diff/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
rc/main/scala/org/apache/samza/container/RunLoop.scala, lines
> > 73-77
> > <https://reviews.apache.org/r/48243/diff/1/?file=1406265#file1406265line73>
> >
> > Same comment as for the async run loop.
Fixed. As commented above.
- Xinyu
-
ystem/TestSystemConsumers.scala
09da62e0f9a10f7c3683345a309c6278ff01fb4b
Diff: https://reviews.apache.org/r/48243/diff/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48243/#review137543
-------
On June 15, 2016, 11:41 p.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
same comment on the last pass. I don't understand how this is
> supposed to work. Might be worth discussing this in person with Xinyu and
> then either fixing the code or the doc as appropriate.
Thanks both of you to catch this. I messed up the code during the task state
refactoring. Now the lo
/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
/samza/container/host/ProcfsBasedStatisticsMonitor.java
(line 177)
<https://reviews.apache.org/r/49877/#comment207134>
Do you think we should catch all the throwable here to prevent the thread
being killed?
- Xinyu Liu
On July 11, 2016, 6:57 a.m., Jagadish Venkatraman
-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala
09da62e0f9a10f7c3683345a309c6278ff01fb4b
Diff: https://reviews.apache.org/r/48243/diff/
Testing
---
unit tests and local testing.
Thanks,
Xinyu Liu
/samza/system/kafka/TestKafkaSystemProducer.scala
8e32bba6ced090f0fc8d4e5176fe0788df36981d
Diff: https://reviews.apache.org/r/48213/diff/
Testing
---
Unit tests and local testing.
Thanks,
Xinyu Liu
96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
---
Tested in yarn.
Thanks,
Xinyu Liu
/samza/container/RunLoop.scala (line 79)
<https://reviews.apache.org/r/50082/#comment208023>
Shall we move this line in the process() function?
- Xinyu Liu
On July 15, 2016, 7:59 p.m., Chris Pettitt wrote:
>
> ---
is thread safe since we might have multiple threads for a
task.
- Xinyu Liu
On July 18, 2016, 4:29 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/TestKeyValueStores.scala
fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
---
Tested in yarn.
Thanks,
Xinyu Liu
/
Testing
---
Tested in yarn.
Thanks,
Xinyu Liu
---
Tested in yarn.
Thanks,
Xinyu Liu
116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/jobs/configuration-table.html
54c52981c3055b398ee60af50eeaf2592ed0e64f
Diff: https://reviews.apache.org/r/50174/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
---
Tested in yarn.
Thanks,
Xinyu Liu
5d2641ab1e54d49f7b983bc526762cfb50f2911b
Diff: https://reviews.apache.org/r/50318/diff/
Testing
---
Tested by locally deployed jobs.
Passed gradle tests.
Thanks,
Xinyu Liu
/50318/diff/
Testing
---
Tested by locally deployed jobs.
Passed gradle tests.
Thanks,
Xinyu Liu
To reply, visit:
https://reviews.apache.org/r/50318/#review143446
-------
On July 25, 2016, 9:29 p.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail.
---
gradle build & tests
Thanks,
Xinyu Liu
-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala
ece0359d1a31e65113f4832dd3baddb788cecef4
Diff: https://reviews.apache.org/r/50451/diff/
Testing
---
gradle build & tests
Thanks,
Xinyu Liu
onfig/TestKafkaConfig.scala
c4a83f60cf049e6fd65f940b69674895d07ab871
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala
ece0359d1a31e65113f4832dd3baddb788cecef4
Diff: https://reviews.apache.org/r/50451/diff/
Testing
---
gradle build & tests
Thanks,
Xinyu Liu
-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala
ece0359d1a31e65113f4832dd3baddb788cecef4
Diff: https://reviews.apache.org/r/50451/diff/
Testing
---
gradle build & tests
Thanks,
Xinyu Liu
Yes, it is undergoing. We were blocked by the integration tests (
https://issues.apache.org/jira/browse/SAMZA-970) and other issues for a
while. Now we got a fix for the tests and I will submit a patch today. The
rest of release should be quick. I will sync with Navina with an ETA. Sorry
about the
/samza_job_yarn_deployer.py
38635ca5899c43fb61d6b4042e8543f0508fd41b
Diff: https://reviews.apache.org/r/50527/diff/
Testing
---
run integration tests and now they work fine.
Thanks,
Xinyu Liu
/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
.
True, my doc was overly simplified. I added more details. Please take a look.
- Xinyu
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50174/#review142985
---
On July 27, 2016, 11:05 p.m., X
9>
Please take a look at this again.
- Xinyu Liu
On July 27, 2016, 11:05 p.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
#x27;s better to have:
Logging.info((message, startupLog:boolean=false) => Any)
That way we can use info log for both startup and non startup logging, and
potentially adding it for debug and error in the future too.
- Xinyu Liu
On July 28, 2016, 8:
scala
75ba8af7cdda6b297abaa3dbb99c98b406e31f88
Diff: https://reviews.apache.org/r/50588/diff/
Testing
---
tested by unit tests and verifed also in hello-samza jobs.
Thanks,
Xinyu Liu
://reviews.apache.org/r/50590/diff/
Testing
---
Tested by running hello-world and check the output.
Thanks,
Xinyu Liu
/diff/
Testing
---
run integration tests and now they work fine.
Thanks,
Xinyu Liu
+1 (non-binding).
Thanks,
Xinyu
On Mon, Aug 1, 2016 at 11:41 AM, Jagadish Venkatraman <
jagadish1...@gmail.com> wrote:
> Thanks for driving this release.+1 approve (non-binding)
>
> Thanks,
> Jagadish
>
> On Mon, Aug 1, 2016 at 11:39 AM, Navina Ramesh
> > wrote:
>
> > Hey all,
> >
> > This is a
ations. Could you
please take a look? Thanks.
- Xinyu Liu
On Aug. 1, 2016, 9:07 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50670/#review144393
---
Ship it!
+1
- Xinyu Liu
On Aug. 1, 2016, 10:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/#review144417
---
Ship it!
+1. thanks for the quick fix!
- Xinyu Liu
On Aug
/diff/
Testing
---
Tested in local deployment and the system producer defined but not used was not
be inited.
Thanks,
Xinyu Liu
/SamzaContainer.scala
f786fc08c8f7eced4f4084dc8326b28b6422
Diff: https://reviews.apache.org/r/51252/diff/
Testing
---
Thanks,
Xinyu Liu
/apache/samza/container/SamzaContainer.scala
f786fc08c8f7eced4f4084dc8326b28b6422
Diff: https://reviews.apache.org/r/51252/diff/
Testing (updated)
---
gradlew clean build.
Thanks,
Xinyu Liu
Hi, All,
There have been quite a lot of new features added to master since 0.10
release to warrant a new major release. At LinkedIn, we've done functional
and performance testing against master in the past weeks, and deployed jobs
with the latest build in production. We will continue to test for s
syncRunLoop.java (line 605)
<https://reviews.apache.org/r/51346/#comment213289>
if(endOfStream) ...
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala (line
355)
<https://reviews.apache.org/r/51346/#comment213294>
No need for this logic since AsyncRunLoop won&#x
eam. Let's chat offline.
- Xinyu Liu
On Aug. 25, 2016, 11:52 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
ed since no invoke anymore, right?
- Xinyu Liu
On Aug. 29, 2016, 11:47 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
1 once
AsyncRunLoop is fully stablized.
- Xinyu Liu
On Aug. 30, 2016, 12:49 a.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
use AsyncStreamTask by default?
> > Esp. on jobs that don't need any async processing.
> > Why is the default value false?
> >
> > If users upgrade to the new version and automatically start using
> > multithreaded execution, will they see any performance impact?
The default of new AsyncRunLoop is still
/main/scala/org/apache/samza/container/SamzaContainer.scala
f786fc08c8f7eced4f4084dc8326b28b6422
Diff: https://reviews.apache.org/r/51252/diff/
Testing
---
gradlew clean build.
Thanks,
Xinyu Liu
It's very exciting that Samza is adding support of bounded input streams.
Nice write-up of different scenarios and options. Look forward to having
this feature work with the upcoming HDFS consumer!
Thanks,
Xinyu
On Tue, Aug 30, 2016 at 12:09 PM, Jagadish Venkatraman <
jagadish1...@gmail.com> wrot
r job.container.thread.pool.size, task.callback.timeout.ms and
> > task.max.concurrency
This config is pretty awkward (so is the name). It's just for fallback to old
runloop if there is any issue with the new AsyncRunLoop. So I don't expect
users to set it no
/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
1)
<https://reviews.apache.org/r/51346/#comment215659>
seems this is only needed for unit test. Please move the code to scala test.
- Xinyu Liu
On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an
/SystemConsumers.scala (line
207)
<https://reviews.apache.org/r/51346/#comment215701>
nit: no ";" at the end for scala
- Xinyu Liu
On Sept. 6, 2016, 4:02 p.m., Jagadish Venkatraman wrote:
>
> ---
> This is an automatic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51819/#review148585
---
Ship it!
Ship It!
- Xinyu Liu
On Sept. 12, 2016, 7:28 p.m
sting
---
Test the web pages locally.
Thanks,
Xinyu Liu
Good catch! Thanks!
- Xinyu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50174/#review148041
---
On Sept
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51934/#review149131
---
Ship it!
Thanks for the fix!
- Xinyu Liu
On Sept. 15, 2016
.html
54c52981c3055b398ee60af50eeaf2592ed0e64f
docs/learn/tutorials/versioned/index.md
b4d687a63638aca4f876af88556de9973acfd718
docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION
Diff: https://reviews.apache.org/r/50174/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50174/#review148826
-----------
On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote:
>
> ---
> This
sit:
https://reviews.apache.org/r/50174/#review148824
---
On Sept. 16, 2016, 5:33 p.m., Xinyu Liu wrote:
>
> ---
> This is an automatically generated e-mail. To re
b4d687a63638aca4f876af88556de9973acfd718
docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION
Diff: https://reviews.apache.org/r/50174/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
.java
a510bb0c5914c772438930d27f100b4d360c1296
Diff: https://reviews.apache.org/r/51962/diff/
Testing
---
Tested by yarn job.
Thanks,
Xinyu Liu
ck_ns are high at the same time.
Diffs
-
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java
a510bb0c5914c772438930d27f100b4d360c1296
Diff: https://reviews.apache.org/r/51962/diff/
Testing
---
Tested by yarn job.
Thanks,
Xinyu Liu
block_ns are high at the same time.
Diffs
-
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java
a510bb0c5914c772438930d27f100b4d360c1296
Diff: https://reviews.apache.org/r/51962/diff/
Testing
---
Tested by yarn job.
Thanks,
Xinyu Liu
/main/java/org/apache/samza/task/AsyncRunLoop.java
a510bb0c5914c772438930d27f100b4d360c1296
Diff: https://reviews.apache.org/r/51962/diff/
Testing
---
Tested by yarn job.
Thanks,
Xinyu Liu
.html
54c52981c3055b398ee60af50eeaf2592ed0e64f
docs/learn/tutorials/versioned/index.md
b4d687a63638aca4f876af88556de9973acfd718
docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION
Diff: https://reviews.apache.org/r/50174/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
() will always be invoked from a single
thread (for all tasks). The reason being asynchronous calls will not require
threads blocking on the calls. The callback can be invoked from multiple
threads. Samza controls when to invoke processAsync()/window()/commit() for
each task.
- Xinyu
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52133/#review149925
---
Ship it!
Ship It!
- Xinyu Liu
On Sept. 21, 2016, 8:36 p.m
ease, can we use 0.11.0 acrose all examples here?
docs/learn/documentation/versioned/operations/split-deployment.md (line 113)
<https://reviews.apache.org/r/52140/#comment217715>
I think we need to mention the framework libraries needed to be placed to
each node in the cluster.
-
docs/learn/tutorials/versioned/index.md
ca2b08fb02a83f72f804c4059f258253c046a1b6
docs/learn/tutorials/versioned/samza-async-user-guide.md PRE-CREATION
Diff: https://reviews.apache.org/r/50174/diff/
Testing
---
Test the web pages locally.
Thanks,
Xinyu Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52140/#review150101
---
Ship it!
Ship It!
- Xinyu Liu
On Sept. 22, 2016, 11:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52140/#review150500
---
Ship it!
Ship It!
- Xinyu Liu
On Sept. 27, 2016, 12:58 a.m
/learn/tutorials/versioned/remote-debugging-samza.md
ad1d04d835f10aeb6996d2ecbee1d0ae65eb98e9
Diff: https://reviews.apache.org/r/52400/diff/
Testing
---
Thanks,
Xinyu Liu
/KafkaCheckpointManager.scala
ea10cae82f2900c185c8c814f48dc02bbcb45621
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala
c360b6c74ff924311f350df2e49424351a5c8d07
Diff: https://reviews.apache.org/r/52401/diff/
Testing
---
./gradlew build
Thanks,
Xinyu Liu
---
./gradlew build
Thanks,
Xinyu Liu
ea10cae82f2900c185c8c814f48dc02bbcb45621
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TeskKafkaCheckpointLogKey.scala
c360b6c74ff924311f350df2e49424351a5c8d07
Diff: https://reviews.apache.org/r/52402/diff/
Testing
---
./gradlew build
Thanks,
Xinyu Liu
1 - 100 of 252 matches
Mail list logo
