GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/13
WW-4346 - Nested visitor validator returns wrong full field name
get correct full field name in visitor field validator
You can merge this pull request into a Git repository by running
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/14
WW-4355 - Remove HTML5 deprecated attributes from templates
Changed HTML5 deprecated attributes to CSS in templates.
You can merge this pull request into a Git repository by running:
$ git
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45139719
In most cases it doesn't really matter, but yes it isn't a perfect
solution. Do you think adding classes to elements and including a CSS file to
`simple
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-45186957
OK. Pushed that changes for future use. There are some places where align
is used directly because of `align` attribute in tags.
---
If your project is set up for it
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/22
WW-4387 - preselect multiple options not working in when key
is not a string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/14#issuecomment-53779898
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/24
WW-4399 - struts2-archetype-angularjs uses absolute paths
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts
feature
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/27
WW-4406 - TextTagTest fails under JDK7 with different default locales for
formatting and displaying
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/28
improved interceptor that accepts and maps JSON array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts feature/map-json
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/24#issuecomment-68294819
@lukaszlenart Looking at the source code changes from this PR are
implemented, but this request is not merged. How that happened? Anyway closing
it now.
---
If
Github user aleksandr-m closed the pull request at:
https://github.com/apache/struts/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/34
WW-4458 - Handle default (unnamed) package security check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts feature/WW-4458
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts-site/pull/2
WW-4502 - File listing for dtd-s
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts-site WW-4502
Alternatively you can
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/38
Feature/remove html5 deprecations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts
feature/remove-html5-deprecations
Github user aleksandr-m closed the pull request at:
https://github.com/apache/struts-site/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/41
WW-4499 - Removed readonly attribute from radio, checkbox and checkboxlist
tags.
Readonly attribute is ignored in radio and checkbox inputs.
You can merge this pull request into a Git
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/44
WW-4520 - Add prefix for CSS classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts feature/css-class-prefix
Hi,
Where exactly, besides CSS files, are you using S2 CSS classes that makes
it so hard to migrate to a new ones?
I agree with Lukasz that "struts-" isn't the best prefix and it should be
changed to something else. But not sure we need yet another theme. With
resolution of https://issues.apache.
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/45
WW-4523 - Add more log statements to RolesInterceptor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts
feature
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/45#issuecomment-120607949
You're right. In that case there is no need for check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/46
WW-4527 - Show property class in debug tag
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts feature/debug_tag_class
Github user aleksandr-m closed the pull request at:
https://github.com/apache/struts/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/49#issuecomment-139461467
Do we really need a list of tokens? Currently if you use different names
for tokens they all will be [stored into
session](https://github.com/apache/struts/blob
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/59#issuecomment-160195199
Tested with own app and it is running fine. Looking forward to see the same
approach with `StrutsTilesContainerFactory` in tiles3 plugin.
BTW what is
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171035814
Same thing here. Getting `NoSuchDefinitionException` exception in my app
when trying to use tiles result.
Note: there is still reference to tiles3-plugin in
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/73#issuecomment-171590254
:+1:
It works.
Thank you for your great work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/75
WW-4590 - Allow to use multiple names in result
Allow to use multiple values in `result` tag `name` attribute and in
`Result` annotation `name`.
So this typical configuration
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50079358
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50153311
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172947410
@swiftelan I was thinking about that too, BUT:
* It will break backward compatibility
* I kind of like that annotation attributes looks the same as in xml
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172982203
@swiftelan So you are proposing to change only type? The name of the
attribute will stay the same i.e `name`, right? There is still some chance that
something going
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50173826
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-173253337
Done. We should add notice in the release notes about breaking change in
`ResultInfo` / `@Result` for those who use `Result.name()` or extend
`ResultInfo`.
---
If
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-204510571
Resources still need to be loaded, NPE check is not enough.
BTW recently portlet-webapp test fails in my environment too (Oracle JDK).
---
If your project
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-205042373
This alone is not enough to solve
[WW-4622](https://issues.apache.org/jira/browse/WW-4622). The `ResourceFinder`
won't handle that case.
---
If your project i
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-205349984
And this will break working stuff also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205352470
Not working for 2.3.x and doubt it will work in 2.5. Take a look at
`ResourceFinder`.
Please try to write a unit tests along with code changes, and if it is
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205429031
In 2.3.28 `StrutsWildcardServletTilesApplicationContext` produces something
like that:
> org.apache.struts2.tiles.StrutsTilesListener - Starting Struts Ti
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219809968
Why not just add some CSS class to this table cell? Then end-users can
style it as they want and align parameter will not be needed.
---
If your project is set up
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219820070
Issue is about Velocity tags, not FreeMarker. Are we still supporting
Velocity tags?
---
If your project is set up for it, you can reply to this email and have your
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219823160
How the Velocity templating is working? The only Velocity templates I see
are in the
[archive](https://github.com/apache/struts/tree/master/core/src/main/resources
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219824169
Yep, the aforementioned commit misses css class for that cell in the
`controlheader.ftl`. It should be the same way as for the buttons. :)
---
If your project is
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219829978
@lukaszlenart Ahh ok. Thanks for clarifying that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220522532
@victorsosa I mean something like `` in
controlheader.ftl and `.tdInput {text-align:left;}` in styles.css. <-- This is
for 2.5.
And if alignment does
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220795005
@victorsosa You see, this commit already *broke* backward compatibility,
but it was incomplete in the way it didn't introduce css class for the input
cell.
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221056549
I would prefer to follow html5 and drop align attribute completely from S2
tags, BUT @victorsosa can you at least add some css class to input cell along
with your
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221326208
@victorsosa IMO it would be great. BUT if we really really want it to be
backward compatible then we can do both. Add a class for future **and** use
align attribute
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/97#issuecomment-221628543
First of all, there is [some
chance](https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/multipart
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221976394
Looks fine. Good job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/105#discussion_r68796281
--- Diff:
core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java
---
@@ -36,6 +36,7 @@
* this class will create
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/113
WW-4636 - File upload error message always in default language
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/113
Yep, we can close #97.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/97
@victorsosa, @lukaszlenart Please close this one. WW-4636 is fixed in
https://github.com/apache/struts/pull/113.
---
If your project is set up for it, you can reply to this email and have your
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/118
@yasserzamani *in case of when action are beans inside user's object
factory, we do not have any way except force user to change config and specify
real class*
Can you elaborat
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/118
Let's break it down:
**chain**
First of all using `chain` is discouraged. Proxying the action itself is
not the best practice too.
If the only viable solution to know t
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/124
Do we need custom annotation utility at all? Can't we just use existing
libraries e.g. Apache Commons
[MethodUtils](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/co
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
I'm still against adding `bean` attribute to action configuration. It is
not intuitive. Chain configuration options belong to `chain` interceptor, json
to `json` result, etc.
In fact
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
You're mixing two very different topics together, security and `chain`
configuration.
> But I think using attribute class for both class name and bean name is
not intui
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
> Not every.
Remember that issue that you've submitted to security list? All actions are
affected. With this proposal `bean` attribute must be added to every action
configuratio
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
Maybe I'm doing something wrong but in my app `method.getDeclaringClass()`
return proxied class as well. :(
We can use something
```
---
If your project is set up for it
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
Maybe I'm doing something wrong but in my app `method.getDeclaringClass()`
returns proxied class as well. :(
We can use something like below. Basically same thing that `AopUti
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/71
@DenizR https://issues.apache.org/jira/browse/WW/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109147
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109235
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109357
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109604
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114148402
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114148973
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/136#discussion_r114149826
--- Diff:
core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
@@ -210,4 +187,33 @@ private void addIfAbsent(List urls, URL fileUrl
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/138
Will this break apps with locales which are using different decimal
separator? E.g. in db `123.456` with locale which uses `,` as a decimal
separator.
---
If your project is set up for it, you
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/138
What about `Float` and `float`? I remember writing custom converter for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/135
@lukaszlenart I think it is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/125
Spoted same
`#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest']` expression
[here](https://stackoverflow.com/q/44291034/1700321). @yasserzamani What do you
use it for
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
What about performance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
But `isAccessible` is called quite often even for rather simple actions.
Also it would be nice to have some property which allows to access proxy
members.
---
If your project is set up
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart Sounds good. Still, it would be nice to allow to turn this
checking completely off even when spring plugin is presented. The issue then
can be avoided with addition of a simple
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart
> The simplest solution is to add a flag, a constant that by default should
turn off this check, but the Spring Plugin should have this flag set on to
enable additio
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/146
add constant to control proxy member access
See discussion in #142.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/153
WW-4827 Not fully initialized ObjectFactory tries to create beans
Inject `Container` in constructor of the `ObjectFactory`.
Can someone test `cdi`, `osgi` and `plexus` plugins
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
Nope, #155 doesn't seem have any effect.
Add following files to project, run under *nix, execute some action which
lead to the JSP, `localizedTextProvider` should not be `nul
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
Ubuntu, oracle jdk8.
If following code prints `setContainer` before other setters (especially
before `setInterceptorFactory`) it will work. On Ubuntu using oracle jdk8
`setContainer` is
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
It isn't about `XWorkConverter` per se. In #155 the injection of
`ConversionPropertiesProcessor` still happens and `TypeConverterCreator` is
injected next and `ObjectFactory#buildBean` is c
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
With the new code in #155 the custom type converter isn't initialized at
all. :(
Call trace of previous code in #155
```
---
If your project is set up for it, you can rep
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
Sure. No problem.
Test project -
https://github.com/aleksandr-m/struts2-objectfactory-container/
This commit adds custom date converter -
https://github.com/aleksandr-m/struts2
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
@yasserzamani Looks like a hack :) I would rather leave as it is, then to
introduce that. If container is needed then it **should** be injected in the
constructor. Take a look at spring object
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/163
WW-4843 DefaultUrlHelper().buildUrl() not outputting port when used as
parameter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr
86 matches
Mail list logo
