Re: Rethinking the crash experience

2014-07-10 Thread David Rajchenbach-Teller
If the user has checked the "Always report crashes" option or equivalent, or once the user has clicked "Report this crash", that sound like a good idea. On 10/07/14 02:18, Tobias B. Besemer wrote: > So maybe a other option for a resolution: > A msg to the user after the restart of FF that a crash-

Re: PSA: Refcounted classes should have a non-public destructor & should be MOZ_FINAL where possible

2014-07-10 Thread Neil
Daniel Holbert wrote: (a) Your class should have an explicitly-declared non-public destructor. (should be 'private' or 'protected') Except for refcounted base classes (which as you note need to have a protected virtual destructor), is there a correct style as to whether the destructor shou

Re: Intent to implement: Ability to surpress default contextmenu items

2014-07-10 Thread Jan Varga
Something like this is actually in the spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#context-menus " When the user clicks the disclosure triangle, such a user agent would expand the context menu in place, to show the browser's own commands" On 10/0

Re: fopen, gtest and try

2014-07-10 Thread Ted Mielczarek
On Thu, Jul 10, 2014, at 12:17 AM, Anthony Jones wrote: > I've recently been using gtest for media code. However I've come across > the issue of fopen() working locally but not on the try servers. > > https://tbpl.mozilla.org/?tree=Try&rev=11d9f94c54bd > > Any suggestions on how I should do this

Re: PSA: Refcounted classes should have a non-public destructor & should be MOZ_FINAL where possible

2014-07-10 Thread Daniel Holbert
On 07/10/2014 02:48 AM, Neil wrote: > Except for refcounted base classes (which as you note need to have a > protected virtual destructor), is there a correct style as to whether > the destructor should be private or protected and virtual or nonvirtual? IMO, the destructor should be nonvirtual, si

Re: PSA: Refcounted classes should have a non-public destructor & should be MOZ_FINAL where possible

2014-07-10 Thread Benjamin Smedberg
On 7/10/2014 10:46 AM, Daniel Holbert wrote: First, if your class is abstract, then it shouldn't have AddRef/Release implementations to begin with. Those belong on the concrete subclasses -- not on your abstract base class. What's correct code for abstract class Foo (implementing interfaces

Re: Misunderstood the "Assigned" at bugs! Sorry !!!

2014-07-10 Thread Ed Morley
On 09/07/2014 16:48:05, Gijs Kruitbosch wrote: As glob noted upthread, the NEW/ASSIGNED distinction is sometimes used by people when they are the assignee. There is only a lack of difference when the assignee is "nob...@mozilla.org". That doesn't warrant abolishing the status (although we could a

Re: PSA: Refcounted classes should have a non-public destructor & should be MOZ_FINAL where possible

2014-07-10 Thread Daniel Holbert
On 07/10/2014 08:03 AM, Benjamin Smedberg wrote: > On 7/10/2014 10:46 AM, Daniel Holbert wrote: >> Shouldn't the refcounting still be on the concrete classes? > Why? > > This happens for example with nsRunnable: nsRunnable does the > refcounting, and all the derivations of nsRunnable only have to

Re: How did mozbuild running XPCSHELL_TESTS_MANIFESTS

2014-07-10 Thread Yonggang Luo
2014-07-10 11:54 GMT+08:00 Nick Alexander : > On 2014-07-09, 8:21 PM, Yonggang Luo wrote: > >> In the moz.build files, there is specified XPCSHELL_TESTS_MANIFESTS, >> but I can not found where to processing this variable/files in mozbuild >> system. >> > > This one is a little tricky, because seve

Re: Intent to implement: Ability to surpress default contextmenu items

2014-07-10 Thread Ian Hickson
On Wed, 9 Jul 2014, Jonas Sicking wrote: > > > > This has been suggested many times, but the reason it's not part of > > the standard is that it's user-hostile. > > This argument always comes up, but I don't think this is an entirely > accurate statement. > > This is less user-hostile than the

Re: Improving Session Restore Experience (was Re: Reordering opened windows)

2014-07-10 Thread Tobias B. Besemer
This would be my suggestion (if possible): 1. Read sessionstore.js; 2. Open first window, don't reload tabs, restore size on the right screen if multi-screen; 3. For each window in sessionstore.js, in the order in which the windows have been opened initially, trigger window opening; 4. After a

Re: Intent to implement: Ability to surpress default contextmenu items

2014-07-10 Thread Cork
I would like to suggest chrome="hidden" instead of chrome="disabled". Disabled is normally related to grayed out widgets on the web () and not hidden elements (, display: none or visibility: collapse). And yes please leave some form of widget in the menu to let the user access the default menu ent

Re: Reordering opened windows

2014-07-10 Thread Tobias B. Besemer
The update of the taskbar preview (if this is possible) should normally happen after the tabs (the first, visible one) of a window are reloaded - not all previews at the end. IMHO the SessonStore should save a Time-Stamp to each window that gets updated each time the window gets focus. This Ti

Changes to B2G test symbols on TBPL

2014-07-10 Thread Ryan VanderMeulen
As we continue the transition from Travis to TBPL, it has been requested to use symbols for the different test suites that better-reflect the names Gaia devs are used to seeing. After discussions in bug 1013691 and on IRC with various stakeholders, the following changes are now live on TBPL: O

How does xpcshell unittest are runned

2014-07-10 Thread Yonggang Luo
I found following code in `runxpcshelltests.py`: def buildXpcsRunArgs(self): """ Add arguments to run the test or make it interactive. """ if self.interactive: self.xpcsRunArgs = [ '-e', 'print("To start the test, type |_execute_test();

Re: How does xpcshell unittest are runned

2014-07-10 Thread Gregory Szorc
On 7/10/14, 6:54 PM, Yonggang Luo wrote: I found following code in `runxpcshelltests.py`: def buildXpcsRunArgs(self): """ Add arguments to run the test or make it interactive. """ if self.interactive: self.xpcsRunArgs = [ '-e',

Re: How does xpcshell unittest are runned

2014-07-10 Thread Yonggang Luo
Thanks, I found the files, but when I running unittest, I have the error code 3 for all test cases. I'd like to know what's the possible reason to cause this. > On 7/10/14, 6:54 PM, Yonggang Luo wrote: > > > I found following code in `runxpcshelltests.py`: > > > > > > def buildXpcsRunArg

Re: Misunderstood the "Assigned" at bugs! Sorry !!!

2014-07-10 Thread Philip Chee
On 09/07/2014 23:48, Gijs Kruitbosch wrote: > As glob noted upthread, the NEW/ASSIGNED distinction is sometimes used > by people when they are the assignee. There is only a lack of difference > when the assignee is "nob...@mozilla.org". That doesn't warrant > abolishing the status (although we c