Re: [edk2-devel] [PATCH] BaseTools: VfrCompile/Pccts: Fix invalid bytes

2019-05-13 Thread Bob Feng
Hi Joe, Please submit a Bugzilla (https://bugzilla.tianocore.org/) and add the BZ link to the commit message. This patch looks good to me. Thanks, Bob -Original Message- From: Joe Richey [mailto:joeric...@google.com] Sent: Saturday, May 11, 2019 12:24 PM To: devel@edk2.groups.io Cc: F

[edk2-devel] [PATCH v2 1/4] ArmPkg/CompilerIntrinsicsLib: Remove unused sources and clean up .inf

2019-05-13 Thread Pete Batard
None of the .c/.h in Arm/ are used any more => remove them. Also merge the CC flags for MSFT ARM and ARM64, since these are the only archs we support for this package. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/Llvm_int_lib.h

[edk2-devel] [PATCH v2 0/4] ArmPkg/CompilerIntrinsicsLib: Update MSFT, GCC intrinsics

2019-05-13 Thread Pete Batard
This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg. The first patch removes sources that are no longer used and cleans up the .inf. The second patch adds memcmp and memmove for MSFT, as I ran into missing symbols for those while compiling a project with VS2017. Note that

[edk2-devel] [PATCH v2 4/4] ArmPkg/CompilerIntrinsicsLib: Add uread, uwrite GCC assembly sources

2019-05-13 Thread Pete Batard
The new sources are a copy of the RVCT version. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/uread.S | 54 ArmPkg/Library/CompilerIntrinsicsLib/Arm/uwrite.S | 53 ++

[edk2-devel] [PATCH v2 2/4] ArmPkg/CompilerIntrinsicsLib: Add memcmp, memmove intrinsics for MSFT

2019-05-13 Thread Pete Batard
We could have reused memmove.asm for ARM, but we would still need to add an implemention for ARM64, so we use the same source for both archs. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 2 ++ ArmPkg/Libra

[edk2-devel] [PATCH v2 3/4] ArmPkg/CompilerIntrinsicsLib: Add lasr ARM assembly source for GCC

2019-05-13 Thread Pete Batard
The new source is a port of the RVCT version. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pete Batard --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/lasr.S| 30 ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf | 1 + 2 files changed, 3

[edk2-devel] [PATCH] SecurityPkg/OpalPassword: Add PCD to skip password prompt in device unlocked status

2019-05-13 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1801 Add a PCD for skipping password prompt. Previous change only support if storage device is in locked device. This change is added to support the case that security status of the storage device is unlocked. Signed-off-by: Maggie Chu Cc: Eric Dong

Re: [edk2-devel] RFC for Edk2-Library

2019-05-13 Thread Laszlo Ersek
On 05/10/19 02:01, Kinney, Michael D wrote: > Laszlo, > > 1) We also use OpenSSL command line tool to locally sign >capsules and recovery images for local testing. So both >tool dependency and source dependency apply to the OpenSSL >content. I haven't used the tools yet that you ref

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Laszlo Ersek
On 05/10/19 21:45, Rodriguez, Christian wrote: > Hashing is not changing file format requirements as Basetools has no > requirement on this even though the spec does have file requirements. That's > why the initial patch was a workaround of sorts because it is allowed by > Basetools to have loca

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
Hi Christian, ModuleMakefile.GetFileDependency() gets the header file recursively for each source file under Inf [Sources] section. You can check if this function can resolve the problem. Thanks, Bob -Original Message- From: Rodriguez, Christian Sent: Saturday, May 11, 2019 3:45 AM T

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
I think checking if [Source] includes all the "source" file under module's folder for each module during build would make build slow down, we have been doing a lot to improve the build performance. Maybe we could create a new python script under BaseTools/Scripts folder to do this check. Thanks

Re: [edk2-devel] [Patch] [edk2-platforms] AdvancedFeaturePkg/Cmos: Add Cmos related libraries.

2019-05-13 Thread Liming Gao
Eric: Now, edk2-platform devel-MinPlatform branch has merged into edk2-platform master branch. For this change, I propose to add new GenericBoardPkg in Platform\Intel directory for the common board features. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:de

[edk2-devel] [PATCH v3 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

2019-05-13 Thread Xiaoyu lu
From: Xiaoyu Lu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL internally redefines the size of HMAC_CTX at crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). Ref: https://github.com/openssl/openssl/pull/4338 We should not use it directly and should remove relevant function

[edk2-devel] [PATCH v3 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-13 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When running process_files.py to configure OpenSSL, we can exclude some unnecessary files. This can reduce porting time, compiling time and library size. Upstream OpenSSL commit 71a5516dcc8a which was as part of OpenSSL_1_1_1b, Add the STOR

[edk2-devel] [PATCH v3 4/6] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

2019-05-13 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Disable warning for building OpenSSL_1_1_1b add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf Although this option is set in some build environm

[edk2-devel] [PATCH v3 1/6] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

2019-05-13 Thread Xiaoyu lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 OpenSSL configure mechanism use --with-rand-seed=xxx option to configure random number generation. OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762) we use default --with-rand-seed=os option to for building it. But OpenSSL_1_1_1b(50

[edk2-devel] [PATCH v3 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Update OpenSSL submodule to OpenSSL_1_1_1b OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) Run process_files.pl script to regenerate OpensslLib[Crypto].inf and opensslconf.h Remove -DNO_SYSLOG from OPENSSL_FL

[edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Xiaoyu lu
(1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93). So add --with-rand-seed=none to process_files.pl. (2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl When running process_files.py t

[edk2-devel] [PATCH v3 3/6] CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue

2019-05-13 Thread Xiaoyu lu
From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 This is for the upcoming upgrade to OpenSSL_1_1_1b Compiler optimization(Visual Studio) may automatically use _ftol2 instead of some type conversion. For example: OpensslLib.lib(drbg_lib.obj) : error LNK2001: unresol

[edk2-devel] [edk2-platforms][ 1/3] Update Platform/Intel/Readme.md to specify master instead of devel-MinPlatform branch

2019-05-13 Thread Liming Gao
Signed-off-by: Liming Gao --- Platform/Intel/Readme.md | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index fbf735173f..1da5d0ad29 100644 --- a/Platform/Intel/Readme.md +++ b/Platform/Intel/Readme.md @@ -8,7 +8,

[edk2-devel] [edk2-platforms][ 2/3] Merge Maintainers.txt in Platform\Intel and Silicon\Intel to root directory

2019-05-13 Thread Liming Gao
Signed-off-by: Liming Gao --- Maintainers.txt| 41 + Platform/Intel/Maintainers.txt | 60 -- Silicon/Intel/Maintainers.txt | 58 3 files changed, 41 insertions(+), 118 del

[edk2-devel] [edk2-platforms][0/3] Update Readme and Maintainers.txt

2019-05-13 Thread Liming Gao
After devel-MinPlatform branch is merged into master branch, Intel platforms information and maintainers are also added. Liming Gao (3): Update Platform/Intel/Readme.md to specify master instead of devel-MinPlatform branch Merge Maintainers.txt in Platform\Intel and Silicon\Intel to root

[edk2-devel] [edk2-platforms][ 3/3] Update Readme.md to list Intel MinPlatform systems

2019-05-13 Thread Liming Gao
Signed-off-by: Liming Gao --- Readme.md | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Readme.md b/Readme.md index 95c0c14522..0d1b6f3ed6 100644 --- a/Readme.md +++ b/Readme.md @@ -223,6 +223,17 @@ they will be documented with the platform. ## Socionext * [SynQuacer](Platform/

Re: [edk2-devel] [PATCH] SecurityPkg/AuthSeriableLib: Always delete variable in certdb

2019-05-13 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Gao, Zhichao Sent: Monday, May 13, 2019 10:55 AM To: devel@edk2.groups.io Cc: Zhang, Chao B ; Yao, Jiewen ; Wang, Jian J ; Zeng, Star ; Gao, Liming Subject: [PATCH] SecurityPkg/AuthSeriableLib: Always delete variable in certdb REF: ht

[edk2-devel] [edk2-platforms/devel-MinPlatform] Specify this branch is read only after it is migrated to master

2019-05-13 Thread Liming Gao
Signed-off-by: Liming Gao --- ReadMe.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ReadMe.md b/ReadMe.md index fbf735173f..f2dcee2e29 100644 --- a/ReadMe.md +++ b/ReadMe.md @@ -1,3 +1,5 @@ +# This branch has been migrated into master. Now, it is read only! + # **EDK II Minimum Platfor

[edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then base on PciHostBridge related PCDs to Initialize RootBridges. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc Chen Cc: Michael Kubacki Cc:

Re: [edk2-devel] RFC for Edk2-Library

2019-05-13 Thread Laszlo Ersek
On 05/10/19 04:48, Sean via Groups.Io wrote: > 1. Agree on the name but not sure whats better. i don't think it > should be edk2-tools because the idea of this is to be a library of > support code but not the tools themselves. This limits dependencies > and keeps the library free of business spec

[edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then base on PciHostBridge related PCDs to Initialize RootBridges. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc Chen Cc: Michael Kubacki Cc:

[edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then base on PciHostBridge related PCDs to Initialize RootBridges. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc Chen Cc: Michael Kubacki Cc:

Re: [edk2-devel] Reg: Need Help in enabling UEFI to existing KVM template

2019-05-13 Thread pavankumar_a
Gentle Reminder. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40512): https://edk2.groups.io/g/devel/message/40512 Mute This Topic: https://groups.io/mt/31577294/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.gr

[edk2-devel] 答复: [edk2] [PATCH] IntelSiliconPkg VTdDxe: a question about the source code

2019-05-13 Thread Jerry Zhou(BJ-RD)
Hi Star, I'am so interested in DMA protection in UEFI. It's a really good design! But I have a question about the implemention of DisableDmar() in IntelSiliconPkg\feature\vtd\intelvtddxe\VtdReg.c Is it a typing error in the code segment below? // // Disable VTd

[edk2-devel] subscribe edk2-devel

2019-05-13 Thread Jerry Zhou(BJ-RD)
subscribe edk2-devel ? ? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the cont

Re: [edk2-devel] [patch 1/5] MdePkg: Merge TianoCustomDecompress algorithm into

2019-05-13 Thread Liming Gao
Dandan: UefiTianoDecompress() API function header doesn't describe the parameter Version and the assert condition when Version is not 1 or 2. Please update the function comments in header file and C source file. With this change, Reviewed-by: Liming Gao Thanks Liming > -Original Messa

Re: [edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

2019-05-13 Thread Laszlo Ersek
On 05/10/19 10:51, Xiaoyu lu wrote: > Hi, Laszlo: > > Thank you for your time. > > I try the method you mentioned. > >> (1) Therefore, the right thing to do here is to add "no-store" to the above >> list, in my opinion. Can you try that, please? >> >> And, this change should be a standalone pat

Re: [edk2-devel] [PATCH v2 0/4] ArmPkg/CompilerIntrinsicsLib: Update MSFT, GCC intrinsics

2019-05-13 Thread Leif Lindholm
Hi Pete, On Mon, May 13, 2019 at 09:54:12AM +0100, Pete Batard wrote: > This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg. > > The first patch removes sources that are no longer used and cleans up the > .inf. > The second patch adds memcmp and memmove for MSFT, as I ra

Re: [edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Laszlo Ersek
On 05/10/19 12:26, Wang, Jian J wrote: > Hi Laszlo, > > rand_* is needed by openssl itself. BaseCryptLib also provide RandomSeed() > and RandomBytes() interface to wrap openssl rand functionality. We can't > just drop them. From platform independent perspective, using performance > counter is the

Re: [edk2-devel] [PATCH v2 0/4] ArmPkg/CompilerIntrinsicsLib: Update MSFT, GCC intrinsics

2019-05-13 Thread Pete Batard
Hi Leif, On 2019.05.13 16:56, Leif Lindholm wrote: Hi Pete, On Mon, May 13, 2019 at 09:54:12AM +0100, Pete Batard wrote: This patch series cleans up and updates the CompilerIntrinsicsLib for ArmPkg. The first patch removes sources that are no longer used and cleans up the .inf. The second pat

Re: [edk2-devel] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only support IN/OUT IO save state read (CVE-2018-12182)

2019-05-13 Thread Laszlo Ersek
On 05/10/19 07:16, Wang, Jian J wrote: > From: Star Zeng > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1136 > CVE: CVE-2018-12182 > > Customer met system hang-up during serial port loopback test in OS. > It is a corner case happened with one CPU core doing "out dx,al" and > another CPU

Re: [edk2-devel] RFC for Edk2-Library

2019-05-13 Thread Michael D Kinney
Laszlo, On Windows build systems, we have to install OpenSSL command line utilities. For all host systems, the OpenSSL command line utilities need to be in the system path. My point is that this is similar to other dependencies like iASL and NASM. For the patch discussion, I did not mean to co

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
Yes there could be a performance hit. It might be better to make it a script. But this is only going to happen when the hash feature is enabled, not ever build. Also we can minimize the performance hit by saving the data from ModuleMakefile.GetFileDependency() to memory and reuse it later in GenM

Re: [edk2-devel] [Patch] [edk2-platforms] AdvancedFeaturePkg/Cmos: Add Cmos related libraries.

2019-05-13 Thread Kubacki, Michael A
Agree, this is not a feature but code that may be reused to support multiple features. We do need a new location to hold such reusable code. Liming, would you like to send the RFC to request this new package? Thanks, Michael > -Original Message- > From: Gao, Liming > Sent: Monday, May

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
I think a warning would be reasonable. I only mention the spec because it requires all headers to be in the sources section of the inf, but it's not enforced strictly by BaseTools. Though the hashing feature relies on this requirement. It not a big deal, I just wanted to make sure false positiv

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] Specify this branch is read only after it is migrated to master

2019-05-13 Thread Kubacki, Michael A
Since the branch is already moved to edk2-platforms/master, I immediately made the update to redirect patch submissions to the master branch. This change is no longer needed. Thanks, Michael > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Lim

Re: [edk2-devel] Reg: Need Help in enabling UEFI to existing KVM template

2019-05-13 Thread Laszlo Ersek
Pavan, On 05/10/19 10:02, Pavan Kumar Aravapalli wrote: > Hi Team, > > > I am looking for pointers in enabling UEFI boot loader to the existing > (KVM)VM template. I am trying to enable it for CentOS 6.5(64-bit) no GUI > 64-bit (KVM) template. * I'm sorry, this really belongs on a CentOS mai

Re: [edk2-devel] [edk2-platforms][ 1/3] Update Platform/Intel/Readme.md to specify master instead of devel-MinPlatform branch

2019-05-13 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Monday, May 13, 2019 7:09 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms][ 1/3] Update > Platform/Intel/Readme.md to specif

Re: [edk2-devel] [edk2-platforms][ 2/3] Merge Maintainers.txt in Platform\Intel and Silicon\Intel to root directory

2019-05-13 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Monday, May 13, 2019 7:09 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms][ 2/3] Merge Maintainers.txt in > Platform\Intel a

Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Laszlo Ersek
On 05/13/19 15:25, Xiaoyu lu wrote: > (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL > OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93). > So add --with-rand-seed=none to process_files.pl. > > (2) CryptoPkg/OpensslLib: Exclude unnecessary files in proc

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
So the direction put forward by my team is that we should raise an error instead of a warning because a false positive successful build would be detrimental to a continuous integration environment. And it would also enforce the Spec requirements. The point they are making is that a warning does

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Laszlo Ersek
On 05/13/19 20:53, Christian Rodriguez wrote: > I think a warning would be reasonable. > > I only mention the spec because it requires all headers to be in the sources > section of the inf, That could be required by the edk2 INF spec, yes. It's totally irrelevant for the UEFI spec however. (Orig

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Christian Rodriguez
Oh sorry about that, I misspoke. I meant to say Edk2 INF spec. Thanks, Christian >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, May 13, 2019 1:20 PM >To: devel@edk2.groups.io; Rodriguez, Christian >; fel...@ami.com >Cc: Feng, Bob C ; Gao, Liming >; Zhu,

Re: [edk2-devel] RFC for Edk2-Library

2019-05-13 Thread Laszlo Ersek
On 05/13/19 20:20, Kinney, Michael D wrote: > Laszlo, > > On Windows build systems, we have to install OpenSSL command line > utilities. For all host systems, the OpenSSL command line > utilities need to be in the system path. My point is that this > is similar to other dependencies like iASL a

Re: [edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Kubacki, Michael A
Please update the copyright years. The other changes look fine. Thanks, Michael > -Original Message- > From: Chen, Marc W > Sent: Monday, May 13, 2019 2:47 AM > To: devel@edk2.groups.io > Cc: Chen, Marc W ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [PATCH] MinPlatformPkg:

Re: [edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Kubacki, Michael A
Actually run PatchCheck.py against the patch there's a few errors that need to be fixed. > -Original Message- > From: Kubacki, Michael A > Sent: Monday, May 13, 2019 2:22 PM > To: Chen, Marc W ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH] MinPlatformPkg: Add mu

Re: [edk2-devel] [Patch 2/2] edk2: Update Maintainers.txt for packages moved to edk2-platforms

2019-05-13 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: May 09, 2019 20:46 > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Steele, Kelly ; Ni, Ray ; Kubacki, > Michael A ; Leif Lindholm > ; Ard Biesheuvel > Subject: [Patch 2/2] edk2: Update Ma

[edk2-devel] [edk2-platforms][PATCH v1 11/16] Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 The below 3 Smbios drivers have dependency on IntelFramework[Module]Pkg: * MemorySubClassDxe * ProcessorSubClassDxe * SmbiosMiscDxe Their dependency is on the header file: IntelFrameworkPkg/Include/FrameworkDxe.h for definition 'STRING_REF'

[edk2-devel] [PATCH 2/2] Platform/BeagleBoard: Drop the consume of PcdShellFile

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 There is no module in the platform that will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will drop the consume of this PCD. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Hao A Wu ---

[edk2-devel] [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 After the drop of the consume of GenericBdsLib, there is no module that will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will drop the consume of this PCD. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinn

[edk2-devel] [edk2-platforms][PATCH v1 01/16] Platform/AMD: Use Lzma decompress lib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the LzmaDecompressLib in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no functional impact for this

[edk2-devel] [edk2-platforms][PATCH v1 05/16] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 Hisilicon platforms have already switched to the BDS driver in MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434. Thus, the consume of GenericBdsLib and PlatformBdsLib is no longer needed. Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2-devel] [edk2-platforms][PATCH v1 09/16] Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC.INC file to consume the ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 ReportStatusCodeLib are almost identical. Thus, th

[edk2-devel] [edk2-platforms][PATCH v1 03/16] Platform/BeagleBoard: Drop the consume of PcdShellFile

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 There is no module in the platform that will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will drop the consume of this PCD. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Hao A Wu ---

[edk2-devel] [edk2-platforms][PATCH v1 13/16] Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the LzmaDecompressLib in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no functional impact for this

[edk2-devel] [edk2-platforms][PATCH v1 15/16] Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the LzmaDecompressLib in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no functional impact for this

[edk2-devel] [edk2-platforms][PATCH v1 12/16] Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsLib

2019-05-13 Thread Wu, Hao A
Hisilicon platforms have already switched to the BDS driver in MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434. Thus, the Hisilicon PlatformBdsLib is no longer needed. This commit will remove this library instance implementation. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael

[edk2-devel] [edk2-platforms][PATCH v1 08/16] Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC.INC file to consume the LzmaDecompressLib in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no functional impact for

[edk2-devel] [edk2-platforms][PATCH v1 04/16] Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the LzmaDecompressLib in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 LzmaDecompressLib are identical. Thus, there is no functional impact for this

[edk2-devel] [edk2-platforms][PATCH v1 06/16] Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit adopts a similar approach to edk2 commit a6d594c5fabd8da2273d2794826ec086cf9c3c04. Currently, Hisilicon platforms use modules from under "IntelFrameworkModulePkg/Universal/StatusCode/", which produce EFI_PEI_PROGRESS_CODE_PPI and

[edk2-devel] [edk2-platforms][PATCH v1 00/16] Drop IntelFramework[Module]Pkg dependency

2019-05-13 Thread Wu, Hao A
This series will drop the IntelFramework[Module]Pkg dependency for platforms within the edk2-platforms repo. This is the 1st part series, which will handle platforms only with explicit dependency on the framework packages. The affected platforms include: * Platform/AMD/OverdriveBoard * Platform/Be

[edk2-devel] [edk2-platforms][PATCH v1 10/16] Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC.INC file to consume the DXE_RUNTIME_DRIVER DebugLib instance in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the 2 DebugLib are almost identical. Thus, there is no funct

[edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the ReportStatusCodeLib (DXE phase and Runtime instances) in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the DXE and Runtime ReportStatusCodeLib instanc

[edk2-devel] [edk2-platforms][PATCH v1 16/16] Platform/SoftIron: Use ReportStatusCodeLib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the ReportStatusCodeLib (DXE phase and Runtime instances) in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the DXE and Runtime ReportStatusCodeLib instanc

[edk2-devel] [edk2-platforms][PATCH v1 14/16] Platform/LeMaker: Use ReportStatusCodeLib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the ReportStatusCodeLib (DXE phase and Runtime instances) in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the DXE and Runtime ReportStatusCodeLib instanc

[edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 This commit will update the DSC file to consume the ReportStatusCodeLib (DXE phase and Runtime instances) in MdeModulePkg, instead of using the one in IntelFrameworkModulePkg. Please note that, the DXE and Runtime ReportStatusCodeLib instanc

Re: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg

2019-05-13 Thread Wu, Hao A
Please ignore this patch. It was sent by mistake. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Tuesday, May 14, 2019 10:08 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm

Re: [edk2-devel] [PATCH 2/2] Platform/BeagleBoard: Drop the consume of PcdShellFile

2019-05-13 Thread Wu, Hao A
Please ignore this patch. It was sent by mistake. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Tuesday, May 14, 2019 10:08 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm

Re: [edk2-devel] [edk2-platforms][PATCH v1 00/16] Drop IntelFramework[Module]Pkg dependency

2019-05-13 Thread Wu, Hao A
Sorry to mention, this series is also available at: https://github.com/hwu25/edk2-platforms/tree/drop_intelframework_part1_v1 Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Tuesday, May 14, 2019 10:08

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
I entered a new BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1804 to track the [Sources] section check function. Agree that "minimize the performance hit by saving the data from ModuleMakefile.GetFileDependency() to memory and reuse it later in GenMake to save on IO and search." Thanks, B

[edk2-devel] RFC for Edk2-ToolEnv

2019-05-13 Thread Sean via Groups.Io
RFC  Edk2-ToolEnv creation Create a new tianocore owned repository to host python code to support an extensible, pluggable, rich environment.  This environment has command line interfaces to support building a product, building CI, running tests, and downloading dependencies. This environment a

Re: [edk2-devel] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only support IN/OUT IO save state read (CVE-2018-12182)

2019-05-13 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, May 14, 2019 12:46 AM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Zeng, Star ; Dong, Eric ; Ni, > Ray > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg PiS

[edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1 2. Base on PciHostBridge related PCDs to Initialize RootBridges. Signed-off-by: Marc Chen Cc: Michael Kubacki Cc: Sai Chaganty --- Platform/Intel/MinPlatformPkg/MinPlat

Re: [edk2-devel] RFC for Edk2-ToolEnv

2019-05-13 Thread rebecca
On 2019-05-13 20:55, Sean via Groups.Io wrote: > > RFC  Edk2-ToolEnv creation > >   > > Create a new tianocore owned repository to host python code to support > an extensible, pluggable, rich environment.  This environment has > command line interfaces to support building a product, building CI, >

Re: [edk2-devel] [PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Liming Gao
This patch is for edk2-platform. Please add edk2-platform in the patch title, like [edk2-platforms][Patch]. When you generate the patch, you can use the command git format-patch -1 --subject-prefix="edk2-platform" Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:d

Re: [edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

2019-05-13 Thread Xiaoyu lu
Hi Laszlo: I'm sorry I missed this email, and also sorry for I didn't understand your points. I focus on what the current code has, so what to add. I should pay more attention to why I need to change it. Your approach is better. Better to make review easier. About 'stupid

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] Specify this branch is read only after it is migrated to master

2019-05-13 Thread Liming Gao
Michael: I know you are aware of this change. This patch is to let people know this branch is read only so that there is no more commit in devel-MinPlatform branch. Thanks Liming >-Original Message- >From: Kubacki, Michael A >Sent: Tuesday, May 14, 2019 3:00 AM >To: devel@edk2.groups.io

Re: [edk2-devel] [Patch] [edk2-platforms] AdvancedFeaturePkg/Cmos: Add Cmos related libraries.

2019-05-13 Thread Liming Gao
Sure. I will send RFC for new Package. >-Original Message- >From: Kubacki, Michael A >Sent: Tuesday, May 14, 2019 2:53 AM >To: Gao, Liming ; devel@edk2.groups.io; Dong, Eric > >Cc: Ni, Ray ; Desimone, Nathaniel L > >Subject: RE: [edk2-devel] [Patch] [edk2-platforms] >AdvancedFeaturePkg/Cm

Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

2019-05-13 Thread Gary Lin
On Mon, May 13, 2019 at 09:24:39PM +0200, Laszlo Ersek wrote: > On 05/13/19 15:25, Xiaoyu lu wrote: > > (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL > > OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93). > > So add --with-rand-seed=none to process_files

[edk2-devel] [edk2-platform] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1 2. Base on PciHostBridge related PCDs to Initialize RootBridges. Signed-off-by: Marc Chen Cc: Michael Kubacki Cc: Sai Chaganty --- Platform/Intel/MinPlatformPkg/MinPlat

[edk2-devel] [edk2-platform][PATCH] MinPlatformPkg: Add multiple segment support for PciHostBridgeLib

2019-05-13 Thread Marc W Chen
https://bugzilla.tianocore.org/show_bug.cgi?id=1799 1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1 2. Base on PciHostBridge related PCDs to Initialize RootBridges. Signed-off-by: Marc Chen Cc: Michael Kubacki Cc: Sai Chaganty --- Platform/Intel/MinPlatformPkg/MinPlat