Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
On Aug 31, 2006, at 5:40 PM, Klaus Hartl wrote: > This is an interesting read regarding user agent spoofing (see > point 9): > http://webstandardsgroup.org/features/david-storey.cfm > Interesting. Open the Web sounds kinda Grease Monkey-ish. Corey

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
On Aug 31, 2006, at 5:34 PM, John Resig wrote: >> It is fairly common to spoof or manipulate a browser's user agent >> string. > > Woah... that's news to me! Especially considering that Safari and > Opera combined have like 4% of the browser market. I looked at Opera 9 > and it's not immediately

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Klaus Hartl
This is an interesting read regarding user agent spoofing (see point 9): http://webstandardsgroup.org/features/david-storey.cfm -- Klaus John Resig schrieb: >> It is fairly common to spoof or manipulate a browser's user agent >> string. > > Woah... that's news to me! Especially considering tha

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread John Resig
> It is fairly common to spoof or manipulate a browser's user agent > string. Woah... that's news to me! Especially considering that Safari and Opera combined have like 4% of the browser market. I looked at Opera 9 and it's not immediately apparent how to switch user agents (in that, I was looking

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Dave Cardwell
Corey Jewett wrote: >> sa = /apple/.test(v), > Why do you prefer this over /webkit/ ? It is fairly common to spoof or manipulate a browser's user agent string. Sometimes it is a native feature of the browser (like Opera), sometimes plugins are used. While for example a Safari user may wan

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Aaron Heimlich
Why do you prefer this over /webkit/ ?>  op = !sa && window.opera != undefined,I think these articles from QuirksMode[1][2] should answer your question.[1]http://www.quirksmode.org/js/support.html[2]http://www.quirksmode.org/js/detect.html (look at the "userAgent and vendor" section in particu

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
On Aug 31, 2006, at 4:43 PM, Dave Cardwell wrote: > Corey Jewett wrote: >> I just now looked into doing so, but I think it will grow the core's >> file size too much. Nice plugin though. > > // As of jQuery 1.0.1[1] the relevant code is: > var b = navigator.userAgent.toLowerCase(); > jQuery.brows

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Dave Cardwell
Corey Jewett wrote: > I just now looked into doing so, but I think it will grow the core's > file size too much. Nice plugin though. // As of jQuery 1.0.1[1] the relevant code is: var b = navigator.userAgent.toLowerCase(); jQuery.browser = { safari: /webkit/.test(b), opera: /opera/.tes

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
Fixed in SVN; r256. Index: src/jquery/jquery.js === --- src/jquery/jquery.js(revision 255) +++ src/jquery/jquery.js(working copy) @@ -1653,7 +1653,7 @@ safari: /webkit/.test(b), opera:

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
I just now looked into doing so, but I think it will grow the core's file size too much. Nice plugin though. Corey On Aug 31, 2006, at 3:46 PM, Dave Cardwell wrote: > Corey Jewett wrote: >> Anybody else noticed that Safari is reported as Mozilla? > > jQBrowser[1] offers a more robust browser

Re: [jQuery] jQuery.browser and Safari

2006-08-31 Thread Dave Cardwell
Corey Jewett wrote: > Anybody else noticed that Safari is reported as Mozilla? jQBrowser[1] offers a more robust browser detection. For Safari it checks navigator.vendor for "Apple", which is generally a safer place to look. Perhaps some of the checks I've used could be incorporated back into

[jQuery] jQuery.browser and Safari

2006-08-31 Thread Corey Jewett
Anybody else noticed that Safari is reported as Mozilla? alert(jQuery.browser.safari + "\n" + jQuery.browser.mozilla) mozilla/5.0 (macintosh; u; intel mac os x; en) applewebkit/418.8 (khtml, like gecko) safari/419.3 true true Based on the code: var b = navigator.userAgent