Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-10 Thread Jani Nikula
On Wed, 10 Aug 2022, Andrzej Hajda wrote: > On 05.08.2022 17:59, Piorkowski, Piotr wrote: >> +/* PCI BARs */ >> +#define GTTMMADR_BAR0 >> +#define GEN2_GTTMMADR_BAR 1 >> +#define GFXMEM_BAR 2 >> +#define GTT_APERTURE_BAR

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-10 Thread Christian König
Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. The strict locking convention prevents deadlock situation for dma-buf importers and exporters. Previously the "unlocked" versions of the dma-buf API functions w

[PATCH 1/4] drm/probe-helper: Add drm_connector_helper_get_modes_static()

2022-08-10 Thread Thomas Zimmermann
Add drm_connector_helper_get_modes_static(), which duplicates a single display mode for a connector. Convert drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 20 +-- drivers/gpu/drm/drm_probe_helper.c | 40 ++ drivers/gpu/

[PATCH 3/4] drm/modes: Add initializer macro DRM_MODE_INIT()

2022-08-10 Thread Thomas Zimmermann
The macro DRM_MODE_INIT() initializes an instance of struct drm_display_mode with typical parameters. Convert simpledrm and also update the macro DRM_SIMPLE_MODE(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 23 - include/drm/drm_modes.h

[PATCH 4/4] drm/format-helper: Add drm_fb_build_fourcc_list() helper

2022-08-10 Thread Thomas Zimmermann
Add drm_fb_build_fourcc_list() function that builds a list of supported formats from native and emulated ones. Helpful for all drivers that do format conversion as part of their plane updates. Update current caller. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 94 ++

[PATCH 0/4] drm/probe-helper, modes: Helpers for single-mode displays

2022-08-10 Thread Thomas Zimmermann
This patchset moves code from simpledrm to probe and display-mode helpers. The new functions will be useful for the upcomming driver for PowerPC displays. [1] Where possible, existing drivers are being converted to use them. [1] https://patchwork.freedesktop.org/series/106538/ Thomas Zimmermann (

[PATCH 2/4] drm/probe-helper: Add drm_crtc_helper_mode_valid_static()

2022-08-10 Thread Thomas Zimmermann
Add drm_crtc_helper_mode_valid_static(), which validates a given mode against a display hardware's mode. Convert simpledrm and use it in a few other drivers with static modes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 18 ++ drivers/gpu/drm/d

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-10 Thread Dave Stevenson
Hi Florian On Tue, 9 Aug 2022 at 20:02, Florian Fainelli wrote: > > On 8/4/22 16:11, Florian Fainelli wrote: > > On 6/13/22 07:47, Maxime Ripard wrote: > >> From: Dave Stevenson > >> > >> The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain > >> attached to the HDMI block, handled

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-10 Thread Andrzej Hajda
On 05.08.2022 17:59, Piorkowski, Piotr wrote: From: Piotr Piórkowski At the moment, when we refer to some PCI BAR we use the number of this BAR in the code. The meaning of BARs between different platforms may be different. Therefore, in order to organize the code, let's start using defined name

[PULL] drm-misc-next-fixes

2022-08-10 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2022-08-10: Short summary of fixes pull: * gem: Annotate WW context in error paths * shmem-helper: Add missing vunmap in error paths The following changes since commit 6f2c8d5f16594a13295

Re: [PATCH v3 2/2] drm/i915: Sanitycheck PCI BARs

2022-08-10 Thread Jani Nikula
On Fri, 05 Aug 2022, "Piorkowski, Piotr" wrote: > From: Piotr Piórkowski > > For proper operation of i915 we need usable PCI GTTMMADDR BAR 0 > (1 for GEN2). In most cases we also need usable PCI GFXMEM BAR 2. > Let's add functions to check if BARs are set, and that it have > a size greater than 0

Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-10 Thread Christian König
Hi guys, Am 05.08.22 um 15:53 schrieb Olivier Masse: add Linaro secure heap bindings: linaro,secure-heap use genalloc to allocate/free buffer from buffer pool. buffer pool info is from dts. use sg_table instore the allocated memory info, the length of sg_table is 1. implement secure_heap_buf_ops

Re: [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()

2022-08-10 Thread Neil Armstrong
On 01/08/2022 14:54, Marek Vasut wrote: The drm_of_lvds_get_data_mapping() returns either negative value on error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure every time 'data-mapping' DT property is specified.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add DSC support to MST path

2022-08-10 Thread Lisovskiy, Stanislav
On Wed, Aug 10, 2022 at 11:25:13AM +0300, Govindapillai, Vinod wrote: > Hi Stan, > > Please find my comments inline > > > On Mon, 2022-04-11 at 19:25 +0300, Stanislav Lisovskiy wrote: > > Whenever we are not able to get enough timeslots > > for required PBN, let's try to allocate those > > using

Re: [Linaro-mm-sig] Re: [PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-10 Thread Christian König
Hi Jeffy, Am 10.08.22 um 06:16 schrieb Chen Jeffy: Hi Christian, On 8/9 星期二 18:18, Christian König wrote: Hi Jeffy, [SNIP] Maybe cache the latest returned handle in the obj(after drm_gem_prime_fd_to_handle), and clear it when that handle been deleted in drm_gem_handle_delete()? That won't

Re: [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-08-10 Thread Christian König
Am 10.08.22 um 10:33 schrieb Daniel Vetter: On Wed, 10 Aug 2022 at 08:52, Christian König wrote: Am 09.08.22 um 18:44 schrieb Daniel Vetter: On Tue, Jul 05, 2022 at 01:33:51PM +0200, Christian König wrote: Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: Use ww_acquire_fini() in the error code

Re: [PATCH] drm/bridge: anx7625: Support HDMI_I2S audio format

2022-08-10 Thread Hsin-Yi Wang
On Tue, Jul 26, 2022 at 5:16 PM Jiaxin Yu wrote: > > On Tue, 2022-07-26 at 11:30 +0800, Xin Ji wrote: > > 1. Support HDMI_I2S audio format. > > 2. Return 0 if there is no sink connection in .hw_param callback. > > > > Signed-off-by: Xin Ji > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c |

[PATCH v2 3/3] drm: rcar-du: Add DRM_MODE_BLEND_PIXEL_NONE support

2022-08-10 Thread Takanari Hayama
DRM_MODE_BLEND_PIXEL_NONE ignores an alpha channel. Rcar-du driver supports only 3 formats with an alpha channel (DRM_FORMAT_ARGB1555, DRM_FORMAT_ARGB and DRM_FORMAT_ARGB). We simply override the format passed to VSP1 for blending with the pixel format without alpha channel. Suggested-by:

[PATCH v2 1/3] media: vsp1: add premultiplied alpha support

2022-08-10 Thread Takanari Hayama
To support DRM blend mode in R-Car DU driver, we must be able to pass a plane with the premultiplied alpha. Adding a new property to vsp1_du_atomic_config allows the R-Car DU driver to pass the premultiplied alpha plane. Signed-off-by: Takanari Hayama --- drivers/media/platform/renesas/vsp1/vsp1

[PATCH v2 2/3] drm: rcar-du: Add DRM_MODE_BLEND_PREMULTI support

2022-08-10 Thread Takanari Hayama
R-Car DU driver implicitly supports DRM_MODE_BLEND_COVERAGE only. This adds a support for DRM_MODE_BLEND_PREMULTI. As a consequence, DRM_MODE_BLEND_PREMULTI becomes the default. If DRM_MODE_BLEND_COVERAGE is desired, it should be set explicitly. This behavior comes from how DRM blend mode is suppo

[PATCH v2 0/3] Add DRM pixel blend mode support to R-Car DU

2022-08-10 Thread Takanari Hayama
The series of patches adds support for DRM pixel blend mode to R-Car DU driver. The current R-Car DU implicitly supports "Coverage" only. Unfortunately, this changes the default blending mode of R-Car DU to "Pre-multiplied" which is the default when pixel blend mode is supported. v2: vsp1: - Ad

Re: [PATCH v8 1/2] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error

2022-08-10 Thread Daniel Vetter
On Wed, 10 Aug 2022 at 08:52, Christian König wrote: > > Am 09.08.22 um 18:44 schrieb Daniel Vetter: > > On Tue, Jul 05, 2022 at 01:33:51PM +0200, Christian König wrote: > >> Am 01.07.22 um 11:02 schrieb Dmitry Osipenko: > >>> Use ww_acquire_fini() in the error code paths. Otherwise lockdep > >>>

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add DSC support to MST path

2022-08-10 Thread Govindapillai, Vinod
Hi Stan, Please find my comments inline On Mon, 2022-04-11 at 19:25 +0300, Stanislav Lisovskiy wrote: > Whenever we are not able to get enough timeslots > for required PBN, let's try to allocate those > using DSC, just same way as we do for SST. > > v2: Removed intel_dp_mst_dsc_compute_config a

[PATCH 2/2] drm/i915: Add DSC support to MST path

2022-08-10 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-08-10 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Signed-off-by: Stanislav Lisovskiy --- include/drm/display/drm_dp.h

[PATCH 0/2] Add DP MST DSC support to i915

2022-08-10 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (2): drm: Add missing DP DSC extended capability definitions. drm/i915: Add DSC support to MST path drivers/gpu/drm/i915/display/intel_dp.c | 76 +- drivers/gpu/drm/i915/display/intel_dp.h | 17 +++ drivers/

[PATCH] drm: Use kzalloc for allocating only one element

2022-08-10 Thread Kenneth Lee
Use kzalloc(...) rather than kcalloc(1, ...) because the number of elements we are specifying in this case is 1, so kzalloc would accomplish the same thing and we can simplify. Signed-off-by: Kenneth Lee --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- drivers/gpu/drm/bridge/nwl-dsi.c

[PATCH] drm/ast: radeon amdgpu for ast add prime

2022-08-10 Thread oushixiong
This patch adds ast specific codes for DRM prime feature. Add the prime function to solve the xorg conflict problem when AST and AMD are in place at the same time, so that both can be displayed. Signed-off-by: oushixiong --- drivers/gpu/drm/ast/ast_drv.c| 22 drivers/gpu/dr

Re: [PATCH v2 00/14] drm/format-helper: Move to struct iosys_map

2022-08-10 Thread Thomas Zimmermann
Thanks everyone for reviewing and testing. Am 08.08.22 um 14:53 schrieb Thomas Zimmermann: Change format-conversion helpers to use struct iosys_map for source and destination buffers. Update all users. Also prepare interface for multi-plane color formats. The format-conversion helpers mostly us

Re: tiny drm driver for NOKIA-5110 LCD

2022-08-10 Thread Thomas Zimmermann
Hi Am 09.08.22 um 18:23 schrieb Andy Shevchenko: On Tue, Aug 9, 2022 at 6:14 PM Aliliche Larbi wrote: Good morning sir, I am developing a linux driver for the nokia 5110 lcd(monochrome), I would like to know if I can use the drm API or tiny drm for this lcd. I'm writing to you because I saw

<    1   2