Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Pekka Paalanen
On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: > We want programs besides the compositor to be able to enable or disable > panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary programs to be able to override the KMS clien

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-16 Thread Javier Martinez Canillas
Doug Anderson writes: Hello Doug, > Hi, > > On Thu, Feb 15, 2024 at 8:53 AM Neil Armstrong > wrote: >> >> Hi Doug, >> >> On 15/02/2024 16:08, Doug Anderson wrote: >> > Hi, >> > >> > On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: >> >> >> >> On Wed, 14 Feb 2024, Doug Anderson wrote: >> >>>

Re: [RFC 0/5] Introduce drm sharpening property

2024-02-16 Thread Pekka Paalanen
On Fri, 16 Feb 2024 04:28:41 + "Garg, Nemesa" wrote: > It is not intel specific and the goal is to have a generic API for > configuring Sharpness, accessible to various vendors. Intel currently > offers sharpness support through the Display Engine, while other > vendors seem to support Sharpn

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-16 Thread neil . armstrong
+ Bjorn + Konrad + Johan On 15/02/2024 18:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 8:53 AM Neil Armstrong wrote: Hi Doug, On 15/02/2024 16:08, Doug Anderson wrote: Hi, On Thu, Feb 15, 2024 at 2:24 AM Jani Nikula wrote: On Wed, 14 Feb 2024, Doug Anderson wrote: Hi, On Tue

Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-16 Thread Uwe Kleine-König
Hello Krzysztof, On Thu, Feb 15, 2024 at 07:44:53PM +0100, Krzysztof Kozlowski wrote: > On 15/02/2024 11:02, Uwe Kleine-König wrote: > > On Mon, Feb 12, 2024 at 11:23:02AM +0100, Krzysztof Kozlowski wrote: > >> On 08/02/2024 11:43, Lee Jones wrote: > >>> Applied, thanks! > >>> > >>> [3/3] dt-bindi

RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Biju Das
Hi Adam Ford, > -Original Message- > From: Adam Ford > Sent: Thursday, February 15, 2024 11:36 PM > Subject: Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > ARCH_K3 > > On Thu, Feb 15, 2024 at 11:22 AM Adam Ford wrote: > > > > On Thu, Feb 15, 2024 at 11:10 AM Adam Ford w

Re: [PATCH v5 0/4] Add common1 region for AM62, AM62A & AM65x

2024-02-16 Thread Tomi Valkeinen
On 16/02/2024 08:24, Devarsh Thakkar wrote: This adds DSS common1 region for respective SoCs supporting it. Changelog: V2 : Remove do-not-merge tag and add am62a dss common1 reion V3 : Add Fixes tag to each commit V4 : Add Reviewed-by tag and AM62A SoC TRM Link V5 : Split dts patch to separate p

Re: [PATCH v4 2/2] arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs

2024-02-16 Thread Vignesh Raghavendra
On 15/02/24 17:25, Devarsh Thakkar wrote: > This adds common1 register space for AM62x, AM62A and AM65x SoC's which are > using TI's Keystone display hardware and supporting it as described in > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > > Fixes: 3618811657b3 ("arm64: dts:

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-16 Thread Joao Paulo Goncalves
>The i.MX8M Plus has an HDMI controller, but it depends on two >other systems, the Parallel Video Interface (PVI) and the >HDMI PHY from Samsung. The LCDIF controller generates the display >and routes it to the PVI which converts passes the parallel video >to the HDMI bridge. The HDMI system has a

2024 X.Org Board of Directors Elections Nomination period is NOW

2024-02-16 Thread Christopher Michael
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2024 election are now open and will remain open until 23:59 UTC on 26 February 2024. The Board consists

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Jani Nikula
On Thu, 15 Feb 2024, Mario Limonciello wrote: > I feel the solution to these concerns is that we should make a knob that > controls whether the DRM property is created or the sysfs file is > created but not let them happen simultaneously. *insert the eyeballs emoji here* I mean no matter what

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-16 Thread Tomi Valkeinen
Hi, On 13/02/2024 13:39, Daniel Stone wrote: Hi, On Tue, 13 Feb 2024 at 10:18, Marius Vlad wrote: On Tue, Feb 13, 2024 at 11:57:59AM +0200, Tomi Valkeinen wrote: I haven't. I'm quite unfamiliar with Weston, and Randolph from TI (cc'd) has been working on the Weston side of things. I also don

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Alexander Stein
Hi all, Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > From: Lucas Stach > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > > --- > V3: C

Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Maxime Ripard
On Fri, Feb 16, 2024 at 08:47:46AM +, Biju Das wrote: > Hi Adam Ford, > > > -Original Message- > > From: Adam Ford > > Sent: Thursday, February 15, 2024 11:36 PM > > Subject: Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > > ARCH_K3 > > > > On Thu, Feb 15, 2024 at 11:2

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-02-16 Thread Tomi Valkeinen
On 15/02/2024 11:03, Alexander Stein wrote: Hi everyone, Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka: On 11.12.23 09:07, Aradhya Bhatia wrote: On 06/12/23 17:41, Tomi Valkeinen wrote: Hi, On 08/11/2023 14:45, Alexander Stein wrote: Hi Tomi, Am Mittwoch, 8. November 202

RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, February 16, 2024 9:05 AM > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > ARCH_K3 > > On Fri, Feb 16, 2024 at 08:47:46AM +, Biju Das wrote: > > Hi Adam Ford, > > > > > -Orig

RE: [PATCH 1/3] drm/radeon: Use RMW accessors for changing LNKCTL2

2024-02-16 Thread Ilpo Järvinen
On Thu, 15 Feb 2024, Deucher, Alexander wrote: > [Public] > > > -Original Message- > > From: Ilpo Järvinen > > Sent: Thursday, February 15, 2024 8:32 AM > > To: Deucher, Alexander ; amd- > > g...@lists.freedesktop.org; Daniel Vetter ; David Airlie > > ; Dennis Dalessandro > > ; dri- > >

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PULL] drm-intel-gt-next

2024-02-16 Thread Thomas Hellström
Hi, Dave On Fri, 2024-02-16 at 12:58 +1000, Dave Airlie wrote: > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > wrote: > > > > Hi Dave, Daniel, > > > > First pull request for 6.9 with probably one more coming in one to > > two > > weeks. > > > > Nothing to interesting in this one, mostly a spr

Re: [PULL] drm-intel-gt-next

2024-02-16 Thread Thomas Hellström
On Fri, 2024-02-16 at 10:31 +0100, Thomas Hellström wrote: > Hi, Dave > > On Fri, 2024-02-16 at 12:58 +1000, Dave Airlie wrote: > > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > First pull request for 6.9 with probably one more coming in one >

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Laurent Pinchart
On Fri, Feb 16, 2024 at 10:05:26AM +0100, Alexander Stein wrote: > Hi all, > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > From: Lucas Stach > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a little bit of SoC integration around it.

Re: [PATCH v2 1/1] drm/mediatek: Filter modes according to hardware capability

2024-02-16 Thread 胡俊光

Re: [PULL] drm-intel-gt-next

2024-02-16 Thread Joonas Lahtinen
(+ Jonathan) Quoting Dave Airlie (2024-02-16 04:58:03) > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > wrote: > > > > Hi Dave, Daniel, > > > > First pull request for 6.9 with probably one more coming in one to two > > weeks. > > > > Nothing to interesting in this one, mostly a sprinkle of small

Re: [PATCH 7/9] media: dt-bindings: Add Chameleon v3 framebuffer

2024-02-16 Thread Krzysztof Kozlowski
On 12/02/2024 16:51, Paweł Anikiel wrote: >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above comm

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-16 Thread Jani Nikula
On Thu, 15 Feb 2024, Abhinav Kumar wrote: > intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > Lets move this to drm_dp_helper to achieve this. > > changes in v2: > - rebased on top of drm-tip > > Acked-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar Acked-by: Jani

[PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Arunpravin Paneer Selvam
Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert Karwatzki Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/drm_buddy.c | 4 ++-- 1 file

Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-16 Thread Krzysztof Kozlowski
On 16/02/2024 09:43, Uwe Kleine-König wrote: >>> I applied the pwm patch now. If Lee wants to pick up this one via his >>> tree that would be fine for me, too. If that's the case please tell me, >>> then I'll drop it from my for-next branch again. Feel free to add >>> my Acked-by: Uwe Kleine-König

Re: [PATCH v5 0/4] Add common1 region for AM62, AM62A & AM65x

2024-02-16 Thread Aradhya Bhatia
On 16-Feb-24 11:54, Devarsh Thakkar wrote: > This adds DSS common1 region for respective SoCs supporting it. > > Changelog: > V2 : Remove do-not-merge tag and add am62a dss common1 reion > V3 : Add Fixes tag to each commit > V4 : Add Reviewed-by tag and AM62A SoC TRM Link > V5 : Split dts patch

[PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Luca Weiss
Introduce the bindings and panel driver for the LCD panel with the model number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It is used on the Fairphone 4 smartphone. Then we can add the panel to the device dts and also enable the GPU. Signed-off-by: Luca Weiss --- Changes in v

[PATCH v3 1/4] dt-bindings: display: panel: Add Himax HX83112A

2024-02-16 Thread Luca Weiss
Himax HX83112A is a display driver IC used to drive LCD DSI panels. Describe it and the DJN 9A-3R063-1102B using it. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112a.yaml | 74 ++ 1 file changed, 74 insertions(+) d

[PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Luca Weiss
Add support for the 2340x1080 LCD panel (DJN 9A-3R063-1102B) bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/

[PATCH v3 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-02-16 Thread Luca Weiss
Add the description for the display panel found on this phone. Unfortunately the LCDB module on PM6150L isn't yet supported upstream so we need to use a dummy regulator-fixed in the meantime. And with this done we can also enable the GPU and set the zap shader firmware path. Reviewed-by: Konrad D

[PATCH v3 3/4] arm64: dts: qcom: sm6350: Remove "disabled" state of GMU

2024-02-16 Thread Luca Weiss
The GMU won't probe without GPU being enabled, so we can remove the disabled status so we don't have to explicitly enable the GMU in all the devices that enable GPU. Reviewed-by: Konrad Dybcio Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 -- 1 file changed, 2 deletions

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-16 Thread Thierry Reding
On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, other software components may rely on the kernel to > keep Host1x operational even during suspend. As such, as a quirk, > skip asserting Host1x's reset on Tegra186. This all sounds a bit vague. Wh

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Christian König
Am 02.02.24 um 16:28 schrieb Hamza Mahfooz: We want programs besides the compositor to be able to enable or disable panel power saving features. Well I don't know the full background, but that is usually a no-go. However, since they are currently only configurable through DRM properties, that

Re: [PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Neil Armstrong
On 16/02/2024 11:10, Luca Weiss wrote: Add support for the 2340x1080 LCD panel (DJN 9A-3R063-1102B) bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile

Re: [PATCH][next] gpu: host1x: remove redundant assignment to variable space

2024-02-16 Thread Thierry Reding
On Thu Feb 15, 2024 at 11:43 PM CET, Colin Ian King wrote: > The variable space is being initialized with a value that is never read, > it is being re-assigned later on. The initialization is redundant and > can be removed. Also merge two declaration lines together. > > Cleans up clang scan build w

[PATCH v3 0/7] drm/msm: Add support for the A750 GPU found on the SM8650 platform

2024-02-16 Thread Neil Armstrong
Unlike the the very close A740 GPU on the SM8550 SoC, the A750 GPU doesn't have an HWCFG block but a separate register set. The missing registers are added in the a6xx.xml.h file that would require a subsequent sync and the non-existent hwcfg is handled in a6xx_set_hwcg(). The A750 GPU info are a

[PATCH v3 2/7] dt-bindings: arm-smmu: fix SM8[45]50 GPU SMMU if condition

2024-02-16 Thread Neil Armstrong
The if condition for the SM8[45]50 GPU SMMU is too large, add the other compatible strings to the condition to only allow the clocks for the GPU SMMU nodes. Fixes: 4fff78dc2490 ("dt-bindings: arm-smmu: Document SM8[45]50 GPU SMMU") Suggested-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong ---

[PATCH v3 1/7] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-16 Thread Neil Armstrong
Document the Adreno 750 GMU found on the SM8650 platform. Reviewed-by: Konrad Dybcio Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm

[PATCH v3 7/7] arm64: dts: qcom: sm8650-qrd: enable GPU

2024-02-16 Thread Neil Armstrong
Add path of the GPU firmware for the SM8650-QRD board Reviewed-by: Konrad Dybcio Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.d

[PATCH v3 4/7] drm/msm/a6xx: Add missing regs for A750

2024-02-16 Thread Neil Armstrong
Sync missing regs for A750 clock gating control related registers from Mesa a6xx.xml.h generated file. Those registers were added in the !27576 merge request [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27576 Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6

[PATCH v3 5/7] drm/msm: add support for A750 GPU

2024-02-16 Thread Neil Armstrong
Add support for the A750 GPU found on the SM8650 platform Unlike the the very close A740 GPU on the SM8550 SoC, the A750 GPU doesn't have an HWCFG block but a separate register set. The A750 GPU info are added under the adreno_is_a750() macro and the ADRENO_7XX_GEN3 family id. Reviewed-by: Konra

[PATCH v3 3/7] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-16 Thread Neil Armstrong
Document the GPU SMMU found on the SM8650 platform. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/

[PATCH v3 6/7] arm64: dts: qcom: sm8650: add GPU nodes

2024-02-16 Thread Neil Armstrong
Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 62e6ae93a9a8

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Matthew Auld
On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert Karwatzki Signed-off-by: Arunpravin Paneer Se

Re: (subset) [PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Neil Armstrong
Hi, On Fri, 16 Feb 2024 11:10:47 +0100, Luca Weiss wrote: > Introduce the bindings and panel driver for the LCD panel with the model > number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It > is used on the Fairphone 4 smartphone. > > Then we can add the panel to the device dts

Re: [PATCH 1/6] drm/tests/drm_buddy: fix 32b build

2024-02-16 Thread Arunpravin Paneer Selvam
Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: Doesn't seem to compile on 32b, presumably due to u64 mod/division. Simplest is to just switch over to u32 here. Also make print modifiers consistent with that. Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add all

Re: [PATCH 3/6] drm/buddy: check range allocation matches alignment

2024-02-16 Thread Arunpravin Paneer Selvam
Its good to check the alignment Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: Likely not a big deal for real users, but for consistency we should respect the min_page_size here. Main issue is that bias allocations turns into normal range allocation if the r

Re: [PATCH 4/6] drm/tests/drm_buddy: add alloc_range_bias test

2024-02-16 Thread Arunpravin Paneer Selvam
Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: Sanity check range bias with DRM_BUDDY_RANGE_ALLOCATION. Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Christian König --- drivers/gpu/drm/tests/drm_buddy_test.c | 218 +

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Adam Ford
On Fri, Feb 16, 2024 at 3:05 AM Alexander Stein wrote: > > Hi all, > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > From: Lucas Stach > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a little bit of SoC integration around it. > > > >

Re: [PATCH 2/6] drm/buddy: fix range bias

2024-02-16 Thread Arunpravin Paneer Selvam
Looks good. Reviewed-by: Arunpravin Paneer Selvam On 2/15/2024 11:14 PM, Matthew Auld wrote: There is a corner case here where start/end is after/before the block range we are currently checking. If so we need to be sure that splitting the block will eventually give use the block size we nee

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Alexander Stein
Am Freitag, 16. Februar 2024, 12:31:12 CET schrieb Adam Ford: > On Fri, Feb 16, 2024 at 3:05 AM Alexander Stein > > wrote: > > Hi all, > > > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > > From: Lucas Stach > > > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsy

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Arunpravin Paneer Selvam
On 2/16/2024 4:41 PM, Matthew Auld wrote: On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy: Fix alloc_range() error handling code") Reported-by: Bert

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-16 Thread Arunpravin Paneer Selvam
Hi Matthew, Could you review the v6? Thanks, Arun. On 2/8/2024 9:19 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each bloc

Re: [PATCH] drm/buddy: Modify duplicate list_splice_tail call

2024-02-16 Thread Christian König
Am 16.02.24 um 12:46 schrieb Arunpravin Paneer Selvam: On 2/16/2024 4:41 PM, Matthew Auld wrote: On 16/02/2024 10:00, Arunpravin Paneer Selvam wrote: Remove the duplicate list_splice_tail call when the total_allocated < size condition is true. Cc: # 6.7+ Fixes: 8746c6c9dfa3 ("drm/buddy:

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-16 Thread Matthew Auld
On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages siz

Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

2024-02-16 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next next-20240216] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4] [If your patch is applied

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/drm_bud

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-b

[PATCH] drm: xlnx: dp: Reset DisplayPort IP

2024-02-16 Thread Rohit Visavalia
Assert DisplayPort reset signal before deasserting, it is to clear out any registers programmed before booting kernel. Signed-off-by: Rohit Visavalia --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xl

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-16 Thread Christian König
Am 15.02.24 um 15:20 schrieb Alex Deucher: On Thu, Feb 15, 2024 at 9:18 AM Christian König wrote: Am 12.02.24 um 22:04 schrieb Alex Deucher: We had a request to add shared buffer stats to fdinfo for amdgpu and while implementing that, Christian mentioned that just looking at the GEM handle cou

[PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-02-16 Thread Katya Orlova
ltdc_load() calls functions drm_crtc_init_with_planes(), drm_universal_plane_init() and drm_encoder_init(). These functions should not be called with parameters allocated with devm_kzalloc() to avoid use-after-free issues [1]. Use allocations managed by the DRM framework. Found by Linux Verificat

Re: [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers

2024-02-16 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.8-rc4 next-20240216] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v5 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-16 Thread kernel test robot
/20240216/202402162038.hp7vzihx-...@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20240216/202402162038.hp7vzihx-...@intel.com/reproduce) If you fix the issue in a

[PATCH 0/4] TTM unlockable restartable LRU list iteration

2024-02-16 Thread Thomas Hellström
This patch-set is a prerequisite for a standalone TTM shrinker and for exhaustive TTM eviction using sleeping dma_resv locks, which is the motivation it. Currently when unlocking the TTM lru list lock, iteration needs to be restarted from the beginning, rather from the next LRU list node. This can

[PATCH 1/4] drm/ttm: Allow TTM LRU list nodes of different types

2024-02-16 Thread Thomas Hellström
To be able to handle list unlocking while traversing the LRU list, we want the iterators not only to point to the next position of the list traversal, but to insert themselves as list nodes at that point to work around the fact that the next node might otherwise disappear from the list while the it

[PATCH 2/4] drm/ttm: Use LRU hitches

2024-02-16 Thread Thomas Hellström
Have iterators insert themselves into the list they are iterating over using hitch list nodes. Since only the iterator owner can remove these list nodes from the list, it's safe to unlock the list and when continuing, use them as a starting point. Due to the way LRU bumping works in TTM, newly adde

[PATCH 3/4] drm/ttm: Consider hitch moves within bulk sublist moves

2024-02-16 Thread Thomas Hellström
To work around the problem with hitches moving when bulk move sublists are bumped, keep a second hitch when traversing a bulk move sublist, which is attached to the list *after* the bulk move sublist. If we detect a sublist bump, we use that second hitch as the continuation point of list traversal.

[PATCH 4/4] drm/ttm: Allow continued swapout after -ENOSPC falure

2024-02-16 Thread Thomas Hellström
The -ENOSPC failure from ttm_bo_swapout() meant that the lru_lock was dropped and simply restarting the iteration meant we'd likely hit the same error again on the same resource. Now that we can restart the iteration even if the lock was dropped, do that. Cc: Christian König Cc: Signed-off-by: T

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Matthew Auld
On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-of

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Hamza Mahfooz
On 2/16/24 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary progr

Re: [PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

2024-02-16 Thread Neil Armstrong
Hi, On Mon, 08 Jan 2024 16:25:14 +0100, Alexander Stein wrote: > The bridge type was set to default (Unknown). Set proper bridge type. > With this fixed, debugfs output imx8mp looks proper. > $ cat /sys/kernel/debug/dri/1/encoder-0/bridges > bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi] >

Re: [PATCH 6/6] drm/xe/stolen: ignore first page for FBC

2024-02-16 Thread Maarten Lankhorst
On 2024-02-15 18:44, Matthew Auld wrote: Seems like we can potentially hit underruns if the CFB offset is within the first page of stolen. Just like i915 skip the first page. BSpec: 50214 Reported-by: Matt Roper Signed-off-by: Matthew Auld --- drivers/gpu/drm/xe/compat-i915-headers/i915_g

Re: [PATCH 0/4] TTM unlockable restartable LRU list iteration

2024-02-16 Thread Christian König
Am 16.02.24 um 14:13 schrieb Thomas Hellström: This patch-set is a prerequisite for a standalone TTM shrinker and for exhaustive TTM eviction using sleeping dma_resv locks, which is the motivation it. Currently when unlocking the TTM lru list lock, iteration needs to be restarted from the beginn

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Hamza Mahfooz
On 2/16/24 03:19, Pekka Paalanen wrote: On Fri, 2 Feb 2024 10:28:35 -0500 Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. Could you also explain why, in the commit message, please? It is unexpected for arbitrary progr

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-16 Thread Daniel Stone
Hi, On Fri, 16 Feb 2024 at 09:00, Tomi Valkeinen wrote: > On 13/02/2024 13:39, Daniel Stone wrote: > > Specifically, you probably want commits 4cde507be6a1 and 58dde0e0c000. > > I think the window of breakage was small enough that - assuming either > > those commits or an upgrade to Weston 12/13

Re: [PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-16 Thread Christian König
Am 16.02.24 um 14:21 schrieb Matthew Auld: On 16/02/2024 12:33, Christian König wrote: Am 16.02.24 um 13:23 schrieb Matthew Auld: On 08/02/2024 15:50, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the re

[PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like power-profiles-daemon) 0-4: User via command line Also

Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-16 Thread Maxime Ripard
On Fri, Feb 16, 2024 at 09:13:14AM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, February 16, 2024 9:05 AM > > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > > ARCH_K3 > > > > On Fri, Feb 16, 202

Re: [PATCH 0/4] TTM unlockable restartable LRU list iteration

2024-02-16 Thread Thomas Hellström
On Fri, 2024-02-16 at 15:00 +0100, Christian König wrote: > Am 16.02.24 um 14:13 schrieb Thomas Hellström: > > This patch-set is a prerequisite for a standalone TTM shrinker > > and for exhaustive TTM eviction using sleeping dma_resv locks, > > which is the motivation it. > > > > Currently when un

[PATCH 0/6] Enable Adaptive Sync SDP Support for DP

2024-02-16 Thread Mitul Golani
An Adaptive Sync SDP allows a DP protocol converter to forward Adaptive Sync video with minimal buffering overhead within the converter. An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the display

[PATCH 1/6] drm/dp: Add an support to indicate if sink supports AS SDP

2024-02-16 Thread Mitul Golani
Add an API which indicates the sink support Adaptive Sync SDP, which can be used by the rest of the DP programming. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 27 inserti

[PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-16 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani] -

[PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-16 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - use as_sdp instead of async [Ankit] - Correct define placeholders to where it is being actually used. [Ja

[PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-16 Thread Mitul Golani
Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.(Ankit) Signed-off-by: Mitul Golani --- dri

[PATCH 4/6] drm/i915/display: Compute and Enable AS SDP

2024-02-16 Thread Mitul Golani
Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx().[Ankit]

[PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-16 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i91

[PATCH 0/6] Enable Adaptive Sync SDP Support for DP

2024-02-16 Thread Mitul Golani
An Adaptive Sync SDP allows a DP protocol converter to forward Adaptive Sync video with minimal buffering overhead within the converter. An Adaptive-Sync-capable DP protocol converter indicates its support by setting the related bit in the DPCD register. Computes AS SDP values based on the display

[PATCH 1/6] drm/dp: Add an support to indicate if sink supports AS SDP

2024-02-16 Thread Mitul Golani
Add an API which indicates the sink support Adaptive Sync SDP, which can be used by the rest of the DP programming. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 27 inserti

[PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-16 Thread Mitul Golani
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - use as_sdp instead of async [Ankit] - Correct define placeholders to where it is being actually used. [Ja

[PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-16 Thread Mitul Golani
Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] - Remove unrelated comments and changes. [Jani] -

[PATCH 4/6] drm/i915/display: Compute and Enable AS SDP

2024-02-16 Thread Mitul Golani
Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx().[Ankit]

[PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-16 Thread Mitul Golani
Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.(Ankit) Signed-off-by: Mitul Golani --- dri

[PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-16 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 .../gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i91

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-16 Thread Harry Wentland
On 2024-02-16 03:19, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 10:28:35 -0500 > Hamza Mahfooz wrote: > >> We want programs besides the compositor to be able to enable or disable >> panel power saving features. > > Could you also explain why, in the commit message, please? > > It is unexpect

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2: DRM -1: sysfs (IE via software like power-

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Mario Limonciello
On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module parameter behavior to control who control ABM: -2

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-16 Thread Christian König
Am 16.02.24 um 15:42 schrieb Mario Limonciello: On 2/16/2024 08:38, Christian König wrote: Am 16.02.24 um 15:07 schrieb Mario Limonciello: By exporting ABM to sysfs it's possible that DRM master and software controlling the sysfs file fight over the value programmed for ABM. Adjust the module

  1   2   3   >