Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:50 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote: On 5/27/2024 4:31 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Michael Niedermayer
On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote: > On 5/27/2024 4:31 PM, Michael Niedermayer wrote: > > On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: > > > On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: > > > > On 5/27/2024 3:11 PM, Michael

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Michael Niedermayer
On Mon, May 27, 2024 at 04:32:43PM -0300, James Almer wrote: > On 5/27/2024 4:20 PM, Michael Niedermayer wrote: > > On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: > > > On 5/27/2024 3:11 PM, Michael Niedermayer wrote: > > > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:31 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 4:20 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Michael Niedermayer
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote: > On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: > > On 5/27/2024 3:11 PM, Michael Niedermayer wrote: > > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Michael Niedermayer
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote: > On 5/27/2024 3:11 PM, Michael Niedermayer wrote: > > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-04-27 02:36:23) > > > > This allows detecting issues in side data related code,

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 3:11 PM, Michael Niedermayer wrote: On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself.

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Michael Niedermayer
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-04-27 02:36:23) > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > > > > Signed-off-by: Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread James Almer
On 5/27/2024 5:15 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2024-04-27 02:36:23) This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed-off-by: Michael Niedermayer --- I am against this patch.

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-05-27 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-04-27 02:36:23) > This allows detecting issues in side data related code, same as what > framecrc does for before already for packet data itself. > > Signed-off-by: Michael Niedermayer > --- I am against this patch. Checksumming side data is a fundamentally

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 9:40 PM, Michael Niedermayer wrote: On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: > On 4/30/2024 8:25 PM, Michael Niedermayer wrote: > > On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > > > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > This allows detecting issues in side data related code, same as what > > > >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread James Almer
On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > This allows detecting issues in side data related code, same as what > framecrc does for before already for packet data itself. > > Signed-off-by: Michael Niedermayer > --- > libavformat/framecrcenc.c | 76 +- > tests/ref/fate/autorotate