Re: [Freeipa-devel] [PATCH] Notify user when deleting nonexistent user or group

2009-07-31 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/30/2009 08:45 PM, Stephen Gallagher wrote: > I'm going to nack the user notification patch. I think we need to think > some more about this. The sysdb has an interface in place for returning > ENOENT when trying to delete, we're just setting it >

Re: [Freeipa-devel] [PATCH] Notify user when deleting nonexistent user or group

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/31/2009 06:02 AM, Jakub Hrozek wrote: > On 07/30/2009 08:45 PM, Stephen Gallagher wrote: >> I'm going to nack the user notification patch. I think we need to think >> some more about this. The sysdb has an interface in place for returning >> ENOE

Re: [Freeipa-devel] [PATCH] Correct check for local domain in tools

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/30/2009 12:50 PM, Jakub Hrozek wrote: > As Stephen noted in a recent post[1], the check for a local non-legacy > domain should be done with checking if provider == local, not by > comparing the domain name. The attached patch fixes this in the to

Re: [Freeipa-devel] [PATCH] Improve error messages

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/28/2009 10:21 AM, Stephen Gallagher wrote: > On 07/28/2009 08:58 AM, Jakub Hrozek wrote: >> Jenny found several cases where our error messages were not very >> descriptive. This patch adds a ERROR() call for those cases. > >> The error message f

Re: [Freeipa-devel] [PATCH] Notify user when deleting nonexistent user or group

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/31/2009 11:55 AM, Stephen Gallagher wrote: > On 07/31/2009 06:02 AM, Jakub Hrozek wrote: >> On 07/30/2009 08:45 PM, Stephen Gallagher wrote: >>> I'm going to nack the user notification patch. I think we need to think >>> some more about this. The

Re: [Freeipa-devel] [PATCH] Correct check for local domain in tools

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/31/2009 12:01 PM, Stephen Gallagher wrote: > On 07/30/2009 12:50 PM, Jakub Hrozek wrote: >> As Stephen noted in a recent post[1], the check for a local non-legacy >> domain should be done with checking if provider == local, not by >> comparing th

[Freeipa-devel] [PATCHES] All-around improvements to baseldap.py classes.

2009-07-31 Thread Pavel Zůna
0001: Enable attribute re-mapping and ordering when printing entries. Also print multiple values on one line separated by commas. --- 0002: Prevent double encoding/decoding when processing compound types. --

[Freeipa-devel] [PATCH] Rewrite pwpolicy plugin based on baseldap.py.

2009-07-31 Thread Pavel Zůna
Fix bugs: 510740, 510739, 510735, 510733, 510532 Pavel 0005-Rewrite-pwpolicy-plugin-based-on-baseldap.py.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Replace TYPE_ERROR by ValidationError

2009-07-31 Thread Pavel Zůna
No more tracebacks when an INT parameter is beyond the type limit. Fix bug: 5107333 There will probably be more patches similar to this one in the future. TYPE_ERROR is used in a several places where a better suited exception is available. Pavel 0006-Replace-TYPE_ERROR-by-ValidationError.

[Freeipa-devel] [PATCH] Fix typo bug in aci.py

2009-07-31 Thread Pavel Zůna
Pavel 0007-Fix-typo-bug-in-aci.py.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES] All-around improvements to baseldap.py classes.

2009-07-31 Thread Rob Crittenden
Pavel Zůna wrote: 0001: Enable attribute re-mapping and ordering when printing entries. Also print multiple values on one line separated by commas. Ok, though we'll have to see what that looks like on very large values. One thing I'm thinking is memberOf. In v1 when showing a user you'd also

Re: [Freeipa-devel] [PATCH] Rewrite pwpolicy plugin based on baseldap.py.

2009-07-31 Thread Rob Crittenden
Pavel Zůna wrote: Fix bugs: 510740, 510739, 510735, 510733, 510532 Pavel A couple of issues with the max values. I checked DS and I think the maxes should shadow it. krbpwdhistorylength: 24 krbpwdmindiffchars: 6 And I have some further questions for the team. Do we want to limit password

Re: [Freeipa-devel] [PATCH] Replace TYPE_ERROR by ValidationError

2009-07-31 Thread Rob Crittenden
Pavel Zůna wrote: No more tracebacks when an INT parameter is beyond the type limit. Fix bug: 5107333 There will probably be more patches similar to this one in the future. TYPE_ERROR is used in a several places where a better suited exception is available. ack smime.p7s Description:

Re: [Freeipa-devel] [PATCH] Fix typo bug in aci.py

2009-07-31 Thread Rob Crittenden
Pavel Zůna wrote: Pavel ack smime.p7s Description: S/MIME Cryptographic Signature ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-07-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/22/2009 06:10 PM, Dmitri Pal wrote: > Patch 1 (small) > > [PATCH] INI Simple fix to properly process multi value config parameters. > Also fixed a typo in the header file. > Ack > Patch 2 (big) > > [PATCH] ELAPI Next round of functionality -