Re: [google gcc-4_8] port gcov-tool to gcc-4_8

2014-01-17 Thread Xinliang David Li
Ok for google branch. It might be good to think about adding regression tests (similar to those gcov tests under g++.dg/gcov, but handling multiple files). David On Fri, Jan 17, 2014 at 12:59 PM, Rong Xu wrote: > last attachment is not the complete patch. Re-send again. > > On Fri, Jan 17, 2014

Re: [google gcc-4_8] port gcov-tool to gcc-4_8

2014-01-17 Thread Rong Xu
Do we have to split params.def? I can include params.h and link in params.o (a special version as we don't have some global vars). As for lipo_cutoff, I think we don't need a special handling -- we should use the default value of 100 and let logic in dyn-ipa.c takes care of the rest. Please find

Re: [google gcc-4_8] port gcov-tool to gcc-4_8

2014-01-17 Thread Xinliang David Li
For LIPO parameters, you can do this 1) isolate all LIPO specific parameters into lipo_params.def, and include it from params.def. 2) include lipo_params.def (after proper definition of DEFPARAM) in the profile tool source dir. By so doing, the compiler setting and profile tool will be in sync. (U