[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

2024-06-16 Thread neels
Attention is currently required from: fixeria, laforge, nt2mku. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported

[M] Change in libosmocore[master]: gsm48_ie: add helper function for speech bearer cap on GSM MS side

2024-06-16 Thread neels
Attention is currently required from: falconia, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36967?usp=email ) Change subject: gsm48_ie: add helper function for speech bearer cap on GSM MS side

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Test initial IMS REGISTER timeout

2024-06-16 Thread neels
Attention is currently required from: jolly, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email ) Change subject: asterisk: Test initial IMS REGISTER timeout

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement SIP UA unregister

2024-06-16 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email ) Change subject: asterisk: Implement SIP UA unregister .. Patch Set 1

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

2024-06-16 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure .. Patch Set 1

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Test auth resync procedure

2024-06-16 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email ) Change subject: asterisk: Test auth resync procedure .. Patch Set 1

[S] Change in osmo-remsim[master]: remsim_client: add support to set sim presence pin polarity

2024-06-16 Thread neels
Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email ) Change subject: remsim_client: add support to set sim presence pin polarity

[M] Change in simtrace2[master]: firmware: allow to change the sim presence pin polarity

2024-06-16 Thread neels
Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email ) Change subject: firmware: allow to change the sim presence pin polarity

[M] Change in docker-playground[master]: s1gw: add ttcn3-s1gw-test

2024-06-16 Thread neels
Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37230?usp=email ) Change subject: s1gw: add ttcn3-s1gw-test .. Patch

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-s1gw-test

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37235?usp=email ) Change subject: jobs/ttcn3: add ttcn3-s1gw-test .. Patch Set 1: Code-Review+1

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file

[S] Change in osmo-msc[master]: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme .. Patch Set 1

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

[S] Change in osmo-qcdiag[master]: Makefile: print files removed when running 'clean'

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37224?usp=email ) Change subject: Makefile: print files removed when running 'clean

[S] Change in osmo-qcdiag[master]: Makefile: fix CFLAGS != CPPFLAGS, allow overriding them

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37223?usp=email ) Change subject: Makefile: fix CFLAGS != CPPFLAGS, allow overriding them

[S] Change in osmo-qcdiag[master]: Makefile: add explicit rule for building *.o files

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37222?usp=email ) Change subject: Makefile: add explicit rule for building *.o files

[S] Change in osmo-qcdiag[master]: Makefile: gprs_l1.{c -> o} (must be an object)

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37221?usp=email ) Change subject: Makefile: gprs_l1.{c -> o} (must be an object) .. Pa

[S] Change in osmo-qcdiag[master]: Makefile: use $(shell ...) to invoke pkg-config

2024-06-16 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37220?usp=email ) Change subject: Makefile: use $(shell ...) to invoke pkg-config .. Patch

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

2024-06-16 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects .. Osmocom_CTRL: counters: return -1 for absent objects

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout

2024-06-16 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: hnbgw: TC_hnb_disconnected_timeout

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

2024-06-16 Thread neels
Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects

[M] Change in osmo-mgw[master]: mgcp_test.c: verify osmo-mgw accepts m=audio 0

2024-06-15 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email ) Change subject: mgcp_test.c: verify osmo-mgw accepts m=audio 0 .. mgcp_test.c: verify osmo-mgw accepts m=audio 0 When osmo-hnbgw does

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT

2024-06-14 Thread neels
Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset

[M] Change in osmo-ttcn3-hacks[master]: msc: test re-assignment to match codec with MT

2024-06-14 Thread neels
Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email ) Change subject: msc: test re-assignment to match codec with MT

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2024-06-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc .. Patch Set 7: (2 comments) Patchset: PS6

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2024-06-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc .. add static SS7 routing example to cs7-config.adoc I put

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2024-06-14 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email ) Change subject: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp .. Patch Set 4: Code-Review+2 -- To view, visit

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email ) Change subject: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp .. dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email ) Change subject: drop list of HNBAP UE Context .. drop list of HNBAP UE Context Last year, I have fixed some more ue_context leak

[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

2024-06-14 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request

[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

2024-06-14 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout

2024-06-14 Thread neels
/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibec009203d38f65714561b7c28edbdbd8b34e704 Gerrit-Change-Number: 37077 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout

2024-06-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email ) Change subject: hnbgw: TC_hnb_disconnected_timeout .. Patch Set 3: Code-Review+2 -- To view, visit https

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

2024-06-14 Thread neels
Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-14 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email ) Change subject: drop list of HNBAP UE Context .. Patch Set 5: (1

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-14 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email ) Change subject: drop list of HNBAP UE Context .. Patch Set 5: Code

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-14 Thread neels
, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ida7eadf36abcf465ae40003725c49e8e321a28c9 Gerrit-Change-Number: 32041 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email ) Change subject: drop list of HNBAP UE Context .. Patch Set 4: (1 comment) File include/osmocom/hnbgw/hnbgw.h: https

[M] Change in osmo-mgw[master]: mgcp-client: always send 'm=audio' line

2024-06-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36633?usp=email ) Change subject: mgcp-client: always send 'm=audio' line .. mgcp-client: always send 'm=audio' line Re-add the m=audio line to SDP

[M] Change in osmo-mgw[master]: mgcp-client: always send 'm=audio' line

2024-06-14 Thread neels
Change-Id: Id95b629453aec999100b5af821c6a0b9562bb597 Gerrit-Change-Number: 36633 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-

[M] Change in osmo-mgw[master]: mgcp-client: always send 'm=audio' line

2024-06-14 Thread neels
Attention is currently required from: fixeria, laforge, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36633?usp=email ) Change subject: mgcp-client: always send 'm=audio' line

[M] Change in osmo-mgw[master]: mgcp_test.c: verify osmo-mgw accepts m=audio 0

2024-06-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37233?usp=email ) Change subject: mgcp_test.c: verify osmo-mgw accepts m=audio 0 .. mgcp_test.c: verify osmo-mgw accepts m=audio 0 When osmo

[M] Change in osmo-mgw[master]: mgcp-client: always send 'm=audio' line

2024-06-14 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36633?usp=email ) Change subject: mgcp-client: always send 'm=audio' line .. Patch Set 3: (3

[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

2024-06-11 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

2024-06-11 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects

[S] Change in osmo-hnbgw[master]: nft-kpi: log errors of counter retrieval

2024-06-11 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37187?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: nft-kpi: log errors of counter retrieval

[M] Change in osmo-hnbgw[master]: nft-kpi: remove X34 drifting: adjust delay by elapsed time

2024-06-11 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37188?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: nft-kpi: remove X34 drifting: adjust delay by elapsed time

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-11 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email ) Change subject: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

[M] Change in osmo-hnbgw[master]: nft-kpi: remove X34 drifting: adjust delay by elapsed time

2024-06-11 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37188?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-11 Thread neels
Attention is currently required from: laforge, neels. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code

[S] Change in osmo-hnbgw[master]: nft-kpi: log errors of counter retrieval

2024-06-11 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37187?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

2024-06-10 Thread neels
Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email ) Change subject: add static SS7 routing example to cs7-config.adoc

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-10 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email ) Change subject: drop list of HNBAP UE Context .. Patch Set 4: (1

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-10 Thread neels
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email to look at the new patch set (#4). The following approvals got outdated and were

[M] Change in osmo-hnbgw[master]: drop list of HNBAP UE Context

2024-06-10 Thread neels
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[S] Change in osmo-bsc[master]: silence error message for N-STATE prim

2024-06-10 Thread neels
Attention is currently required from: laforge, osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email ) Change subject: silence error message for N-STATE prim .. Patch Set

[S] Change in osmo-bsc[master]: silence error message for N-STATE prim

2024-06-10 Thread neels
Attention is currently required from: neels, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-10 Thread neels
-Number: 37186 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

[M] Change in osmo-hnbgw[master]: nft-kpi: remove X34 drifting: adjust delay by elapsed time

2024-06-10 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37188?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout

2024-06-10 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email to look at the new patch set (#3). Change subject: hnbgw: TC_hnb_disconnected_timeout

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

2024-06-10 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects .. Osmocom_CTRL: counters: return -1

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions

2024-06-10 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1

[S] Change in osmo-hnbgw[master]: change back dispatch ordering in map_rua_init_action()

2024-06-10 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36888?usp=email ) Change subject: change back dispatch ordering in map_rua_init_action() .. Abandoned this other patch avoids all described use

[S] Change in osmo-hnbgw[master]: improve HNBAP error logging

2024-06-10 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email ) Change subject: improve HNBAP error logging .. improve HNBAP error logging We have a situation where HNBAP is not answered by osmo

[S] Change in osmo-hnbgw[master]: improve HNBAP error logging

2024-06-10 Thread neels
Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email ) Change subject: improve HNBAP error logging .. Patch Set 3: (1 comment

[S] Change in osmo-hnbgw[master]: improve HNBAP error logging

2024-06-10 Thread neels
Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email ) Change subject: improve HNBAP error logging .. Patch Set 3: Code-Review+2

[M] Change in osmo-hnbgw[master]: nft-kpi: remove X34 drifting: adjust delay by elapsed time

2024-06-10 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37188?usp=email ) Change subject: nft-kpi: remove X34 drifting: adjust delay by elapsed time .. nft-kpi: remove X34 drifting: adjust delay

[S] Change in osmo-hnbgw[master]: nft-kpi: log errors of counter retrieval

2024-06-10 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37187?usp=email ) Change subject: nft-kpi: log errors of counter retrieval .. nft-kpi: log errors of counter retrieval Make sure errors

[S] Change in osmo-hnbgw[master]: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp

2024-06-10 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email ) Change subject: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp .. dbg log: nft kpi: clarify nr of rate ctrs vs

[S] Change in osmo-hnbgw[master]: prevent use-after-free after FSM instance termination

2024-06-10 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37147?usp=email ) Change subject: prevent use-after-free after FSM instance termination .. prevent use-after-free after FSM instance termination

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) Change subject: hnb_persistent: introduce disconnected timeout .. hnb_persistent: introduce disconnected timeout Add timer hnbgw

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

2024-06-09 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) Change subject: hnb_persistent: introduce disconnected timeout .. Patch Set 3: -Code-Review (2 comments) Patchset: PS3

[S] Change in osmo-hnbgw[master]: prevent use-after-free after FSM instance termination

2024-06-09 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37147?usp=email ) Change subject: prevent use-after-free after FSM instance termination .. prevent use-after-free after FSM instance

[S] Change in osmo-hnbgw[master]: add LOG_HNBP() for hnb_persistent

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37075?usp=email ) Change subject: add LOG_HNBP() for hnb_persistent .. add LOG_HNBP() for hnb_persistent Add macro for the pattern LOGP(DHNB

[L] Change in osmo-hnbgw[master]: add umts_cell_id_test.c

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email ) Change subject: add umts_cell_id_test.c .. add umts_cell_id_test.c Prepare for adding proper mnc_3_digits support to struct

[S] Change in osmo-hnbgw[master]: umts_cell_id: add umts_cell_id_to_str_buf()

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36891?usp=email ) Change subject: umts_cell_id: add umts_cell_id_to_str_buf() .. umts_cell_id: add umts_cell_id_to_str_buf() Prepare

[M] Change in osmo-hnbgw[master]: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email ) Change subject: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id .. 3-digit MNC: use osmo_plmn_id in struct umts_cell_id

[S] Change in osmo-hnbgw[master]: use osmo_jhash for the hnb_persistent hashtable

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36912?usp=email ) Change subject: use osmo_jhash for the hnb_persistent hashtable .. use osmo_jhash for the hnb_persistent hashtable Use hashing like

[S] Change in osmo-hnbgw[master]: rename to umts_cell_id_to_str()

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36890?usp=email ) Change subject: rename to umts_cell_id_to_str() .. rename to umts_cell_id_to_str() A subsequent patch adds umts_cell_id_to_str_buf

[S] Change in osmo-hnbgw[master]: fix stat_item leak in hnb_persistent_free()

2024-06-09 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37074?usp=email ) Change subject: fix stat_item leak in hnb_persistent_free() .. fix stat_item leak in hnb_persistent_free() Add missing stat_item

[M] Change in osmo-hnbgw[master]: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id

2024-06-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email ) Change subject: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id .. Patch Set 4: Code-Review+2 -- To view, visit

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

2024-06-06 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: hnb_persistent: introduce disconnected timeout

[L] Change in osmo-hnbgw[master]: add umts_cell_id_test.c

2024-06-06 Thread neels
Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email ) Change subject: add umts_cell_id_test.c .. Patch Set 4: (1 comment) File

[S] Change in osmo-hnbgw[master]: rename to umts_cell_id_to_str()

2024-06-06 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36890?usp=email ) Change subject: rename to umts_cell_id_to_str() .. Patch Set 3: Code-Review+2 -- To view, visit https

[S] Change in osmo-hnbgw[master]: use osmo_jhash for the hnb_persistent hashtable

2024-06-06 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36912?usp=email ) Change subject: use osmo_jhash for the hnb_persistent hashtable .. Patch Set 3: Code-Review+2 -- To view, visit https

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

2024-06-05 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins

[S] Change in osmo-hnbgw[master]: warn earlier for missing nftables support

2024-06-05 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email ) Change subject: warn earlier for missing nftables support .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions

2024-06-05 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email ) Change subject: hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions .. hnbgw: TC_hnb_disconnected_timeout

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

2024-06-05 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) Change subject: hnb_persistent: introduce disconnected timeout .. Patch Set 2: This change is ready for review

[M] Change in osmo-hnbgw[master]: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id

2024-06-05 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email ) Change subject: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id .. Patch Set 4: This change is ready for review

[L] Change in osmo-hnbgw[master]: add umts_cell_id_test.c

2024-06-05 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email ) Change subject: add umts_cell_id_test.c .. Patch Set 4: This change is ready for review. -- To view, visit https

[S] Change in osmo-hnbgw[master]: umts_cell_id: add umts_cell_id_to_str_buf()

2024-06-05 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36891?usp=email ) Change subject: umts_cell_id: add umts_cell_id_to_str_buf() .. Patch Set 4: This change is ready for review. -- To view

[S] Change in osmo-hnbgw[master]: rename to umts_cell_id_to_str()

2024-06-05 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36890?usp=email ) Change subject: rename to umts_cell_id_to_str() .. Patch Set 3: This change is ready for review. -- To view, visit

[S] Change in osmo-hnbgw[master]: add LOG_HNBP() for hnb_persistent

2024-06-05 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37075?usp=email ) Change subject: add LOG_HNBP() for hnb_persistent .. add LOG_HNBP() for hnb_persistent Add macro for the pattern LOGP

[S] Change in osmo-hnbgw[master]: fix stat_item leak in hnb_persistent_free()

2024-06-05 Thread neels
: I7326c53d595dce7b442eced89ff8f4b972bd2a82 Gerrit-Change-Number: 37074 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

[S] Change in osmo-hnbgw[master]: warn earlier for missing nftables support

2024-06-05 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email ) Change subject: warn earlier for missing nftables support .. warn earlier for missing nftables support Change-Id

  1   2   3   4   5   6   7   8   9   10   >