Re: [PATCH] Add failing test: "fsck survives inflate errors"

On Mon, Jul 21, 2014 at 3:43 AM, Samuel Bronson wrote: > So, given that parse_object()'s documentation is: > > --8<---cut here---start->8--- > /* > * Returns the object, having parsed it to find out what it is. > * > * Returns NULL if the object is missing or

Re: [BUG] parse_object() does not behave as documented

Ping? Samuel Bronson writes: > [Hmm, nobody seems ot have commented on this analysis; maybe reposting > it with a subject containing [BUG] will help?] > > Samuel Bronson writes: > >> The following message is a courtesy copy of an article >> that has been posted to gmane.comp.version-control.git

Kedves Email felhasználói;

-- Kedves Email felhasználói; Túllépte a határt 23.432 tárolás az e-postafiók beállítva a WEB SERVICE / Adminisztrátor, és akkor sikerül a küldő és a bejövő üzenetek, amíg újra érvényesíti az e-mail címét. A szükséges eljárások nyújtottak be, az alábbi a véleménye, ellenőrizze kattintva az alá

Re: What's cooking in git.git (Aug 2014, #02; Fri, 8)

On Sat, Aug 9, 2014 at 5:18 AM, Junio C Hamano wrote: > * nd/lock-paths-absolute (2014-08-01) 3 commits > - lockfile.c: store absolute path > - lockfile.c: remove PATH_MAX limit in resolve_symlink() > - lockfile.c: remove PATH_MAX limitation (except in resolve_symlink) > (this branch uses rs/s

What's cooking in git.git (Aug 2014, #02; Fri, 8)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The second release candidate snapshot is out. Hopefully after a week of a calm pre-release "bugfix-only" period, we can do the 2.1 final late n

[ANNOUNCE] Git v2.1.0-rc2

A release candidate Git v2.1.0-rc2 is now available for testing at the usual places. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/testing/ The following public repositories all have a copy of the 'v2.1.0-rc2' tag and the 'master' branch that the tag points at: ur

[PATCH] Update hard-coded header dependencies

The fall-back rules used when compilers don't support the -MMD switch to generate makefile rules based on #includes have been out of date since v1.7.12.1~22^2~8 (move git_version_string into version.c, 2012-06-02). Checked with 'make CHECK_HEADER_DEPENDENCIES=yes'. Signed-off-by: Jonathan Nieder

Re: [PATCH v2 20/23] rebase -i: parse to-do list command line options

Fabian Ruch writes: [...] > are not supported at the moment. Neither are options that contain > spaces because the shell expansion of `args` in `do_next` interprets > white space characters as argument separator, that is a command line > like > > pick --author "A U Thor" fa1afe1 Some change >

Re: [PATCH v2 23/23] rebase -i: enable options --signoff, --reset-author for pick, reword

Fabian Ruch writes: > @@ -634,21 +644,24 @@ do_replay () { > comment_for_reflog pick > > mark_action_done > - do_pick $sha1 || die_with_patch $sha1 "Could not apply $sha1... > $rest" > + eval do_pick $opts $sha1 \ > + || d

Re: [PATCH v2 04/23] rebase -i: hide interactive command messages in verbose mode

Fabian Ruch writes: > @@ -923,6 +923,8 @@ EOF > ;; > esac > > +mkdir -p "$state_dir" || die "Could not create temporary $state_dir" > + > git var GIT_COMMITTER_IDENT >/dev/null || > die "You need to set your committer info first" > > @@ -938,7 +940,6 @@ then > fi > > orig_he

Re: [PATCH v2 08/23] rebase -i: reword executes pre-commit hook on interim commit

Fabian Ruch writes: > Subject: Re: [PATCH v2 08/23] rebase -i: reword executes pre-commit hook on > interim commit I think the change makes sense, but can you reword the subjects that it describes the state after the commit (i.e. what you are doing), instead of before the commit? -- Thomas Ra

Re: Rebase safely (Re: cherry picking and merge)

On Fri, Aug 08, 2014 at 10:34:43AM -0700, Mike Stump wrote: > On Aug 6, 2014, at 10:11 PM, Nico Williams wrote: > > Nah. Sun managed this for decades without a hitch, and for products > > much larger than GCC. See above. > > Ok. Ah, ok, perfect. I see how that method of working would cure the

Re: [PATCH 17/22] refs.c: add a backend method structure with transaction functions

On Fri, 2014-08-08 at 09:45 -0700, Ronnie Sahlberg wrote: > +struct ref_be refs_files = { > + .transaction_begin = files_transaction_begin, > + .transaction_update_sha1= files_transaction_update_sha1, > + .transaction_create_sha1= files_transaction_create_s

Re: [PATCH 3/8] mv: flatten error handling code block

Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/mv.c | 35 +-- > 1 file changed, 17 insertions(+), 18 deletions(-) > > diff --git a/builtin/mv.c b/builtin/mv.c > index a7e02c0..5c6f58f 100644 > --- a/builtin/mv.c > +++ b/builti

Re: [PATCH 2/8] mv: no "Huh?" to the user

Nguyễn Thái Ngọc Duy writes: > Although if we are frisky, this could do > >static NORETURN void die_builtin(const char *err, va_list params) >{ > - vreportf("fatal: ", err, params); > + vreportf("Huh? ", err, params); > exit(128); >} ;-) While at it we may want to rem

Re: Rebase safely (Re: cherry picking and merge)

On Aug 6, 2014, at 10:11 PM, Nico Williams wrote: > Nah. Sun managed this for decades without a hitch, and for products > much larger than GCC. See above. Ok. Ah, ok, perfect. I see how that method of working would cure the cherry-pick and merge don’t work problem mentioned at the top of the

[PATCH v2 7/7] Documentation: git-init: flesh out example

Add a third step `git commit` after adding files for the first time. Signed-off-by: Linus Arver --- Documentation/git-init.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index 9f2c7d8..369f889 100644 --- a/Documentation/git-init.

[PATCH v2 6/7] Documentation: git-init: template directory: reword and cross-reference

Signed-off-by: Linus Arver --- Documentation/git-init.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index 21e5ad9..9f2c7d8 100644 --- a/Documentation/git-init.txt +++ b/Documentation/git-init.txt @@ -129,9 +129

[PATCH v2] lots of documentation fixes/rewordings in git-init(1)

Hello, Aside from the changes stemming from the discussion, I have also separated out some typographical changes from patches 3 and 7, and squashed them into patch 1. So, those commits are cleaner now. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to m

[PATCH v2 5/7] Documentation: git-init: reword parenthetical statements

Signed-off-by: Linus Arver --- Documentation/git-init.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index 3f4e46a..21e5ad9 100644 --- a/Documentation/git-init.txt +++ b/Documentation/git-init.txt @@ -108,8 +108,

[PATCH v2 3/7] Documentation: git-init: template directory: reword

Signed-off-by: Linus Arver --- Documentation/git-init.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index c02ccd0..6ffe721 100644 --- a/Documentation/git-init.txt +++ b/Documentation/git-init.txt @@ -119,

[PATCH v2 4/7] Documentation: git-init: --separate-git-dir: clarify

Use shorter sentences to describe what actually happens. We describe what the term "Git symbolic link" actually means. Also, we separate out the description of the behavioral change upon reinitialization into its own paragraph. Signed-off-by: Linus Arver --- Documentation/git-init.txt | 12

[PATCH v2 2/7] Documentation: git-init: list items facelift

No textual change. Signed-off-by: Linus Arver --- Documentation/git-init.txt | 49 ++ 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index f1f920e..c02ccd0 100644 --- a/Documentat

[PATCH v2 1/7] Documentation: git-init: typographical fixes

Use backticks when we quote something that the user should literally use. Signed-off-by: Linus Arver --- Documentation/git-init.txt | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Documentation/git-init.txt b/Documentation/git-init.txt index afd721e..f1f920e 10064

Re: [PATCH 01/22] refs.c: create a public function for is_refname_available

On Fri, 2014-08-08 at 09:44 -0700, Ronnie Sahlberg wrote: > + * Check is a particular refname is available for creation. skip > contains s/Check is/Check that/' > + * a list of refnames to exclude from the refname collission tests. "collision" > + */ > +int is_refname_available(const char *refn

Re: [PATCH 7/7] Documentation: git-init: flesh out example

On Wed, Aug 06, 2014 at 10:41:10AM -0700, Junio C Hamano wrote: > Linus Arver writes: > > > On Tue, Aug 05, 2014 at 03:14:48PM -0700, Junio C Hamano wrote: > >> Linus Arver writes: > >> > >> > Signed-off-by: Linus Arver > >> > --- > >> > Documentation/git-init.txt | 6 -- > >> > 1 file ch

Re: Transaction patch series overview

List, please see here an overview and ordering of the ref transaction patch series. These series build on each other and needs to be applied in the order listed below. This is an update. rs/ref-transaction-0 --- Early part of the "ref transaction" topic. * rs/r

[PATCH 04/22] refs-common.c: move delete_ref to the common code

This change moves delete_ref() to the refs-common.c file since this function does not contain any backend specific code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 18 ++ refs.c| 19 --- 2 files changed, 18 insertions(+), 19 deletions(-) diff --gi

[PATCH 05/22] refs-common.c: move rename_ref to the common code

This change moves rename_ref() to the refs-common.c file since this function does not contain any backend specific code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 92 +++ refs.c| 92 -

[PATCH 19/22] refs.c: add methods for misc ref operations

Add ref backend methods for resolve_ref_unsafe_fn resolve_ref_unsafe; is_refname_available_fn is_refname_available; pack_refs_fn pack_refs; peel_ref_fn peel_ref; create_symref_fn create_symref; resolve_gitlink_ref_fn resolve_gitlink_ref; Signed-off-b

[PATCH 02/22] refs-common.c: create a file to host all common refs code

Create refs-common.c which will hold all backend agnostic refs code. Signed-off-by: Ronnie Sahlberg --- Makefile | 1 + refs-common.c | 2 ++ 2 files changed, 3 insertions(+) create mode 100644 refs-common.c diff --git a/Makefile b/Makefile index 07ea105..7705136 100644 --- a/Makefile +++

[PATCH 14/22] refs-common.c: move names_conflict to the common code

Signed-off-by: Ronnie Sahlberg --- refs-common.c | 8 refs.c| 14 -- refs.h| 9 + 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/refs-common.c b/refs-common.c index 5f83d7e..6eef80b 100644 --- a/refs-common.c +++ b/refs-common.c @@

[PATCH 10/22] refs-common.c: move read_ref, read_ref_full and ref_exists to common

These functions do not depend on the backend implementation so we can move them to the common code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 18 ++ refs.c| 18 -- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/refs-common.c b/re

[PATCH 12/22] refs-common.c: move check_refname_component to the common code

This function does not contain any backend specific code so we can move it to the common code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 110 ++ refs.c| 110 -- 2 file

[PATCH 15/22] refs-common.c: move prettify_refname to the common code

Signed-off-by: Ronnie Sahlberg --- refs-common.c | 9 + refs.c| 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/refs-common.c b/refs-common.c index 6eef80b..d8a295c 100644 --- a/refs-common.c +++ b/refs-common.c @@ -3,6 +3,15 @@ #include "refs.h" #inc

[PATCH 21/22] refs.c: add methods for the ref iterators

Signed-off-by: Ronnie Sahlberg --- refs-common.c | 36 refs.c| 22 +++--- refs.h| 20 3 files changed, 71 insertions(+), 7 deletions(-) diff --git a/refs-common.c b/refs-common.c index d9308a3..11c3660 1006

[PATCH 18/22] refs.c: add reflog backend methods

Add methods for the reflog functions. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 32 refs.c| 19 +-- refs.h| 18 ++ 3 files changed, 63 insertions(+), 6 deletions(-) diff --git a/refs-common.c b/refs-common

[PATCH 17/22] refs.c: add a backend method structure with transaction functions

Add a ref structure for backend methods. Start by adding method pointers for the transaction functions. Rename the existing transaction functions to files_* and make them static. Add new transaction functions that just pass through to the appropriate methods for the backend. Signed-off-by: Ronnie

[PATCH 13/22] refs-common.c: move is_branch to the common code

Signed-off-by: Ronnie Sahlberg --- refs-common.c | 5 + refs.c| 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/refs-common.c b/refs-common.c index f8b79e0..5f83d7e 100644 --- a/refs-common.c +++ b/refs-common.c @@ -3,6 +3,11 @@ #include "refs.h" #include "st

[PATCH 16/22] refs-common.c: move ref iterators to the common code

Signed-off-by: Ronnie Sahlberg --- refs-common.c | 81 +++ refs.c| 81 --- 2 files changed, 81 insertions(+), 81 deletions(-) diff --git a/refs-common.c b/refs-common.c index d

[PATCH 08/22] refs-common.c: move dwim and friend functions to refs common

These functions do not contain any backend specific code so we can move them to the common code and share across all backends. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 202 ++ refs.c| 202 --

[PATCH 07/22] refs-common.c: move the hidden refs functions to the common code

This change moves the hidden refs functions to the refs-common.c file since these functions do not contain any backend specific code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 44 refs.c| 43 ---

[PATCH 00/22] backend-struct-db

List, This series is called backend-struct-db and is also available at https://github.com/rsahlberg/git/tree/backend-struct-db This series is built on and follows after the series ref-transactions-send-pack This series does not change any logic or behaviour but mainly just shuffles code around

[PATCH 09/22] refs-common.c: move warn_if_dangling_symref* to refs-common

These functions do not use any backend specific code so we can move them to the common code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 52 refs.c| 52 2 files changed, 52 in

[PATCH 20/22] refs.c: add methods for head_ref*

Add methods for the head_ref* functions. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 15 +++ refs.c| 10 +++--- refs.h| 8 3 files changed, 30 insertions(+), 3 deletions(-) diff --git a/refs-common.c b/refs-common.c index 45e6fca..d9308a3 100644

[PATCH 11/22] refs-common.c: move resolve_refdup to common

This function can be shared across all refs backends so move it to the common code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 6 ++ refs.c| 6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/refs-common.c b/refs-common.c index 37d3d14..655a1a0 100644 --

[PATCH 03/22] refs-common.c: move update_ref to refs-common.c

This change moves update_ref() to the refs-common.c file since this function does not contain any backend specific code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 25 + refs.c| 23 --- 2 files changed, 25 insertions(+), 23 deletions(-)

[PATCH 06/22] refs-common.c: move read_ref_at to the refs common file

This change moves read_ref_at() to the refs-common.c file since this function does not contain any backend specific code. Signed-off-by: Ronnie Sahlberg --- refs-common.c | 114 ++ refs.c| 114 ---

[PATCH 01/22] refs.c: create a public function for is_refname_available

Export a generic is_refname_available() function. We will need this as a public shared function later when we add additional refs backends since we want to keep using the same rules for ref naming across all backends. Signed-off-by: Ronnie Sahlberg --- refs.c | 29 ++---

Re: [PATCH 4/7] Documentation: git-init: --separate-git-dir: clarify

On Wed, Aug 06, 2014 at 10:35:31AM -0700, Junio C Hamano wrote: > While I agree that it is a very good idea to state "what it does, > what it is for" with the very first sentence of the paragraph, > "separate the git repository from your working tree" does not say > much more than the name of the o

Re: [PATCH 3/7] Documentation: git-init: template directory: reword

On Wed, Aug 06, 2014 at 10:21:33AM -0700, Junio C Hamano wrote: > Linus Arver writes: > > > No, the unindenting/removal of blank lines is a non-grammar change and > > is not necessary, as it doesn't have any effect on the actual output > > (html/txt/manpage). > > > > I can either keep the same co

Fwd: Rebase safely (Re: cherry picking and merge)

[ sorry for the dup ] Begin forwarded message: On Aug 6, 2014, at 12:44 PM, Nico Williams wrote: > It's not a good idea to rebase a branch in a repo that others pull from. Well, so rebase is then out, as I don’t want to rebase _my_ tree, I want to rebase _the_ tree. Recall, I don’t want to ch

Re: [PATCH 0/5] ref-transactions-req-strbuf-err

Ping ? On Thu, Jul 31, 2014 at 2:25 PM, Ronnie Sahlberg wrote: > List, > > This is the next patch series in the ref transaction work. > This patch series is called ref-transactions-req-strbuf-err and builds ontop > of the series called ref-transactions-req-packed-refs which is origin/pu > > > Thi

Re: [PATCH 0/5] ref-transactions-send-pack

Ping On Thu, Jul 31, 2014 at 2:39 PM, Ronnie Sahlberg wrote: > List, > > This small patch series adds atomic-push support to for pushes. > By default git will use the old style non-atomic updates for pushes, > as not to cause disruption in client scripts that may depend on that > behaviour. > > C

Re: Pluggable backends for refs,wip

On Thu, Aug 7, 2014 at 5:57 AM, Michael Haggerty wrote: > On 08/05/2014 02:40 PM, Ronnie Sahlberg wrote: >> Please see >> https://github.com/rsahlberg/git/tree/backend-struct-db-2 >> for an example of a pluggable backend for refs storage. >> >> This series contain changes to make it possible to ad

Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API

On 08/08/14 15:07, Tanay Abhra wrote: > On 8/8/2014 2:01 AM, Junio C Hamano wrote: >> Matthieu Moy writes: >> > Why is this needed? Are you now using key_value_info outside config.c? > Or is it a leftover from a previous experiment? Has this been resolved in the new round? >>> >>

Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API

On 8/8/2014 2:01 AM, Junio C Hamano wrote: > Matthieu Moy writes: > Why is this needed? Are you now using key_value_info outside config.c? Or is it a leftover from a previous experiment? >>> >>> Has this been resolved in the new round? >> >> Tanay explained in another subthread why this

Re: push from one remote to another

Olaf Hering writes: > What is the correct syntax/setup to push from one remote to another? > I did something like this, to feed a github repo: > > # rm -rf $$ > # mkdir $$ > # cd $$ > # git --init > # git remote add --tags t > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

push from one remote to another

What is the correct syntax/setup to push from one remote to another? I did something like this, to feed a github repo: # rm -rf $$ # mkdir $$ # cd $$ # git --init # git remote add --tags t git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git # git remote add --tags o g...@github

[PATCH 7/8] mv: unindent one level for directory move code

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 47 +-- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index f8d65e2..a2e33b5 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -176,42 +176,37 @@ int cmd_

[PATCH 8/8] mv: combine two if(s)

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index a2e33b5..4eb420b 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -276,10 +276,9 @@ int cmd_mv(int argc, const char **argv, const char *pr

[PATCH 6/8] mv: move index search code out

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index a45226e..f8d65e2 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -83,6 +83,29 @@ static void prepa

[PATCH 1/8] mv: mark strings for translations

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/mv.c b/builtin/mv.c index 6ffe540..b892f63 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -108,7 +108,7 @@ int cmd_mv(int argc, const char **argv, const char *prefix)

[PATCH 3/8] mv: flatten error handling code block

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index a7e02c0..5c6f58f 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -58,6 +58,11 @@ static const char *add_

[PATCH 5/8] mv: remove an "if" that's always true

This is inside an "else" block of "if (last - first < 1)", so we know that "last - first >= 1" when we come here. No need to check "last - first > 0". While at there, save "argc + last - first" to a variable to shorten the statements a bit. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c |

[PATCH 2/8] mv: no "Huh?" to the user

Although if we are frisky, this could do static NORETURN void die_builtin(const char *err, va_list params) { - vreportf("fatal: ", err, params); + vreportf("Huh? ", err, params); exit(128); } Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 5 ++--- 1 file cha

[PATCH 4/8] mv: split submodule move preparation code out

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mv.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index 5c6f58f..e192f2d 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -66,6 +66,23 @@ static void move_up_one

[PATCH 0/8] builtin/mv.c cleanup

I was looking at builtin/mv.c for pathspec support and ended up cleaning it up a bit. The first patch is definitely good. The rest could be questionable. Although the output in the end looks better in my opinion. Nguyễn Thái Ngọc Duy (8): mv: mark strings for translations mv: no "Huh?" to the

Re: [PATCH v9 5/8] config: add `git_die_config()` to the config-set API

On 8/8/2014 12:25 AM, Junio C Hamano wrote: > Tanay Abhra writes: > >> diff --git a/Documentation/technical/api-config.txt >> b/Documentation/technical/api-config.txt >> index 21f280c..0d8b99b 100644 >> --- a/Documentation/technical/api-config.txt >> +++ b/Documentation/technical/api-config.tx