ke 24. lokak. 2018 klo 2.03 brian m. carlson
(sand...@crustytoothpaste.net) kirjoitti:
> You have an extra '1" at the end of this line.
> Also, missing sign-off. See Documentation/SubmittingPatches.
After reading SubmittingPatches I didn't find if I should now send a
fresh patch with
changes squa
From: Nickolai Belakovski
lock_reason is now populated during the execution of get_worktrees
is_worktree_locked has been simplified, renamed, and changed to internal
linkage. It is simplified to only return the lock reason (or NULL in case
there is no lock reason) and to not have any side effect
Signed-off-by: Denton Liu
Signed-off-by: Anmol Mago
Signed-off-by: Brian Ho
Signed-off-by: David Lu
Signed-off-by: Ryan Wang
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash
b/contrib/complet
In line with how difftool accepts a -g/--[no-]gui option, make mergetool
accept the same option in order to use the `merge.guitool` variable to
find the default mergetool instead of `merge.tool`.
Signed-off-by: Denton Liu
Signed-off-by: Anmol Mago
Signed-off-by: Brian Ho
Signed-off-by: David Lu
Ævar Arnfjörð Bjarmason writes:
> Notes on the implementation:
>
> * The only reason we need a new "git-sh-i18n--helper" and the
>corresponding "test-tool gettext-poison" is to expose
>git_env_bool() to shellscripts, since git-sh-i18n and friends need
>to inspect the $GIT_TEST_GETTE
On Wed, Oct 24, 2018 at 02:10:14PM +0900, Junio C Hamano wrote:
> Denton Liu writes:
>
> > Subject: Re: [PATCH 1/2] mergetool: Accept -g/--[no-]gui as arguments
>
> Other people may point it out, but s/Accept/accept/.
>
> > In line with how difftool accepts a -g/--[no-]gui option, make mergetoo
ke 24. lokak. 2018 klo 0.57 Stefan Beller (sbel...@google.com) kirjoitti:
> On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen wrote:
> > I would expect that if git-config has fetch.recurseSubmodules set,
> > also git pull should use this setting, or at least similar option such
>
> This makes sens
On Wed, Oct 24, 2018 at 02:10:14PM +0900, Junio C Hamano wrote:
> In mode_ok shell function, we seem to be prepared to deal with a
> case where neither diff_mode nor merge_mode is true. Should this
> codepath also be prepared to?
>
According to Documentation/git-mergetool--lib.txt,
>Before so
Junio C Hamano writes:
> Lucas De Marchi writes:
>
>> Your reply arrived just a little after I sent the v2, so I thought it
>> was just the race and you would end up seeing the unread email in the
>> same thread. Sorry for not including the msg id:
>> 20181011081750.24240-1-lucas.demar...@intel.
Lucas De Marchi writes:
> Your reply arrived just a little after I sent the v2, so I thought it
> was just the race and you would end up seeing the unread email in the
> same thread. Sorry for not including the msg id:
> 20181011081750.24240-1-lucas.demar...@intel.com
OK, then I am not surprised
Denton Liu writes:
> Subject: Re: [PATCH 1/2] mergetool: Accept -g/--[no-]gui as arguments
Other people may point it out, but s/Accept/accept/.
> In line with how difftool accepts a -g/--[no-]gui option, make mergetool
> accept the same option in order to use the `merge.guitool` variable to
> f
Matthew DeVore writes:
> No code which reads cmdline in struct rev_info can handle NULL objects
> in cmdline.rev[i].item, so stop adding them to the cmdline.rev array.
"The code is not prepared to have cmdline.rev[].item that is NULL"
is something everybody would understand and agree with, but t
Andreas Gruenbacher writes:
> Commit [1] added the --exclude option to revision.c. The --all,
> --branches, --tags, --remotes, and --glob options clear the exclude
> list. Shortly therafter, commit [2] added the same to 'git rev-parse',
> but without clearing the exclude list for the --all opti
"Johannes Schindelin via GitGitGadget"
writes:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index c6a7943d5..9217fc832 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -549,6 +549,12 @@ int cmd_repack(int argc, const char **argv, const char
> *prefix)
> if (!po
Jonathan, do you see any issues with the use of lookup_commit() in
this change wrt lazy clone? I am wondering what happens when the
commit in question is at, an immediate parent of, or an immediate
child of a promisor object. I _think_ this change won't make it
worse for two features in playing t
On Wed, Oct 24, 2018 at 11:12:51AM +0900, Junio C Hamano wrote:
> Lucas De Marchi writes:
>
> >> Yes, I agree on both counts (i.e. it was totally unclear what
> >> problem is being solved and what the root cause of the problem is,
> >> and we would want a new test to protect this "fix" from getti
"Johannes Schindelin via GitGitGadget"
writes:
> From: Johannes Schindelin
>
> A `git fetch --prune` can turn previously-reachable objects unreachable,
> even commits that are in the `shallow` list. A subsequent `git repack
> -ad` will then unceremoniously drop those unreachable commits, and the
Matthew DeVore writes:
> On Tue, 23 Oct 2018, Junio C Hamano wrote:
>
>> Not really. We were already doing a controlled failure via die(),
>> so these two tests would not have caught the problem in the code
>> before the fix in this patch.
>>
>
> BUG is apparently considered a "wrong" failure an
Carlo Marcelo Arenas Belón writes:
> in f48000fc ("Yank writing-back support from gitfakemmap.", 2005-10-08)
> support for writting back changes was removed but the specific prot
> flag that would be used was not checked for
>
> Acked-by: Johannes Schindelin
> Signed-off-by: Carlo Marcelo Arena
Stefan Beller writes:
>> Anyway, even though "make coccicheck" does not run in subsecond,
>> I've updated my machinery to rebuild the integration branches so
>> that I can optionally queue generated coccicheck patches, and what I
>> pushed out tonight has one at the tip of 'pu' and also another a
Lucas De Marchi writes:
>> Yes, I agree on both counts (i.e. it was totally unclear what
>> problem is being solved and what the root cause of the problem is,
>> and we would want a new test to protect this "fix" from getting
>> broken in the future.
>
> have you seen I sent a v2 with proper test
"brian m. carlson" writes:
> On Mon, Oct 22, 2018 at 06:38:19PM +0200, Michał Górny wrote:
>> Replace the logic used to determine whether key and signer information
>> is present to use explicit flags in sigcheck_gpg_status[] array. This
>> is more future-proof, since it makes it possible to add
Carlo Marcelo Arenas Belón writes:
> contrib/nedmalloc doesn't support MALLOC_CHECK_ or MALLOC_PERTURB_
> so add it to the same exception that is being used with valgrind
>
> Signed-off-by: Carlo Marcelo Arenas Belón
> ---
> t/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Oct 22, 2018 at 10:11:50AM +0200, Ralf Jung wrote:
> Hi all,
>
> I have been repeatedly bitten by the default behavior of `git stash` to stash
> not just the unstaged but also the staged changes, and then `git stash pop`
> making all changes unstaged. This means `git stash && git stash pop
On 23/10/2018 20:04, Ben Peart wrote:
> From: Ben Peart
Sorry for the late reply, ... I've been away from email - I am
still trying to catch up.
>
> Add a reset.quiet config setting that sets the default value of the --quiet
> flag when running the reset command. This enables users to chang
On Tue, Oct 23, 2018 at 03:23:21AM -0700, Karsten Blees via GitGitGadget wrote:
> - if (!get_file_info_by_handle(fh, buf))
> + case FILE_TYPE_CHAR:
> + case FILE_TYPE_PIPE:
> + /* initialize stat fields */
> + memset(buf, 0, sizeof(*buf));
> + buf->st
Jeff King writes:
> I also think we may want to make a fundamental shift in our view of
> thread support. In the early days, it was "well, this is a thing that
> modern systems can take advantage of for certain commands". But these
> days I suspect it is more like "there are a handful of legacy s
Ben Peart writes:
>>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>>> index f6f4c21a54..a2d1b8b116 100644
>>> --- a/Documentation/config.txt
>>> +++ b/Documentation/config.txt
>>> @@ -2728,6 +2728,9 @@ rerere.enabled::
>>> `$GIT_DIR`, e.g. if "rerere" was previously
In line with how difftool accepts a -g/--[no-]gui option, make mergetool
accept the same option in order to use the `merge.guitool` variable to
find the default mergetool instead of `merge.tool`.
Signed-off-by: Denton Liu
Signed-off-by: Anmol Mago
Signed-off-by: Brian Ho
Signed-off-by: David Lu
Slavica writes:
> +test_expect_failure 'stash with HOME as non-existing directory' '
> +test_commit 1 &&
> +test_config user.useconfigonly true &&
> +test_config stash.usebuiltin true &&
> +(
> +HOME=$(pwd)/none &&
> +export HOME &&
What is the reason why this tes
Signed-off-by: Denton Liu
Signed-off-by: Anmol Mago
Signed-off-by: Brian Ho
Signed-off-by: David Lu
Signed-off-by: Ryan Wang
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash
b/contrib/complet
> > Another thing you need to clarify is what happens if the fetch-by-commit
> > fails. Right now, it seems that it will make the whole thing fail, which
> > might be a surprising change in behavior.
>
> But a positive surprise, I would assume?
Whether positive or negative, I think that this need
On Wed, Oct 24, 2018 at 12:04:06AM +0300, Tommi Vainikainen wrote:
> I configured my local git to fetch with recurseSubmodules = on-demand,
> which I found the most convenient setting. However then I noticed that
> I mostly use git pull actually to fetch from remotes, but git pull
> does not utiliz
On Tue, Oct 23, 2018 at 3:00 PM Jeff King wrote:
> On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote:
> > #define implement_static_commit_slab(slabname, elemtype) \
> > - implement_commit_slab(slabname, elemtype, static MAYBE_UNUSED)
> > + implement_commit_slab(sl
On Tue, Oct 23, 2018 at 3:55 PM Jonathan Tan wrote:
> > When adding the comment here, we'd also want to have
> > the comment in prepare_submodule_repo_env, which
> > could be its own preparation commit.
>
> I agree with the protection. As for the preparation commit, I don't
> think it's always the
On Mon, Oct 22, 2018 at 06:38:19PM +0200, Michał Górny wrote:
> Replace the logic used to determine whether key and signer information
> is present to use explicit flags in sigcheck_gpg_status[] array. This
> is more future-proof, since it makes it possible to add additional
> statuses without hav
> > Why does GIT_DIR need to be set? Is it to avoid subcommands recursively
> > checking the parent directories in case the CWD is a malformed Git
> > repository? If yes, maybe it's worth adding a comment.
>
> It is copying the structure from prepare_submodule_repo_env,
> specifically 10f5c52656 (
On Wed, Oct 17, 2018 at 5:40 PM Jonathan Tan wrote:
>
> > Currently when git-fetch is asked to recurse into submodules, it dispatches
> > a plain "git-fetch -C " (with some submodule related options
> > such as prefix and recusing strategy, but) without any information of the
> > remote or the tip
On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote:
> after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18)
> it is expected to be used to prevent -Wunused-function warnings for code
> that was macro generated
Makes sense.
> diff --git a/commit-slab-im
No code which reads cmdline in struct rev_info can handle NULL objects
in cmdline.rev[i].item, so stop adding them to the cmdline.rev array.
Objects in cmdline are NULL when the given object is promisor and
--exclude-promisor-objects is enabled.
This new behavior avoids a segmentation fault in the
On Tue, Oct 23, 2018 at 2:04 PM Tommi Vainikainen wrote:
>
> I configured my local git to fetch with recurseSubmodules = on-demand,
> which I found the most convenient setting. However then I noticed that
> I mostly use git pull actually to fetch from remotes, but git pull
> does not utilize any r
showing the following when compiled with latest clang (OpenBSD, Fedors
and macOS):
delta-islands.c:23:1: warning: unused function 'kh_destroy_str'
[-Wunused-function]
delta-islands.c:23:1: warning: unused function 'kh_clear_str'
[-Wunused-function]
delta-islands.c:23:1: warning: unused
the macro generated code from delta-islands (using khash) triggers
some unused function warnings in macOS, OpenBSD and some linux with a
newer version of clang
Carlo Marcelo Arenas Belón (2):
commit-slabs: move MAYBE_UNUSED out
khash: silence -Wunused-function for delta-islands
commit-slab-i
after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18)
it is expected to be used to prevent -Wunused-function warnings for code
that was macro generated
Signed-off-by: Carlo Marcelo Arenas Belón
---
commit-slab-impl.h | 4 ++--
git-compat-util.h | 2 ++
2 files changed, 4 ins
I configured my local git to fetch with recurseSubmodules = on-demand,
which I found the most convenient setting. However then I noticed that
I mostly use git pull actually to fetch from remotes, but git pull
does not utilize any recurseSubmoddules setting now, or at least I
could not find such.
I
Change the GETTEXT_POISON compile-time + runtime GIT_GETTEXT_POISON
test parameter to only be a GIT_TEST_GETTEXT_POISON= runtime
parameter, to be consistent with other parameters documented in
"Running tests with special setups" in t/README.
When I added GETTEXT_POISON in bb946bba76 ("i18n: add GE
On 10/22, René Scharfe wrote:
> Am 22.10.2018 um 23:10 schrieb Thomas Gummerer:
> > compare_commit_by_gen is used to sort a list of pointers to 'struct
> > commit'. The comparison function for qsort is called with pointers to
> > the objects it needs to compare, so when sorting a list of 'struct
>
On Thu, Oct 18, 2018 at 08:05:22PM +0200, Nguyễn Thái Ngọc Duy wrote:
> On Thu, Oct 18, 2018 at 7:09 PM Jeff King wrote:
> > > In this particular case though I think we should be able to avoid so
> > > much #if if we make a wrapper for pthread api that would return an
> > > error or something whe
On Tue, Oct 23, 2018 at 03:13:06PM -0400, Ben Peart wrote:
> At one point I also had the additional #ifndef NO_PTHREADS lines but it was
> starting to get messy with the threaded vs non-threaded code paths so I
> removed them. I'm fine with which ever people find more readable.
>
> It does make
On Tue, Oct 23 2018, Ben Peart wrote:
> On 10/23/2018 5:13 AM, Ævar Arnfjörð Bjarmason wrote:
>>
>> On Wed, Oct 17 2018, Jeff King wrote:
>>
>>> On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote:
>>>
On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote:
> Add a reset.quietDefau
On Tue, Oct 23, 2018 at 02:11:01PM -0400, Ben Peart wrote:
> This sounds like an easy way to choose a set of default values that we think
> make sense to get bundled together. That could be a way for users to quickly
> choose a set of good defaults but I still think you would want find grained
> c
From: Johannes Schindelin
Since we cannot stash dirty submodules, there is no use in requiring
them to be clean (or stash them when they are not).
This brings the built-in rebase in line with the previous, scripted
version, which also did not care about dirty submodules (but it was
admittedly no
This bug report came in via Git for Windows (already with version 2.19.0,
but I misread the reporter's enthusiasm to take matters into his own hands).
The culprit is, in a nutshell, that the built-in rebase tries to run git
stash only when the worktree is dirty, but it includes submodules in that.
From: Johannes Schindelin
It has been reported that dirty submodules cause problems with the
built-in rebase when it is asked to autostash. The symptom is:
fatal: Unexpected stash response: ''
This patch adds a regression test that demonstrates that bug.
Original report: https://github
Hi Duy,
On Tue, 23 Oct 2018, Duy Nguyen wrote:
> On Tue, Oct 23, 2018 at 1:01 AM Ben Peart wrote:
> >
> > > -Original Message-
> > > From: Johannes Schindelin
> > > Sent: Monday, October 22, 2018 4:45 PM
> > > To: Ben Peart
> > > Cc: git@vger.kernel.org; gits...@pobox.com; Ben Peart
>
On Tue, Oct 23, 2018 at 12:31 PM Slavica wrote:
> This is part of enhancement request that ask for `git stash` to work even if
> `user.name` is not configured.
> The issue is discussed here:
> https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u.
As Christian mentioned already,
Commit [1] added the --exclude option to revision.c. The --all,
--branches, --tags, --remotes, and --glob options clear the exclude
list. Shortly therafter, commit [2] added the same to 'git rev-parse',
but without clearing the exclude list for the --all option. Fix that.
[1] e7b432c52 ("revisi
On 10/22/2018 7:05 PM, Junio C Hamano wrote:
Jeff King writes:
If nobody uses it, should we drop the return value, too? Like:
Yup.
I'm good with that.
At one point I also had the additional #ifndef NO_PTHREADS lines but it
was starting to get messy with the threaded vs non-threaded c
From: Ben Peart
Updated the wording in the documentation and commit messages to (hopefully)
make it clearer. Added the warning about 'reset --quiet' to the advice
system so that it can be turned off.
Base Ref:
Web-Diff: https://github.com/benpeart/git/commit/8a2fef45d4
Checkout: git fetch https
From: Ben Peart
When git reset is run with the --quiet flag, don't bother finding any
additional unstaged changes as they won't be output anyway. This speeds up
the git reset command by avoiding having to lstat() every file looking for
changes that aren't going to be reported anyway.
The saving
From: Ben Peart
refresh_index() is done after a reset command as an optimization. Because
it can be an expensive call, warn the user if it takes more than 2 seconds
and tell them how to avoid it using the --quiet command line option or
reset.quiet config setting.
Signed-off-by: Ben Peart
---
From: Ben Peart
Add a reset.quiet config setting that sets the default value of the --quiet
flag when running the reset command. This enables users to change the
default behavior to take advantage of the performance advantages of
avoiding the scan for unstaged changes after reset. Defaults to f
On Tue, Oct 23, 2018 at 6:35 PM Slavica wrote:
>
> This is part of enhancement request that ask for `git stash` to work even if
> `user.name` is not configured.
> The issue is discussed here:
> https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u.
We prefer commit messages that
On 10/22/2018 10:45 AM, Duy Nguyen wrote:
On Mon, Oct 22, 2018 at 3:38 PM Ben Peart wrote:
From: Ben Peart
Add a reset.quiet config setting that sets the default value of the --quiet
flag when running the reset command. This enables users to change the
default behavior to take advantage
On Wed, Oct 17, 2018 at 3:58 PM Jonathan Tan wrote:
>
> > This patch started as a refactoring to make 'get_next_submodule' more
> > readable, but upon doing so, I realized that "git fetch" of the submodule
> > actually doesn't need to be run in the submodules worktree. So let's run
> > it in its g
On 10/23/2018 5:13 AM, Ævar Arnfjörð Bjarmason wrote:
On Wed, Oct 17 2018, Jeff King wrote:
On Wed, Oct 17, 2018 at 02:19:59PM -0400, Eric Sunshine wrote:
On Wed, Oct 17, 2018 at 12:40 PM Ben Peart wrote:
Add a reset.quietDefault config setting that sets the default value of the
--quiet
On Tue, 23 Oct 2018, Junio C Hamano wrote:
Not really. We were already doing a controlled failure via die(),
so these two tests would not have caught the problem in the code
before the fix in this patch.
BUG is apparently considered a "wrong" failure and not a controlled one
by test_must_
On Tue, Oct 23, 2018 at 01:31:58PM -0400, Ben Peart wrote:
> On 10/22/2018 4:06 PM, Jeff King wrote:
> > On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote:
> >
> > > > -q::
> > > > --quiet::
> > > > - Be quiet, only report errors.
> > > > +--no-quiet::
> > > > + Be quie
On 10/22/2018 4:06 PM, Jeff King wrote:
On Mon, Oct 22, 2018 at 08:13:32PM +0100, Ramsay Jones wrote:
-q::
--quiet::
- Be quiet, only report errors.
+--no-quiet::
+ Be quiet, only report errors. The default behavior respects the
+ `reset.quiet` config option, or `--no-q
On Tue, Oct 23, 2018 at 2:38 AM Junio C Hamano wrote:
>
> Junio C Hamano writes:
>
> > I actually think this round does a far nicer job playing well with
> > other topics than any earlier series. The pain you are observing I
> > think come primarily from my not making the best use of these
> > p
On 10/22/2018 8:23 PM, Junio C Hamano wrote:
Ben Peart writes:
From: Ben Peart
refresh_index() is done after a reset command as an optimization. Because
it can be an expensive call, warn the user if it takes more than 2 seconds
and tell them how to avoid it using the --quiet command line
On Tue, 23 Oct 2018, Junio C Hamano wrote:
Thanks; both patches make sense.
As the problematic feature appeared in 2.17.x track, I'll see if I
can easily make it ready to be merged down to maint-2.17 track later
when somebody wants to.
Great. Thank you for the review.
Hi Johannes,
this looks good to me, too!
Cheers,
Alban
On Tue, Oct 23, 2018 at 9:19 AM René Scharfe wrote:
> With Clang 6 and GCC 8 on Debian I don't get any warnings on master or
> 36da893114.
I see it with Clang 7 on Fedora (at least Rawhide but suspect also to
affect the next release, now in beta: 29)
> With Clang 6 on OpenBSD I get warnings abo
On Tue, Oct 23 2018, Duy Nguyen wrote:
> On Tue, Oct 23, 2018 at 12:17 PM Ævar Arnfjörð Bjarmason
> wrote:
>>
>>
>> On Tue, Oct 23 2018, Johannes Schindelin wrote:
>>
>> > Hi Ævar,
>> >
>> > On Mon, 22 Oct 2018, Ævar Arnfjörð Bjarmason wrote:
>> >
>> >> So I think the only reason to keep it [GE
This is part of enhancement request that ask for `git stash` to work even if
`user.name` is not configured.
The issue is discussed here:
https://public-inbox.org/git/87o9debty4@evledraar.gmail.com/T/#u.
Signed-off-by: Slavica
---
t/t3903-stash.sh | 17 +
1 file changed, 17
Am 23.10.2018 um 13:34 schrieb Carlo Marcelo Arenas Belón:
> after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18)
> macro generated code should use a similar solution than commit-slab to
> silence the compiler.
With Clang 6 and GCC 8 on Debian I don't get any warnings on maste
From: Torsten Bögershausen
When streaming data from disk into a blob, it should be possible to commit
a file with a file size > 4 GiB using the streaming functionality in Git.
Because of the streaming there is no need to load the whole data into
memory at once.
Today this is not possible on e.g.
"Derrick Stolee via GitGitGadget" writes:
> From: Derrick Stolee
>
> As we are working to rewrite some of the revision-walk machinery,
> there could easily be some interesting interactions between the
> options that force topological constraints (--topo-order,
> --date-order, and --author-date-o
On Tue, Oct 23, 2018 at 1:01 AM Ben Peart wrote:
>
> > -Original Message-
> > From: Johannes Schindelin
> > Sent: Monday, October 22, 2018 4:45 PM
> > To: Ben Peart
> > Cc: git@vger.kernel.org; gits...@pobox.com; Ben Peart
> > ; p...@peff.net; sunsh...@sunshineco.com
> > Subject: Re: [PA
On Tue, Oct 23, 2018 at 1:42 PM Carlo Marcelo Arenas Belón
wrote:
>
> after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18)
> macro generated code should use a similar solution than commit-slab to
> silence the compiler.
>
> Signed-off-by: Carlo Marcelo Arenas Belón
> ---
> k
On Tue, Oct 23, 2018 at 12:17 PM Ævar Arnfjörð Bjarmason
wrote:
>
>
> On Tue, Oct 23 2018, Johannes Schindelin wrote:
>
> > Hi Ævar,
> >
> > On Mon, 22 Oct 2018, Ævar Arnfjörð Bjarmason wrote:
> >
> >> So I think the only reason to keep it [GETTEXT_POISON] compile-time is
> >> performance, but I d
On Mon, Oct 22, 2018 at 10:23 PM SZEDER Gábor wrote:
> [TODO: Fallout?
>A 'printf(_("foo: %s"), var);' call includes the contents of
>'var' unscrambled in the output. Could that hide the
>translation of a string that should not have been translated?
>I'm afraid yes
On Mon, Oct 22, 2018 at 10:23 PM SZEDER Gábor wrote:
> Once upon a time a GETTEXT_POISON build job failed on me, and the
> error message:
>
> error: # GETTEXT POISON #
>
> was not particularly useful. Ook wouldn't help with that...
Oook?
> So I came up with the following couple of patches tha
On Thu, Oct 11, 2018 at 05:25:02PM +0900, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
> > On Wed, Oct 10 2018, Lucas De Marchi wrote:
> >
> >> Do like it's done in grep so mode doesn't end up as
> >> 016, which means range-diff doesn't work if one has
> >> "submodule.diff = log"
On 10/22/2018 9:37 AM, Jakub Narebski wrote:
"Derrick Stolee via GitGitGadget" writes:
From: Derrick Stolee
The current --topo-order algorithm requires walking all
reachable commits up front, topo-sorting them, all before
outputting the first value. This patch introduces a new
algorithm whic
On Tuesday, October 23, 2018 6:16:43 AM MST Stephen Smith wrote:
> On Tuesday, October 23, 2018 3:52:49 AM MST you wrote:
> > From: Anton Serbulov
> >
> > `GetLongPathName()` function may fail when it is unable to query
> > the parent directory of a path component to determine the long name
> > f
On Tuesday, October 23, 2018 3:52:49 AM MST you wrote:
> From: Anton Serbulov
>
> `GetLongPathName()` function may fail when it is unable to query
> the parent directory of a path component to determine the long name
> for that component. It happens, because of it uses `FindFirstFile()`
s/of it/i
in f48000fc ("Yank writing-back support from gitfakemmap.", 2005-10-08)
support for writting back changes was removed but the specific prot
flag that would be used was not checked for
Acked-by: Johannes Schindelin
Signed-off-by: Carlo Marcelo Arenas Belón
---
Changes in v2:
* reset-author t
after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18)
macro generated code should use a similar solution than commit-slab to
silence the compiler.
Signed-off-by: Carlo Marcelo Arenas Belón
---
khash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/khash.h
Issue: While running a git stash command including the '-u' flag to include
untracked files, the command failed due to arguments in the incorrect order.
After this untracked files the were present had been removed and permanently
lost.
Environment: Windows 10, Powershell w/ PoshGit
State be
Hi Ævar,
On Tue, 23 Oct 2018, Ævar Arnfjörð Bjarmason wrote:
> On Tue, Oct 23 2018, Johannes Schindelin wrote:
>
> > On Mon, 22 Oct 2018, Ævar Arnfjörð Bjarmason wrote:
> >
> >> So I think the only reason to keep it [GETTEXT_POISON] compile-time is
> >> performance, but I don't think that matter
From: Anton Serbulov
`GetLongPathName()` function may fail when it is unable to query
the parent directory of a path component to determine the long name
for that component. It happens, because of it uses `FindFirstFile()`
function for each next short part of path. The `FindFirstFile()`
requires
On Windows, file names are recorded case-sensitively, but looked up
case-insensitively. Therefore, it is possible to switch to a directory by
using incorrect case, e.g. cd documentation will still get you into the
Documentation subdirectory.
In Powershell, doing so will however report the current
From: Johannes Schindelin
When switching the current working directory, say, in PowerShell, it is
quite possible to use a different capitalization than the one that is
recorded on disk. While doing the same in `cmd.exe` adjusts the
capitalization magically, that does not happen in PowerShell so t
From: Johannes Schindelin
When we access IPv6-related functions, we load the corresponding system
library using the `LoadLibrary()` function, which is not the recommended
way to load system libraries.
In practice, it does not make a difference: the `ws2_32.dll` library
containing the IPv6 functi
The search order for DLLs on Windows is a bit funny, and for system
libraries, it is recommended to use a strict search path.
In practice, this should not make a difference, as the library has been
loaded into memory already, and therefore the LoadLibrary() call would just
return the handle instea
From: Karsten Blees
fstat() is the only stat-related CRT function for which we don't have a
full replacement yet (and thus the only reason to stick with MSVCRT's
'struct stat' definition).
Fully implement fstat(), in preparation of implementing a POSIX 2013
compatible 'struct stat' with nanoseco
From: Karsten Blees
We no longer use any of MSVCRT's stat-functions, so there's no need to
stick to a CRT-compatible 'struct stat' either.
Define and use our own POSIX-2013-compatible 'struct stat' with nanosecond-
precision file times.
Note: This can cause performance issues when using Git var
From: Johannes Schindelin
In our fstat() emulation, we convert the file metadata from Win32 data
structures to an emulated POSIX structure.
To structure the code better, let's factor that part out into its own
function.
Note: it would be tempting to try to unify this code with the part of
do_ls
1 - 100 of 114 matches
Mail list logo