Re: [RFC] [GSoC] Draft of Proposal for GSoC

2014-03-21 Thread Brian Bourn
On Fri, Mar 21, 2014 at 2:07 PM, Jeff King wrote: > On Fri, Mar 21, 2014 at 02:03:41PM -0400, Brian Bourn wrote: > >> > What do they do, what does the caller expect to see (do they get >> > something as return values? do they expect some side effects?)? >> >

Re: [RFC] [GSoC] Draft of Proposal for GSoC

2014-03-21 Thread Brian Bourn
On Fri, Mar 21, 2014 at 1:45 PM, Junio C Hamano wrote: > Brian Bourn writes: > >> Something like this? >> >> Sample api calls >> Add_Opt_Group() >> Parse_with_contains() >> Parse_with_merged() >> Parse_with_no_merged() >> Parse_with_format

Re: [RFC] [GSoC] Draft of Proposal for GSoC

2014-03-21 Thread Brian Bourn
Parts of v2, once again, i'd love some more comments on what I've rewritten On Fri, Mar 21, 2014 at 1:42 AM, Jeff King wrote: > On Thu, Mar 20, 2014 at 02:15:29PM -0400, Brian Bourn wrote: > >> Going through the annals of the listserve thus far I've found a few >&g

Re: [RFC] [GSoC] Draft of Proposal for GSoC

2014-03-20 Thread Brian Bourn
Hello again, Please it would be very helpful for me to get some comments on this proposal I would be very grateful towards anyone who could take some time to look at it, even if it's just the wording. Regards, Brian Bourn On Thu, Mar 20, 2014 at 2:15 PM, Brian Bourn wrote: > Hi all,

[RFC] [GSoC] Draft of Proposal for GSoC

2014-03-20 Thread Brian Bourn
lpful feedback as when I submitted my Microproject. My name is Brian Bourn, I'm currently a computer engineering student at Columbia university in the city of New York. I've used git since my freshman year however this past week has been my first time attempting to contribute to the project,

[GSoC] Choosing a Project Proposal

2014-03-19 Thread Brian Bourn
ortant. Thanks for the Help, Brian Bourn -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 2/2][GSoC] diff-no-index: replace manual "."/".." check with is_dot_or_dotdot()

2014-03-19 Thread Brian Bourn
Signed-off-by: Brian Bourn --- Part 2 of my submission for GSoC diff-no-index.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/diff-no-index.c b/diff-no-index.c index ec51106..c554691 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -15,6 +15,7 @@ #include &quo

[PATCH v3 1/2][GSoC] diff-no-index: rename read_directory()

2014-03-19 Thread Brian Bourn
ory step, rename the local read_directory() to avoid the collision. Signed-off-by: Brian Bourn --- Part 1 of my submission for GSoC diff-no-index.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 8e10bff..ec51106 100644 --- a/d

[PATCH v2 2/2] [GSoC] diff:use is_dot_or_dotdot() in code

2014-03-18 Thread Brian Bourn
From: Brian Bourn Subject: replace manual "."/".." check with is_dot_or_dotdot() Signed-off-by: Brian Bourn --- Part 2 of my GSoC submission where the actual change is made diff-no-index.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/diff-no-index

[PATCH v2 1/2] [GSoC] diff: rename read_directory()

2014-03-18 Thread Brian Bourn
From: Brian Bourn It is desirable to replace manual checking of "." or ".." in diff-no-index.c with is_dot_or_dotdot(), which is defined in dir.h. However, dir.h declares a read_directory which conflicts with a (different) static read_directory() defined in in diff-no-index

[PATCH] [GSoC 2014]diff: Imported dir.h and renamed read_directory()

2014-03-18 Thread Brian Bourn
this was done in order to implement the GSoC Micro project for diff-no-index.c this is the first patch importing dir.h, for the use of is_dot_or_dotdot(), and renaming read_directory() to read_directory_contents() in order to deal with the conflicting function in dir.h Signed-off-by: Brian Bourn