[PATCH v3 7/8] t0021/rot13-filter: add capability functions

2017-11-10 Thread Christian Couder
ose changes, we can still require a set of capabilities, and die if one of them is not supported. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 58 ++--- 1 file changed, 45 insertions(+), 13 deletions(-) diff --git a/t/t0021/rot13-filt

[PATCH v3 6/8] t0021/rot13-filter: refactor checking final lf

2017-11-10 Thread Christian Couder
As checking for a lf character at the end of a buffer will be useful in another function, let's refactor this functionality into a small remove_final_lf_or_die() helper function. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 16 1 file changed, 12 inser

[PATCH v3 5/8] t0021/rot13-filter: add packet_initialize()

2017-11-10 Thread Christian Couder
Let's refactor the code to initialize communication into its own packet_initialize() function, so that we can reuse this functionality in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 26 -- 1 file changed, 16 insertions(+

[PATCH v3 3/8] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-11-10 Thread Christian Couder
Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder --- t/t

[PATCH v3 4/8] t0021/rot13-filter: improve error message

2017-11-10 Thread Christian Couder
If there is no new line at the end of something it receives, the packet_txt_read() function die()s, but it's difficult to debug without much context. Let's give a bit more information when that happens. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 3 ++- 1 file

[PATCH v3 2/8] t0021/rot13-filter: refactor packet reading functions

2017-11-10 Thread Christian Couder
n a common case. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index 4b2d9087d4..b1909699f4 100644 --- a/t/t0021/rot13-fi

[PATCH v3 0/8] Create Git/Packet.pm

2017-11-10 Thread Christian Couder
70916080731.13925-1-chrisc...@tuxfamily.org/ They are also available in the following branches: https://github.com/chriscool/git/commits/gl-external-odb12 https://github.com/chriscool/git/commits/gl-external-odb22 https://github.com/chriscool/git/commits/gl-external-odb61 https://github.com/chri

[PATCH v3 1/8] t0021/rot13-filter: fix list comparison

2017-11-10 Thread Christian Couder
not what we want. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index ad685d92f8..4b2d9087d4 100644 --- a/t/t0021/rot13-filter.pl

Re: [RFC PATCH] rebisect: add script for easier bisect log editing

2017-11-08 Thread Christian Couder
>> +git bisect replay "$GIT_BISECT_LOG_TMP" >> +rm -f "$GIT_BISECT_LOG_TMP" While at it, is there a reason for the -f option above?

Re: [RFC PATCH] rebisect: add script for easier bisect log editing

2017-11-08 Thread Christian Couder
On Wed, Nov 8, 2017 at 2:59 PM, Adam Dinwoodie wrote: > Add a short script, vaguely inspired by `git rebase --interactive`, to > ease the process described in the `git bisect` documentation of saving > off a bisect log, editing it, then replaying it. Nice idea. > Signed-off-by: Adam Dinwoodie >

Re: [PATCH v2 2/8] t0021/rot13-filter: refactor packet reading functions

2017-11-06 Thread Christian Couder
On Tue, Nov 7, 2017 at 2:15 AM, Junio C Hamano wrote: > Christian Couder writes: > >> +sub packet_required_key_val_read { >> + my ( $key ) = @_; >> + my ( $res, $buf ) = packet_txt_read(); >> + unless ( $res == -1 or ( $buf =~ s/^$key=// and $buf ne 

[PATCH v2 5/8] t0021/rot13-filter: add packet_initialize()

2017-11-05 Thread Christian Couder
Let's refactor the code to initialize communication into its own packet_initialize() function, so that we can reuse this functionality in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 26 -- 1 file changed, 16 insertions(+

[PATCH v2 6/8] t0021/rot13-filter: refactor checking final lf

2017-11-05 Thread Christian Couder
As checking for a lf character at the end of a buffer will be useful in another function, let's refactor this functionality into a small remove_final_lf_or_die() helper function. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 14 +++--- 1 file changed, 11 insertions(

[PATCH v2 3/8] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-11-05 Thread Christian Couder
Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder --- t/t

[PATCH v2 7/8] t0021/rot13-filter: add capability functions

2017-11-05 Thread Christian Couder
ose changes, we can still require a set of capabilities, and die if one of them is not supported. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 58 ++--- 1 file changed, 45 insertions(+), 13 deletions(-) diff --git a/t/t0021/rot13-filt

[PATCH v2 4/8] t0021/rot13-filter: improve error message

2017-11-05 Thread Christian Couder
If there is no new line at the end of something it receives, the packet_txt_read() function die()s, but it's difficult to debug without much context. Let's give a bit more information when that happens. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 3 ++- 1 file

[PATCH v2 0/8] Create Git/Packet.pm

2017-11-05 Thread Christian Couder
its/gl-external-odb373 https://github.com/chriscool/git/commits/gl-external-odb411 Christian Couder (8): t0021/rot13-filter: fix list comparison t0021/rot13-filter: refactor packet reading functions t0021/rot13-filter: improve 'if .. elsif .. else' style t0021/rot13-filter: improve er

[PATCH v2 1/8] t0021/rot13-filter: fix list comparison

2017-11-05 Thread Christian Couder
not what we want. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index ad685d92f8..4b2d9087d4 100644 --- a/t/t0021/rot13-filter.pl

[PATCH v2 2/8] t0021/rot13-filter: refactor packet reading functions

2017-11-05 Thread Christian Couder
out in a common case. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index 4b2d9087d4..c025518c0a 100644 --- a/t/t0021/rot13-

[PATCH v2 8/8] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

2017-11-05 Thread Christian Couder
And while at it let's simplify t0021/rot13-filter.pl by using Git/Packet.pm. This will make it possible to reuse packet related functions in other test scripts. Signed-off-by: Christian Couder --- perl/Git/Packet.pm | 168 perl/Mak

Re: [PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-11-05 Thread Christian Couder
On Sun, Oct 22, 2017 at 2:58 AM, Junio C Hamano wrote: > Christian Couder writes: > >> To make it possible in a following commit to move packet >> reading and writing functions into a Packet.pm module, >> let's refactor these functions, so they don't handle &g

Re: [PATCH 5/6] t0021/rot13-filter: add capability functions

2017-11-04 Thread Christian Couder
On Sun, Oct 22, 2017 at 3:46 AM, Junio C Hamano wrote: > Christian Couder writes: > >> Add functions to help read and write capabilities. >> These functions will be reused in following patches. > > One more thing that is more noteworthy (read: do not forget to > desc

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-29 Thread Christian Couder
Hi, On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote: > I've queued this from Dscho; please take it into consideration when > you reroll. Yeah, I was planning to add something like that, though in Dscho's first email the patch was adding: +modules += Git/Packet and now it's adding: > +mo

Re: [PATCH 4/6] t0021/rot13-filter: add packet_initialize()

2017-10-26 Thread Christian Couder
On Fri, Oct 27, 2017 at 4:57 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> It is fine to leave the original code broken at this step while we >> purely move the lines around, and hopefully this will be corrected >> in a later step in the series (I am responding as I read on, so I do >>

[PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-10-19 Thread Christian Couder
To make it possible in a following commit to move packet reading and writing functions into a Packet.pm module, let's refactor these functions, so they don't handle printing debug output and exiting. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 12 1 fi

[PATCH 0/6] Create Git/Packet.pm

2017-10-19 Thread Christian Couder
al-odb239 https://github.com/chriscool/git/commits/gl-external-odb373 https://github.com/chriscool/git/commits/gl-external-odb411 Christian Couder (6): t0021/rot13-filter: refactor packet reading functions t0021/rot13-filter: improve 'if .. elsif .. else' style t0021/rot13-filter: improve er

[PATCH 4/6] t0021/rot13-filter: add packet_initialize()

2017-10-19 Thread Christian Couder
Let's refactor the code to initialize communication into its own packet_initialize() function, so that we can reuse this functionality in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 20 +--- 1 file changed, 13 insertions(+), 7 dele

[PATCH 6/6] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

2017-10-19 Thread Christian Couder
And while at it let's simplify t0021/rot13-filter.pl by using Git/Packet.pm. This will make it possible to reuse packet related functions in other test scripts. Signed-off-by: Christian Couder --- perl/Git/Packet.pm | 118 t/t0021/

[PATCH 2/6] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-10-19 Thread Christian Couder
Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder --- t/t

[PATCH 3/6] t0021/rot13-filter: improve error message

2017-10-19 Thread Christian Couder
If there is no new line at the end of something it receives, the packet_txt_read() function die()s, but it's difficult to debug without much context. Let's give a bit more information when that happens. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 3 ++- 1 file

[PATCH 5/6] t0021/rot13-filter: add capability functions

2017-10-19 Thread Christian Couder
Add functions to help read and write capabilities. These functions will be reused in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/t/t0021/rot13

Re: [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script

2017-10-18 Thread Christian Couder
On Wed, Oct 18, 2017 at 12:58 PM, Kevin Daudt wrote: > On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote: >> diff --git a/t/perf/run b/t/perf/run >> index beb4acc0e428d..1e7c2a59e45dc 100755 >> --- a/t/perf/run >> +++ b/t/perf/run >> @@

Re: git-clone causes out of memory

2017-10-13 Thread Christian Couder
On Fri, Oct 13, 2017 at 12:37 PM, Mike Hommey wrote: > On Fri, Oct 13, 2017 at 12:26:46PM +0200, Christian Couder wrote: >> >> After cloning it with -n, there is the following "funny" situation: >> >> $ time git rev-list HEAD >&g

Re: git-clone causes out of memory

2017-10-13 Thread Christian Couder
On Fri, Oct 13, 2017 at 12:06 PM, Mike Hommey wrote: > On Fri, Oct 13, 2017 at 12:51:58PM +0300, Constantine wrote: >> There's a gitbomb on github. It is undoubtedly creative and funny, but since >> this is a bug in git, I thought it'd be nice to report. The command: >> >> $ git clone https:

Re: [PATCH 07/18] sha1_file: support lazily fetching missing objects

2017-10-12 Thread Christian Couder
On Thu, Oct 12, 2017 at 4:42 PM, Christian Couder wrote: > > Instead of adding labels and gotos, I would suggest adding a new > function like the following does on top of your changes: Sorry for the usual Gmail related problems. You can find the patch and a further refactoring tha

Re: [PATCH 07/18] sha1_file: support lazily fetching missing objects

2017-10-12 Thread Christian Couder
On Fri, Sep 29, 2017 at 10:11 PM, Jonathan Tan wrote: > diff --git a/sha1_file.c b/sha1_file.c > index b4a67bb83..77aa0ffdf 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -29,6 +29,7 @@ > #include "mergesort.h" > #include "quote.h" > #include "packfile.h" > +#include "fetch-object.h" > >

Re: [PATCH][Outreachy] New git config variable to specify string that will be automatically passed as --push-option

2017-10-11 Thread Christian Couder
On Thu, Oct 12, 2017 at 3:21 AM, Junio C Hamano wrote: > "Thais D. Braz" writes: > >> --- >> Documentation/git-push.txt | 3 +++ >> builtin/push.c | 9 - >> 2 files changed, 11 insertions(+), 1 deletion(-) > > Can somebody explain what is going on? > > I am guessing that Thai

[ANNOUNCE] Git Rev News edition 32

2017-10-11 Thread Christian Couder
Hi everyone, The 32st edition of Git Rev News is now published: https://git.github.io/rev_news/2017/10/11/edition-32/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Draft of Git Rev News edition 32

2017-10-09 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-32.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: git send-email does not work with Google anymore?!

2017-10-06 Thread Christian Couder
Hi, On Thu, Oct 5, 2017 at 12:52 PM, Lars Schneider wrote: > Of couse I tried to log in via web browser etc. Does anyone else use > Google as SMTP server? If yes, does it work for you? As I wrote at the top of: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@ma

Re: [RFC PATCH 0/4] interpret-trailers: introduce "move" action

2017-10-06 Thread Christian Couder
On Fri, Oct 6, 2017 at 2:39 PM, Paolo Bonzini wrote: > On 06/10/2017 14:33, Christian Couder wrote: >> Ok. I think you might want something called for example >> "replaceIfIdenticalClose" where "IdenticalClose" means: "there is a >> trailer with the s

Re: [RFC PATCH 0/4] interpret-trailers: introduce "move" action

2017-10-06 Thread Christian Couder
On Fri, Oct 6, 2017 at 12:40 PM, Paolo Bonzini wrote: > On 06/10/2017 12:30, Christian Couder wrote: >> Did you try using `--where end --if-exists replace --trailer "$sob"`? > > Yes, it's a different behavior; "--if-exists replace" matches on others'

Re: [RFC PATCH 0/4] interpret-trailers: introduce "move" action

2017-10-06 Thread Christian Couder
On Thu, Oct 5, 2017 at 3:22 PM, Paolo Bonzini wrote: > The purpose of this action is for scripts to be able to keep the > user's Signed-off-by at the end. For example say I have a script > that adds a Reviewed-by tag: > > #! /bin/sh > them=$(git log -i -1 --pretty='format:%an <%ae>' --aut

Re: Security of .git/config and .git/hooks

2017-10-03 Thread Christian Couder
Hi, On Tue, Oct 3, 2017 at 1:45 AM, Jonathan Nieder wrote: > Proposed fix: because of case (1), I would like a way to tell Git to > stop trusting any files in .git. That is: > > 1. Introduce a (configurable) list of "safe" configuration items that > can be set in .git/config and don't resp

Re: [PATCH v6 09/40] Add initial external odb support

2017-10-03 Thread Christian Couder
On Fri, Sep 29, 2017 at 10:36 PM, Jonathan Tan wrote: > On Wed, 27 Sep 2017 18:46:30 +0200 > Christian Couder wrote: >> I don't think single-shot processes would be a huge burden, because >> the code is simpler, and because for example for filters we already >> have

Re: [PATCH v6 00/40] Add initial experimental external ODB support

2017-10-02 Thread Christian Couder
On Mon, Oct 2, 2017 at 4:18 PM, Ben Peart wrote: > > On 9/16/2017 4:06 AM, Christian Couder wrote: > > - Patch 1/40 is a small code cleanup that I already sent to the >> >>mailing list but may be removed in the end due to ongoing work >>on &qu

Re: [PATCH 00/18] Partial clone (from clone to lazy fetch in 18 patches)

2017-10-02 Thread Christian Couder
On Fri, Sep 29, 2017 at 10:11 PM, Jonathan Tan wrote: > These patches are also available online: > https://github.com/jonathantanmy/git/commits/partialclone3 > > (I've announced it in another e-mail, but am now sending the patches to the > mailing list too.) > > Here's an update of my work so far.

Re: [PATCH Outreachy] mru: use double-linked list from list.h

2017-09-29 Thread Christian Couder
On Fri, Sep 29, 2017 at 9:23 AM, Jeff King wrote: > On Fri, Sep 29, 2017 at 09:18:11AM +0200, Christian Couder wrote: > >> As we use the "prepare_packed_git_run_once" static, this function will >> only be called only once when packed_git_mru has not yet been >>

Re: [PATCH Outreachy] mru: use double-linked list from list.h

2017-09-29 Thread Christian Couder
On Fri, Sep 29, 2017 at 12:42 AM, Jeff King wrote: > On Thu, Sep 28, 2017 at 08:38:39AM +, Olga Telezhnaya wrote: > >> diff --git a/packfile.c b/packfile.c >> index f69a5c8d607af..ae3b0b2e9c09a 100644 >> --- a/packfile.c >> +++ b/packfile.c >> @@ -876,6 +876,7 @@ void prepare_packed_git(void)

Re: Help

2017-09-27 Thread Christian Couder
Hi, On Thu, Sep 28, 2017 at 3:21 AM, Nityananda wrote: > Hello, > I am new to this community. I am facing a problem while using the > "make" command inside the "t/" folder. > > The error is > > > "1..31 > Makefile:49: recipe for target 't5551-http-fetch-smart.sh' failed > make[1]: *** [t5551-http

Re: [PATCH v6 09/40] Add initial external odb support

2017-09-27 Thread Christian Couder
extension. I am ok to add one if this is needed, but I am not sure it is, as the repository format does not really change. > - I get compile errors when I "git am" these onto master. I think >'#include "config.h"' is needed in some places. It's strang

Re: [PATCH] [Outreachy] cleanup: use list.h in mru.h and mru.c

2017-09-27 Thread Christian Couder
mru.h and related code by reusing the double-linked list implementation from list.h instead of a custom one." could be a bit better. > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder , Jeff King > I think it's better if Peff is on another "Mentored-by: ...&q

Re: [PATCH v2 0/9] Teach 'run' perf script to read config files

2017-09-26 Thread Christian Couder
On Sun, Sep 24, 2017 at 9:59 AM, Junio C Hamano wrote: > Christian Couder writes: > >> (It looks like smtp.gmail.com isn't working anymore for me, so I am >> trying to send this using Gmail for the cover letter and Submitgit for >> the patches.) > > SubmitGi

[PATCH v2 3/9] perf/run: add GIT_PERF_DIRS_OR_REVS

2017-09-23 Thread Christian Couder
or directories whose Git versions should be tested. Signed-off-by: Christian Couder --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run index 41580ac6df44a..ad442fe64a828 100755 --- a/t/perf/run +++ b/t/perf/run @@ -113,6 +113,9 @@ get_va

[PATCH v2 6/9] perf/run: update get_var_from_env_or_config() for subsections

2017-09-23 Thread Christian Couder
As we will set some config options in subsections, let's teach get_var_from_env_or_config() to get the config options from the subsections if they are set there. Signed-off-by: Christian Couder --- t/perf/run | 32 1 file changed, 20 insertions(+), 12 dele

[PATCH v2 7/9] perf/run: add run_subsection()

2017-09-23 Thread Christian Couder
Let's actually use the subsections we find in the config file to run the perf tests separately for each subsection. Signed-off-by: Christian Couder --- t/perf/run | 47 +++ 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/t/perf/ru

[PATCH v2 8/9] perf/run: show name of rev being built

2017-09-23 Thread Christian Couder
It is nice for the user to not just show the sha1 of the current revision being built but also the actual name of this revision. Signed-off-by: Christian Couder --- t/perf/run | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index cb8687bfcf98d

[PATCH v2 9/9] perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/"

2017-09-23 Thread Christian Couder
tion name. The aggregate.perl, when it is run for a subsection, should then aggregate the results found in "test-results/$GIT_PERF_SUBSECTION/". Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 11 --- t/perf/perf-lib.sh| 1 + 2 files changed, 9 insertions(+), 3 deletion

[PATCH v2 2/9] perf/run: add get_var_from_env_or_config()

2017-09-23 Thread Christian Couder
the default value. Signed-off-by: Christian Couder --- t/perf/perf-lib.sh | 3 --- t/perf/run | 21 + 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index b50211b2591d1..2f88fc12a9b5c 100644 --- a/t/perf/perf

[PATCH v2 4/9] perf/run: add calls to get_var_from_env_or_config()

2017-09-23 Thread Christian Couder
These calls make it possible to have the make command or the make options in a config file, instead of in environment variables. Signed-off-by: Christian Couder --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run index ad442fe64a828..6bd15e701756b

[PATCH v2 5/9] perf/run: add get_subsections()

2017-09-23 Thread Christian Couder
This function makes it possible to find subsections, so that we will be able to run different tests for different subsections in a later commit. Signed-off-by: Christian Couder --- t/perf/run | 7 +++ 1 file changed, 7 insertions(+) diff --git a/t/perf/run b/t/perf/run index 6bd15e701756b

[PATCH v2 1/9] perf/run: add '--config' option to the 'run' script

2017-09-23 Thread Christian Couder
x27;--config' option. This variable is not used yet. It will be used in a following commit. Signed-off-by: Christian Couder --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index beb4acc0e428d..1e7c2a59e45dc 100755 --- a/t/perf/run

[PATCH v2 0/9] Teach 'run' perf script to read config files

2017-09-23 Thread Christian Couder
vements to be already valuable. Links ~ This patch series is also available here: https://github.com/chriscool/git/commits/perf-conf Links to the previous version of this series are: v1: https://github.com/chriscool/git/commits/perf-conf5 https://public-inbox.org/git/201707130650

[ANNOUNCE] Git Rev News edition 31

2017-09-20 Thread Christian Couder
Hi everyone, The 31st edition of Git Rev News is now published: https://git.github.io/rev_news/2017/09/20/edition-31/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: My first contribution

2017-09-19 Thread Christian Couder
Hi Olga, On Tue, Sep 19, 2017 at 8:44 AM, Оля Тележная wrote: > Hello Jeff, > I want to try myself into new role of a Git contributor. Welcome to Git! > All of the projects sound super interesting for me and I am ready to take > part in all of them, but the project "Unifying Git's format langua

Re: [PATCH] pack: make packed_git_mru global a value instead of a pointer

2017-09-17 Thread Christian Couder
On Sun, Sep 17, 2017 at 10:42 PM, Christian Couder wrote: > On Sun, Sep 17, 2017 at 10:17 PM, phionah bugosi wrote: >> Signed-off-by: phionah bugosi >> --- >> builtin/pack-objects.c | 5 +++-- >> cache.h| 7 --- >> list.h

Re: [PATCH] pack: make packed_git_mru global a value instead of a pointer

2017-09-17 Thread Christian Couder
On Sun, Sep 17, 2017 at 10:17 PM, phionah bugosi wrote: > Signed-off-by: phionah bugosi > --- > builtin/pack-objects.c | 5 +++-- > cache.h| 7 --- > list.h | 6 ++ > packfile.c | 12 ++-- > 4 files changed, 15 insertions(+), 15 dele

Draft of Git Rev News edition 31

2017-09-17 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-31.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

[PATCH v6 02/40] t0021/rot13-filter: refactor packet reading functions

2017-09-16 Thread Christian Couder
To make it possible in a following commit to move packet reading and writing functions into a Packet.pm module, let's refactor these functions, so they don't handle printing debug output and exiting. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 12 1 fi

[PATCH v6 03/40] t0021/rot13-filter: improve 'if .. elsif .. else' style

2017-09-16 Thread Christian Couder
Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder --- t/t

[PATCH v6 15/40] Add GIT_NO_EXTERNAL_ODB env variable

2017-09-16 Thread Christian Couder
This new environment variable will be used to perform git commands without involving any external odb mechanism. This makes it possible for example to create new blobs that will not be sent to an external odb even if the external odb supports "put_*" instructions. Signed-off-by: Christ

[PATCH v6 06/40] t0021/rot13-filter: add capability functions

2017-09-16 Thread Christian Couder
Add functions to help read and write capabilities. These functions will be reused in following patches. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/t/t0021/rot13

[PATCH v6 24/40] external-odb: add 'get_direct' support

2017-09-16 Thread Christian Couder
ave the same kind of mechanism to "put" objects into an external odb, where the odb helper would access blobs it wants to send to an external odb directly from files, but it would be strange to call that a fault-in mode too. Signed-off-by: Christian Couder --- external-odb.c | 21 ++

[PATCH v6 12/40] external odb: add 'put_raw_obj' support

2017-09-16 Thread Christian Couder
_raw_obj' is supported by an odb helper. This is not a great default, but let's leave it to following commits to tweak that. Signed-off-by: Christian Couder --- external-odb.c | 15 +++ external-odb.h | 2 ++ odb-helper.c | 43 ++- o

[PATCH v6 08/40] sha1_file: prepare for external odbs

2017-09-16 Thread Christian Couder
name less generic. Let's also split out 'sha1_file_name_alt()' from 'sha1_file_name()' and 'open_sha1_file_alt()' from 'open_sha1_file()', as we will need both of these new functions too. Helped-by: Jeff King Signed-off-by: Christian Couder --- cache.h |

[PATCH v6 13/40] external-odb: accept only blobs for now

2017-09-16 Thread Christian Couder
The mechanism to decide which blobs should be sent to which external object database will be very simple for now. If the external odb helper support any "put_*" instruction all the new blobs will be sent to it. Signed-off-by: Christian Couder --- external-odb.c | 4 1 file

[PATCH v6 00/40] Add initial experimental external ODB support

2017-09-16 Thread Christian Couder
s ~ This patch series is available here: https://github.com/chriscool/git/commits/external-odb Version 1, 2, 3, 4 and 5 are here: https://github.com/chriscool/git/commits/gl-external-odb12 https://github.com/chriscool/git/commits/gl-external-odb22 https://github.com/chriscool/git/commits/gl-externa

[PATCH v6 17/40] lib-httpd: pass config file to start_httpd()

2017-09-16 Thread Christian Couder
This makes it possible to start an apache web server with different config files. This will be used in a later patch to pass a config file that makes apache store external objects. Signed-off-by: Christian Couder --- t/lib-httpd.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH v6 27/40] Add t0450 to test 'get_direct' mechanism

2017-09-16 Thread Christian Couder
From: Ben Peart Signed-off-by: Ben Peart Signed-off-by: Christian Couder --- t/t0450-read-object.sh | 28 + t/t0450/read-object| 68 ++ 2 files changed, 96 insertions(+) create mode 100755 t/t0450-read-object.sh create

[PATCH v6 21/40] odb-helper: add odb_helper_get_raw_object()

2017-09-16 Thread Christian Couder
The existing odb_helper_get_object() is renamed odb_helper_get_git_object() and a new odb_helper_get_raw_object() is introduced to deal with external objects that are not in Git format. Signed-off-by: Christian Couder --- odb-helper.c | 113

[PATCH v6 20/40] lib-httpd: add apache-e-odb.conf

2017-09-16 Thread Christian Couder
This is an apache config file to test external object databases. It uses the upload.sh and list.sh cgi that have been added previously to make apache store external objects. Signed-off-by: Christian Couder --- t/lib-httpd/apache-e-odb.conf | 214 ++ 1

[PATCH v6 09/40] Add initial external odb support

2017-09-16 Thread Christian Couder
cript mode is supported, and only the 'have' and 'get_git_obj' instructions are supported. Helped-by: Jeff King Signed-off-by: Christian Couder --- Makefile| 2 + cache.h | 1 + external-odb.c | 113 externa

[PATCH v6 23/40] Add t0420 to test transfer to HTTP external odb

2017-09-16 Thread Christian Couder
This tests that an apache web server can be used as an external object database and store files in their native format instead of converting them to a Git object. Signed-off-by: Christian Couder --- t/t0420-transfer-http-e-odb.sh | 142 + 1 file changed

[PATCH v6 18/40] lib-httpd: add upload.sh

2017-09-16 Thread Christian Couder
This cgi will be used to upload objects to, or to delete objects from, an apache web server. This way the apache server can work as an external object database. Signed-off-by: Christian Couder --- t/lib-httpd.sh| 1 + t/lib-httpd/upload.sh | 45

[PATCH v6 35/40] clone: add 'initial' param to write_remote_refs()

2017-09-16 Thread Christian Couder
We want to make it possible to separate fetching remote refs into an initial part and a later part. To prepare for that, let's add an 'initial' boolean parameter to write_remote_refs() to tell this function if we are performing the initial part or not. Signed-off-by: C

[PATCH v6 36/40] clone: add --initial-refspec option

2017-09-16 Thread Christian Couder
initial fetch. Signed-off-by: Christian Couder --- builtin/clone.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 2e5d60521d..57cecd194c 100644 --- a/builtin/clone.c +++ b/builtin

[PATCH v6 34/40] Add Documentation/technical/external-odb.txt

2017-09-16 Thread Christian Couder
This describes the external odb mechanism's purpose and how it works. Helped-by: Ben Peart Signed-off-by: Christian Couder --- Documentation/technical/external-odb.txt | 342 +++ 1 file changed, 342 insertions(+) create mode 100644 Documentation/technical/ext

[PATCH v6 25/40] odb-helper: add 'script_mode' to 'struct odb_helper'

2017-09-16 Thread Christian Couder
0. Helpers defined using the existing "odb..scriptcommand" are marked with the 'script_mode' field set to 1. Implementation of the different capabilities/instructions in the new (sub-)process mode is left for following commits. Signed-off-by: Christian Couder --- external-

[PATCH v6 28/40] Add t0460 to test passing git objects

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0460-read-object-git.sh | 28 + t/t0460/read-object-git| 78 ++ 2 files changed, 106 insertions(+) create mode 100755 t/t0460-read-object-git.sh create mode 100755 t/t0460/read-object-git

[PATCH v6 39/40] Add t0430 to test cloning using bundles

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0430-clone-bundle-e-odb.sh | 85 +++ 1 file changed, 85 insertions(+) create mode 100755 t/t0430-clone-bundle-e-odb.sh diff --git a/t/t0430-clone-bundle-e-odb.sh b/t/t0430-clone-bundle-e-odb.sh new file mode 100755

[PATCH v6 29/40] odb-helper: add put_object_process()

2017-09-16 Thread Christian Couder
This adds the infrastructure to send objects to a sub-process handling the communication with an external odb. For now we only handle sending raw blobs using the 'put_raw_obj' instruction. Signed-off-by: Christian Couder --- odb-hel

[PATCH v6 40/40] Doc/external-odb: explain transfering objects and metadata

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/technical/external-odb.txt | 105 +++ 1 file changed, 105 insertions(+) diff --git a/Documentation/technical/external-odb.txt b/Documentation/technical/external-odb.txt index 58ec8a8145..76dd1e2e6c 100644 --- a

[PATCH v6 26/40] odb-helper: add init_object_process()

2017-09-16 Thread Christian Couder
From: Ben Peart This adds the infrastructure to launch and use long running sub-processes as external odb helpers. For now only the 'init' and 'get_direct' capabilities are supported with sub-processes. Signed-off-by: Christian Couder --- external-odb.c | 52 ---

[PATCH v6 31/40] odb-helper: add have_object_process()

2017-09-16 Thread Christian Couder
This adds the infrastructure to handle 'have' instructions in process mode. The answer from the helper sub-process should be like the output in script mode, that is lines like this: sha1 SPACE size SPACE type NEWLINE Signed-off-by: Christian Couder --- odb-hel

[PATCH v6 30/40] Add t0470 to test passing raw objects

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0470-read-object-http-e-odb.sh | 109 ++ t/t0470/read-object-plain | 83 + 2 files changed, 192 insertions(+) create mode 100755 t/t0470-read-object-http-e-odb.sh create mode 100755

[PATCH v6 37/40] clone: disable external odb before initial clone

2017-09-16 Thread Christian Couder
To make it possible to have the external odb mechanism only kick in after the initial part of a clone, we should disable it during the initial part of the clone. Let's do that by saving and then restoring the value of the 'use_external_odb' global variable. Signed-off-by: C

[PATCH v6 32/40] Add t0480 to test "have" capability and raw objects

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0480-read-object-have-http-e-odb.sh | 109 + t/t0480/read-object-plain-have | 103 +++ 2 files changed, 212 insertions(+) create mode 100755 t/t0480-read-object-have-http-e-odb.sh create

[PATCH v6 33/40] external-odb: use 'odb=magic' attribute to mark odb blobs

2017-09-16 Thread Christian Couder
To tell which blobs should be sent to the "magic" external odb, let's require that the blobs be marked using the 'odb=magic' attribute. Signed-off-by: Christian Couder --- external-odb.c | 22 -- external-odb.h

[PATCH v6 38/40] Add tests for 'clone --initial-refspec'

2017-09-16 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t0420-transfer-http-e-odb.sh | 7 + t/t0470-read-object-http-e-odb.sh | 7 + t/t0480-read-object-have-http-e-odb.sh | 7 + t/t5616-clone-initial-refspec.sh | 48 ++ 4 files changed, 69

[PATCH v6 22/40] pack-objects: don't pack objects in external odbs

2017-09-16 Thread Christian Couder
Objects managed by an external ODB should not be put into pack files. They should be transfered using other mechanism that can be specific to the external odb. Signed-off-by: Christian Couder --- builtin/pack-objects.c | 4 1 file changed, 4 insertions(+) diff --git a/builtin/pack

<    4   5   6   7   8   9   10   11   12   13   >