mds, nr, cmd_category_cmp);
for (i = 0; i < nr; i++) {
@@ -343,6 +352,9 @@ void list_all_cmds_help(void)
int nr = ARRAY_SIZE(command_list);
struct cmdname_help *cmds = command_list;
+ if (nr == 0)
+ BUG("empty command_list");
+
for (i = 0; i < nr; i++) {
struct cmdname_help *cmd = cmds + i;
This had a very dramatic effect on the test-suite, since every single
test file failed while sourcing 'test-lib.sh'. [The test for having
built git ('"$GIT_BUILD_DIR/git" >/dev/null') tries to output help,
because you haven't given a command, and hits BUG - core dump!]
I haven't tried this patch series yet (I will hopefully find some
time tonight), but it looks like it will fix the problem.
ATB,
Ramsay Jones
t;zzz
$ tail -3 zzz
{"gitweb", N_("Git web interface (web frontend to Git repositories)"),
CAT_ancillaryinterrogators, GROUP_NONE },
{"workflows", N_("An overview of recommended workflows with Git"),
CAT_guide, GROUP_NONE },
};
$ dash generate-cmdlist.sh command-list.txt >zzz
generate-cmdlist.sh: 73: generate-cmdlist.sh: Bad substitution
$ tail -3 zzz
static struct cmdname_help command_list[] = {
};
$
This leads to a very broken 'git help'.
ATB,
Ramsay Jones
On 10/04/18 21:22, Ramsay Jones wrote:
>
>
> On 10/04/18 20:35, Derrick Stolee wrote:
>> On 4/10/2018 3:21 PM, Ramsay Jones wrote:
>>>
>>> On 10/04/18 13:57, Derrick Stolee wrote:
>>>> On 4/9/2018 6:08 PM, Junio C Hamano wrote:
>>>&
On 10/04/18 20:35, Derrick Stolee wrote:
> On 4/10/2018 3:21 PM, Ramsay Jones wrote:
>>
>> On 10/04/18 13:57, Derrick Stolee wrote:
>>> On 4/9/2018 6:08 PM, Junio C Hamano wrote:
>>>> I guess we'd want a final cleaned-up round after all ;-) Thanks.
&g
y to current 'master', 'next' or 'pu'. I fixed
up a few patches, but just got bored ... ;-)
ATB,
Ramsay Jones
> SP builtin/commit-graph.c
> builtin/commit-graph.c:34:38: warning: Using plain integer as NULL pointer
299d304
< fast-import.c:303:40: warning: Using plain integer as NULL pointer
312a318
> SP t/helper/test-json-writer.c
315a322
> SP t/helper/test-print-larger-than-ssize.c
$
ATB,
Ramsay Jones
of
> leeway. So even if the pace of development speeds up or we have a
> quicker project, it still seems we have a pretty reasonable safety
> margin.
I didn't read the patches closely, but isn't it ~20,000 years?
Given that '#define GENERATION_NUMBER_MAX 0x3FFF', that is. ;-)
ATB,
Ramsay Jones
fast-import.c:301:40: warning: Using plain integer as NULL pointer
In order to suppress the warning, replace the '0' used to initialise the
'mp_block' field (of type 'struct mp_block *') with NULL.
Signed-off-by: Ramsay Jones
---
Hi Junio,
This was going to be
On 27/03/18 18:14, Jeff Hostetler wrote:
>
>
> On 3/27/2018 11:45 AM, Ramsay Jones wrote:
>>
>>
>> On 27/03/18 04:18, Ramsay Jones wrote:
>>> On 26/03/18 15:31, g...@jeffhostetler.com wrote:
>>>> From: Jeff Hostetler
>>>>
>>
On 27/03/18 04:18, Ramsay Jones wrote:
> On 26/03/18 15:31, g...@jeffhostetler.com wrote:
>> From: Jeff Hostetler
>>
> [snip]
>
> Thanks, this version fixes all issues I had (with the compilation
> and sparse warnings).
>
> [Was using UINT64_C(0x
On 26/03/18 18:04, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>>>> @@ -120,7 +120,7 @@ void jw_object_uint64(struct json_writer *jw, const
>>>> char *key, uint64_t value)
>>>>maybe_add_comma(jw);
>>>>
>>>>a
le encode such strings) in the future.
>
> The initial use for the json-writer routines is for generating telemetry
> data for executed Git commands. Later, we may want to use them in other
> commands, such as status.
>
> Helped-by: René Scharfe
> Helped-by
On 24/03/18 15:14, Ramsay Jones wrote:
>
>
> On 24/03/18 05:37, Wink Saville wrote:
>> In routines jw_object_uint64 and jw_object_double strbuf_addf is
>> invoked with strbuf_addf(&jw->json, ":%"PRIuMAX, value) where value
>> is a uint64_t. This caus
> + strbuf_addf(&jw->json, ":%"PRIu64, value);
In this code-base, that would normally be written as:
strbuf_addf(&jw->json, ":%"PRIuMAX, (uintmax_t) value);
ATB,
Ramsay Jones
r/test-json-writer.c:10:20: warning: symbol 'obj1' was not declared.
Should it be static?
$
I decided to use the UINT64_C(v) macro from , which is
a C99 feature, and will (hopefully) not be a problem.
ATB,
Ramsay Jones
-- >8 --
Subject: [PATCH] json-writer: fix up gcc and sparse w
eal0m0.104s
> user0m0.088s
> sys 0m0.016s
>
> [reverting 8b8dfd5132, going back to qsort]
> real0m1.193s
> user0m1.176s
> sys 0m0.016s
>
> So it's now a factor of 11. Yikes.
Thanks for looking into this, even if it was a wild
goose chase. :)
ATB,
Ramsay Jones
On 23/03/18 02:46, Jeff King wrote:
> On Fri, Mar 23, 2018 at 01:28:12AM +0000, Ramsay Jones wrote:
>
>>> Of the used heap after your patches:
>>>
>>> - ~40% of that is from packlist_alloc()
>>> - ~17% goes to "struct object"
>>>
much slower would it be if we
replaced the radix-sort with an in-place sort (e.g. heapsort).
I hacked up the patch below, just for fun. I don't have any
large repos (or enough disk space) to do any meaningful perf
tests, but I did at least compile it and it passes the test-suite.
(That is no gu
On 20/03/18 14:46, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Mon, 19 Mar 2018, Ramsay Jones wrote:
>
>> This series removes all 'self-initialised' variables (ie. var =
>> var;). This construct has been used to silence gcc
>> '-W[
On 20/03/18 04:36, Jeff King wrote:
> On Mon, Mar 19, 2018 at 05:56:11PM +0000, Ramsay Jones wrote:
>
[snip]
>> diff --git a/read-cache.c b/read-cache.c
>> index 2eb81a66b..49607ddcd 100644
>> --- a/read-cache.c
>> +++ b/read-cache.c
>> @@ -2104,13 +
On 20/03/18 04:32, Jeff King wrote:
> On Mon, Mar 19, 2018 at 05:53:09PM +0000, Ramsay Jones wrote:
>> If we now add a patch to remove all self-initialization, which would be the
>> first patch plus the obvious change to 'saved_namelen' in read-cache.c, then
>&
On 19/03/18 17:54, Ramsay Jones wrote:
>
> The 'self-initialised' variables construct (ie var = var;) has
> been used to silence gcc '-W[maybe-]uninitialized' warnings. This has,
> unfortunately, caused MSVC to issue 'uninitialized variable' warnings.
ew 'stripped_name'
boolean variable. We also take the opportunity to change the type
of 'saved_namelen' to 'unsigned int' to match ce->ce_namelen.
Signed-off-by: Ramsay Jones
---
read-cache.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff -
recursive.c: mrtree in merge() is not used before set", 2007-10-29).
3. fast-import.c:3023 'oe', see commit 85c62395b1 ("fast-import: let
importers retrieve blobs", 2010-11-28).
4. fast-import.c:3006 'oe', see commit 28c7b1f7b7 ("fast-import: add
as parameter of type 'long' which may
cause truncation of value [-Wabsolute-value]
25. config.c:790:21: warning: absolute value function 'labs' given an argument
of type 'intmax_t' (aka 'long long') but has parameter of type 'long' which may
cause t
ns of clang and gcc ('different' if you count 64-bit and 32-bit
compilers with the same version number as different!)
However, I can tell you that clang version 3.4 and 3.8.0 don't
support -Og, but clang version 5.0.1 does.
ATB,
Ramsay Jones
t; --first-parent --oneline master..pu" would show where the tip of the
> topic is.
BTW, thanks for adding the 'SQUASH??? sparse fixes' on top of that
branch - sparse is now quiet on the 'pu' branch. (The same can't
be said of static-check.pl, but that is a different issue. ;-) ).
Thanks!
ATB,
Ramsay Jones
On 14/03/18 22:15, Jeff King wrote:
> On Wed, Mar 14, 2018 at 09:56:06PM +0000, Ramsay Jones wrote:
>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Junio,
>>
>> I happened to be building git on an _old_ laptop earlier this evening
>> and gcc com
Signed-off-by: Ramsay Jones
---
Hi Junio,
I happened to be building git on an _old_ laptop earlier this evening
and gcc complained, thus:
CC http.o
http.c:77:20: warning: ‘curl_no_proxy’ defined but not used
[-Wunused-variable]
static const char *curl_no_proxy
ain integer as a NULL pointer, in builtin/commit-
graph.c, and the 'commit_graph' symbol should be file-local, in
commit-graph.c).
Thanks!
ATB,
Ramsay Jones
-- >8 --
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 62ac26e44..855df66bd 100644
--- a/builtin/commit-graph
On 02/03/18 17:19, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Junio, do you want me to re-roll, or would you mind tweaking the
>> commit message while queueing?
>
> Perfect timing ;-) I was about to get to these two patches. Here
> is what is queued.
On 02/03/18 03:59, Jonathan Nieder wrote:
> Hi,
>
> Ramsay Jones wrote:
>
>> Commit fcfba37337 ('ref-filter: make "--contains " less chatty if
>> is invalid', 2018-02-23) added the add_str_to_commit_list()
>> function, which causes sparse to
Commit fcfba37337 ('ref-filter: make "--contains " less chatty if
is invalid', 2018-02-23), removed the last use of the callback
function parse_opt_commits(). Remove this function declaration and
definition, since it is now dead code.
Signed-off-by: Ramsay Jones
---
par
, mark that function as static.
Signed-off-by: Ramsay Jones
---
ref-filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ref-filter.c b/ref-filter.c
index f375e7670..69bf7b587 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -2000,7 +2000,7 @@ static void do_merge_f
quite noisy with regard to sparse
and static-check.pl at the moment).
These patches were developed on top of 'next', however, I also tested
them on top of commit fcfba37337 directly. (Note, this is branch
'ps/contains-id-error-message' merged at commit 9623d6817b).
Ramsay Jo
, it's a while since I looked at that code, but I don't think
you have a commit with two trees - the second 'tree ' line
is just part of the commit message, isn't it?
ATB,
Ramsay Jones
On 28/02/18 00:42, SZEDER Gábor wrote:
> On Wed, Feb 28, 2018 at 12:47 AM, Ramsay Jones
> wrote:
>>
>>
>> On 27/02/18 22:05, Junio C Hamano wrote:
>>> Junio C Hamano writes:
>>>
>>>> OK, somehow I had the version from Ramsay on a topic
the cover letter, I wasn't too sure that
I had passed that patch along correctly. ;-)
> so I'll use that version. We still want sign-off from Szeder,
> though.
I would be happy with either version, or maybe Szeder would like
to tweak the commit message. In any event, it would be good to
get sign-off from Szeder.
Thanks!
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/commit-graph' branch, could you
please squash this into the relevant patches (corresponding to
commits 0fd2d95ee6 ["commit-graph: implement --set-latest"],
a33b9b79ff ["commit-graph: impleme
ctive invocation of sort at the end of a grep pipeline.
Instead of fixing these minor problems in verify_stderr(), we take
the simpler approach of directly searching the error file, using
test_i18ngrep, for the specific message(s) we expect. (The only
minor downside is that we would not notice a
content
being compared is not subject to i18n anyway.
Signed-off-by: Ramsay Jones
---
t/t4151-am-abort.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/t/t4151-am-abort.sh b/t/t4151-am-abort.sh
index 9473c2779..16432781d 100755
--- a/t/t4151-am-abort.sh
+++ b/t/t4151-am
s required. Thanks!]
[1]
https://public-inbox.org/git/%3c20180213100437.15685-1-szeder@gmail.com%3E/
Ramsay Jones (2):
t4151: consolidate multiple calls to test_i18ngrep
t5536: simplify checking of messages output to stderr
t/t4151-am-abort.sh| 5 ++---
t/t5536-fetch-conflic
On 18/02/18 22:55, Ramsay Jones wrote:
>
>
> On 16/02/18 14:55, Adam Dinwoodie wrote:
>> On 12 February 2018 at 08:08, Olga Telezhnaya wrote:
>>> Add some tests for new formatting atoms from ref-filter.
>>> Some of new atoms are supported automatically,
>>
-
... and now this test passes on cygwin (and the SANITIZE build on Linux).
Of course, this is not a real fix, since this has probably only changed
the stack-overflow into an un-diagnosed heap-overflow bug! ;-)
However, the above should provide enough info for someone more familiar
with the code to implement a correct fix.
[BTW, the symbol that should be marked static is: cat_file_info, in file
ref-filter.c, line 103.]
ATB,
Ramsay Jones
On 12/02/18 20:18, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Attempting to grep the output of test_i18ngrep will not work under a
>> poison build, since the output is (almost) guaranteed not to have the
>> string you are looking for. In this case, the outpu
tual limit used (-fmemcpy-max-count=COUNT), rather than a hard-coded
limit of 10.
In order to suppress the warning, add a target for pack-revindex.sp that
adds the '-Wno-memcpy-max-count' option to the SPARSE_FLAGS variable.
Signed-off-by: Ramsay Jones
---
Makefile | 2 ++
1 file c
32 header files).
In addition, the '-Wno-one-bit-signed-bitfield' option can be removed,
since the warning suppressed by that option was only provoked by a WIN32
header file.
Signed-off-by: Ramsay Jones
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.mak.
These patches are based on v2.16, but a test merge to master, next and
pu are all clean.
Ramsay Jones (2):
config.mak.uname: remove SPARSE_FLAGS setting for cygwin
Makefile: suppress a sparse warning for pack-revindex.c
Makefile | 2 ++
config.mak.uname | 1 -
2 files changed, 2
ng up unexpectedly' warning message. Use a regular 'grep -E' to
replace the call to test_i18ngrep in the filter pipeline.
Also, remove a useless invocation of 'sort' as the final element of the
pipeline.
Signed-off-by: Ramsay Jones
---
t/t5536-fetch-conflicts.sh | 2 +-
1 f
content
being compared is not subject to i18n anyway.
Signed-off-by: Ramsay Jones
---
t/t4151-am-abort.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/t/t4151-am-abort.sh b/t/t4151-am-abort.sh
index 9473c2779..16432781d 100755
--- a/t/t4151-am-abort.sh
+++ b/t/t4151-am
r, I can rebuild these patches on top of 'next' and re-submit. Just
let me know.
Note that I replaced an 'test_i18ngrep -E' with 'grep -E' rather than egrep.
(the grep man page claims that egrep, fgrep and rgrep are deprecated, but I
think that has been the case for as l
OPTION_INTEGER, 'n', NULL, &filter.lines, N_("n"),
> @@ -386,6 +391,7 @@ int cmd_tag(int argc, const char **argv, const char
> *prefix)
> OPT_CALLBACK('m', "message", &msg, N_("message"),
>N_("tag message"), parse_msg_arg),
> OPT_FILENAME('F', "file", &msgfile, N_("read message from
> file")),
> + OPT_BOOL('e', "edit", &edit_flag, N_("force edit of commit")),
s/commit/tag message/ ?
ATB,
Ramsay Jones
en extract it elsewhere" is truly necessary.
> IOW, why isn't it sufficient to do this instead, for example?
>
> umask 022 && cp -r po/build/locale/. '$(DESTDIR_SQ)$(localedir_SQ)'
Given the above, I suspect that (for some unknown reason), a verbose
'listing' of the locale files is required ... :-D
ATB,
Ramsay Jones
the commit message to a
> different file and running the hook. Using a different file means that
> if the commit is cancelled the original message file is
> unchanged. Also move the checks for an empty commit so the order
> matches 'git commit'.
>
> Reported-by: Dm
Signed-off-by: Ramsay Jones
---
Hi Phillip,
If you need to re-roll your 'pw/sequencer-in-process-commit' branch, could
you please squash this into the relevant patch (commit da96adcf5a,
"sequencer: run 'prepare-commit-msg' hook", 2018-01-19).
Thanks.
ATB,
Ramsay
On 19/01/18 21:20, Jeff King wrote:
> On Fri, Jan 19, 2018 at 08:28:48PM +0000, Ramsay Jones wrote:
>
>>> diff --git a/remote.c b/remote.c
>>> index 4e93753e1..c18f9de7f 100644
>>> --- a/remote.c
>>> +++ b/remote.c
>>> @@ -11,6 +11,10 @@
>
ed (__TANDEM)
> +#define __attribute(a)
> +#endif
> +
Hmm, the only use of __attribute() I can find is in compat/regex/.
In particular, there is no use of __attribute() in regex.c.
[__attribute__() is used in regex.c]
Is this an old patch which is no longer required?
puzzled.
ATB,
Ramsay Jones
> enum map_direction { FROM_SRC, FROM_DST };
>
> static struct refspec s_tag_refspec = {
>
On 04/01/18 20:55, Johannes Schindelin wrote:
> On Tue, 2 Jan 2018, Ramsay Jones wrote:
[snip]
>> Also, when logged-in remotely it fails consistently, when logged-in
>> directly it passes consistently. :-D
>
> You are most likely hitting cmd.exe at some point there. In cmd.
Signed-off-by: Ramsay Jones
---
Hi Brandon,
If you need to re-roll your 'bw/protocol-v2' branch, could you please
squash this (or something like it) into the relevant patches. The first
hunk would go in commit 6ec1105192, "upload-pack: convert to a builtin",
2018-01-02)
Signed-off-by: Ramsay Jones
---
Hi Lars,
If you need to re-roll your 'ls/checkout-encoding' branch, could you
please squash this into the relevant patch (commit d5318db2d0,
"utf8: add function to detect prohibited UTF-16/32 BOM", 2017-12-31).
[yes, noticed by sparse].
On 02/01/18 15:32, Ramsay Jones wrote:
> On 02/01/18 11:36, Adam Dinwoodie wrote:
>> On Saturday 30 December 2017 at 02:40 pm +, Adam Dinwoodie wrote:
>>> On Saturday 30 December 2017 at 02:21 pm +, Ramsay Jones wrote:
[snip]
>> I'm not able to reproduce this
On 02/01/18 11:36, Adam Dinwoodie wrote:
> On Saturday 30 December 2017 at 02:40 pm +, Adam Dinwoodie wrote:
>> On Saturday 30 December 2017 at 02:21 pm +0000, Ramsay Jones wrote:
>>> Hi Junio, Adam,
>>>
>>> Just a quick note about the failure of the tes
c'/
... and so on, until:
$ ls -ld '//localhost/C$'
d---r-x---+ 1 TrustedInstaller TrustedInstaller 0 Oct 28 16:16
'//localhost/C$'/
$
Doing a quick web-search on '//localhost/C$' lead me to several posts which
seem to suggest the problem could be related to UAC filtering on remote
shares (and the fact that I am on Windows 10), along with a registry setting
for 'LocalAccountTokenFilterPolicy'. However, I have not had time to look
into any of that.
Adam, are you running the tests on Windows 10?
I have to go now, so I can't look at this further today. Just FYI.
ATB,
Ramsay Jones
tch-conflicts.sh (#3 and #6-7), which on a
very quick inspection seem to be due to this (ie your SQUASH commit
e5c5e24ad9).
For t4151 the test (both 3 & 6) is using test_i18ngrep on the output
of a previous test_i18ngrep, and t5536 is doing likewise in the
verify_stderr() helper function.
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Junio,
Could you please add (or squash) this on top of the 'ab/sha1dc-build'
branch, so that I can build with NO_DC_SHA1_SUBMODULE=NoThanks in my
config.mak.
[If I were to get a vote, I would vote no to the submodule. ;-) ]
Thanks!
ATB,
Ra
On 10/12/17 20:33, Ævar Arnfjörð Bjarmason wrote:
> On Sun, Dec 10, 2017 at 8:58 PM, Ramsay Jones
> wrote:
>> I noticed the revert of the 'ab/simplify-perl-makefile' branch on
>> top of 'pu'. So, I fired up my 32-bit Linux and attempted to see
>&
H.]
Sorry I couldn't help with this! :(
ATB,
Ramsay Jones
static keyword.
Signed-off-by: Ramsay Jones
---
Hi Junio,
Now that the 'pw/sequencer-in-process-commit' branch has
graduated to 'next', the static-check.pl script is barking on
that branch. This patch applies to the next (and pu) branches
without conflict. You mentioned that the p
Makefile with a different blob'. That commit was a 'last minute'
revert of a topic _prior_ to v2.0.0, which resulted in the _same_
blob as commit 47fbfded53. (i.e. a53f3a8326c2e62dc79bae7169d64137ac3dab20).
[I haven't been following this topic, so just ignore me if I have
misunderstood what the above was describing! :-D ]
ATB,
Ramsay Jones
On 06/12/17 21:07, Jeff Hostetler wrote:
>
>
> On 12/6/2017 12:39 PM, Ramsay Jones wrote:
>> Hi Jeff,
>>
>> commit f1862e8153 ("partial-clone: define partial clone settings
>> in config", 2017-12-05), which is part of your &
intentional and that, presumably, a future series will include
a call to this function.
Thanks!
ATB,
Ramsay Jones
On 29/11/17 01:35, brian m. carlson wrote:
> On Tue, Nov 28, 2017 at 03:01:19AM +0000, Ramsay Jones wrote:
>>
>> Commit 78a6766802 ("Integrate hash algorithm support with repo setup",
>> 2017-11-12) added a 'const struct git_hash_algo *hash_algo' fiel
since the '0' initializer
for the 'ignore_env:1' bit-field is interpreted as a NULL pointer (hence
the warning), and the final field (now with no initializer) receives a
default '0'.
Signed-off-by: Ramsay Jones
---
Hi Junio,
I don't recall Brian doing a
to using a tcl version of msgfmt in the first place!. ;-)
If a given platform does not have gettext/msgfmt, then you just
don't get an i18n-ed version of git. (no need for BYPASS_ ...).
Am I missing something?
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Thomas,
If you need to re-roll your 'tg/worktree-create-tracking' branch, could
you please squash this into the relevant patch (commit 6736ae9593,
"checkout: factor out functions to new lib file", 2017-11-22).
[noticed by sparse]
Thanks
On 21/11/17 01:16, Jonathan Nieder wrote:
> Hi,
>
> Ramsay Jones wrote:
>
>> If you need to re-roll your 'jh/object-filtering' branch, could you
>> please squash this (or something like it) into the relevant patch
>> (commit bf0aedcbe1, "list-ob
On 21/11/17 01:06, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Signed-off-by: Ramsay Jones
>> ---
>>
>> Hi Miklos,
>>
>> If you need to re-roll your 'mv/cherry-pick-s' branch, could you
>> please squash this into the relevant pat
we've decided to put it on hold for now. We'll keep it in our
> back pocket in case we need it in the future.
Since you are withdrawing the 'bp/fastindex' branch, I won't send the
patch to fix up the sparse warnings (unless you would like to see it
before you put it in your back pocket). ;-)
ATB,
Ramsay Jones
no callers, so we simply remove the (unused) definition.
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/object-filtering' branch, could you
please squash this (or something like it) into the relevant patch
(commit bf0aedcbe1, "list-objects: filter object
Signed-off-by: Ramsay Jones
---
Hi Miklos,
If you need to re-roll your 'mv/cherry-pick-s' branch, could you
please squash this into the relevant patch (commit 5ed75e2a3f,
"cherry-pick: don't forget -s on failure", 14-09-2017).
[noticed by sparse].
Thanks!
ATB,
Ramsa
it didn't immediately seem to be
related to the problem, along with the above errors, this may well
not be the culprit.
Just FYI.
ATB,
Ramsay Jones
On 17/11/17 19:49, Jeff Hostetler wrote:
>
>
> On 11/16/2017 2:57 PM, Ramsay Jones wrote:
>>
>>
>> On 16/11/17 18:12, Jeff Hostetler wrote:
>>> From: Jonathan Tan
>>>
>>> Introduce fetch-object, providing the ability to fetch one obj
nsport_set_option(transport, TRANS_OPT_NO_HAVES, "1");
> + transport_fetch_refs(transport, ref);
> +}
> diff --git a/fetch-object.h b/fetch-object.h
> new file mode 100644
> index 000..f371300
> --- /dev/null
> +++ b/fetch-object.h
> @@ -0,0 +1,6 @@
> +#ifndef FETCH_OBJECT_H
> +#define FETCH_OBJECT_H
> +
> +extern void fetch_object(const char *remote_name, const unsigned char *sha1);
> +
> +#endif
ATB,
Ramsay Jones
ich moves
code from builtin/commit.c to sequencer.[ch].
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/fsck-promisors' branch, could you
please squash this into the relevant patch (commit 1a4b4ca4e9,
"introduce fetch-object: fetch one promisor object", 02-11-2017).
[This silences a sparse warning].
On 08/11/17 22:34, Ramsay Jones wrote:
>
>
> On 08/11/17 20:36, Stefan Beller wrote:
>> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones
>> wrote:
>>
>>> t5300-pack-object.sh (Wstat: 256 Tests: 40
>&
On 08/11/17 20:36, Stefan Beller wrote:
> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones
> wrote:
>
>> t5300-pack-object.sh (Wstat: 256 Tests: 40
>> Failed: 2)
>
>> t5500-fetch-pack.sh (Wstat: 256 Tests:
st' failed
make: *** [test] Error 2
$
Looking at the first test failure in each file, the failures seems
to be related to the 'jh/partial-clone' branch.
Just FYI. Thanks.
ATB,
Ramsay Jones
nt to check for the pairs "--term-{good,old}" and
"--term-{bad,new}", so maybe this instead:
+ if (one_of(argv[i], "--term-good", "--term-old", NULL))
+ printf("%s\n", terms->term_good);
+ else if (one_of(argv[i], "--term-bad", "--term-new", NULL))
+ printf("%s\n", terms->term_bad);
+ else
> + error(_("BUG: invalid argument %s for 'git bisect
> terms'.\n"
> + "Supported options are: "
> + "--term-good|--term-old and "
> + "--term-bad|--term-new."), argv[i]);
> + }
> +
> + return 0;
> +}
> +
ATB,
Ramsay Jones
h_bisect_start())) {
> + error(_("You need to give me at least one %s and "
> + "%s revision. You can use \"git bisect %s\" "
> + "and \"git bisect %s\" for that.\n"),
> + voc[0], voc[1], voc[0], voc[1]);
... this is (arguably) easier to read:
+ vocab_bad, vocab_good, vocab_bad, vocab_good);
> + goto fail;
> + } else {
> + error(_("You need to start by \"git bisect start\". You "
> + "then need to give me at least one %s and %s "
> + "revision. You can use \"git bisect %s\" and "
> + "\"git bisect %s\" for that.\n"),
> + voc[1], voc[0], voc[1], voc[0]);
ditto
ATB,
Ramsay Jones
!has_term_file) {
> + if (one_of(cmd, "bad", "good", NULL)) {
> + free_terms(terms);
> + set_terms(terms, "bad", "good");
> + return write_terms(terms->term_bad, terms->term_good);
> + }
> + else if (one_of(cmd, "new", "old", NULL)) {
cuddle the else: '} else if (one_of()) {'
OR, simply remove the else.
ATB,
Ramsay Jones
rts of the code as
> well.
>
> Also introduce a function free_terms() to free the memory of `struct
> bisect_terms` and set_terms() to set the values of members in `struct
> bisect_terms`.
>
> Helped-by: Ramsay Jones
> Mentored-by: Lars Schneider
> Mentored-by: Christi
path_bisect_start(), 0) < 1)
> + return !printf(_("We are not bisecting.\n"));
I've no idea what this is about! If printf encounters an error, then
this will be equivalent to !-1. If printf does not encounter an error,
then this will be ! (whatever that may be, given that
the string is marked for translation).
I would suggest that you don't want to do that. ;-)
ATB,
Ramsay Jones
Signed-off-by: Ramsay Jones
---
Hi Jeff,
If you need to re-roll your 'jh/object-filtering' branch, could
you please squash this into the relevant commit (b87fd93d81,
"list-objects: filter objects in traverse_commit_list", 02-11-2017).
[This error was issued by sparse]
hen doing an
'git log --oneline' display which, naturally, puts focus on the
subject lines. ;-) ]
ATB,
Ramsay Jones
d test-suite run and, of course, t0021 ran
without problem this time. Hmm, I don't think I have time to chase
this down at the moment. I will keep your 'perl hypothesis' in mind
for next time, however.
Thanks.
ATB,
Ramsay Jones
On 11/10/17 23:15, Ramsay Jones wrote:
> Hi Adam,
>
> I had a test failure on the v2.15.0-rc1 build tonight.
> The test in question being t0021-conversion.sh #15
> ('required process filter should filter data'). I didn't
> have any test failures on v2.15.0-rc0,
lso, I ran this test by hand (well, in a shell loop) at
least 70 times tonight (after the test-suite run), without
any failures, so ... (unfortunately, I don't have a trash
directory to look at. :( )
I have just kicked off another full test-suite run.
Just a heads up! ;-)
ATB,
Ramsay Jones
On 03/10/17 04:51, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> On 02/10/17 14:44, Pranit Bauva wrote:
>> [snip]
>>> ...
>> Yes, I also meant to tidy that up by removing some, now
>> redundant, initialisation later in that function.
>>
>&g
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/find-unique-abbrev-optim' branch,
could you please squash this into the relevant patch (commit 3792c78ba0,
"test-list-objects: list a subset of object ids", 01-10-2017).
Thanks!
ATB,
Ramsay Jones
201 - 300 of 1047 matches
Mail list logo
