Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-17 Thread Quint Guvernator
2014-03-17 15:27 GMT-04:00 Eric Sunshine : > A quick (perhaps inaccurate) search of the mailing list shows that, of > the remaining "untaken" items, #10, 11, 12, 15, 16, and 18 have had > just one submission, and #13 had two, so we're okay. I am still working on #14: "Change fetch-pack.c:filter_re

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-17 Thread Eric Sunshine
On Mon, Mar 17, 2014 at 10:11 AM, Michael Haggerty wrote: > On 03/17/2014 08:31 AM, Junio C Hamano wrote: >> Eric Sunshine writes: >> >>> Perhaps it is time to mark this microproject as "taken" on the GSoC >>> page [2], along a fews others for which we have received multiple >>> submissions. > >

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-17 Thread Junio C Hamano
Michael Haggerty writes: > On 03/17/2014 08:31 AM, Junio C Hamano wrote: > >> So in short, yes it would have been nicer if we had more micros than >> candidates, but I do not think it was detrimental for the purpose of >> these micro exercises that multiple candidates ended up attempting >> the s

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-17 Thread Michael Haggerty
On 03/17/2014 08:31 AM, Junio C Hamano wrote: > Eric Sunshine writes: > >> Perhaps it is time to mark this microproject as "taken" on the GSoC >> page [2], along a fews others for which we have received multiple >> submissions. I just marked #8 as taken, as it's been beaten to death. I haven't

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-17 Thread Junio C Hamano
Eric Sunshine writes: > Perhaps it is time to mark this microproject as "taken" on the GSoC > page [2], along a fews others for which we have received multiple > submissions. > > [2]: > https://github.com/git/git.github.io/blob/master/SoC-2014-Microprojects.md I actually have been of multiple m

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-16 Thread Eric Sunshine
On Fri, Mar 14, 2014 at 12:54 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> On Thu, Mar 13, 2014 at 4:20 PM, Yao Zhao wrote: >>> Subject: [PATCH] GSoC Change multiple if-else statements to be table-driven >> >> It's a good idea to let reviewers kn

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-14 Thread Junio C Hamano
Eric Sunshine writes: > Thanks for the resubmission. Comments below. Thanks, Eric, for helping so many micro exercises. > On Thu, Mar 13, 2014 at 4:20 PM, Yao Zhao wrote: >> Subject: [PATCH] GSoC Change multiple if-else statements to be table-driven > > It's a good ide

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-13 Thread Eric Sunshine
Thanks for the resubmission. Comments below. On Thu, Mar 13, 2014 at 4:20 PM, Yao Zhao wrote: > Subject: [PATCH] GSoC Change multiple if-else statements to be table-driven It's a good idea to let reviewers know that this is attempt 2. Do so by saying [PATCH v2]. Your next one will be [

[PATCH] GSoC Change multiple if-else statements to be table-driven

2014-03-13 Thread Yao Zhao
Signed-off-by: Yao Zhao --- GSoC_MicroProject_#8 Hello Eric, Thanks for reviewing my code. I implemented table-driven method this time and correct the style problems indicated in review. Thank you, Yao branch.c | 72 1 file ch