Re: [PATCH] Geolocation support

2015-02-12 Thread Junio C Hamano
Alessandro Di Marco writes: > Junio C Hamano writes: > >> More importantly, adding non-essential stuff left and right will force >> third party Git reimplementations to pay attention to them and also >> will leave room for them to make mistakes when deciding what to >> propagate, what to drop an

Re: [PATCH] Geolocation support

2015-02-12 Thread Alessandro Di Marco
Junio C Hamano writes: > Ævar Arnfjörð Bjarmason writes: >> We've already told clients for a long time to ignore fields they >> don't know about, > Yes, but the reason that mechanism is there is not because we want to > add random cruft Git does not have to know about. It is to avoid > older

Re: [PATCH] Geolocation support

2015-02-09 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Mon, Feb 9, 2015 at 2:24 AM, Junio C Hamano wrote: >> In case I was not clear, I do not think it is likely for us to accept >> a patch that mucks with object header fields with this information. >> Have them in the log text and let UI interpret them. > > We'v

Re: [PATCH] Geolocation support

2015-02-09 Thread Ævar Arnfjörð Bjarmason
On Mon, Feb 9, 2015 at 2:24 AM, Junio C Hamano wrote: > In case I was not clear, I do not think it is likely for us to accept > a patch that mucks with object header fields with this information. > Have them in the log text and let UI interpret them. We've already told clients for a long time to

Re: [PATCH] Geolocation support

2015-02-08 Thread Junio C Hamano
In case I was not clear, I do not think it is likely for us to accept a patch that mucks with object header fields with this information. Have them in the log text and let UI interpret them. On Sun, Feb 8, 2015 at 4:03 PM, Alessandro Di Marco wrote: > Junio C Hamano writes: > >> I would personal

Re: [PATCH] Geolocation support

2015-02-08 Thread Alessandro Di Marco
Junio C Hamano writes: > I would personally find the "feature" cute, but > Wouldn't it be sufficient to treat this in a similar way as > references to tracker entries and references to other commit objects > in the text of the commit message body are treated by gitk and > friends? Just embed

Re: [PATCH] Geolocation support

2013-05-23 Thread Junio C Hamano
Antoine Pelisse writes: > I'm really not convinced this kind of changes should make it into > Junio's tree (of course, he's the only one to decide). I really > believe this is a very specific solution to a very specific problem > (that is not for me to judge if the problem is real). Bloating the

Re: [PATCH] Geolocation support

2013-05-23 Thread Alessandro Di Marco
Antoine Pelisse writes: On Thu, May 23, 2013 at 10:45 AM, Ramkumar Ramachandra wrote: > Alessandro Di Marco wrote: >> this is a hack I made a couple of years ago in order to store my current >> location in git commits (I travel a lot and being able to associate a >> place with

Re: [PATCH] Geolocation support

2013-05-23 Thread Antoine Pelisse
On Thu, May 23, 2013 at 10:45 AM, Ramkumar Ramachandra wrote: > Alessandro Di Marco wrote: >> this is a hack I made a couple of years ago in order to store my current >> location in git commits (I travel a lot and being able to associate a >> place with the commit date helps me to quickly recover

Re: [PATCH] Geolocation support

2013-05-23 Thread Ramkumar Ramachandra
Alessandro Di Marco wrote: > this is a hack I made a couple of years ago in order to store my current > location in git commits (I travel a lot and being able to associate a > place with the commit date helps me to quickly recover what were doing > at that time). Long story short, the screeenshot a

[PATCH] Geolocation support

2013-05-22 Thread Alessandro Di Marco
Hi all, this is a hack I made a couple of years ago in order to store my current location in git commits (I travel a lot and being able to associate a place with the commit date helps me to quickly recover what were doing at that time). Long story short, the screeenshot at http://tinypic.com/r/war