On Wed, Aug 26, 2015 at 9:48 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> We currently ignore the first line passed to `git interpret-trailers`,
>> when looking for the beginning of the trailers.
>>
>> Unfortunately this does not work well when a commit is created with a
>> line brea
Christian Couder writes:
> We currently ignore the first line passed to `git interpret-trailers`,
> when looking for the beginning of the trailers.
>
> Unfortunately this does not work well when a commit is created with a
> line break in the title, using for example the following command:
>
> git
Junio C Hamano writes:
> While the reordering would certainly stop showing the comments and
> patch, I am not sure if that is a move in the right direction. It
> will rob from the hooks information that they have traditionally
> been given---
The information given in the comments do not have a
Christian Couder writes:
> There is already code to detect a patch in interpret-trailers, but it
> relies on the patch starting with a line with only three dashes.
Hmm, then it can be taught to notice "everything below..." as
another marker, right?
> Maybe. I don't know if there is a reason why
Sorry I sent the part below privately by mistake:
On Tue, Aug 25, 2015 at 11:07 PM, Matthieu Moy
wrote:
>
> Now, I found another issue: I still have this "interpret-trailers" in my
> hooks/commit-msg, and it behaves badly when I use "git commit -v". With
> -v, I get a diff in COMMIT_EDITMSG, and
On Tue, Aug 25, 2015 at 11:07 PM, Matthieu Moy
wrote:
> Christian Couder writes:
>
>> Unfortunately this does not work well when a commit is created with a
>> line break in the title, using for example the following command:
>>
>> git commit -m 'place of
>> code: change we made'
>
> I confirm tha
Christian Couder writes:
> Unfortunately this does not work well when a commit is created with a
> line break in the title, using for example the following command:
>
> git commit -m 'place of
> code: change we made'
I confirm that this patch fixes the behavior for me.
Now, I found another issu
We currently ignore the first line passed to `git interpret-trailers`,
when looking for the beginning of the trailers.
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the following command:
git commit -m 'place of
code: change we ma
8 matches
Mail list logo
