Re: [PATCH v7 00/11] Add interpret-trailers builtin

2014-03-10 Thread Junio C Hamano
Øystein Walle writes: > Junio C Hamano pobox.com> writes: > >> >> ... >> >> is easier to read and maintain if written like so (with using HT >> properly---our MUAs may damage it and turn the indentation into >> spaces): >> >> ... && >> sed -e "s/ Z$/ /" >>expect <<-\EOF && >>

Re: [PATCH v7 00/11] Add interpret-trailers builtin

2014-03-08 Thread Øystein Walle
Junio C Hamano pobox.com> writes: > > ... > > is easier to read and maintain if written like so (with using HT > properly---our MUAs may damage it and turn the indentation into > spaces): > > ... && > sed -e "s/ Z$/ /" >>expect <<-\EOF && > Fixes: Z > Acked-by

Re: [PATCH v7 00/11] Add interpret-trailers builtin

2014-03-07 Thread Junio C Hamano
Christian Couder writes: > * many style fixes This round is readable ;-) Thanks. > * clearer and nicer setup tests Those long lines that use "printf" with many embedded \n were harder to read and also looked harder to maintain if we ever wanted to change them. Splicing a string with \n in th

[PATCH v7 00/11] Add interpret-trailers builtin

2014-03-06 Thread Christian Couder
This patch series implements a new command: git interpret-trailers and an infrastructure to process trailers that can be reused, for example in "commit.c". 1) Rationale: This command should help with RFC 822 style headers, called "trailers", that are found at the end of commit messages.