Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-21 Thread Ramsay Jones
Junio C Hamano wrote: > Ramsay Jones writes: > >> Jonathan Nieder wrote: >>> Ramsay Jones wrote: >>> One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) >>> >>> Do you know what version of gcc introduced the

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-18 Thread Junio C Hamano
Ramsay Jones writes: > Jonathan Nieder wrote: >> Ramsay Jones wrote: >> >>> One of the three gcc compilers that I use does not understand the >>> sentinel function attribute. (so, it spews 108 warning messages) >> >> Do you know what version of gcc introduced the sentinel attribute? >> Would it

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-18 Thread Ramsay Jones
Jonathan Nieder wrote: > Ramsay Jones wrote: > >> One of the three gcc compilers that I use does not understand the >> sentinel function attribute. (so, it spews 108 warning messages) > > Do you know what version of gcc introduced the sentinel attribute? > Would it make sense for the ifdef in git

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-17 Thread Andreas Schwab
Junio C Hamano writes: > Also do we know what version of GCC started supporting this > attribute? http://gcc.gnu.org/gcc-4.0/changes.html mentions it in > "New Languages and Language specific improvements" section, but the > page also says "The latest release in the 4.0 release series is GCC > 4

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-17 Thread Junio C Hamano
Ramsay Jones writes: > diff --git a/git-compat-util.h b/git-compat-util.h > index 9f1eaca..e846e01 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -300,6 +300,12 @@ extern char *gitbasename(char *); > #endif > #endif > > +#if defined(__GNUC__) && !defined(NO_SENTINEL) > +#defi

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-15 Thread Jonathan Nieder
Ramsay Jones wrote: > One of the three gcc compilers that I use does not understand the > sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute? Would it make sense for the ifdef in git-compat-util.h to be keyed on __GN

[RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-15 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Jeff, One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Is this, or something like it, too ugly for you to squash into your patch? :-D ATB, Ramsay Jones Makefile | 6