Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

On 08/09, Junio C Hamano wrote: > Thomas Gummerer writes: > > > On 08/08, Junio C Hamano wrote: > >> ... > >> Let me ask the same question in a more direct way. Which part of > >> this test break with your series? > >> > >> test_expect_success 'git add --refresh with pathspec' ' > >>

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

Thomas Gummerer writes: > On 08/08, Junio C Hamano wrote: >> ... >> Let me ask the same question in a more direct way. Which part of >> this test break with your series? >> >> test_expect_success 'git add --refresh with pathspec' ' >> git reset --hard && >>

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

On 08/08, Junio C Hamano wrote: > Junio C Hamano writes: > > > So whether done with "sleep" or "test-chmtime", avoiding a racily > > clean situation sounds like sweeping a bug in the v5 code in racy > > situation under the rug to me (unless I am misunderstanding what > > you are doing with this c

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

Junio C Hamano writes: > So whether done with "sleep" or "test-chmtime", avoiding a racily > clean situation sounds like sweeping a bug in the v5 code in racy > situation under the rug to me (unless I am misunderstanding what > you are doing with this change and in your explanation, or the test >

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

Thomas Gummerer writes: > On 08/05, Junio C Hamano wrote: >> Thomas Gummerer writes: >> >> > The new git racy code uses the mtime of cache-entries to smudge >> > a racy clean entry, and loads the work, of checking the file-system >> >> -ECANTPARSE. > > The git racy code for index-v5 uses the m

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

On 08/05, Junio C Hamano wrote: > Thomas Gummerer writes: > > > The new git racy code uses the mtime of cache-entries to smudge > > a racy clean entry, and loads the work, of checking the file-system > > -ECANTPARSE. The git racy code for index-v5 uses the mtime of the cache-entries as smudge m

Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

Thomas Gummerer writes: > The new git racy code uses the mtime of cache-entries to smudge > a racy clean entry, and loads the work, of checking the file-system -ECANTPARSE. > if the entry has really changed, off to the reader. This interferes > with this test, because the entry is racily smudge