Re: [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests

2013-12-28 Thread Jeff King
On Sat, Dec 28, 2013 at 02:13:13PM -0800, Jonathan Nieder wrote: > So the idea if I am reading correctly is "Instead of relying on the > implicit output directory chosen with chdir, which doesn't even work > any more, set TEST_OUTPUT_DIRECTORY to decide where output for the > sub-tests used by t00

Re: [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests

2013-12-28 Thread Jonathan Nieder
Jonathan Nieder wrote: > - git used to only use TEST_OUTPUT_DIRECTORY to decide where test >results go. You'd have to use --root to set a custom location for >trash directories. > > - in that old setup, t leaves around extra trash directories with >--root, since the sub-tests in

Re: [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests

2013-12-28 Thread Jonathan Nieder
Hi, Jeff King wrote: > Once upon a time, the test-lib library would create trash > directories in the current working directory, unless we were > explicitly told to put it elsewhere via --root. As a result, > t created the sub-test trash directories inside its own > trash directory. > > Howev